181875 2018-01-19 13:02:58 -0800 [Curl] CurlRequest must protect its client from disposal while it's on duty. 2018-01-23 14:31:54 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 117300 1 basuke basuke achristensen basuke commit-queue don.olmstead ews-watchlist galpeter rniwa webkit-bug-importer oldest_to_newest 1391125 0 basuke 2018-01-19 13:02:58 -0800 Adding retain/release method to the client protocol and use them to protect the client from disposal. 1391149 1 331779 basuke 2018-01-19 13:23:29 -0800 Created attachment 331779 patch 1391172 2 331779 achristensen 2018-01-19 14:05:22 -0800 Comment on attachment 331779 patch View in context: https://bugs.webkit.org/attachment.cgi?id=331779&action=review > Source/WebCore/platform/network/curl/CurlRequestClient.h:39 > + virtual void retain() = 0; > + virtual void release() = 0; Can these be called ref and deref? Then we can just make RefPtr's instead of manually calling retain and release. We do something similar in several places, like IDBConnectionToServerDelegate, IDBConnectionToClientDelegate, CSSFontFace::Client, CSSRuleList, CSSStyleDeclaration, and ServiceWorkerJobClient 1391252 3 basuke 2018-01-19 15:59:53 -0800 (In reply to Alex Christensen from comment #2) > Comment on attachment 331779 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=331779&action=review > > > Source/WebCore/platform/network/curl/CurlRequestClient.h:39 > > + virtual void retain() = 0; > > + virtual void release() = 0; > > Can these be called ref and deref? Then we can just make RefPtr's instead > of manually calling retain and release. > We do something similar in several places, like > IDBConnectionToServerDelegate, IDBConnectionToClientDelegate, > CSSFontFace::Client, CSSRuleList, CSSStyleDeclaration, and > ServiceWorkerJobClient Okay, thanks. We'll take a look into those. 1392220 4 332065 basuke 2018-01-23 13:08:01 -0800 Created attachment 332065 use ref/deref 1392257 5 commit-queue 2018-01-23 14:30:12 -0800 The commit-queue encountered the following flaky tests while processing attachment 332065: js/arity-mismatch-at-vmentry.html bug 182014 (authors: cdumez@apple.com and msaboff@apple.com) The commit-queue is continuing to process your patch. 1392258 6 332065 commit-queue 2018-01-23 14:30:44 -0800 Comment on attachment 332065 use ref/deref Clearing flags on attachment: 332065 Committed r227449: <https://trac.webkit.org/changeset/227449> 1392259 7 commit-queue 2018-01-23 14:30:46 -0800 All reviewed patches have been landed. Closing bug. 1392261 8 webkit-bug-importer 2018-01-23 14:31:54 -0800 <rdar://problem/36794134> 331779 2018-01-19 13:23:29 -0800 2018-01-23 13:08:01 -0800 patch 181875.diff text/plain 7479 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZjMwODRhNjk2My4uMzhiNjAxZGIyZGMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxOC0wMS0xOSAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIEN1cmxSZXF1ZXN0IG11c3QgcHJvdGVjdCBpdHMgY2xp ZW50IGZyb20gZGlzcG9zYWwgd2hpbGUgaXQncyBvbiBkdXR5LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxODc1CisKKyAgICAgICAgQWRkaW5nIHJl dGFpbi9yZWxlYXNlIG1ldGhvZCB0byBDdXJsUmVxdWVzdENsaWVudCBwcm90b2NvbCBhbmQKKyAg ICAgICAgY2FsbCB0aGVtIGJlZm9yZSBhbmQgYWZ0ZXIgaXQgY2FsbHMgdGhlbS4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVj YXVzZSBubyBuZXcgYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwv Q3VybERvd25sb2FkLmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1 ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpjYWxsQ2xpZW50KToKKyAg ICAgICAgKFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpkaWRSZWNlaXZlRGF0YSk6CisgICAgICAgIChX ZWJDb3JlOjpDdXJsUmVxdWVzdDo6ZGlkUmVjZWl2ZURhdGFGcm9tTXVsdGlwYXJ0KToKKyAgICAg ICAgKFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpkaWRDb21wbGV0ZVRyYW5zZmVyKToKKyAgICAgICAg KFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjppbnZva2VEaWRSZWNlaXZlUmVzcG9uc2UpOgorICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5oOgorICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdENsaWVudC5oOgorICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5oOgorCiAyMDE4LTAxLTE4 ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIyMjU2NTApOiBUaGUgc2NvcmVzIG9mIE1vdGlvbk1hcmsgdGVzdHMgTXVsdGlwbHkgYW5kIExl YXZlcyBkcm9wcGVkIGJ5IDglCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2N1cmwvQ3VybERvd25sb2FkLmgKaW5kZXggZWNiZjdkZmRkNzQuLjc1OTlmMTVjZTM2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25s b2FkLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxEb3du bG9hZC5oCkBAIC02Niw2ICs2Niw5IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldERlc3RpbmF0aW9u KGNvbnN0IFN0cmluZyYgZGVzdGluYXRpb24pIHsgbV9kZXN0aW5hdGlvbiA9IGRlc3RpbmF0aW9u OyB9CiAKIHByaXZhdGU6CisgICAgdm9pZCByZXRhaW4oKSBvdmVycmlkZSB7IHJlZigpOyB9Cisg ICAgdm9pZCByZWxlYXNlKCkgb3ZlcnJpZGUgeyBkZXJlZigpOyB9CisKICAgICBSZWY8Q3VybFJl cXVlc3Q+IGNyZWF0ZUN1cmxSZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYpOwogICAgIHZvaWQgY3Vy bERpZFJlY2VpdmVSZXNwb25zZShjb25zdCBDdXJsUmVzcG9uc2UmKSBvdmVycmlkZTsKICAgICB2 b2lkIGN1cmxEaWRSZWNlaXZlQnVmZmVyKFJlZjxTaGFyZWRCdWZmZXI+JiYpIG92ZXJyaWRlOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1 ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVz dC5jcHAKaW5kZXggNzg2YzZhMzk0YmIuLmQ1NDlmODVmZTAwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5jcHAKQEAgLTE0Miwx NSArMTQyLDIxIEBAIHZvaWQgQ3VybFJlcXVlc3Q6OnJlc3VtZSgpCiB9CiAKIC8qIGB0aGlzYCBp cyBwcm90ZWN0ZWQgaW5zaWRlIHRoaXMgbWV0aG9kLiAqLwotdm9pZCBDdXJsUmVxdWVzdDo6Y2Fs bENsaWVudChXVEY6OkZ1bmN0aW9uPHZvaWQoQ3VybFJlcXVlc3RDbGllbnQqKT4gdGFzaykKK3Zv aWQgQ3VybFJlcXVlc3Q6OmNhbGxDbGllbnQoV1RGOjpGdW5jdGlvbjx2b2lkKEN1cmxSZXF1ZXN0 Q2xpZW50Jik+IHRhc2spCiB7CiAgICAgaWYgKGlzTWFpblRocmVhZCgpKSB7Ci0gICAgICAgIGlm IChDdXJsUmVxdWVzdENsaWVudCogY2xpZW50ID0gbV9jbGllbnQpCi0gICAgICAgICAgICB0YXNr KGNsaWVudCk7CisgICAgICAgIGlmIChDdXJsUmVxdWVzdENsaWVudCogY2xpZW50ID0gbV9jbGll bnQpIHsKKyAgICAgICAgICAgIGNsaWVudC0+cmV0YWluKCk7CisgICAgICAgICAgICB0YXNrKCpj bGllbnQpOworICAgICAgICAgICAgY2xpZW50LT5yZWxlYXNlKCk7CisgICAgICAgIH0KICAgICB9 IGVsc2UgewogICAgICAgICBjYWxsT25NYWluVGhyZWFkKFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJl ZigqdGhpcyksIHRhc2sgPSBXVEZNb3ZlKHRhc2spXSgpIG11dGFibGUgewotICAgICAgICAgICAg aWYgKEN1cmxSZXF1ZXN0Q2xpZW50KiBjbGllbnQgPSBwcm90ZWN0ZWRUaGlzLT5tX2NsaWVudCkK LSAgICAgICAgICAgICAgICB0YXNrKGNsaWVudCk7CisgICAgICAgICAgICBpZiAoQ3VybFJlcXVl c3RDbGllbnQqIGNsaWVudCA9IHByb3RlY3RlZFRoaXMtPm1fY2xpZW50KSB7CisgICAgICAgICAg ICAgICAgY2xpZW50LT5yZXRhaW4oKTsKKyAgICAgICAgICAgICAgICB0YXNrKCpjbGllbnQpOwor ICAgICAgICAgICAgICAgIGNsaWVudC0+cmVsZWFzZSgpOworICAgICAgICAgICAgfQogICAgICAg ICB9KTsKICAgICB9CiB9CkBAIC0zNTMsOSArMzU5LDggQEAgc2l6ZV90IEN1cmxSZXF1ZXN0Ojpk aWRSZWNlaXZlRGF0YShSZWY8U2hhcmVkQnVmZmVyPiYmIGJ1ZmZlcikKICAgICAgICAgaWYgKG1f bXVsdGlwYXJ0SGFuZGxlKQogICAgICAgICAgICAgbV9tdWx0aXBhcnRIYW5kbGUtPmRpZFJlY2Vp dmVEYXRhKGJ1ZmZlcik7CiAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgY2FsbENsaWVudChb dGhpcywgYnVmZmVyID0gV1RGTW92ZShidWZmZXIpXShDdXJsUmVxdWVzdENsaWVudCogY2xpZW50 KSBtdXRhYmxlIHsKLSAgICAgICAgICAgICAgICBpZiAoY2xpZW50KQotICAgICAgICAgICAgICAg ICAgICBjbGllbnQtPmN1cmxEaWRSZWNlaXZlQnVmZmVyKFdURk1vdmUoYnVmZmVyKSk7CisgICAg ICAgICAgICBjYWxsQ2xpZW50KFt0aGlzLCBidWZmZXIgPSBXVEZNb3ZlKGJ1ZmZlcildKEN1cmxS ZXF1ZXN0Q2xpZW50JiBjbGllbnQpIG11dGFibGUgeworICAgICAgICAgICAgICAgIGNsaWVudC5j dXJsRGlkUmVjZWl2ZUJ1ZmZlcihXVEZNb3ZlKGJ1ZmZlcikpOwogICAgICAgICAgICAgfSk7CiAg ICAgICAgIH0KICAgICB9CkBAIC0zODYsOSArMzkxLDggQEAgdm9pZCBDdXJsUmVxdWVzdDo6ZGlk UmVjZWl2ZURhdGFGcm9tTXVsdGlwYXJ0KFJlZjxTaGFyZWRCdWZmZXI+JiYgYnVmZmVyKQogICAg IGF1dG8gcmVjZWl2ZUJ5dGVzID0gYnVmZmVyLT5zaXplKCk7CiAKICAgICBpZiAocmVjZWl2ZUJ5 dGVzKSB7Ci0gICAgICAgIGNhbGxDbGllbnQoW3RoaXMsIGJ1ZmZlciA9IFdURk1vdmUoYnVmZmVy KV0oQ3VybFJlcXVlc3RDbGllbnQqIGNsaWVudCkgbXV0YWJsZSB7Ci0gICAgICAgICAgICBpZiAo Y2xpZW50KQotICAgICAgICAgICAgICAgIGNsaWVudC0+Y3VybERpZFJlY2VpdmVCdWZmZXIoV1RG TW92ZShidWZmZXIpKTsKKyAgICAgICAgY2FsbENsaWVudChbdGhpcywgYnVmZmVyID0gV1RGTW92 ZShidWZmZXIpXShDdXJsUmVxdWVzdENsaWVudCYgY2xpZW50KSBtdXRhYmxlIHsKKyAgICAgICAg ICAgIGNsaWVudC5jdXJsRGlkUmVjZWl2ZUJ1ZmZlcihXVEZNb3ZlKGJ1ZmZlcikpOwogICAgICAg ICB9KTsKICAgICB9CiB9CkBAIC00MTUsOSArNDE5LDggQEAgdm9pZCBDdXJsUmVxdWVzdDo6ZGlk Q29tcGxldGVUcmFuc2ZlcihDVVJMY29kZSByZXN1bHQpCiAgICAgICAgICAgICAgICAgbV9uZXR3 b3JrTG9hZE1ldHJpY3MgPSAqbWV0cmljczsKIAogICAgICAgICAgICAgZmluYWxpemVUcmFuc2Zl cigpOwotICAgICAgICAgICAgY2FsbENsaWVudChbdGhpc10oQ3VybFJlcXVlc3RDbGllbnQqIGNs aWVudCkgewotICAgICAgICAgICAgICAgIGlmIChjbGllbnQpCi0gICAgICAgICAgICAgICAgICAg IGNsaWVudC0+Y3VybERpZENvbXBsZXRlKCk7CisgICAgICAgICAgICBjYWxsQ2xpZW50KFt0aGlz XShDdXJsUmVxdWVzdENsaWVudCYgY2xpZW50KSB7CisgICAgICAgICAgICAgICAgY2xpZW50LmN1 cmxEaWRDb21wbGV0ZSgpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0KICAgICB9IGVsc2Ug ewpAQCAtNDI2LDkgKzQyOSw4IEBAIHZvaWQgQ3VybFJlcXVlc3Q6OmRpZENvbXBsZXRlVHJhbnNm ZXIoQ1VSTGNvZGUgcmVzdWx0KQogICAgICAgICAgICAgcmVzb3VyY2VFcnJvci5zZXRTc2xFcnJv cnMobV9zc2xWZXJpZmllci5zc2xFcnJvcnMoKSk7CiAKICAgICAgICAgZmluYWxpemVUcmFuc2Zl cigpOwotICAgICAgICBjYWxsQ2xpZW50KFt0aGlzLCBlcnJvciA9IHJlc291cmNlRXJyb3IuaXNv bGF0ZWRDb3B5KCldKEN1cmxSZXF1ZXN0Q2xpZW50KiBjbGllbnQpIHsKLSAgICAgICAgICAgIGlm IChjbGllbnQpCi0gICAgICAgICAgICAgICAgY2xpZW50LT5jdXJsRGlkRmFpbFdpdGhFcnJvcihl cnJvcik7CisgICAgICAgIGNhbGxDbGllbnQoW3RoaXMsIGVycm9yID0gcmVzb3VyY2VFcnJvci5p c29sYXRlZENvcHkoKV0oQ3VybFJlcXVlc3RDbGllbnQmIGNsaWVudCkgeworICAgICAgICAgICAg Y2xpZW50LmN1cmxEaWRGYWlsV2l0aEVycm9yKGVycm9yKTsKICAgICAgICAgfSk7CiAgICAgfQog fQpAQCAtNTI3LDkgKzUyOSw4IEBAIHZvaWQgQ3VybFJlcXVlc3Q6Omludm9rZURpZFJlY2VpdmVS ZXNwb25zZShjb25zdCBDdXJsUmVzcG9uc2UmIHJlc3BvbnNlLCBBY3Rpb24KICAgICBtX2RpZE5v dGlmeVJlc3BvbnNlID0gdHJ1ZTsKICAgICBtX2FjdGlvbkFmdGVySW52b2tlID0gYmVoYXZpb3JB ZnRlckludm9rZTsKIAotICAgIGNhbGxDbGllbnQoW3RoaXMsIHJlc3BvbnNlID0gcmVzcG9uc2Uu aXNvbGF0ZWRDb3B5KCldKEN1cmxSZXF1ZXN0Q2xpZW50KiBjbGllbnQpIHsKLSAgICAgICAgaWYg KGNsaWVudCkKLSAgICAgICAgICAgIGNsaWVudC0+Y3VybERpZFJlY2VpdmVSZXNwb25zZShyZXNw b25zZSk7CisgICAgY2FsbENsaWVudChbdGhpcywgcmVzcG9uc2UgPSByZXNwb25zZS5pc29sYXRl ZENvcHkoKV0oQ3VybFJlcXVlc3RDbGllbnQmIGNsaWVudCkgeworICAgICAgICBjbGllbnQuY3Vy bERpZFJlY2VpdmVSZXNwb25zZShyZXNwb25zZSk7CiAgICAgfSk7CiB9CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmgKaW5kZXggYjAx MThlYzM1NzkuLmIwMDNmNzIyODQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuaApAQCAtMTAyLDcgKzEwMiw3IEBAIHByaXZhdGU6 CiAKICAgICB2b2lkIHN0YXJ0V2l0aEpvYk1hbmFnZXIoKTsKIAotICAgIHZvaWQgY2FsbENsaWVu dChXVEY6OkZ1bmN0aW9uPHZvaWQoQ3VybFJlcXVlc3RDbGllbnQqKT4pOworICAgIHZvaWQgY2Fs bENsaWVudChXVEY6OkZ1bmN0aW9uPHZvaWQoQ3VybFJlcXVlc3RDbGllbnQmKT4pOwogCiAgICAg Ly8gVHJhbnNmZXIgcHJvY2Vzc2luZyBvZiBSZXF1ZXN0IGJvZHksIFJlc3BvbnNlIGhlYWRlci9i b2R5CiAgICAgLy8gQ2FsbGVkIGJ5IHdvcmtlciB0aHJlYWQgaW4gY2FzZSBvZiBhc3luYywgbWFp biB0aHJlYWQgaW4gY2FzZSBvZiBzeW5jLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0Q2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3RDbGllbnQuaAppbmRleCA2ZDc2MzJiNGNj MC4uNjQ5MWFhMGM5YmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9DdXJsUmVxdWVzdENsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdENsaWVudC5oCkBAIC0zNSw2ICszNSw5IEBAIGNsYXNz IFNoYXJlZEJ1ZmZlcjsKIAogY2xhc3MgQ3VybFJlcXVlc3RDbGllbnQgewogcHVibGljOgorICAg IHZpcnR1YWwgdm9pZCByZXRhaW4oKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIHJlbGVhc2UoKSA9 IDA7CisKICAgICB2aXJ0dWFsIHZvaWQgY3VybERpZFJlY2VpdmVSZXNwb25zZShjb25zdCBDdXJs UmVzcG9uc2UmKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGN1cmxEaWRSZWNlaXZlQnVmZmVyKFJl ZjxTaGFyZWRCdWZmZXI+JiYpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgY3VybERpZENvbXBsZXRl KCkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L1Jlc291cmNlSGFuZGxlQ3VybERlbGVnYXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsRGVsZWdhdGUuaAppbmRleCA1YWQ4YWZlNmMy Mi4uMzMyY2IxMmIzM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5oCkBAIC02 MCw2ICs2MCw5IEBAIHB1YmxpYzoKICAgICB2b2lkIGNvbnRpbnVlV2lsbFNlbmRSZXF1ZXN0KFJl c291cmNlUmVxdWVzdCYmKTsKIAogcHJpdmF0ZToKKyAgICB2b2lkIHJldGFpbigpIG92ZXJyaWRl IHsgcmVmKCk7IH0KKyAgICB2b2lkIHJlbGVhc2UoKSBvdmVycmlkZSB7IGRlcmVmKCk7IH0KKwog ICAgIC8vIENhbGxlZCBmcm9tIG1haW4gdGhyZWFkLgogICAgIFJlc291cmNlUmVzcG9uc2UmIHJl c3BvbnNlKCk7CiAK 332065 2018-01-23 13:08:01 -0800 2018-01-23 14:30:44 -0800 use ref/deref 181875.diff text/plain 7408 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNTA5MWU0NDA1Yi4uYmFkNjlmMDI3ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxOC0wMS0yMyAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIEN1cmxSZXF1ZXN0IG11c3QgcHJvdGVjdCBpdHMgY2xp ZW50IGZyb20gZGlzcG9zYWwgd2hpbGUgaXQncyBvbiBkdXR5LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxODc1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBJdCdzIGNvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3Vy bERvd25sb2FkLmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpjYWxsQ2xpZW50KToKKyAgICAg ICAgKFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpkaWRSZWNlaXZlRGF0YSk6CisgICAgICAgIChXZWJD b3JlOjpDdXJsUmVxdWVzdDo6ZGlkUmVjZWl2ZURhdGFGcm9tTXVsdGlwYXJ0KToKKyAgICAgICAg KFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpkaWRDb21wbGV0ZVRyYW5zZmVyKToKKyAgICAgICAgKFdl YkNvcmU6OkN1cmxSZXF1ZXN0OjppbnZva2VEaWRSZWNlaXZlUmVzcG9uc2UpOgorICAgICAgICAq IHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5oOgorICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdENsaWVudC5oOgorICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5oOgorCiAyMDE4LTAxLTE5ICBZ b3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBDYWNoZSBzdG9yYWdl IGVycm9ycyBsaWtlIFF1b3RhIHNob3VsZCB0cmlnZ2VyIGNvbnNvbGUgbWVzc2FnZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuaApp bmRleCBlY2JmN2RmZGQ3NC4uZDg1MzRhODE3YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmgKQEAgLTUyLDYgKzUyLDkgQEAg cHVibGljOgogICAgIEN1cmxEb3dubG9hZCgpID0gZGVmYXVsdDsKICAgICB+Q3VybERvd25sb2Fk KCk7CiAKKyAgICB2b2lkIHJlZigpIG92ZXJyaWRlIHsgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8Q3Vy bERvd25sb2FkPjo6cmVmKCk7IH0KKyAgICB2b2lkIGRlcmVmKCkgb3ZlcnJpZGUgeyBUaHJlYWRT YWZlUmVmQ291bnRlZDxDdXJsRG93bmxvYWQ+OjpkZXJlZigpOyB9CisKICAgICB2b2lkIGluaXQo Q3VybERvd25sb2FkTGlzdGVuZXImLCBjb25zdCBVUkwmKTsKICAgICB2b2lkIGluaXQoQ3VybERv d25sb2FkTGlzdGVuZXImLCBSZXNvdXJjZUhhbmRsZSosIGNvbnN0IFJlc291cmNlUmVxdWVzdCYs IGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5jcHAKaW5kZXggNDZiYjM0Y2EzODYuLmEx MWUxMTg1N2MyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvQ3VybFJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9DdXJsUmVxdWVzdC5jcHAKQEAgLTE0MiwxNSArMTQyLDE5IEBAIHZvaWQgQ3VybFJlcXVl c3Q6OnJlc3VtZSgpCiB9CiAKIC8qIGB0aGlzYCBpcyBwcm90ZWN0ZWQgaW5zaWRlIHRoaXMgbWV0 aG9kLiAqLwotdm9pZCBDdXJsUmVxdWVzdDo6Y2FsbENsaWVudChXVEY6OkZ1bmN0aW9uPHZvaWQo Q3VybFJlcXVlc3RDbGllbnQqKT4gdGFzaykKK3ZvaWQgQ3VybFJlcXVlc3Q6OmNhbGxDbGllbnQo V1RGOjpGdW5jdGlvbjx2b2lkKEN1cmxSZXF1ZXN0Q2xpZW50Jik+IHRhc2spCiB7CiAgICAgaWYg KGlzTWFpblRocmVhZCgpKSB7Ci0gICAgICAgIGlmIChDdXJsUmVxdWVzdENsaWVudCogY2xpZW50 ID0gbV9jbGllbnQpCi0gICAgICAgICAgICB0YXNrKGNsaWVudCk7CisgICAgICAgIGlmIChDdXJs UmVxdWVzdENsaWVudCogY2xpZW50ID0gbV9jbGllbnQpIHsKKyAgICAgICAgICAgIFJlZlB0cjxD dXJsUmVxdWVzdENsaWVudD4gcHJvdGVjdGVkQ2xpZW50KGNsaWVudCk7CisgICAgICAgICAgICB0 YXNrKCpjbGllbnQpOworICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgY2FsbE9uTWFp blRocmVhZChbcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCB0YXNrID0gV1RGTW92ZSh0 YXNrKV0oKSBtdXRhYmxlIHsKLSAgICAgICAgICAgIGlmIChDdXJsUmVxdWVzdENsaWVudCogY2xp ZW50ID0gcHJvdGVjdGVkVGhpcy0+bV9jbGllbnQpCi0gICAgICAgICAgICAgICAgdGFzayhjbGll bnQpOworICAgICAgICAgICAgaWYgKEN1cmxSZXF1ZXN0Q2xpZW50KiBjbGllbnQgPSBwcm90ZWN0 ZWRUaGlzLT5tX2NsaWVudCkgeworICAgICAgICAgICAgICAgIFJlZlB0cjxDdXJsUmVxdWVzdENs aWVudD4gcHJvdGVjdGVkQ2xpZW50KGNsaWVudCk7CisgICAgICAgICAgICAgICAgdGFzaygqY2xp ZW50KTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfSk7CiAgICAgfQogfQpAQCAtMzU2LDkgKzM2 MCw4IEBAIHNpemVfdCBDdXJsUmVxdWVzdDo6ZGlkUmVjZWl2ZURhdGEoUmVmPFNoYXJlZEJ1ZmZl cj4mJiBidWZmZXIpCiAgICAgICAgIGlmIChtX211bHRpcGFydEhhbmRsZSkKICAgICAgICAgICAg IG1fbXVsdGlwYXJ0SGFuZGxlLT5kaWRSZWNlaXZlRGF0YShidWZmZXIpOwogICAgICAgICBlbHNl IHsKLSAgICAgICAgICAgIGNhbGxDbGllbnQoW3RoaXMsIGJ1ZmZlciA9IFdURk1vdmUoYnVmZmVy KV0oQ3VybFJlcXVlc3RDbGllbnQqIGNsaWVudCkgbXV0YWJsZSB7Ci0gICAgICAgICAgICAgICAg aWYgKGNsaWVudCkKLSAgICAgICAgICAgICAgICAgICAgY2xpZW50LT5jdXJsRGlkUmVjZWl2ZUJ1 ZmZlcihXVEZNb3ZlKGJ1ZmZlcikpOworICAgICAgICAgICAgY2FsbENsaWVudChbYnVmZmVyID0g V1RGTW92ZShidWZmZXIpXShDdXJsUmVxdWVzdENsaWVudCYgY2xpZW50KSBtdXRhYmxlIHsKKyAg ICAgICAgICAgICAgICBjbGllbnQuY3VybERpZFJlY2VpdmVCdWZmZXIoV1RGTW92ZShidWZmZXIp KTsKICAgICAgICAgICAgIH0pOwogICAgICAgICB9CiAgICAgfQpAQCAtMzg5LDkgKzM5Miw4IEBA IHZvaWQgQ3VybFJlcXVlc3Q6OmRpZFJlY2VpdmVEYXRhRnJvbU11bHRpcGFydChSZWY8U2hhcmVk QnVmZmVyPiYmIGJ1ZmZlcikKICAgICBhdXRvIHJlY2VpdmVCeXRlcyA9IGJ1ZmZlci0+c2l6ZSgp OwogCiAgICAgaWYgKHJlY2VpdmVCeXRlcykgewotICAgICAgICBjYWxsQ2xpZW50KFt0aGlzLCBi dWZmZXIgPSBXVEZNb3ZlKGJ1ZmZlcildKEN1cmxSZXF1ZXN0Q2xpZW50KiBjbGllbnQpIG11dGFi bGUgewotICAgICAgICAgICAgaWYgKGNsaWVudCkKLSAgICAgICAgICAgICAgICBjbGllbnQtPmN1 cmxEaWRSZWNlaXZlQnVmZmVyKFdURk1vdmUoYnVmZmVyKSk7CisgICAgICAgIGNhbGxDbGllbnQo W2J1ZmZlciA9IFdURk1vdmUoYnVmZmVyKV0oQ3VybFJlcXVlc3RDbGllbnQmIGNsaWVudCkgbXV0 YWJsZSB7CisgICAgICAgICAgICBjbGllbnQuY3VybERpZFJlY2VpdmVCdWZmZXIoV1RGTW92ZShi dWZmZXIpKTsKICAgICAgICAgfSk7CiAgICAgfQogfQpAQCAtNDE4LDkgKzQyMCw4IEBAIHZvaWQg Q3VybFJlcXVlc3Q6OmRpZENvbXBsZXRlVHJhbnNmZXIoQ1VSTGNvZGUgcmVzdWx0KQogICAgICAg ICAgICAgICAgIG1fbmV0d29ya0xvYWRNZXRyaWNzID0gKm1ldHJpY3M7CiAKICAgICAgICAgICAg IGZpbmFsaXplVHJhbnNmZXIoKTsKLSAgICAgICAgICAgIGNhbGxDbGllbnQoW3RoaXNdKEN1cmxS ZXF1ZXN0Q2xpZW50KiBjbGllbnQpIHsKLSAgICAgICAgICAgICAgICBpZiAoY2xpZW50KQotICAg ICAgICAgICAgICAgICAgICBjbGllbnQtPmN1cmxEaWRDb21wbGV0ZSgpOworICAgICAgICAgICAg Y2FsbENsaWVudChbXShDdXJsUmVxdWVzdENsaWVudCYgY2xpZW50KSB7CisgICAgICAgICAgICAg ICAgY2xpZW50LmN1cmxEaWRDb21wbGV0ZSgpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0K ICAgICB9IGVsc2UgewpAQCAtNDMwLDkgKzQzMSw4IEBAIHZvaWQgQ3VybFJlcXVlc3Q6OmRpZENv bXBsZXRlVHJhbnNmZXIoQ1VSTGNvZGUgcmVzdWx0KQogICAgICAgICAgICAgcmVzb3VyY2VFcnJv ci5zZXRTc2xFcnJvcnMobV9zc2xWZXJpZmllci5zc2xFcnJvcnMoKSk7CiAKICAgICAgICAgZmlu YWxpemVUcmFuc2ZlcigpOwotICAgICAgICBjYWxsQ2xpZW50KFt0aGlzLCBlcnJvciA9IHJlc291 cmNlRXJyb3IuaXNvbGF0ZWRDb3B5KCldKEN1cmxSZXF1ZXN0Q2xpZW50KiBjbGllbnQpIHsKLSAg ICAgICAgICAgIGlmIChjbGllbnQpCi0gICAgICAgICAgICAgICAgY2xpZW50LT5jdXJsRGlkRmFp bFdpdGhFcnJvcihlcnJvcik7CisgICAgICAgIGNhbGxDbGllbnQoW2Vycm9yID0gcmVzb3VyY2VF cnJvci5pc29sYXRlZENvcHkoKV0oQ3VybFJlcXVlc3RDbGllbnQmIGNsaWVudCkgeworICAgICAg ICAgICAgY2xpZW50LmN1cmxEaWRGYWlsV2l0aEVycm9yKGVycm9yKTsKICAgICAgICAgfSk7CiAg ICAgfQogfQpAQCAtNTMxLDkgKzUzMSw4IEBAIHZvaWQgQ3VybFJlcXVlc3Q6Omludm9rZURpZFJl Y2VpdmVSZXNwb25zZShjb25zdCBDdXJsUmVzcG9uc2UmIHJlc3BvbnNlLCBBY3Rpb24KICAgICBt X2RpZE5vdGlmeVJlc3BvbnNlID0gdHJ1ZTsKICAgICBtX2FjdGlvbkFmdGVySW52b2tlID0gYmVo YXZpb3JBZnRlckludm9rZTsKIAotICAgIGNhbGxDbGllbnQoW3RoaXMsIHJlc3BvbnNlID0gcmVz cG9uc2UuaXNvbGF0ZWRDb3B5KCldKEN1cmxSZXF1ZXN0Q2xpZW50KiBjbGllbnQpIHsKLSAgICAg ICAgaWYgKGNsaWVudCkKLSAgICAgICAgICAgIGNsaWVudC0+Y3VybERpZFJlY2VpdmVSZXNwb25z ZShyZXNwb25zZSk7CisgICAgY2FsbENsaWVudChbcmVzcG9uc2UgPSByZXNwb25zZS5pc29sYXRl ZENvcHkoKV0oQ3VybFJlcXVlc3RDbGllbnQmIGNsaWVudCkgeworICAgICAgICBjbGllbnQuY3Vy bERpZFJlY2VpdmVSZXNwb25zZShyZXNwb25zZSk7CiAgICAgfSk7CiB9CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmgKaW5kZXggYjAx MThlYzM1NzkuLmIwMDNmNzIyODQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuaApAQCAtMTAyLDcgKzEwMiw3IEBAIHByaXZhdGU6 CiAKICAgICB2b2lkIHN0YXJ0V2l0aEpvYk1hbmFnZXIoKTsKIAotICAgIHZvaWQgY2FsbENsaWVu dChXVEY6OkZ1bmN0aW9uPHZvaWQoQ3VybFJlcXVlc3RDbGllbnQqKT4pOworICAgIHZvaWQgY2Fs bENsaWVudChXVEY6OkZ1bmN0aW9uPHZvaWQoQ3VybFJlcXVlc3RDbGllbnQmKT4pOwogCiAgICAg Ly8gVHJhbnNmZXIgcHJvY2Vzc2luZyBvZiBSZXF1ZXN0IGJvZHksIFJlc3BvbnNlIGhlYWRlci9i b2R5CiAgICAgLy8gQ2FsbGVkIGJ5IHdvcmtlciB0aHJlYWQgaW4gY2FzZSBvZiBhc3luYywgbWFp biB0aHJlYWQgaW4gY2FzZSBvZiBzeW5jLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0Q2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3RDbGllbnQuaAppbmRleCA2ZDc2MzJiNGNj MC4uZmMzZWZmNTExOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9DdXJsUmVxdWVzdENsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdENsaWVudC5oCkBAIC0zNSw2ICszNSw5IEBAIGNsYXNz IFNoYXJlZEJ1ZmZlcjsKIAogY2xhc3MgQ3VybFJlcXVlc3RDbGllbnQgewogcHVibGljOgorICAg IHZpcnR1YWwgdm9pZCByZWYoKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIGRlcmVmKCkgPSAwOwor CiAgICAgdmlydHVhbCB2b2lkIGN1cmxEaWRSZWNlaXZlUmVzcG9uc2UoY29uc3QgQ3VybFJlc3Bv bnNlJikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBjdXJsRGlkUmVjZWl2ZUJ1ZmZlcihSZWY8U2hh cmVkQnVmZmVyPiYmKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGN1cmxEaWRDb21wbGV0ZSgpID0g MDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNv dXJjZUhhbmRsZUN1cmxEZWxlZ2F0ZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jdXJsL1Jlc291cmNlSGFuZGxlQ3VybERlbGVnYXRlLmgKaW5kZXggNWFkOGFmZTZjMjIuLjc3 Y2M1ZWMzMDkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvUmVzb3VyY2VIYW5kbGVDdXJsRGVsZWdhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsRGVsZWdhdGUuaApAQCAtNDMsNiAr NDMsOSBAQCBwdWJsaWM6CiAgICAgUmVzb3VyY2VIYW5kbGVDdXJsRGVsZWdhdGUoUmVzb3VyY2VI YW5kbGUqKTsKICAgICB+UmVzb3VyY2VIYW5kbGVDdXJsRGVsZWdhdGUoKTsKIAorICAgIHZvaWQg cmVmKCkgb3ZlcnJpZGUgeyBUaHJlYWRTYWZlUmVmQ291bnRlZDxSZXNvdXJjZUhhbmRsZUN1cmxE ZWxlZ2F0ZT46OnJlZigpOyB9CisgICAgdm9pZCBkZXJlZigpIG92ZXJyaWRlIHsgVGhyZWFkU2Fm ZVJlZkNvdW50ZWQ8UmVzb3VyY2VIYW5kbGVDdXJsRGVsZWdhdGU+OjpkZXJlZigpOyB9CisKICAg ICBib29sIGhhc0hhbmRsZSgpIGNvbnN0OwogICAgIHZvaWQgcmVsZWFzZUhhbmRsZSgpOwogCg==