181871 2018-01-19 12:09:45 -0800 oss-fuzz jsc build is broken: StringImpl.h:27:10: fatal error: 'unicode/ustring.h' file not found 2018-01-23 15:19:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/google/oss-fuzz/issues/1093 https://bugs.webkit.org/show_bug.cgi?id=181874 InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen annulen cgarcia inferno jfbastien mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1391090 0 ddkilzer 2018-01-19 12:09:45 -0800 Title: jsc build broken GitHub: <https://github.com/google/oss-fuzz/issues/1093> Step #4: FAILED: /usr/local/bin/clang++ -DBUILDING_JSCONLY__ -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DSTATICALLY_LINKED_WITH_WTF -I. -I../../Source/JavaScriptCore -I../../Source/JavaScriptCore/.. -I../../Source/JavaScriptCore/API -I../../Source/JavaScriptCore/ForwardingHeaders -I../../Source/JavaScriptCore/assembler -I../../Source/JavaScriptCore/b3 -I../../Source/JavaScriptCore/b3/air -I../../Source/JavaScriptCore/bindings -I../../Source/JavaScriptCore/builtins -I../../Source/JavaScriptCore/bytecode -I../../Source/JavaScriptCore/bytecompiler -I../../Source/JavaScriptCore/dfg -I../../Source/JavaScriptCore/disassembler -I../../Source/JavaScriptCore/disassembler/udis86 -I../../Source/JavaScriptCore/disassembler/ARM64 -I../../Source/JavaScriptCore/domjit -I../../Source/JavaScriptCore/ftl -I../../Source/JavaScriptCore/heap -I../../Source/JavaScriptCore/debugger -I../../Source/JavaScriptCore/inspector -I../../Source/JavaScriptCore/inspector/agents -I../../Source/JavaScriptCore/inspector/augmentable -I../../Source/JavaScriptCore/inspector/remote -I../../Source/JavaScriptCore/interpreter -I../../Source/JavaScriptCore/jit -I../../Source/JavaScriptCore/llint -I../../Source/JavaScriptCore/parser -I../../Source/JavaScriptCore/profiler -I../../Source/JavaScriptCore/runtime -I../../Source/JavaScriptCore/tools -I../../Source/JavaScriptCore/wasm -I../../Source/JavaScriptCore/wasm/js -I../../Source/JavaScriptCore/yarr -IDerivedSources/ForwardingHeaders -IDerivedSources/JavaScriptCore -IDerivedSources/JavaScriptCore/inspector -IDerivedSources/JavaScriptCore/runtime -IDerivedSources/JavaScriptCore/yarr -I../../Source/bmalloc -I../../Source/WTF -IDerivedSources -I../../Source/ThirdParty -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -stdlib=libc++ -DU_STATIC_IMPLEMENTATION -fno-strict-aliasing -fno-exceptions -std=c++14 -fno-rtti -gsplit-dwarf -g -fPIE -MMD -MT Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -MF Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -c ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp Step #4: In file included from ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28: Step #4: In file included from ../../Source/JavaScriptCore/bytecode/ArrayProfile.h:28: Step #4: In file included from ../../Source/JavaScriptCore/runtime/ConcurrentJSLock.h:28: Step #4: In file included from ../../Source/JavaScriptCore/heap/DeferGC.h:29: Step #4: In file included from ../../Source/JavaScriptCore/heap/Heap.h:24: Step #4: In file included from ../../Source/JavaScriptCore/runtime/ArrayBuffer.h:35: Step #4: In file included from ../../Source/WTF/wtf/text/WTFString.h:31: Step #4: ../../Source/WTF/wtf/text/StringImpl.h:27:10: fatal error: 'unicode/ustring.h' file not found Step #4: #include <unicode/ustring.h> Step #4: ^~~~~~~~~~~~~~~~~~~ Step #4: 1 error generated. Step #4: ninja: build stopped: subcommand failed. Finished Step #4 ERROR ERROR: build step 4 "gcr.io/oss-fuzz/jsc" failed: exit status 1 1391095 1 ddkilzer 2018-01-19 12:14:52 -0800 The WPE and GTK Linux ports are compiling without errors on WebKit's buildbots (scroll to the bottom), although they aren't doing clean builds every time: <https://build.webkit.org/dashboard/> oss-fuzz folks: Is the <unicode/ustring.h> header installed with the ICU package(s) on the builder? It appears that the compiler command for Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp is not including a path to the ICU headers. If so, this may be a CMake configuration issue, and Source/JavaScriptCore/CMakeLists.txt may need something like this for the LLIntOffsetsExtractor target: set(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES "${ICU_INCLUDE_DIRS}" ) If I had to guess, it would be to add something like this to Source/JavaScriptCore/CMakeLists.txt: set(LLIntOffsetsExtractor_SYSTEM_INCLUDE_DIRECTORIES "${ICU_INCLUDE_DIRS}" ) However, I'm not a CMake expert, so I have no idea if that would work. 1391102 2 331769 ddkilzer 2018-01-19 12:26:40 -0800 Created attachment 331769 Patch v1 1391103 3 ddkilzer 2018-01-19 12:30:02 -0800 (In reply to David Kilzer (:ddkilzer) from comment #1) > If I had to guess, it would be to add something like this to > Source/JavaScriptCore/CMakeLists.txt: > > set(LLIntOffsetsExtractor_SYSTEM_INCLUDE_DIRECTORIES > "${ICU_INCLUDE_DIRS}" > ) > > However, I'm not a CMake expert, so I have no idea if that would work. I Guessed Different in Attachment #331769: target_include_directories(LLIntOffsetsExtractor SYSTEM PUBLIC ${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES}) 1391104 4 331770 ddkilzer 2018-01-19 12:31:39 -0800 Created attachment 331770 Patch v2 1391106 5 ddkilzer 2018-01-19 12:32:47 -0800 (In reply to David Kilzer (:ddkilzer) from comment #4) > Created attachment 331770 [details] > Patch v2 Just fixed the title of the bug in the ChangeLog; no other changes. 1391107 6 331770 jfbastien 2018-01-19 12:38:10 -0800 Comment on attachment 331770 Patch v2 rs=me if that works. Thanks! 1391164 7 ddkilzer 2018-01-19 13:48:01 -0800 (In reply to JF Bastien from comment #6) > Comment on attachment 331770 [details] > Patch v2 > > rs=me if that works. Thanks! Abhishek confirmed via email that this fixed the build. Landing shortly. 1391165 8 ddkilzer 2018-01-19 13:48:50 -0800 Committed r227233: <https://trac.webkit.org/changeset/227233> 1391166 9 webkit-bug-importer 2018-01-19 13:49:27 -0800 <rdar://problem/36669691> 1391245 10 annulen 2018-01-19 15:53:06 -0800 This change is correct. It could have been SYSTEM PRIVATE to match PRIVATE on previous line, but for executable target it actually makes no difference. 1392291 11 ddkilzer 2018-01-23 15:19:39 -0800 (In reply to Konstantin Tokarev from comment #10) > This change is correct. It could have been SYSTEM PRIVATE to match PRIVATE > on previous line, but for executable target it actually makes no difference. Landed this change in: Committed r227453: <https://trac.webkit.org/changeset/227453> Thanks! 331769 2018-01-19 12:26:40 -0800 2018-01-19 12:31:38 -0800 Patch v1 bug-181871-20180119122639.patch text/plain 1527 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NTc4M2U3NWRiNzZkN2M2YzlmNWZhNjY1MmY0M2U5NjNkNDUwNzBjLi41MTBmMDIwODcwODgxMjY4 ZGQ2ZjFhYjhjZjRmMjYzMjFkZjc2NjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wMS0xOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIG9zcy1mdXp6IGJ1aWxkIGlzIGJyb2tlbjogU3RyaW5nSW1wbC5oOjI3OjEw OiBmYXRhbCBlcnJvcjogJ3VuaWNvZGUvdXN0cmluZy5oJyBmaWxlIG5vdCBmb3VuZAorICAgICAg ICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTgxODcxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IEFkZCBJQ1UgaGVhZGVy IHNlYXJjaCBwYXRoIHRvCisgICAgICAgIExMSW50T2Zmc2V0c0V4dHJhY3RvciB0YXJnZXQgYnkg cmV1c2luZworICAgICAgICBKYXZhU2NyaXB0Q29yZV9TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklF Uy4KKwogMjAxOC0wMS0xOCAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAg ICAgICAgU2V0IHRoZSBtaW5pbXVtIGV4ZWN1dGFibGUgYWxsb2NhdG9yIHNpemUgcHJvcGVybHkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBmZjZhZTEyN2Q5ZjU4NWMyNTlh OGIxNGUyYjVhMzczMmNhYzc3MzI3Li45MTRlMTg5MGJmM2ZlM2MwOWFiNzMxOTUxMzI3ODU4OTk2 ZTNjMTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC01OTYsNiArNTk2 LDcgQEAgV0VCS0lUX0lOQ0xVREVfQ09ORklHX0ZJTEVTX0lGX0VYSVNUUygpCiBXRUJLSVRfQ1JF QVRFX0ZPUldBUkRJTkdfSEVBREVSUyhKYXZhU2NyaXB0Q29yZSBESVJFQ1RPUklFUyAke0phdmFT Y3JpcHRDb3JlX0ZPUldBUkRJTkdfSEVBREVSU19ESVJFQ1RPUklFU30gRklMRVMgJHtKYXZhU2Ny aXB0Q29yZV9GT1JXQVJESU5HX0hFQURFUlNfRklMRVN9KQogCiB0YXJnZXRfaW5jbHVkZV9kaXJl Y3RvcmllcyhMTEludE9mZnNldHNFeHRyYWN0b3IgUFJJVkFURSAke0phdmFTY3JpcHRDb3JlX0lO Q0xVREVfRElSRUNUT1JJRVN9KQordGFyZ2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMoTExJbnRPZmZz ZXRzRXh0cmFjdG9yIFNZU1RFTSBQVUJMSUMgJHtKYXZhU2NyaXB0Q29yZV9TWVNURU1fSU5DTFVE RV9ESVJFQ1RPUklFU30pCiAKIGFkZF9zdWJkaXJlY3Rvcnkoc2hlbGwpCiAK 331770 2018-01-19 12:31:39 -0800 2018-01-19 12:31:51 -0800 Patch v2 bug-181871-20180119123139.patch text/plain 1531 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NTc4M2U3NWRiNzZkN2M2YzlmNWZhNjY1MmY0M2U5NjNkNDUwNzBjLi4xYWM1YjE2ZDZmODEwZGY0 MGI5MDc1MGI2MTFhNjljMDNjNmVkNDhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wMS0xOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIG9zcy1mdXp6IGpzYyBidWlsZCBpcyBicm9rZW46IFN0cmluZ0ltcGwuaDoy NzoxMDogZmF0YWwgZXJyb3I6ICd1bmljb2RlL3VzdHJpbmcuaCcgZmlsZSBub3QgZm91bmQKKyAg ICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE4MTg3MT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBBZGQgSUNVIGhl YWRlciBzZWFyY2ggcGF0aCB0bworICAgICAgICBMTEludE9mZnNldHNFeHRyYWN0b3IgdGFyZ2V0 IGJ5IHJldXNpbmcKKyAgICAgICAgSmF2YVNjcmlwdENvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNU T1JJRVMuCisKIDIwMTgtMDEtMTggIEpGIEJhc3RpZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgog CiAgICAgICAgIFNldCB0aGUgbWluaW11bSBleGVjdXRhYmxlIGFsbG9jYXRvciBzaXplIHByb3Bl cmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggZmY2YWUxMjdkOWY1ODVj MjU5YThiMTRlMmI1YTM3MzJjYWM3NzMyNy4uOTE0ZTE4OTBiZjNmZTNjMDlhYjczMTk1MTMyNzg1 ODk5NmUzYzE2OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMu dHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtNTk2LDYg KzU5Niw3IEBAIFdFQktJVF9JTkNMVURFX0NPTkZJR19GSUxFU19JRl9FWElTVFMoKQogV0VCS0lU X0NSRUFURV9GT1JXQVJESU5HX0hFQURFUlMoSmF2YVNjcmlwdENvcmUgRElSRUNUT1JJRVMgJHtK YXZhU2NyaXB0Q29yZV9GT1JXQVJESU5HX0hFQURFUlNfRElSRUNUT1JJRVN9IEZJTEVTICR7SmF2 YVNjcmlwdENvcmVfRk9SV0FSRElOR19IRUFERVJTX0ZJTEVTfSkKIAogdGFyZ2V0X2luY2x1ZGVf ZGlyZWN0b3JpZXMoTExJbnRPZmZzZXRzRXh0cmFjdG9yIFBSSVZBVEUgJHtKYXZhU2NyaXB0Q29y ZV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKK3RhcmdldF9pbmNsdWRlX2RpcmVjdG9yaWVzKExMSW50 T2Zmc2V0c0V4dHJhY3RvciBTWVNURU0gUFVCTElDICR7SmF2YVNjcmlwdENvcmVfU1lTVEVNX0lO Q0xVREVfRElSRUNUT1JJRVN9KQogCiBhZGRfc3ViZGlyZWN0b3J5KHNoZWxsKQogCg==