181863 2018-01-19 10:10:57 -0800 REGRESSION (r223149): Ref WebPageProxy objects before calling their functionality 2018-01-19 11:02:10 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181771 InRadar, Regression P2 Normal --- 178102 1 dbates dbates cdumez sam thorton webkit-bug-importer oldest_to_newest 1391003 0 dbates 2018-01-19 10:10:57 -0800 Changeset <https://trac.webkit.org/changeset/223149/> (bug #178102) inadvertently changed the copying semantics in WebProcessProxy such that we no longer ref WebPageProxy objects before calling their functionality. In bug #181771 we fixed this inadvertent change made in WebProcessProxy::didClose(). There are more places that r223149 touched that we need to fix up. It is not safe to loop over WebPageProxy objects calling functionality that may call a delegate because the delegate can do anything including deallocating itself and other WebPageProxy objects. 1391004 1 webkit-bug-importer 2018-01-19 10:11:50 -0800 <rdar://problem/36662452> 1391007 2 331748 dbates 2018-01-19 10:20:07 -0800 Created attachment 331748 Patch 1391009 3 331748 cdumez 2018-01-19 10:21:10 -0800 Comment on attachment 331748 Patch r=me 1391031 4 331748 dbates 2018-01-19 11:02:09 -0800 Comment on attachment 331748 Patch Clearing flags on attachment: 331748 Committed r227218: <https://trac.webkit.org/changeset/227218> 1391032 5 dbates 2018-01-19 11:02:10 -0800 All reviewed patches have been landed. Closing bug. 331748 2018-01-19 10:20:07 -0800 2018-01-19 11:02:09 -0800 Patch bug-181863-20180119102006.patch text/plain 3149 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE4ODdhYjMxZjU4OTIzNGZh M2IxMjU5OTEyMjAxNzMxYjQ0M2VmMGMuLmM0OTdmZTZjNTdiNDFkMTA3YmFiMWY4MTdhZDZiYjcx MDE0OWM3MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDEtMTkgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMjMxNDkp OiBSZWYgV2ViUGFnZVByb3h5IG9iamVjdHMgYmVmb3JlIGNhbGxpbmcgdGhlaXIgZnVuY3Rpb25h bGl0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgx ODYzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjY2MjQ1Mj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3JlIGZpeCB1cHMgZm9sbG93aW5nIHIy MjMxNDkuIFdoZW4gbm90aWZ5aW5nIGFsbCBwYWdlcyBvZiBhIHByb2Nlc3Mgc3RhdGUgY2hhbmdl IHdlIG5lZWQgdG8KKyAgICAgICAgdGFrZSBjYXJlIHRvIHJlZiBhbGwgdGhlIHBhZ2VzIGJlZm9y ZSBpdGVyYXRpbmcgb3ZlciB0aGVtIGFuZCBub3RpZnlpbmcgdGhlbSBvZiB0aGUgY2hhbmdlLgor ICAgICAgICBOb3RpZnlpbmcgYSBwYWdlIG9mIHN1Y2ggYSBzdGF0ZSBjaGFuZ2UgbWF5IHVsdGlt YXRlbHkgZGVsZWdhdGUgdG8gdGhlIGVtYmVkZGluZyBjbGllbnQuIEFuZAorICAgICAgICB0aGUg ZW1iZWRkaW5nIGNsaWVudCBjYW4gZG8gYW55dGhpbmcsIGluY2x1ZGluZyBkZWFsbG9jYXRpbmcg b25lIG9yIG1vcmUgcGFnZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5OjpkaWRCZWNvbWVVbnJlc3Bv bnNpdmUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmRpZEJlY29tZVJlc3Bv bnNpdmUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OndpbGxDaGFuZ2VJc1Jl c3BvbnNpdmUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmRpZENoYW5nZUlz UmVzcG9uc2l2ZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6cmVxdWVzdFRl cm1pbmF0aW9uKToKKwogMjAxOC0wMS0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIFdlIHNob3VsZCBiZSBhYmxlIHRvIHRlcm1pbmF0ZSBzZXJ2aWNlIHdvcmtl cnMgdGhhdCBhcmUgdW5yZXNwb25zaXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Byb3h5LmNwcAppbmRleCAzYTI3MWJlY2YyNWY3MWZkYzE2ZDYzZDcxZTQ0ODZmMzc5NDFj ZTU1Li5kNWZiODlmYjljYWEwNjA3NDAyMmI3ZjQ0NTE1NWFjZWU1ZDJlZmI0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKQEAgLTY2Niw3ICs2NjYsNyBA QCB2b2lkIFdlYlByb2Nlc3NQcm94eTo6ZGlkQmVjb21lVW5yZXNwb25zaXZlKCkKIAogICAgIGF1 dG8gaXNSZXNwb25zaXZlQ2FsbGJhY2tzID0gV1RGTW92ZShtX2lzUmVzcG9uc2l2ZUNhbGxiYWNr cyk7CiAKLSAgICBmb3IgKGF1dG8mIHBhZ2UgOiBjb3B5VG9WZWN0b3IobV9wYWdlTWFwLnZhbHVl cygpKSkKKyAgICBmb3IgKGF1dG8mIHBhZ2UgOiBjb3B5VG9WZWN0b3JPZjxSZWZQdHI8V2ViUGFn ZVByb3h5Pj4obV9wYWdlTWFwLnZhbHVlcygpKSkKICAgICAgICAgcGFnZS0+cHJvY2Vzc0RpZEJl Y29tZVVucmVzcG9uc2l2ZSgpOwogCiAgICAgYm9vbCBpc1dlYlByb2Nlc3NSZXNwb25zaXZlID0g ZmFsc2U7CkBAIC02NzgsMTkgKzY3OCwxOSBAQCB2b2lkIFdlYlByb2Nlc3NQcm94eTo6ZGlkQmVj b21lUmVzcG9uc2l2ZSgpCiB7CiAgICAgbV9pc1Jlc3BvbnNpdmUgPSBOb09yTWF5YmU6Ok1heWJl OwogCi0gICAgZm9yIChhdXRvJiBwYWdlIDogY29weVRvVmVjdG9yKG1fcGFnZU1hcC52YWx1ZXMo KSkpCisgICAgZm9yIChhdXRvJiBwYWdlIDogY29weVRvVmVjdG9yT2Y8UmVmUHRyPFdlYlBhZ2VQ cm94eT4+KG1fcGFnZU1hcC52YWx1ZXMoKSkpCiAgICAgICAgIHBhZ2UtPnByb2Nlc3NEaWRCZWNv bWVSZXNwb25zaXZlKCk7CiB9CiAKIHZvaWQgV2ViUHJvY2Vzc1Byb3h5Ojp3aWxsQ2hhbmdlSXNS ZXNwb25zaXZlKCkKIHsKLSAgICBmb3IgKGF1dG8mIHBhZ2UgOiBjb3B5VG9WZWN0b3IobV9wYWdl TWFwLnZhbHVlcygpKSkKKyAgICBmb3IgKGF1dG8mIHBhZ2UgOiBjb3B5VG9WZWN0b3JPZjxSZWZQ dHI8V2ViUGFnZVByb3h5Pj4obV9wYWdlTWFwLnZhbHVlcygpKSkKICAgICAgICAgcGFnZS0+d2ls bENoYW5nZVByb2Nlc3NJc1Jlc3BvbnNpdmUoKTsKIH0KIAogdm9pZCBXZWJQcm9jZXNzUHJveHk6 OmRpZENoYW5nZUlzUmVzcG9uc2l2ZSgpCiB7Ci0gICAgZm9yIChhdXRvJiBwYWdlIDogY29weVRv VmVjdG9yKG1fcGFnZU1hcC52YWx1ZXMoKSkpCisgICAgZm9yIChhdXRvJiBwYWdlIDogY29weVRv VmVjdG9yT2Y8UmVmUHRyPFdlYlBhZ2VQcm94eT4+KG1fcGFnZU1hcC52YWx1ZXMoKSkpCiAgICAg ICAgIHBhZ2UtPmRpZENoYW5nZVByb2Nlc3NJc1Jlc3BvbnNpdmUoKTsKIH0KIApAQCAtODg4LDcg Kzg4OCw3IEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5OjpyZXF1ZXN0VGVybWluYXRpb24oUHJvY2Vz c1Rlcm1pbmF0aW9uUmVhc29uIHJlYXNvbikKICAgICBpZiAod2ViQ29ubmVjdGlvbigpKQogICAg ICAgICB3ZWJDb25uZWN0aW9uKCktPmRpZENsb3NlKCk7CiAKLSAgICBhdXRvIHBhZ2VzID0gY29w eVRvVmVjdG9yKG1fcGFnZU1hcC52YWx1ZXMoKSk7CisgICAgYXV0byBwYWdlcyA9IGNvcHlUb1Zl Y3Rvck9mPFJlZlB0cjxXZWJQYWdlUHJveHk+PihtX3BhZ2VNYXAudmFsdWVzKCkpOwogCiAgICAg c2h1dERvd24oKTsKIAo=