181827 2018-01-18 19:00:30 -0800 Update XPCSPI.h 2018-01-19 10:09:29 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap benjamin cdumez cmarcelo commit-queue dbates ews-watchlist thorton oldest_to_newest 1390772 0 ap 2018-01-18 19:00:30 -0800 rdar://problem/36393031 1390795 1 331702 ap 2018-01-18 20:18:24 -0800 Created attachment 331702 proposed patch 1390796 2 ews-watchlist 2018-01-18 20:19:58 -0800 Attachment 331702 did not pass style-queue: ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1390820 3 331709 ap 2018-01-18 21:30:28 -0800 Created attachment 331709 proposed patch 1390821 4 ews-watchlist 2018-01-18 21:32:54 -0800 Attachment 331709 did not pass style-queue: ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1390828 5 331710 ap 2018-01-18 21:53:21 -0800 Created attachment 331710 proposed patch 1390829 6 331711 ap 2018-01-18 21:54:24 -0800 Created attachment 331711 proposed patch 1390830 7 ews-watchlist 2018-01-18 21:56:22 -0800 Attachment 331711 did not pass style-queue: ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1390842 8 331711 dbates 2018-01-18 22:39:43 -0800 Comment on attachment 331711 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=331711&action=review I am assuming this only affects iOS as this patch conditioanlizes on it. > Source/WTF/wtf/spi/darwin/XPCSPI.h:59 > +#define XPC_NOESCAPE __attribute__((__noescape__)) I am surprised this works on iOS. I guess clang accepts an attribute name with and without leading and trailing underscores. According to <https://clang.llvm.org/docs/AttributeReference.html#noescape-clang-noescape> clang recognizes __attribute__((noescape)). 1390966 9 ap 2018-01-19 09:36:29 -0800 > I am assuming this only affects iOS as this patch conditioanlizes on it. Both are affected. This patch adds XPC_NOESCAPE to the prototype unconditionally, but also defines it to empty on platforms that don't have it, such as those using older Mac SDKs. Newer Mac SDKs have it. > __attribute__((noescape)) Curious indeed. But it matches the definition in xpc/base.h. 1391000 10 331711 commit-queue 2018-01-19 10:09:27 -0800 Comment on attachment 331711 proposed patch Clearing flags on attachment: 331711 Committed r227212: <https://trac.webkit.org/changeset/227212> 1391001 11 commit-queue 2018-01-19 10:09:29 -0800 All reviewed patches have been landed. Closing bug. 331702 2018-01-18 20:18:24 -0800 2018-01-18 21:30:28 -0800 proposed patch xpcspi.txt text/plain 1983 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjcxNzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTAxLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBYUENTUEkuaAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxODI3CisgICAgICAgIHJkYXI6 Ly9wcm9ibGVtLzM2MzkzMDMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvc3BpL2Rhcndpbi9YUENTUEkuaDoKKwogMjAxOC0wMS0xOCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFdlIHNob3VsZCBiZSBhYmxl IHRvIHRlcm1pbmF0ZSBzZXJ2aWNlIHdvcmtlcnMgdGhhdCBhcmUgdW5yZXNwb25zaXZlCkluZGV4 OiBTb3VyY2UvV1RGL3d0Zi9zcGkvZGFyd2luL1hQQ1NQSS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmgJKHJldmlzaW9uIDIyNzE3OCkKKysrIFNvdXJj ZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTU2LDEwICs1 NiwxOCBAQCB0eXBlZGVmIHZvaWQqIHhwY19jb25uZWN0aW9uX3Q7CiB0eXBlZGVmIGNvbnN0IHN0 cnVjdCBfeHBjX3R5cGVfcyogeHBjX3R5cGVfdDsKIAogI2lmIENPTVBJTEVSX1NVUFBPUlRTKEJM T0NLUykKKworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfU1VQUE9SVEVEID49IDEwMTMwMCAm JiBfX2hhc19hdHRyaWJ1dGUobm9lc2NhcGUpCisjZGVmaW5lIFhQQ19OT0VTQ0FQRSBfX2F0dHJp YnV0ZV9fKChfX25vZXNjYXBlX18pKQorI2Vsc2UKKyNkZWZpbmUgWFBDX05PRVNDQVBFCisjZW5k aWYKKwogdHlwZWRlZiBib29sICheeHBjX2FycmF5X2FwcGxpZXJfdCkoc2l6ZV90IGluZGV4LCB4 cGNfb2JqZWN0X3QpOwogdHlwZWRlZiBib29sICheeHBjX2RpY3Rpb25hcnlfYXBwbGllcl90KShj b25zdCBjaGFyICprZXksIHhwY19vYmplY3RfdCB2YWx1ZSk7CiB0eXBlZGVmIHZvaWQgKF54cGNf aGFuZGxlcl90KSh4cGNfb2JqZWN0X3QpOwotI2VuZGlmCisKKyNlbmRpZiAvLyBDT01QSUxFUl9T VVBQT1JUUyhCTE9DS1MpCiAKIHR5cGVkZWYgdm9pZCAoKnhwY19jb25uZWN0aW9uX2hhbmRsZXJf dCkoeHBjX2Nvbm5lY3Rpb25fdCBjb25uZWN0aW9uKTsKIApAQCAtOTUsOCArMTAzLDggQEAgZXh0 ZXJuIGNvbnN0IHN0cnVjdCBfeHBjX3R5cGVfcyBfeHBjX3R5cAogCiB4cGNfb2JqZWN0X3QgeHBj X2FycmF5X2NyZWF0ZShjb25zdCB4cGNfb2JqZWN0X3QqLCBzaXplX3QgY291bnQpOwogI2lmIENP TVBJTEVSX1NVUFBPUlRTKEJMT0NLUykKLWJvb2wgeHBjX2FycmF5X2FwcGx5KHhwY19vYmplY3Rf dCwgeHBjX2FycmF5X2FwcGxpZXJfdCk7Ci1ib29sIHhwY19kaWN0aW9uYXJ5X2FwcGx5KHhwY19v YmplY3RfdCB4ZGljdCwgeHBjX2RpY3Rpb25hcnlfYXBwbGllcl90IGFwcGxpZXIpOworYm9vbCB4 cGNfYXJyYXlfYXBwbHkoeHBjX29iamVjdF90LCBYUENfTk9FU0NBUEUgeHBjX2FycmF5X2FwcGxp ZXJfdCk7Citib29sIHhwY19kaWN0aW9uYXJ5X2FwcGx5KHhwY19vYmplY3RfdCB4ZGljdCwgWFBD X05PRVNDQVBFIHhwY19kaWN0aW9uYXJ5X2FwcGxpZXJfdCBhcHBsaWVyKTsKICNlbmRpZgogc2l6 ZV90IHhwY19hcnJheV9nZXRfY291bnQoeHBjX29iamVjdF90KTsKIGNvbnN0IGNoYXIqIHhwY19h cnJheV9nZXRfc3RyaW5nKHhwY19vYmplY3RfdCwgc2l6ZV90IGluZGV4KTsK 331709 2018-01-18 21:30:28 -0800 2018-01-18 21:53:21 -0800 proposed patch xpcspi.txt text/plain 1983 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjcxNzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTAxLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBYUENTUEkuaAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxODI3CisgICAgICAgIHJkYXI6 Ly9wcm9ibGVtLzM2MzkzMDMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvc3BpL2Rhcndpbi9YUENTUEkuaDoKKwogMjAxOC0wMS0xOCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFdlIHNob3VsZCBiZSBhYmxl IHRvIHRlcm1pbmF0ZSBzZXJ2aWNlIHdvcmtlcnMgdGhhdCBhcmUgdW5yZXNwb25zaXZlCkluZGV4 OiBTb3VyY2UvV1RGL3d0Zi9zcGkvZGFyd2luL1hQQ1NQSS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmgJKHJldmlzaW9uIDIyNzE3OCkKKysrIFNvdXJj ZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTU2LDEwICs1 NiwxOCBAQCB0eXBlZGVmIHZvaWQqIHhwY19jb25uZWN0aW9uX3Q7CiB0eXBlZGVmIGNvbnN0IHN0 cnVjdCBfeHBjX3R5cGVfcyogeHBjX3R5cGVfdDsKIAogI2lmIENPTVBJTEVSX1NVUFBPUlRTKEJM T0NLUykKKworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfU1VQUE9SVEVEID49IDEwMTMwMCAm JiBfX2hhc19hdHRyaWJ1dGUobm9lc2NhcGUpCisjZGVmaW5lIFhQQ19OT0VTQ0FQRSBfX2F0dHJp YnV0ZV9fKChfX25vZXNjYXBlX18pKQorI2Vsc2UKKyNkZWZpbmUgWFBDX05PRVNDQVBFCisjZW5k aWYKKwogdHlwZWRlZiBib29sICheeHBjX2FycmF5X2FwcGxpZXJfdCkoc2l6ZV90IGluZGV4LCB4 cGNfb2JqZWN0X3QpOwogdHlwZWRlZiBib29sICheeHBjX2RpY3Rpb25hcnlfYXBwbGllcl90KShj b25zdCBjaGFyICprZXksIHhwY19vYmplY3RfdCB2YWx1ZSk7CiB0eXBlZGVmIHZvaWQgKF54cGNf aGFuZGxlcl90KSh4cGNfb2JqZWN0X3QpOwotI2VuZGlmCisKKyNlbmRpZiAvLyBDT01QSUxFUl9T VVBQT1JUUyhCTE9DS1MpCiAKIHR5cGVkZWYgdm9pZCAoKnhwY19jb25uZWN0aW9uX2hhbmRsZXJf dCkoeHBjX2Nvbm5lY3Rpb25fdCBjb25uZWN0aW9uKTsKIApAQCAtOTUsOCArMTAzLDggQEAgZXh0 ZXJuIGNvbnN0IHN0cnVjdCBfeHBjX3R5cGVfcyBfeHBjX3R5cAogCiB4cGNfb2JqZWN0X3QgeHBj X2FycmF5X2NyZWF0ZShjb25zdCB4cGNfb2JqZWN0X3QqLCBzaXplX3QgY291bnQpOwogI2lmIENP TVBJTEVSX1NVUFBPUlRTKEJMT0NLUykKLWJvb2wgeHBjX2FycmF5X2FwcGx5KHhwY19vYmplY3Rf dCwgeHBjX2FycmF5X2FwcGxpZXJfdCk7Ci1ib29sIHhwY19kaWN0aW9uYXJ5X2FwcGx5KHhwY19v YmplY3RfdCB4ZGljdCwgeHBjX2RpY3Rpb25hcnlfYXBwbGllcl90IGFwcGxpZXIpOworYm9vbCB4 cGNfYXJyYXlfYXBwbHkoeHBjX29iamVjdF90LCBYUENfTk9FU0NBUEUgeHBjX2FycmF5X2FwcGxp ZXJfdCk7Citib29sIHhwY19kaWN0aW9uYXJ5X2FwcGx5KHhwY19vYmplY3RfdCB4ZGljdCwgWFBD X05PRVNDQVBFIHhwY19kaWN0aW9uYXJ5X2FwcGxpZXJfdCBhcHBsaWVyKTsKICNlbmRpZgogc2l6 ZV90IHhwY19hcnJheV9nZXRfY291bnQoeHBjX29iamVjdF90KTsKIGNvbnN0IGNoYXIqIHhwY19h cnJheV9nZXRfc3RyaW5nKHhwY19vYmplY3RfdCwgc2l6ZV90IGluZGV4KTsK 331710 2018-01-18 21:53:21 -0800 2018-01-18 21:54:24 -0800 proposed patch XPCSPI.h text/plain 6930 ap LyoKICogQ29weXJpZ2h0IChDKSAyMDE0LTIwMTYgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgogKgogKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv cm1zLCB3aXRoIG9yIHdpdGhvdXQKICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCiAqIGFyZSBtZXQ6CiAqIDEuIFJlZGlz dHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0 CiAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lci4KICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVw cm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQogKiAgICBkb2N1bWVu dGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0 aW9uLgogKgogKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gYGBBUyBJ UycnIEFORCBBTlkKICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5U QUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCiAqIFBVUlBPU0UgQVJFIERJU0NM QUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SCiAqIENPTlRSSUJVVE9SUyBC RSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLAog KiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9U IExJTUlURUQgVE8sCiAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklD RVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgogKiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJV UFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCiAqIE9GIExJQUJJTElUWSwg V0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAogKiAoSU5DTFVE SU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRI RSBVU0UKICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4gCiAqLwoKI3ByYWdtYSBvbmNlCgojaW5jbHVkZSA8ZGlzcGF0 Y2gvZGlzcGF0Y2guaD4KI2luY2x1ZGUgPG9zL29iamVjdC5oPgoKI2lmIFBMQVRGT1JNKE1BQykg fHwgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKI2luY2x1ZGUgPHhwYy94cGMuaD4KI2Vsc2UKCiNp ZiBPU19PQkpFQ1RfVVNFX09CSkMKT1NfT0JKRUNUX0RFQ0woeHBjX29iamVjdCk7CnR5cGVkZWYg eHBjX29iamVjdF90IHhwY19jb25uZWN0aW9uX3Q7CgpzdGF0aWMgQUxXQVlTX0lOTElORSB2b2lk IF94cGNfb2JqZWN0X3ZhbGlkYXRlKHhwY19vYmplY3RfdCBvYmplY3QpCnsKICAgIHZvaWQgKmlz YSA9ICoodm9pZCAqIHZvbGF0aWxlICopKE9TX09CSkVDVF9CUklER0Ugdm9pZCAqKW9iamVjdDsK ICAgICh2b2lkKWlzYTsKfQoKI2RlZmluZSBYUENfR0xPQkFMX09CSkVDVChvYmplY3QpICgoT1Nf T0JKRUNUX0JSSURHRSB4cGNfb2JqZWN0X3QpJihvYmplY3QpKQoKI2Vsc2UgLy8gT1NfT0JKRUNU X1VTRV9PQkpDCgp0eXBlZGVmIHZvaWQqIHhwY19vYmplY3RfdDsKdHlwZWRlZiB2b2lkKiB4cGNf Y29ubmVjdGlvbl90OwoKI2RlZmluZSBYUENfR0xPQkFMX09CSkVDVChvYmplY3QpICgmKG9iamVj dCkpCgojZW5kaWYgLy8gT1NfT0JKRUNUX1VTRV9PQkpDCgp0eXBlZGVmIGNvbnN0IHN0cnVjdCBf eHBjX3R5cGVfcyogeHBjX3R5cGVfdDsKCiNpZiBQTEFURk9STShJT1MpICYmIF9faGFzX2F0dHJp YnV0ZShub2VzY2FwZSkKI2RlZmluZSBYUENfTk9FU0NBUEUgX19hdHRyaWJ1dGVfXygoX19ub2Vz Y2FwZV9fKSkKI2VuZGlmCgojaWYgQ09NUElMRVJfU1VQUE9SVFMoQkxPQ0tTKQp0eXBlZGVmIGJv b2wgKF54cGNfYXJyYXlfYXBwbGllcl90KShzaXplX3QgaW5kZXgsIHhwY19vYmplY3RfdCk7CnR5 cGVkZWYgYm9vbCAoXnhwY19kaWN0aW9uYXJ5X2FwcGxpZXJfdCkoY29uc3QgY2hhciAqa2V5LCB4 cGNfb2JqZWN0X3QgdmFsdWUpOwp0eXBlZGVmIHZvaWQgKF54cGNfaGFuZGxlcl90KSh4cGNfb2Jq ZWN0X3QpOwojZW5kaWYgLy8gQ09NUElMRVJfU1VQUE9SVFMoQkxPQ0tTKQoKdHlwZWRlZiB2b2lk ICgqeHBjX2Nvbm5lY3Rpb25faGFuZGxlcl90KSh4cGNfY29ubmVjdGlvbl90IGNvbm5lY3Rpb24p OwoKI2RlZmluZSBYUENfQVJSQVlfQVBQRU5EICgoc2l6ZV90KSgtMSkpCiNkZWZpbmUgWFBDX0VS Uk9SX0NPTk5FQ1RJT05fSU5WQUxJRCBYUENfR0xPQkFMX09CSkVDVChfeHBjX2Vycm9yX2Nvbm5l Y3Rpb25faW52YWxpZCkKI2RlZmluZSBYUENfRVJST1JfVEVSTUlOQVRJT05fSU1NSU5FTlQgWFBD X0dMT0JBTF9PQkpFQ1QoX3hwY19lcnJvcl90ZXJtaW5hdGlvbl9pbW1pbmVudCkKI2RlZmluZSBY UENfVFlQRV9BUlJBWSAoJl94cGNfdHlwZV9hcnJheSkKI2RlZmluZSBYUENfVFlQRV9CT09MICgm X3hwY190eXBlX2Jvb2wpCiNkZWZpbmUgWFBDX1RZUEVfRElDVElPTkFSWSAoJl94cGNfdHlwZV9k aWN0aW9uYXJ5KQojZGVmaW5lIFhQQ19UWVBFX0VSUk9SICgmX3hwY190eXBlX2Vycm9yKQojZGVm aW5lIFhQQ19UWVBFX1NUUklORyAoJl94cGNfdHlwZV9zdHJpbmcpCgojZW5kaWYgLy8gUExBVEZP Uk0oTUFDKSB8fCBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQoKI2lmIFVTRShBUFBMRV9JTlRFUk5B TF9TREspCiNpbmNsdWRlIDx4cGMvcHJpdmF0ZS5oPgojZWxzZQplbnVtIHsKICAgIERJU1BBVENI X01BQ0hfU0VORF9QT1NTSUJMRSA9IDB4OCwKfTsKI2VuZGlmCgojaWYgIWRlZmluZWQoWFBDX05P RVNDQVBFKQojZGVmaW5lIFhQQ19OT0VTQ0FQRQojZW5kaWYKCldURl9FWFRFUk5fQ19CRUdJTgoK ZXh0ZXJuIGNvbnN0IHN0cnVjdCBfeHBjX2RpY3Rpb25hcnlfcyBfeHBjX2Vycm9yX2Nvbm5lY3Rp b25faW52YWxpZDsKZXh0ZXJuIGNvbnN0IHN0cnVjdCBfeHBjX2RpY3Rpb25hcnlfcyBfeHBjX2Vy cm9yX3Rlcm1pbmF0aW9uX2ltbWluZW50OwoKZXh0ZXJuIGNvbnN0IHN0cnVjdCBfeHBjX3R5cGVf cyBfeHBjX3R5cGVfYXJyYXk7CmV4dGVybiBjb25zdCBzdHJ1Y3QgX3hwY190eXBlX3MgX3hwY190 eXBlX2Jvb2w7CmV4dGVybiBjb25zdCBzdHJ1Y3QgX3hwY190eXBlX3MgX3hwY190eXBlX2RpY3Rp b25hcnk7CmV4dGVybiBjb25zdCBzdHJ1Y3QgX3hwY190eXBlX3MgX3hwY190eXBlX2Vycm9yOwpl eHRlcm4gY29uc3Qgc3RydWN0IF94cGNfdHlwZV9zIF94cGNfdHlwZV9zdHJpbmc7Cgp4cGNfb2Jq ZWN0X3QgeHBjX2FycmF5X2NyZWF0ZShjb25zdCB4cGNfb2JqZWN0X3QqLCBzaXplX3QgY291bnQp OwojaWYgQ09NUElMRVJfU1VQUE9SVFMoQkxPQ0tTKQpib29sIHhwY19hcnJheV9hcHBseSh4cGNf b2JqZWN0X3QsIFhQQ19OT0VTQ0FQRSB4cGNfYXJyYXlfYXBwbGllcl90KTsKYm9vbCB4cGNfZGlj dGlvbmFyeV9hcHBseSh4cGNfb2JqZWN0X3QgeGRpY3QsIFhQQ19OT0VTQ0FQRSB4cGNfZGljdGlv bmFyeV9hcHBsaWVyX3QgYXBwbGllcik7CiNlbmRpZgpzaXplX3QgeHBjX2FycmF5X2dldF9jb3Vu dCh4cGNfb2JqZWN0X3QpOwpjb25zdCBjaGFyKiB4cGNfYXJyYXlfZ2V0X3N0cmluZyh4cGNfb2Jq ZWN0X3QsIHNpemVfdCBpbmRleCk7CnZvaWQgeHBjX2FycmF5X3NldF9zdHJpbmcoeHBjX29iamVj dF90LCBzaXplX3QgaW5kZXgsIGNvbnN0IGNoYXIqIHN0cmluZyk7CmJvb2wgeHBjX2Jvb2xfZ2V0 X3ZhbHVlKHhwY19vYmplY3RfdCk7CnZvaWQgeHBjX2Nvbm5lY3Rpb25fY2FuY2VsKHhwY19jb25u ZWN0aW9uX3QpOwp4cGNfY29ubmVjdGlvbl90IHhwY19jb25uZWN0aW9uX2NyZWF0ZShjb25zdCBj aGFyKiBuYW1lLCBkaXNwYXRjaF9xdWV1ZV90KTsKeHBjX2Nvbm5lY3Rpb25fdCB4cGNfY29ubmVj dGlvbl9jcmVhdGVfbWFjaF9zZXJ2aWNlKGNvbnN0IGNoYXIqIG5hbWUsIGRpc3BhdGNoX3F1ZXVl X3QsIHVpbnQ2NF90IGZsYWdzKTsKcGlkX3QgeHBjX2Nvbm5lY3Rpb25fZ2V0X3BpZCh4cGNfY29u bmVjdGlvbl90KTsKdm9pZCB4cGNfY29ubmVjdGlvbl9yZXN1bWUoeHBjX2Nvbm5lY3Rpb25fdCk7 CnZvaWQgeHBjX2Nvbm5lY3Rpb25fc2VuZF9tZXNzYWdlKHhwY19jb25uZWN0aW9uX3QsIHhwY19v YmplY3RfdCk7CnZvaWQgeHBjX2Nvbm5lY3Rpb25fc2VuZF9tZXNzYWdlX3dpdGhfcmVwbHkoeHBj X2Nvbm5lY3Rpb25fdCwgeHBjX29iamVjdF90LCBkaXNwYXRjaF9xdWV1ZV90LCB4cGNfaGFuZGxl cl90KTsKdm9pZCB4cGNfY29ubmVjdGlvbl9zZXRfZXZlbnRfaGFuZGxlcih4cGNfY29ubmVjdGlv bl90LCB4cGNfaGFuZGxlcl90KTsKdm9pZCB4cGNfY29ubmVjdGlvbl9zZXRfdGFyZ2V0X3F1ZXVl KHhwY19jb25uZWN0aW9uX3QsIGRpc3BhdGNoX3F1ZXVlX3QpOwp4cGNfb2JqZWN0X3QgeHBjX2Rp Y3Rpb25hcnlfY3JlYXRlKGNvbnN0IGNoYXIqICBjb25zdCoga2V5cywgY29uc3QgeHBjX29iamVj dF90Kiwgc2l6ZV90IGNvdW50KTsKeHBjX29iamVjdF90IHhwY19kaWN0aW9uYXJ5X2NyZWF0ZV9y ZXBseSh4cGNfb2JqZWN0X3QpOwppbnQgeHBjX2RpY3Rpb25hcnlfZHVwX2ZkKHhwY19vYmplY3Rf dCwgY29uc3QgY2hhcioga2V5KTsKeHBjX2Nvbm5lY3Rpb25fdCB4cGNfZGljdGlvbmFyeV9nZXRf cmVtb3RlX2Nvbm5lY3Rpb24oeHBjX29iamVjdF90KTsKYm9vbCB4cGNfZGljdGlvbmFyeV9nZXRf Ym9vbCh4cGNfb2JqZWN0X3QsIGNvbnN0IGNoYXIqIGtleSk7CmNvbnN0IGNoYXIqIHhwY19kaWN0 aW9uYXJ5X2dldF9zdHJpbmcoeHBjX29iamVjdF90LCBjb25zdCBjaGFyKiBrZXkpOwp1aW50NjRf dCB4cGNfZGljdGlvbmFyeV9nZXRfdWludDY0KHhwY19vYmplY3RfdCwgY29uc3QgY2hhcioga2V5 KTsKeHBjX29iamVjdF90IHhwY19kaWN0aW9uYXJ5X2dldF92YWx1ZSh4cGNfb2JqZWN0X3QsIGNv bnN0IGNoYXIqIGtleSk7CnZvaWQgeHBjX2RpY3Rpb25hcnlfc2V0X2Jvb2woeHBjX29iamVjdF90 LCBjb25zdCBjaGFyKiBrZXksIGJvb2wgdmFsdWUpOwp2b2lkIHhwY19kaWN0aW9uYXJ5X3NldF9m ZCh4cGNfb2JqZWN0X3QsIGNvbnN0IGNoYXIqIGtleSwgaW50IGZkKTsKdm9pZCB4cGNfZGljdGlv bmFyeV9zZXRfc3RyaW5nKHhwY19vYmplY3RfdCwgY29uc3QgY2hhcioga2V5LCBjb25zdCBjaGFy KiBzdHJpbmcpOwp2b2lkIHhwY19kaWN0aW9uYXJ5X3NldF91aW50NjQoeHBjX29iamVjdF90LCBj b25zdCBjaGFyKiBrZXksIHVpbnQ2NF90IHZhbHVlKTsKdm9pZCB4cGNfZGljdGlvbmFyeV9zZXRf dmFsdWUoeHBjX29iamVjdF90LCBjb25zdCBjaGFyKmtleSwgeHBjX29iamVjdF90IHZhbHVlKTsK eHBjX3R5cGVfdCB4cGNfZ2V0X3R5cGUoeHBjX29iamVjdF90KTsKdm9pZCB4cGNfbWFpbih4cGNf Y29ubmVjdGlvbl9oYW5kbGVyX3QpOwpjb25zdCBjaGFyKiB4cGNfc3RyaW5nX2dldF9zdHJpbmdf cHRyKHhwY19vYmplY3RfdCk7CnZvaWQgeHBjX3RyYW5zYWN0aW9uX2JlZ2luKHZvaWQpOwp2b2lk IHhwY190cmFuc2FjdGlvbl9lbmQodm9pZCk7CnZvaWQgeHBjX3RyYW5zYWN0aW9uX2V4aXRfY2xl YW4odm9pZCk7CnZvaWQgeHBjX3RyYWNrX2FjdGl2aXR5KHZvaWQpOwoKeHBjX29iamVjdF90IHhw Y19jb25uZWN0aW9uX2NvcHlfZW50aXRsZW1lbnRfdmFsdWUoeHBjX2Nvbm5lY3Rpb25fdCwgY29u c3QgY2hhciogZW50aXRsZW1lbnQpOwp2b2lkIHhwY19jb25uZWN0aW9uX2dldF9hdWRpdF90b2tl bih4cGNfY29ubmVjdGlvbl90LCBhdWRpdF90b2tlbl90Kik7CnZvaWQgeHBjX2Nvbm5lY3Rpb25f a2lsbCh4cGNfY29ubmVjdGlvbl90LCBpbnQpOwp2b2lkIHhwY19jb25uZWN0aW9uX3NldF9pbnN0 YW5jZSh4cGNfY29ubmVjdGlvbl90LCB1dWlkX3QpOwptYWNoX3BvcnRfdCB4cGNfZGljdGlvbmFy eV9jb3B5X21hY2hfc2VuZCh4cGNfb2JqZWN0X3QsIGNvbnN0IGNoYXIqKTsKdm9pZCB4cGNfZGlj dGlvbmFyeV9zZXRfbWFjaF9zZW5kKHhwY19vYmplY3RfdCwgY29uc3QgY2hhciosIG1hY2hfcG9y dF90KTsKCnZvaWQgeHBjX2Nvbm5lY3Rpb25fc2V0X2Jvb3RzdHJhcCh4cGNfY29ubmVjdGlvbl90 LCB4cGNfb2JqZWN0X3QgYm9vdHN0cmFwKTsKeHBjX29iamVjdF90IHhwY19jb3B5X2Jvb3RzdHJh cCh2b2lkKTsKdm9pZCB4cGNfY29ubmVjdGlvbl9zZXRfb25lc2hvdF9pbnN0YW5jZSh4cGNfY29u bmVjdGlvbl90LCB1dWlkX3QgaW5zdGFuY2UpOwoKI2lmIE9TX09CSkVDVF9VU0VfT0JKQ19SRVRB SU5fUkVMRUFTRQojaWYgIWRlZmluZWQoeHBjX3JldGFpbikKI2RlZmluZSB4cGNfcmV0YWluKG9i amVjdCkgKHsgeHBjX29iamVjdF90IF9vID0gKG9iamVjdCk7IF94cGNfb2JqZWN0X3ZhbGlkYXRl KF9vKTsgW19vIHJldGFpbl07IH0pCiNlbmRpZgojZWxzZQp4cGNfb2JqZWN0X3QgeHBjX3JldGFp bih4cGNfb2JqZWN0X3QpOwojZW5kaWYKCiNpZiBPU19PQkpFQ1RfVVNFX09CSkNfUkVUQUlOX1JF TEVBU0UKI2lmICFkZWZpbmVkKHhwY19yZWxlYXNlKQojZGVmaW5lIHhwY19yZWxlYXNlKG9iamVj dCkgKHsgeHBjX29iamVjdF90IF9vID0gKG9iamVjdCk7IF94cGNfb2JqZWN0X3ZhbGlkYXRlKF9v KTsgW19vIHJlbGVhc2VdOyB9KQojZW5kaWYKI2Vsc2UKdm9pZCB4cGNfcmVsZWFzZSh4cGNfb2Jq ZWN0X3QpOwojZW5kaWYKCldURl9FWFRFUk5fQ19FTkQK 331711 2018-01-18 21:54:24 -0800 2018-01-19 10:09:27 -0800 proposed patch xpcspi.txt text/plain 2115 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjcxNzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTAxLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBYUENTUEkuaAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxODI3CisgICAgICAgIHJkYXI6 Ly9wcm9ibGVtLzM2MzkzMDMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvc3BpL2Rhcndpbi9YUENTUEkuaDoKKwogMjAxOC0wMS0xOCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFdlIHNob3VsZCBiZSBhYmxl IHRvIHRlcm1pbmF0ZSBzZXJ2aWNlIHdvcmtlcnMgdGhhdCBhcmUgdW5yZXNwb25zaXZlCkluZGV4 OiBTb3VyY2UvV1RGL3d0Zi9zcGkvZGFyd2luL1hQQ1NQSS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmgJKHJldmlzaW9uIDIyNzE3OCkKKysrIFNvdXJj ZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTU1LDExICs1 NSwxNSBAQCB0eXBlZGVmIHZvaWQqIHhwY19jb25uZWN0aW9uX3Q7CiAKIHR5cGVkZWYgY29uc3Qg c3RydWN0IF94cGNfdHlwZV9zKiB4cGNfdHlwZV90OwogCisjaWYgUExBVEZPUk0oSU9TKSAmJiBf X2hhc19hdHRyaWJ1dGUobm9lc2NhcGUpCisjZGVmaW5lIFhQQ19OT0VTQ0FQRSBfX2F0dHJpYnV0 ZV9fKChfX25vZXNjYXBlX18pKQorI2VuZGlmCisKICNpZiBDT01QSUxFUl9TVVBQT1JUUyhCTE9D S1MpCiB0eXBlZGVmIGJvb2wgKF54cGNfYXJyYXlfYXBwbGllcl90KShzaXplX3QgaW5kZXgsIHhw Y19vYmplY3RfdCk7CiB0eXBlZGVmIGJvb2wgKF54cGNfZGljdGlvbmFyeV9hcHBsaWVyX3QpKGNv bnN0IGNoYXIgKmtleSwgeHBjX29iamVjdF90IHZhbHVlKTsKIHR5cGVkZWYgdm9pZCAoXnhwY19o YW5kbGVyX3QpKHhwY19vYmplY3RfdCk7Ci0jZW5kaWYKKyNlbmRpZiAvLyBDT01QSUxFUl9TVVBQ T1JUUyhCTE9DS1MpCiAKIHR5cGVkZWYgdm9pZCAoKnhwY19jb25uZWN0aW9uX2hhbmRsZXJfdCko eHBjX2Nvbm5lY3Rpb25fdCBjb25uZWN0aW9uKTsKIApAQCAtODIsNiArODYsMTAgQEAgZW51bSB7 CiB9OwogI2VuZGlmCiAKKyNpZiAhZGVmaW5lZChYUENfTk9FU0NBUEUpCisjZGVmaW5lIFhQQ19O T0VTQ0FQRQorI2VuZGlmCisKIFdURl9FWFRFUk5fQ19CRUdJTgogCiBleHRlcm4gY29uc3Qgc3Ry dWN0IF94cGNfZGljdGlvbmFyeV9zIF94cGNfZXJyb3JfY29ubmVjdGlvbl9pbnZhbGlkOwpAQCAt OTUsOCArMTAzLDggQEAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBfeHBjX3R5cGVfcyBfeHBjX3R5cAog CiB4cGNfb2JqZWN0X3QgeHBjX2FycmF5X2NyZWF0ZShjb25zdCB4cGNfb2JqZWN0X3QqLCBzaXpl X3QgY291bnQpOwogI2lmIENPTVBJTEVSX1NVUFBPUlRTKEJMT0NLUykKLWJvb2wgeHBjX2FycmF5 X2FwcGx5KHhwY19vYmplY3RfdCwgeHBjX2FycmF5X2FwcGxpZXJfdCk7Ci1ib29sIHhwY19kaWN0 aW9uYXJ5X2FwcGx5KHhwY19vYmplY3RfdCB4ZGljdCwgeHBjX2RpY3Rpb25hcnlfYXBwbGllcl90 IGFwcGxpZXIpOworYm9vbCB4cGNfYXJyYXlfYXBwbHkoeHBjX29iamVjdF90LCBYUENfTk9FU0NB UEUgeHBjX2FycmF5X2FwcGxpZXJfdCk7Citib29sIHhwY19kaWN0aW9uYXJ5X2FwcGx5KHhwY19v YmplY3RfdCB4ZGljdCwgWFBDX05PRVNDQVBFIHhwY19kaWN0aW9uYXJ5X2FwcGxpZXJfdCBhcHBs aWVyKTsKICNlbmRpZgogc2l6ZV90IHhwY19hcnJheV9nZXRfY291bnQoeHBjX29iamVjdF90KTsK IGNvbnN0IGNoYXIqIHhwY19hcnJheV9nZXRfc3RyaW5nKHhwY19vYmplY3RfdCwgc2l6ZV90IGlu ZGV4KTsK