181816 2018-01-18 15:06:45 -0800 Set the minimum executable allocator size properly 2018-01-18 15:53:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jfbastien jfbastien commit-queue fpizlo jfbastien keith_miller mark.lam msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1390676 0 jfbastien 2018-01-18 15:06:45 -0800 Executable allocator expects at least two page size's worth of allocation in certain conditions, and that causes some tests to now fail because they ask for less. Set that minimum correctly. We were already rounding up to a page size, so having a minimum of 2 page sizes is fine. 1390677 1 webkit-bug-importer 2018-01-18 15:07:19 -0800 <rdar://problem/36635533> 1390678 2 331664 jfbastien 2018-01-18 15:09:04 -0800 Created attachment 331664 patch 1390680 3 331664 saam 2018-01-18 15:11:54 -0800 Comment on attachment 331664 patch r=me 1390684 4 331664 commit-queue 2018-01-18 15:53:27 -0800 Comment on attachment 331664 patch Clearing flags on attachment: 331664 Committed r227168: <https://trac.webkit.org/changeset/227168> 1390685 5 commit-queue 2018-01-18 15:53:29 -0800 All reviewed patches have been landed. Closing bug. 331664 2018-01-18 15:09:04 -0800 2018-01-18 15:53:27 -0800 patch 0001-ExecutableAllocator-min.patch text/plain 2246 jfbastien RnJvbSBhNzM1NDU4ODg3Y2M5ZGJkYjkwZDdhMjhiYWY3YzgzNDBlY2Q4ZWZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUaHUsIDE4IEphbiAyMDE4IDE1OjA4OjQxIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gRXhlY3V0 YWJsZUFsbG9jYXRvciBtaW4KCi0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICB8IDE3ICsrKysrKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwIHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdl ZCwgMTggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CmluZGV4IDUxN2QzM2YuLmM5NmUyYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIwIEBACisyMDE4LTAxLTE4ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4K KworICAgICAgICBTZXQgdGhlIG1pbmltdW0gZXhlY3V0YWJsZSBhbGxvY2F0b3Igc2l6ZSBwcm9w ZXJseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgx ODE2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjYzNTUzMz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeGVjdXRhYmxlIGFsbG9jYXRvciBleHBl Y3RzIGF0IGxlYXN0IHR3byBwYWdlIHNpemUncyB3b3J0aCBvZgorICAgICAgICBhbGxvY2F0aW9u IGluIGNlcnRhaW4gY29uZGl0aW9ucywgYW5kIHRoYXQgY2F1c2VzIHNvbWUgdGVzdHMgdG8KKyAg ICAgICAgbm93IGZhaWwgYmVjYXVzZSB0aGV5IGFzayBmb3IgbGVzcy4gU2V0IHRoYXQgbWluaW11 bSBjb3JyZWN0bHkuIFdlCisgICAgICAgIHdlcmUgYWxyZWFkeSByb3VuZGluZyB1cCB0byBhIHBh Z2Ugc2l6ZSwgc28gaGF2aW5nIGEgbWluaW11bSBvZiAyCisgICAgICAgIHBhZ2Ugc2l6ZXMgaXMg ZmluZS4KKworICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcDoKKyAgICAgICAg KEpTQzo6Rml4ZWRWTVBvb2xFeGVjdXRhYmxlQWxsb2NhdG9yOjpGaXhlZFZNUG9vbEV4ZWN1dGFi bGVBbGxvY2F0b3IpOgorCiAyMDE4LTAxLTE2ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnph cm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBUZXN0IHByb2dyYW1zIHNob3VsZCBvbmx5IGJlIGJ1 aWx0IGluIGRldmVsb3BlciBtb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9F eGVjdXRhYmxlQWxsb2NhdG9yLmNwcAppbmRleCA3ZWVjYWM3Li5hZTVjY2Q1IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHAKQEAgLTEy MSw3ICsxMjEsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICByZXNlcnZhdGlvblNpemUgPSBPcHRp b25zOjpqaXRNZW1vcnlSZXNlcnZhdGlvblNpemUoKTsKICAgICAgICAgZWxzZQogICAgICAgICAg ICAgcmVzZXJ2YXRpb25TaXplID0gZml4ZWRFeGVjdXRhYmxlTWVtb3J5UG9vbFNpemU7Ci0gICAg ICAgIHJlc2VydmF0aW9uU2l6ZSA9IHJvdW5kVXBUb011bHRpcGxlT2YocGFnZVNpemUoKSwgcmVz ZXJ2YXRpb25TaXplKTsKKyAgICAgICAgcmVzZXJ2YXRpb25TaXplID0gc3RkOjptYXgocm91bmRV cFRvTXVsdGlwbGVPZihwYWdlU2l6ZSgpLCByZXNlcnZhdGlvblNpemUpLCBwYWdlU2l6ZSgpICog Mik7CiAgICAgICAgIG1fcmVzZXJ2YXRpb24gPSBQYWdlUmVzZXJ2YXRpb246OnJlc2VydmVXaXRo R3VhcmRQYWdlcyhyZXNlcnZhdGlvblNpemUsIE9TQWxsb2NhdG9yOjpKU0pJVENvZGVQYWdlcywg RVhFQ1VUQUJMRV9QT09MX1dSSVRBQkxFLCB0cnVlKTsKICAgICAgICAgaWYgKG1fcmVzZXJ2YXRp b24pIHsKICAgICAgICAgICAgIEFTU0VSVChtX3Jlc2VydmF0aW9uLnNpemUoKSA9PSByZXNlcnZh dGlvblNpemUpOwotLSAKMi4xMC4xCgo=