181808 2018-01-18 12:41:06 -0800 run-test.py script should make sure 'node_modules' directory exist before installing 2018-01-24 06:27:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=182040 P2 Normal --- 1 dewei_zhu webkit-unassigned aakash_jain dewei_zhu rniwa oldest_to_newest 1390630 0 dewei_zhu 2018-01-18 12:41:06 -0800 run-test.py script should make sure 'node_modules' directory exist before installing 1390631 1 331651 dewei_zhu 2018-01-18 12:42:23 -0800 Created attachment 331651 Patch 1392421 2 aakash_jain 2018-01-23 20:25:55 -0800 This change causes unit-tests to fail as mkdir fails when the directory already exists. [~]$ tools/run-tests.py unit-tests Traceback (most recent call last): File "tools/run-tests.py", line 25, in <module> main() File "tools/run-tests.py", line 13, in main os.makedirs(node_modules_dir) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/os.py", line 157, in makedirs mkdir(name, mode) OSError: [Errno 17] File exists: '/Volume/Data/OpenSource/Websites/perf.webkit.org/node_modules' 1392422 3 aakash_jain 2018-01-23 20:27:18 -0800 Referring to https://trac.webkit.org/changeset/227395/webkit 1392425 4 331651 aakash_jain 2018-01-23 20:40:48 -0800 Comment on attachment 331651 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331651&action=review > Websites/perf.webkit.org/tools/run-tests.py:13 > + os.makedirs(node_modules_dir) This fails when the directory already exists. Should check first if the directory exists. e.g.: if not os.path.exists(node_modules_dir): os.makedirs(node_modules_dir) 1392468 5 331651 dewei_zhu 2018-01-24 00:34:29 -0800 Comment on attachment 331651 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331651&action=review >> Websites/perf.webkit.org/tools/run-tests.py:13 >> + os.makedirs(node_modules_dir) > > This fails when the directory already exists. Should check first if the directory exists. e.g.: > > if not os.path.exists(node_modules_dir): > os.makedirs(node_modules_dir) You are right. I'll land the fix. 331651 2018-01-18 12:42:23 -0800 2018-01-22 18:57:37 -0800 Patch bug-181808-20180118124223.patch text/plain 2005 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MTU2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBlZDJiMWZiMWE4MDc3ZjcxMmZjMjBmM2FjMTI3YTQyZmE0ZjBhNTlhLi4xMjhlNWFmNzli NjgyN2I2ZDgxN2E2ODA2MGFmYjNkNjBkNTcwOGQ5IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wMS0xOCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICAncnVuLXRlc3QucHknIHNjcmlwdCBzaG91bGQgbWFrZSBz dXJlICdub2RlX21vZHVsZXMnIGRpcmVjdG9yeSBleGlzdHMgYmVmb3JlIGluc3RhbGxpbmcgbm9k ZSBwYWNrYWdlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MTgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICdydW4tdGVzdC5weScgd2lsbCBmYWlsIGlmICdub2RlX21vZHVsZXMnIGRvZXMgbm90IGV4 aXN0IGJlZm9yZSBydW5uaW5nIHRoaXMgc2NyaXB0LgorICAgICAgICBJbnN0ZWFkIG9mIGNhbGxp bmcgJ29zLmNoZGlyJyB0byBjaGFuZ2UgZGlyZWN0b3J5LCB1c2UgJ2N3ZCcgaW4gc3VicHJvY2Vz cyBpbnN0ZWFkLgorCisgICAgICAgICogdG9vbHMvcnVuLXRlc3RzLnB5OiBBZGRlZCB0aGUgbG9n aWMgdG8gZW5zdXJlICdub2RlX21vZHVsZXMnIGV4aXN0cy4KKyAgICAgICAgQWxzbyB1c2UgJ2N3 ZCcgaW4gc3VicHJvY2Vzcy5jYWxsIGluc3RlYWQgb2YgY2FsbGluZyAnb3MuY2hkaXInIGFoZWFk LgorCiAyMDE4LTAxLTE3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJlbmFtZSBjb25maWcuanNvbiB0byBjb25maWcuanNvbi5zYW1wbGUKZGlmZiAtLWdpdCBh L1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy90b29scy9ydW4tdGVzdHMucHkgYi9XZWJzaXRlcy9w ZXJmLndlYmtpdC5vcmcvdG9vbHMvcnVuLXRlc3RzLnB5CmluZGV4IDAzOThmMjU0M2FjMDlkZThm NDEyNThlOTA2YTdjZmEzOWVjNjZjMjguLmViNTg2NTQ0ZmFkZjFlNWYyYTEyNjI2ZjI4OTdiNGQ0 Zjc5ZjFkMjEgMTAwNzU1Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy90b29scy9ydW4t dGVzdHMucHkKKysrIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rvb2xzL3J1bi10ZXN0cy5w eQpAQCAtMTAsMTIgKzEwLDEyIEBAIGRlZiBtYWluKCk6CiAgICAgcm9vdF9kaXIgPSBvcy5wYXRo LmFic3BhdGgob3MucGF0aC5qb2luKHRvb2xzX2RpciwgJy4uJykpCiAgICAgbm9kZV9tb2R1bGVz X2RpciA9IG9zLnBhdGguam9pbihyb290X2RpciwgJ25vZGVfbW9kdWxlcycpCiAKLSAgICBvcy5j aGRpcihyb290X2RpcikKKyAgICBvcy5tYWtlZGlycyhub2RlX21vZHVsZXNfZGlyKQogICAgIHBh Y2thZ2VzID0gWydtb2NoYScsICdwZycsICdmb3JtLWRhdGEnXQogICAgIGZvciBwYWNrYWdlX25h bWUgaW4gcGFja2FnZXM6CiAgICAgICAgIHRhcmdldF9kaXIgPSBvcy5wYXRoLmpvaW4obm9kZV9t b2R1bGVzX2RpciwgcGFja2FnZV9uYW1lKQogICAgICAgICBpZiBub3Qgb3MucGF0aC5pc2Rpcih0 YXJnZXRfZGlyKToKLSAgICAgICAgICAgIHN1YnByb2Nlc3MuY2FsbChbJ25wbScsICdpbnN0YWxs JywgcGFja2FnZV9uYW1lXSkKKyAgICAgICAgICAgIHN1YnByb2Nlc3MuY2FsbChbJ25wbScsICdp bnN0YWxsJywgcGFja2FnZV9uYW1lXSwgY3dkPW5vZGVfbW9kdWxlc19kaXIpCiAKICAgICBtb2No YV9wYXRoID0gb3MucGF0aC5qb2luKG5vZGVfbW9kdWxlc19kaXIsICdtb2NoYS9iaW4vbW9jaGEn KQogICAgIHRlc3RfcGF0aHMgPSBzeXMuYXJndlsxOl0gb3IgWyd1bml0LXRlc3RzJywgJ3NlcnZl ci10ZXN0cyddCg==