181801 2018-01-18 10:10:41 -0800 [Win] Null pointer crash under WebCore::RenderStyle::colorIncludingFallback. 2018-01-22 14:13:04 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1390554 0 pvollan 2018-01-18 10:10:41 -0800 CONTEXT: (.ecxr) .ecxr eax=00000001 ebx=00000000 ecx=00407724 edx=59d76bb4 esi=00000000 edi=00000000 eip=592bfb2a esp=004076c4 ebp=004076f8 iopl=0 nv up ei pl zr na pe nc cs=001b ss=0023 ds=0023 es=0023 fs=003b gs=0000 efl=00210246 WebKit!WebCore::RenderStyle::backgroundColor [inlined in WebKit!WebCore::RenderStyle::colorIncludingFallback+0x7a]: 592bfb2a 8b4608 mov eax,dword ptr [esi+8] ds:0023:00000008=???????? .cxr Resetting default scope FAULTING_IP: WebKit!WebCore::RenderStyle::colorIncludingFallback+7a 592bfb2a 8b4608 mov eax,dword ptr [esi+8] EXCEPTION_RECORD: (.exr -1) .exr -1 ExceptionAddress: 592bfb2a (WebKit!WebCore::RenderStyle::backgroundColor) ExceptionCode: c0000005 (Access violation) ExceptionFlags: 00000000 NumberParameters: 2 Parameter[0]: 00000000 Parameter[1]: 00000008 Attempt to read from address 00000008 DEFAULT_BUCKET_ID: NULL_CLASS_PTR_READ STACK_TEXT: 004076f8 592bf420 00407724 0000002d 00000000 WebKit!WebCore::RenderStyle::colorIncludingFallback+0x7a 00407738 5939516f 00407764 0000002d 00000073 WebKit!WebCore::RenderStyle::visitedDependentColor+0x30 00407770 59394ab4 00000073 004077a0 0040779f WebKit!WebCore::RenderMenuList::getItemBackgroundColor+0x7f 004077ac 5954cb85 00407a40 00000073 0000000f WebKit!WebCore::RenderMenuList::itemStyle+0x84 00407b3c 5954e1e7 00407bb4 93011346 00000000 WebKit!WebCore::PopupMenuWin::paint+0x1e5 00407be8 5954e015 00070524 0000000f 00000000 WebKit!WebCore::PopupMenuWin::wndProc+0x197 00407c04 7639c4b7 00070524 0000000f 00000000 WebKit!WebCore::PopupMenuWin::PopupMenuWndProc+0x25 00407c30 76395f6f 5954dff0 00070524 0000000f user32!InternalCallWinProc+0x23 00407ca8 76394ede 00000000 5954dff0 00070524 user32!UserCallWinProcCheckWow+0xe0 00407d04 76394f4d 02f3bc08 0000000f 00000000 user32!DispatchClientMessage+0xcf 00407d2c 772d6bae 00407d44 00000018 0040eb34 user32!__fnDWORD+0x24 00407d58 76391bb4 7638ff95 00070524 00000060 ntdll!KiUserCallbackDispatcher+0x2e 00407d5c 7638ff95 00070524 00000060 00407d8c user32!NtUserCallHwndLock+0xc 00407d6c 5954c5a5 00070524 1d368de0 59444c7b user32!UpdateWindow+0x32 00407d78 59444c7b 1e123f40 1d368de0 00407e2c WebKit!WebCore::PopupMenuWin::updateFromElement+0x35 00407d8c 59441925 00000073 00000000 1e123f40 WebKit!WebCore::HTMLSelectElement::selectOption+0x10b 00407da4 59165d0a 1d368de0 1e123f40 092dd488 WebKit!WebCore::HTMLOptionElement::insertedInto+0x65 00407de8 59124222 1d368de0 1e123f40 00407e2c WebKit!WebCore::notifyNodeInsertedIntoDocument+0x2a 00407e04 590eacc4 1d368de0 1e123f40 00407e2c WebKit!WebCore::notifyChildNodeInserted+0x82 00407e68 590eaeef 1e123f40 00407e7c 00407ec0 WebKit!WebCore::ContainerNode::notifyChildInserted+0x84 00407e8c 590e806f 1e123f40 00000000 1e42f0e0 WebKit!WebCore::ContainerNode::updateTreeAfterInsertion+0x9f 00407f18 590e3442 00407f4c 1e123f40 1e22e570 WebKit!WebCore::ContainerNode::insertBefore+0x2bf 00407f2c 59a76a27 00407f4c 1e123f40 1e22e570 WebKit!WebCore::Node::insertBefore+0x32 00407f7c 59a74fbb 00407fa8 15a65b00 00407f90 WebKit!WebCore::JSDOMConstructorNotConstructable<WebCore::JSNode>::prototypeForStructure+0x12c7 00407f98 0c463edd 00407fa8 fffffffb 00408088 WebKit!WebCore::jsNodePrototypeFunctionInsertBefore+0x3b 1390560 1 pvollan 2018-01-18 10:25:15 -0800 <rdar://problem/35614900> 1390565 2 331638 pvollan 2018-01-18 10:32:59 -0800 Created attachment 331638 Patch 1390571 3 331640 pvollan 2018-01-18 10:45:23 -0800 Created attachment 331640 Patch 1390602 4 331640 zalan 2018-01-18 11:49:46 -0800 Comment on attachment 331640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331640&action=review > Source/WebCore/ChangeLog:8 > + Check if html element in menu list is connected before getting its style. In general, we should be able to access the style even when the element is detached. Looking at the stacktrace, the real issue here might be that WIN is too eager to paint a disconnected(?) popup (that should not happen for sure) and we end up accessing the computed style unexpectedly. 1390606 5 pvollan 2018-01-18 11:51:42 -0800 (In reply to zalan from comment #4) > Comment on attachment 331640 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=331640&action=review > > > Source/WebCore/ChangeLog:8 > > + Check if html element in menu list is connected before getting its style. > > In general, we should be able to access the style even when the element is > detached. Looking at the stacktrace, the real issue here might be that WIN > is too eager to paint a disconnected(?) popup (that should not happen for > sure) and we end up accessing the computed style unexpectedly. Thanks for reviewing! I'll look into fixing this on the Win side. 1391295 6 331819 pvollan 2018-01-19 16:58:02 -0800 Created attachment 331819 Patch 1391300 7 331822 pvollan 2018-01-19 17:01:33 -0800 Created attachment 331822 Patch 1391302 8 331823 pvollan 2018-01-19 17:03:48 -0800 Created attachment 331823 Patch 1391308 9 331823 simon.fraser 2018-01-19 17:30:21 -0800 Comment on attachment 331823 Patch No layout test? 1391326 10 pvollan 2018-01-19 18:28:05 -0800 (In reply to Simon Fraser (smfr) from comment #9) > Comment on attachment 331823 [details] > Patch > > No layout test? I am actually close to having one, but I have not been able to open a popup with JavaScript yet which is required to reproduce this. I partially succeeded by opening the popup with a mouse down from window.eventsender, but the events are synchronous in the Windows event sender, which means the mouse down event will block further JS execution, since the mouse down will start the popup event loop, and will not return from there until the popup is closed. Perhaps there are other ways to open a popup with JavaScript? 1391651 11 331931 pvollan 2018-01-22 08:54:42 -0800 Created attachment 331931 Patch 1391653 12 pvollan 2018-01-22 08:56:34 -0800 (In reply to Per Arne Vollan from comment #11) > Created attachment 331931 [details] > Patch Added an explanation of why I have not added a new test. 1391757 13 331931 bfulgham 2018-01-22 13:03:18 -0800 Comment on attachment 331931 Patch r=me. 1391796 14 331931 pvollan 2018-01-22 13:48:46 -0800 Comment on attachment 331931 Patch Thanks for reviewing! 1391811 15 331931 commit-queue 2018-01-22 14:13:03 -0800 Comment on attachment 331931 Patch Clearing flags on attachment: 331931 Committed r227357: <https://trac.webkit.org/changeset/227357> 1391812 16 commit-queue 2018-01-22 14:13:04 -0800 All reviewed patches have been landed. Closing bug. 331638 2018-01-18 10:32:59 -0800 2018-01-18 10:45:21 -0800 Patch bug-181801-20180118103259.patch text/plain 1380 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzE1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBOdWxsIHBvaW50 ZXIgY3Jhc2ggdW5kZXIgV2ViQ29yZTo6UmVuZGVyU3R5bGU6OmNvbG9ySW5jbHVkaW5nRmFsbGJh Y2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE4 MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg bnVsbCBwb2ludGVyIGNoZWNrLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgSSBoYXZlIG5vdCBi ZWVuIGFibGUgdG8gcmVwcm9kdWNlLiAKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNZW51 TGlzdC5jcHA6CisgICAgICAgIChSZW5kZXJNZW51TGlzdDo6aXRlbVN0eWxlIGNvbnN0KToKKwog MjAxOC0wMS0xOCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTihyMjI1NjUwKTogVGhlIHNjb3JlcyBvZiBNb3Rpb25NYXJrIHRlc3RzIE11bHRp cGx5IGFuZCBMZWF2ZXMgZHJvcHBlZCBieSA4JQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck1lbnVMaXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTWVudUxpc3QuY3BwCShyZXZpc2lvbiAyMjcxNDApCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTWVudUxpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MTAs NiArNTEwLDkgQEAgUG9wdXBNZW51U3R5bGUgUmVuZGVyTWVudUxpc3Q6Oml0ZW1TdHlsZQogICAg IH0KICAgICBIVE1MRWxlbWVudCogZWxlbWVudCA9IGxpc3RJdGVtc1tsaXN0SW5kZXhdOwogCisg ICAgaWYgKCFlbGVtZW50IHx8ICFlbGVtZW50LT5jb21wdXRlZFN0eWxlKCkpCisgICAgICAgIHJl dHVybiBtZW51U3R5bGUoKTsKKwogICAgIENvbG9yIGl0ZW1CYWNrZ3JvdW5kQ29sb3I7CiAgICAg Ym9vbCBpdGVtSGFzQ3VzdG9tQmFja2dyb3VuZENvbG9yOwogICAgIGdldEl0ZW1CYWNrZ3JvdW5k Q29sb3IobGlzdEluZGV4LCBpdGVtQmFja2dyb3VuZENvbG9yLCBpdGVtSGFzQ3VzdG9tQmFja2dy b3VuZENvbG9yKTsK 331640 2018-01-18 10:45:23 -0800 2018-01-19 16:58:01 -0800 Patch bug-181801-20180118104522.patch text/plain 1416 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzE1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBOdWxsIHBvaW50 ZXIgY3Jhc2ggdW5kZXIgV2ViQ29yZTo6UmVuZGVyU3R5bGU6OmNvbG9ySW5jbHVkaW5nRmFsbGJh Y2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE4 MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVj ayBpZiBodG1sIGVsZW1lbnQgaW4gbWVudSBsaXN0IGlzIGNvbm5lY3RlZCBiZWZvcmUgZ2V0dGlu ZyBpdHMgc3R5bGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBJIGhhdmUgbm90IGJlZW4gYWJs ZSB0byByZXByb2R1Y2UuIAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNw cDoKKyAgICAgICAgKFJlbmRlck1lbnVMaXN0OjppdGVtU3R5bGUgY29uc3QpOgorCiAyMDE4LTAx LTE4ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OKHIyMjU2NTApOiBUaGUgc2NvcmVzIG9mIE1vdGlvbk1hcmsgdGVzdHMgTXVsdGlwbHkgYW5k IExlYXZlcyBkcm9wcGVkIGJ5IDglCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTWVudUxpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJNZW51TGlzdC5jcHAJKHJldmlzaW9uIDIyNzE0MCkKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJNZW51TGlzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxMCw2ICs1MTAs OSBAQCBQb3B1cE1lbnVTdHlsZSBSZW5kZXJNZW51TGlzdDo6aXRlbVN0eWxlCiAgICAgfQogICAg IEhUTUxFbGVtZW50KiBlbGVtZW50ID0gbGlzdEl0ZW1zW2xpc3RJbmRleF07CiAKKyAgICBpZiAo IWVsZW1lbnQtPmlzQ29ubmVjdGVkKCkpCisgICAgICAgIHJldHVybiBtZW51U3R5bGUoKTsKKwog ICAgIENvbG9yIGl0ZW1CYWNrZ3JvdW5kQ29sb3I7CiAgICAgYm9vbCBpdGVtSGFzQ3VzdG9tQmFj a2dyb3VuZENvbG9yOwogICAgIGdldEl0ZW1CYWNrZ3JvdW5kQ29sb3IobGlzdEluZGV4LCBpdGVt QmFja2dyb3VuZENvbG9yLCBpdGVtSGFzQ3VzdG9tQmFja2dyb3VuZENvbG9yKTsK 331819 2018-01-19 16:58:02 -0800 2018-01-19 17:01:31 -0800 Patch bug-181801-20180120015803.patch text/plain 1511 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzI1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTE5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBOdWxsIHBvaW50 ZXIgY3Jhc2ggdW5kZXIgV2ViQ29yZTo6UmVuZGVyU3R5bGU6OmNvbG9ySW5jbHVkaW5nRmFsbGJh Y2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE4 MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBu b3QgcGFpbnQgc3luY2hyb25vdXNseSB3aGVuIHBvcHVwIGl0ZW1zIGhhdmUgYmVlbiBhZGRlZCBv ciBjaGFuZ2VkIHdoaWxlIHRoZSBwb3B1cCBpcyB2aXNpYmxlLgorICAgICAgICBJZiBuZXcgcG9w dXAgaXRlbXMgaGF2ZSBiZWVuIGFkZGVkIGFmdGVyIHRoZSBwb3B1cCB3YXMgc2hvd24sIGEgc3lu Y2hyb25vdXMgcGFpbnQgb3BlcmF0aW9uIHdpbGwKKyAgICAgICAgcG9zc2libHkgYWNjZXNzIHRo ZWlyIHN0eWxlIGJlZm9yZSBpdCBpcyByZWFkeSwgbGVhZGluZyB0byBhIG51bGwgcG9pbnRlciBj cmFzaC4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UG9wdXBNZW51V2luOjp1cGRhdGVGcm9tRWxlbWVudCk6CisKIDIwMTgtMDEt MTkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIENhY2hlIHN0 b3JhZ2UgZXJyb3JzIGxpa2UgUXVvdGEgc2hvdWxkIHRyaWdnZXIgY29uc29sZSBtZXNzYWdlcwpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1BvcHVwTWVudVdpbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1BvcHVwTWVudVdpbi5jcHAJKHJl dmlzaW9uIDIyNzI1MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVX aW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzIsOCArNTcyLDcgQEAgdm9pZCBQb3B1cE1lbnVX aW46OnVwZGF0ZUZyb21FbGVtZW50KCkKICAgICBtX2ZvY3VzZWRJbmRleCA9IGNsaWVudCgpLT5z ZWxlY3RlZEluZGV4KCk7CiAKICAgICA6OkludmFsaWRhdGVSZWN0KG1fcG9wdXAsIDAsIFRSVUUp OwotICAgIGlmICghc2Nyb2xsVG9SZXZlYWxTZWxlY3Rpb24oKSkKLSAgICAgICAgOjpVcGRhdGVX aW5kb3cobV9wb3B1cCk7CisgICAgc2Nyb2xsVG9SZXZlYWxTZWxlY3Rpb24oKTsKIH0KIAogY29u c3QgaW50IHNlcGFyYXRvclBhZGRpbmcgPSA0Owo= 331822 2018-01-19 17:01:33 -0800 2018-01-19 17:03:46 -0800 Patch bug-181801-20180120020134.patch text/plain 1573 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzI1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAxLTE5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBOdWxsIHBvaW50 ZXIgY3Jhc2ggdW5kZXIgV2ViQ29yZTo6UmVuZGVyU3R5bGU6OmNvbG9ySW5jbHVkaW5nRmFsbGJh Y2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE4 MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBu b3QgcGFpbnQgc3luY2hyb25vdXNseSB3aGVuIHBvcHVwIGl0ZW1zIGhhdmUgYmVlbiBhZGRlZCBv ciBjaGFuZ2VkIHdoaWxlIHRoZSBwb3B1cCBpcyB2aXNpYmxlLgorICAgICAgICBJZiBuZXcgcG9w dXAgaXRlbXMgaGF2ZSBiZWVuIGFkZGVkIGFmdGVyIHRoZSBwb3B1cCB3YXMgc2hvd24sIGEgc3lu Y2hyb25vdXMgcGFpbnQgb3BlcmF0aW9uIHdpbGwKKyAgICAgICAgcG9zc2libHkgYWNjZXNzIHRo ZWlyIHN0eWxlIGJlZm9yZSBpdCBpcyByZWFkeSwgbGVhZGluZyB0byBhIG51bGwgcG9pbnRlciBj cmFzaC4gVGhlIGludmFsaWRhdGVkCisgICAgICAgIGFyZWEgd2lsbCBiZSBwYWludGVkIGFzeW5j aHJvbm91c2x5LgorCisgICAgICAgICogcGxhdGZvcm0vd2luL1BvcHVwTWVudVdpbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpQb3B1cE1lbnVXaW46OnVwZGF0ZUZyb21FbGVtZW50KToKKwogMjAx OC0wMS0xOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2Fj aGUgc3RvcmFnZSBlcnJvcnMgbGlrZSBRdW90YSBzaG91bGQgdHJpZ2dlciBjb25zb2xlIG1lc3Nh Z2VzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNw cAkocmV2aXNpb24gMjI3MjUwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1BvcHVw TWVudVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3Miw4ICs1NzIsNyBAQCB2b2lkIFBvcHVw TWVudVdpbjo6dXBkYXRlRnJvbUVsZW1lbnQoKQogICAgIG1fZm9jdXNlZEluZGV4ID0gY2xpZW50 KCktPnNlbGVjdGVkSW5kZXgoKTsKIAogICAgIDo6SW52YWxpZGF0ZVJlY3QobV9wb3B1cCwgMCwg VFJVRSk7Ci0gICAgaWYgKCFzY3JvbGxUb1JldmVhbFNlbGVjdGlvbigpKQotICAgICAgICA6OlVw ZGF0ZVdpbmRvdyhtX3BvcHVwKTsKKyAgICBzY3JvbGxUb1JldmVhbFNlbGVjdGlvbigpOwogfQog CiBjb25zdCBpbnQgc2VwYXJhdG9yUGFkZGluZyA9IDQ7Cg== 331823 2018-01-19 17:03:48 -0800 2018-01-22 08:54:41 -0800 Patch bug-181801-20180120020349.patch text/plain 1608 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzI1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAxLTE5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBOdWxsIHBvaW50 ZXIgY3Jhc2ggdW5kZXIgV2ViQ29yZTo6UmVuZGVyU3R5bGU6OmNvbG9ySW5jbHVkaW5nRmFsbGJh Y2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE4 MDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1NjE0OTAwPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBwYWludCBzeW5jaHJvbm91c2x5 IHdoZW4gcG9wdXAgaXRlbXMgaGF2ZSBiZWVuIGFkZGVkIG9yIGNoYW5nZWQgd2hpbGUgdGhlIHBv cHVwIGlzIHZpc2libGUuCisgICAgICAgIElmIG5ldyBwb3B1cCBpdGVtcyBoYXZlIGJlZW4gYWRk ZWQgYWZ0ZXIgdGhlIHBvcHVwIHdhcyBzaG93biwgYSBzeW5jaHJvbm91cyBwYWludCBvcGVyYXRp b24gd2lsbAorICAgICAgICBwb3NzaWJseSBhY2Nlc3MgdGhlaXIgc3R5bGUgYmVmb3JlIGl0IGlz IHJlYWR5LCBsZWFkaW5nIHRvIGEgbnVsbCBwb2ludGVyIGNyYXNoLiBUaGUgaW52YWxpZGF0ZWQK KyAgICAgICAgYXJlYSB3aWxsIGJlIHBhaW50ZWQgYXN5bmNocm9ub3VzbHkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVw TWVudVdpbjo6dXBkYXRlRnJvbUVsZW1lbnQpOgorCiAyMDE4LTAxLTE5ICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBDYWNoZSBzdG9yYWdlIGVycm9ycyBsaWtl IFF1b3RhIHNob3VsZCB0cmlnZ2VyIGNvbnNvbGUgbWVzc2FnZXMKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCShyZXZpc2lvbiAyMjcyNTApCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTcyLDggKzU3Miw3IEBAIHZvaWQgUG9wdXBNZW51V2luOjp1cGRhdGVGcm9tRWxl bWVudCgpCiAgICAgbV9mb2N1c2VkSW5kZXggPSBjbGllbnQoKS0+c2VsZWN0ZWRJbmRleCgpOwog CiAgICAgOjpJbnZhbGlkYXRlUmVjdChtX3BvcHVwLCAwLCBUUlVFKTsKLSAgICBpZiAoIXNjcm9s bFRvUmV2ZWFsU2VsZWN0aW9uKCkpCi0gICAgICAgIDo6VXBkYXRlV2luZG93KG1fcG9wdXApOwor ICAgIHNjcm9sbFRvUmV2ZWFsU2VsZWN0aW9uKCk7CiB9CiAKIGNvbnN0IGludCBzZXBhcmF0b3JQ YWRkaW5nID0gNDsK 331931 2018-01-22 08:54:42 -0800 2018-01-22 14:13:03 -0800 Patch bug-181801-20180122175446.patch text/plain 2200 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzI1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE4LTAxLTE5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBOdWxsIHBvaW50 ZXIgY3Jhc2ggdW5kZXIgV2ViQ29yZTo6UmVuZGVyU3R5bGU6OmNvbG9ySW5jbHVkaW5nRmFsbGJh Y2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE4 MDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1NjE0OTAwPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBwYWludCBzeW5jaHJvbm91c2x5 IHdoZW4gcG9wdXAgaXRlbXMgaGF2ZSBiZWVuIGFkZGVkIG9yIGNoYW5nZWQgd2hpbGUgdGhlIHBv cHVwIGlzIHZpc2libGUuCisgICAgICAgIElmIG5ldyBwb3B1cCBpdGVtcyBoYXZlIGJlZW4gYWRk ZWQgYWZ0ZXIgdGhlIHBvcHVwIHdhcyBzaG93biwgYSBzeW5jaHJvbm91cyBwYWludCBvcGVyYXRp b24gd2lsbAorICAgICAgICBwb3NzaWJseSBhY2Nlc3MgdGhlaXIgc3R5bGUgYmVmb3JlIGl0IGlz IHJlYWR5LCBsZWFkaW5nIHRvIGEgbnVsbCBwb2ludGVyIGNyYXNoLiBUaGUgaW52YWxpZGF0ZWQK KyAgICAgICAgYXJlYSB3aWxsIGJlIHBhaW50ZWQgYXN5bmNocm9ub3VzbHkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiBUbyByZXByb2R1Y2UgdGhpcyBjcmFzaCwgaXQgaXMgbmVjZXNzYXJ5IHRv IG9wZW4gYSBwb3B1cCB3aXRoIEphdmFTY3JpcHQsIGFkZCBuZXcKKyAgICAgICAgcG9wdXAgaXRl bXMsIGFuZCB0aGVuIGVuZCB0aGUgdGVzdC4gT3BlbmluZyB0aGUgcG9wdXAgY2FuIGJlIGRvbmUg Ynkgc2VuZGluZyBhIG1vdXNlZG93biBldmVudAorICAgICAgICB3aXRoIHRoZSBldmVudHNlbmRl ci4gSG93ZXZlciwgb24gV2luZG93cyB0aGUgbW91c2Vkb3duIGV2ZW50IGlzIHNlbnQgc3luY2hy b25vdXNseSwgYW5kIHdpbGwKKyAgICAgICAgYmxvY2sgYXMgbG9uZyBhcyB0aGUgcG9wdXAgaXMg b3BlbiBhbmQgcnVubmluZyB0aGUgcG9wdXAgZXZlbnQgbG9vcC4gVGhpcyBtZWFucyBubyBKUyBj YW4gYmUKKyAgICAgICAgZXhlY3V0ZWQgdW50aWwgdGhlIHBvcHVwIGlzIGNsb3NlZCwgY2F1c2lu ZyB0aGUgdGVzdCB0byBhbHdheXMgdGltZSBvdXQgYmVmb3JlIG5ldyBwb3B1cCBpdGVtcworICAg ICAgICBjYW4gYmUgYWRkZWQuIEkgaGF2ZSB2ZXJpZmllZCB0aGUgZml4IHdpdGggYSBtYW51YWwg dGVzdCBjYXNlLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL1BvcHVwTWVudVdpbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpQb3B1cE1lbnVXaW46OnVwZGF0ZUZyb21FbGVtZW50KToKKwogMjAx OC0wMS0xOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2Fj aGUgc3RvcmFnZSBlcnJvcnMgbGlrZSBRdW90YSBzaG91bGQgdHJpZ2dlciBjb25zb2xlIG1lc3Nh Z2VzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNw cAkocmV2aXNpb24gMjI3MjUwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1BvcHVw TWVudVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3Miw4ICs1NzIsNyBAQCB2b2lkIFBvcHVw TWVudVdpbjo6dXBkYXRlRnJvbUVsZW1lbnQoKQogICAgIG1fZm9jdXNlZEluZGV4ID0gY2xpZW50 KCktPnNlbGVjdGVkSW5kZXgoKTsKIAogICAgIDo6SW52YWxpZGF0ZVJlY3QobV9wb3B1cCwgMCwg VFJVRSk7Ci0gICAgaWYgKCFzY3JvbGxUb1JldmVhbFNlbGVjdGlvbigpKQotICAgICAgICA6OlVw ZGF0ZVdpbmRvdyhtX3BvcHVwKTsKKyAgICBzY3JvbGxUb1JldmVhbFNlbGVjdGlvbigpOwogfQog CiBjb25zdCBpbnQgc2VwYXJhdG9yUGFkZGluZyA9IDQ7Cg==