181795 2018-01-18 05:04:18 -0800 REGRESSION (r223604): Setting :before/after pseudo element on <noscript> asserts 2018-01-18 09:37:35 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham cdumez cmarcelo commit-queue dbates ddkilzer esprehn+autocc ews-watchlist kangil.han rniwa webkit-bug-importer oldest_to_newest 1390475 0 koivisto 2018-01-18 05:04:18 -0800 Pseudo elements on elements that don't disallow renderers outside CSS mechanisms (like <noscript>) hit asserts. 1390476 1 koivisto 2018-01-18 05:04:37 -0800 <rdar://problem/36334524> 1390477 2 331612 koivisto 2018-01-18 05:14:49 -0800 Created attachment 331612 patch 1390523 3 331612 ddkilzer 2018-01-18 09:00:53 -0800 Comment on attachment 331612 patch r=me 1390544 4 331612 commit-queue 2018-01-18 09:37:34 -0800 Comment on attachment 331612 patch Clearing flags on attachment: 331612 Committed r227145: <https://trac.webkit.org/changeset/227145> 1390545 5 commit-queue 2018-01-18 09:37:35 -0800 All reviewed patches have been landed. Closing bug. 331612 2018-01-18 05:14:49 -0800 2018-01-18 09:37:34 -0800 patch noscript-pseudo-crash.patch text/plain 4005 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNzEzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE4LTAxLTE4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjIzNjA0 KTogU2V0dGluZyA6YmVmb3JlL2FmdGVyIHBzZXVkbyBlbGVtZW50IG9uIDxub3NjcmlwdD4gYXNz ZXJ0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgx Nzk1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjMzNDUyND4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8bm9zY3JpcHQ+IGRpc2FsbG93cyByZW5k ZXJlciBnZW5lcmF0aW9uIG91dHNpZGUgQ1NTIG1lY2hhbmlzbXMsIGhvd2V2ZXIgd2Ugd291bGQg c3RpbGwgY29uc3RydWN0CisgICAgICAgIFBzZXVkb0VsZW1lbnRzIGZvciB0aGVtIGR1cmluZyBz dHlsZSByZXNvbHV0aW9uLiBUaGVzZSB3ZXJlIG5ldmVyIHJlbW92ZWQgcHJvcGVybHkgYmVjYXVz ZSB0aGUKKyAgICAgICAgcHNldWRvIGVsZW1lbnQgcmVtb3ZhbCB3YXMgdGllZCB0byByZW5kZXIg dHJlZSB0ZWFyZG93bi4gV2l0aG91dCBwcm9wZXIgcmVtb3ZhbCB0aGUgYXNzb2NpYXRlZAorICAg ICAgICBhbmltYXRpb25zIHdlcmUgYWxzbyBub3QgY2FuY2VsZWQuCisKKyAgICAgICAgVGVzdDog ZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvbm9zY3JpcHQtcHNldWRvLWFuaW0tY3Jhc2guaHRt bAorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVu dDo6cmVtb3ZlZEZyb21BbmNlc3Rvcik6CisKKyAgICAgICAgVGFrZSBjYXJlIHRvIGdldCByaWQg b2YgUHNldWRvRWxlbWVudHMgd2hlbiB0aGUgZWxlbWVudCBpcyByZW1vdmVkIGZyb20gdGhlIHRy ZWUuCisgICAgICAgIFRoaXMgYWxzbyBjYW5jZWxzIGFueSBhc3NvY2lhdGVkIGFuaW1hdGlvbnMu CisKIDIwMTgtMDEtMTggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAK ICAgICAgICAgW2lPU10gU3BlY2lmeSAtW05TVVJMIF90aXRsZV0gZm9yIHRoZSBhc3NvY2lhdGVk IFVSTCB3aGVuIGNvcHlpbmcgYW4gaW1hZ2UgZWxlbWVudApJbmRleDogU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcAkocmV2aXNpb24gMjI2OTcwKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNzQ2LDYgKzE3NDYsOSBAQCB2b2lkIEVsZW1lbnQ6OnJlbW92 ZWRGcm9tQW5jZXN0b3IoUmVtb3ZhCiAgICAgICAgICAgICBzaGFkb3dSb290LT5ob3N0Q2hpbGRF bGVtZW50RGlkQ2hhbmdlKCp0aGlzKTsKICAgICB9CiAKKyAgICBjbGVhckJlZm9yZVBzZXVkb0Vs ZW1lbnQoKTsKKyAgICBjbGVhckFmdGVyUHNldWRvRWxlbWVudCgpOworCiAgICAgQ29udGFpbmVy Tm9kZTo6cmVtb3ZlZEZyb21BbmNlc3RvcihyZW1vdmFsVHlwZSwgb2xkUGFyZW50T2ZSZW1vdmVk VHJlZSk7CiAKICAgICBpZiAoaGFzUGVuZGluZ1Jlc291cmNlcygpKQpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMjI2OTcwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTgtMDEtMTggIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMjM2MDQpOiBTZXR0aW5nIDpiZWZvcmUvYWZ0ZXIg cHNldWRvIGVsZW1lbnQgb24gPG5vc2NyaXB0PiBhc3NlcnRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE3OTUKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM2MzM0NTI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvbm9zY3JpcHQtcHNldWRvLWFuaW0t Y3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0ZWQt Y29udGVudC9ub3NjcmlwdC1wc2V1ZG8tYW5pbS1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxOC0w MS0xNiAgWWFjaW5lIEJhbmRvdSAgPHlhY2luZS5iYW5kb3VfZXh0QHNvZnRhdGhvbWUuY29tPgog CiAgICAgICAgIFtFTUVdIEFkZCBsYXlvdXQgdGVzdCBmb3IgdGhlIE1TRSBwbGF5YmFjayBvZiBD bGVhcktleSBlbmNyeXB0ZWQgYXVkaW8gYW5kIHZpZGVvCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9ub3NjcmlwdC1wc2V1ZG8tYW5pbS1jcmFzaC1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRl bnQvbm9zY3JpcHQtcHNldWRvLWFuaW0tY3Jhc2gtZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkK KysrIExheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L25vc2NyaXB0LXBzZXVk by1hbmltLWNyYXNoLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxIEBACitU aGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXNuJ3QgYXNzZXJ0IG9yIGNyYXNoCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9ub3NjcmlwdC1wc2V1ZG8tYW5pbS1j cmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1j b250ZW50L25vc2NyaXB0LXBzZXVkby1hbmltLWNyYXNoLmh0bWwJKG5vbmV4aXN0ZW50KQorKysg TGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvbm9zY3JpcHQtcHNldWRvLWFu aW0tY3Jhc2guaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUg aHRtbD4KKzxodG1sPgorPHN0eWxlPgorOmJlZm9yZSB7CisgICAgLXdlYmtpdC1hbmltYXRpb24t bmFtZTogbmFtZTE7CisgICAgLXdlYmtpdC1hbmltYXRpb24tZHVyYXRpb246IDhzOworICAgIC13 ZWJraXQtYW5pbWF0aW9uLXRpbWluZy1mdW5jdGlvbjogZWFzZS1pbiAhIGltcG9ydGFudDsKKyAg ICBALXdlYmtpdC1rZXlmcmFtZXMgbmFtZTEgeworICAgICAgICBmcm9tIHsKKyAgICAgICAgICAg IG1hcmdpbi1ib3R0b206IGF1dG87CisgICAgICAgIH0KKyAgICAgICAgdG8geworICAgICAgICAg ICAgbWFyZ2luLWJvdHRvbTogMjU2aW47CisgICAgICAgIH0KKyAgICB9Cit9OworPC9zdHlsZT4K Kzxib2R5PgorPG5vc2NyaXB0Pjwvbm9zY3JpcHQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0 UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgdGVzdFJ1bm5l ci5kdW1wQXNUZXh0KCk7CisgICAgc2V0VGltZW91dCgoKSA9PiB0ZXN0UnVubmVyLm5vdGlmeURv bmUoKSwgNTApOworfQorZG9jdW1lbnQuYm9keS5vZmZzZXRMZWZ0OworZG9jdW1lbnQuYm9keS5p bm5lckhUTUwgPSAiVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IGFzc2VydCBvciBjcmFz aCI7Cis8L3NjcmlwdD4K