181786 2018-01-17 22:57:10 -0800 Don't fetch more than two builds to check duplicity of builds in ReportProcessor 2018-01-18 15:02:50 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1390425 0 rniwa 2018-01-17 22:57:10 -0800 Right now, ReportProcessor::resolve_build_id fetches all builds that match the builder number and time. This can result in a long delay & a high memory usage. 1390427 1 331600 rniwa 2018-01-17 23:00:26 -0800 Created attachment 331600 Fixes the bug 1390667 2 331600 wenson_hsieh 2018-01-18 14:55:29 -0800 Comment on attachment 331600 Fixes the bug rs=me. I'm a bit curious why the maximum limit of 2 builds is hard-coded. Is this hardware-dependent, and "2" is the most reasonable cap for our machines we're using to run the perf dashboard? It seems like maybe it should be configurable, but I'm not familiar with this code at all :P 1390670 3 331600 rniwa 2018-01-18 15:01:47 -0800 Comment on attachment 331600 Fixes the bug Clearing flags on attachment: 331600 Committed r227166: <https://trac.webkit.org/changeset/227166> 1390671 4 rniwa 2018-01-18 15:01:49 -0800 All reviewed patches have been landed. Closing bug. 1390672 5 rniwa 2018-01-18 15:01:54 -0800 (In reply to Wenson Hsieh from comment #2) > Comment on attachment 331600 [details] > Fixes the bug > > rs=me. > > I'm a bit curious why the maximum limit of 2 builds is hard-coded. Is this > hardware-dependent, and "2" is the most reasonable cap for our machines > we're using to run the perf dashboard? It seems like maybe it should be > configurable, but I'm not familiar with this code at all :P It's two because we're trying to check that it's unique. When there are more than two entries, we know there is at least one duplicate. We don't need to fetch all the duplicates to know that there are some duplicate. 1390673 6 webkit-bug-importer 2018-01-18 15:02:50 -0800 <rdar://problem/36635350> 331600 2018-01-17 23:00:26 -0800 2018-01-18 15:01:47 -0800 Fixes the bug bug-181786-20180117230025.patch text/plain 1786 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3MTI3KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTAxLTE3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIERvbid0IGZldGNoIG1vcmUgdGhhbiB0d28gYnVpbGRzIHRvIGNoZWNrIGR1cGxp Y2l0eSBvZiBidWlsZHMgaW4gUmVwb3J0UHJvY2Vzc29yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE3ODYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaW1pdCB0aGUgbnVtYmVyIG9mIGJ1aWxkcyB0byBj aGVjayB0byBhdm9pZCB1c2luZyBhIGxvdCBvZiBtZW1vcnkgd2l0aCBhIGxvbmcgZGVsYXkuCisK KyAgICAgICAgKiBwdWJsaWMvaW5jbHVkZS9yZXBvcnQtcHJvY2Vzc29yLnBocDoKKyAgICAgICAg KFJlcG9ydFByb2Nlc3Nvcjo6cmVzb2x2ZV9idWlsZF9pZCk6IAorCiAyMDE4LTAxLTE3ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQg Zml4ZXMgaW4gVGVzdEdyb3VwUmVzdWx0c1ZpZXdlci4KSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Vi a2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9yZXBvcnQtcHJvY2Vzc29yLnBocAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUvcmVwb3J0LXByb2Nlc3Nv ci5waHAJKHJldmlzaW9uIDIyNzEyNCkKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvaW5jbHVkZS9yZXBvcnQtcHJvY2Vzc29yLnBocAkod29ya2luZyBjb3B5KQpAQCAtMTMwLDcg KzEzMCw3IEBAIGNsYXNzIFJlcG9ydFByb2Nlc3NvciB7CiAgICAgcHJpdmF0ZSBmdW5jdGlvbiBy ZXNvbHZlX2J1aWxkX2lkKCYkYnVpbGRfZGF0YSwgJHJldmlzaW9ucywgJGJ1aWxkX3JlcXVlc3Rf aWQpIHsKICAgICAgICAgLy8gRklYTUU6IFRoaXMgY29kZSBoYXMgYSByYWNlIGNvbmRpdGlvbi4g U2VlIDxyZGFyOi8vcHJvYmxlbS8xNTg3NjMwMz4uCiAgICAgICAgICRyZXN1bHRzID0gJHRoaXMt PmRiLT5xdWVyeV9hbmRfZmV0Y2hfYWxsKCJTRUxFQ1QgYnVpbGRfaWQsIGJ1aWxkX3NsYXZlIEZS T00gYnVpbGRzCi0gICAgICAgICAgICBXSEVSRSBidWlsZF9idWlsZGVyID0gJDEgQU5EIGJ1aWxk X251bWJlciA9ICQyIEFORCBidWlsZF90aW1lIDw9ICQzIEFORCBidWlsZF90aW1lICsgaW50ZXJ2 YWwgJzEgZGF5JyA+ICQzIiwKKyAgICAgICAgICAgIFdIRVJFIGJ1aWxkX2J1aWxkZXIgPSAkMSBB TkQgYnVpbGRfbnVtYmVyID0gJDIgQU5EIGJ1aWxkX3RpbWUgPD0gJDMgQU5EIGJ1aWxkX3RpbWUg KyBpbnRlcnZhbCAnMSBkYXknID4gJDMgTElNSVQgMiIsCiAgICAgICAgICAgICBhcnJheSgkYnVp bGRfZGF0YVsnYnVpbGRlciddLCAkYnVpbGRfZGF0YVsnbnVtYmVyJ10sICRidWlsZF9kYXRhWyd0 aW1lJ10pKTsKICAgICAgICAgaWYgKCRyZXN1bHRzKSB7CiAgICAgICAgICAgICAkZmlyc3RfcmVz dWx0ID0gJHJlc3VsdHNbMF07Cg==