181774 2018-01-17 18:07:23 -0800 clean up pushToSaveImmediateWithoutTouchingRegisters a bit 2018-01-31 02:06:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1390322 0 saam 2018-01-17 18:07:23 -0800 ... 1390326 1 331570 saam 2018-01-17 18:15:58 -0800 Created attachment 331570 patch 1390341 2 331576 saam 2018-01-17 18:49:39 -0800 Created attachment 331576 patch 1390757 3 331686 saam 2018-01-18 18:18:51 -0800 Created attachment 331686 patch 1390758 4 saam 2018-01-18 18:19:13 -0800 (In reply to Saam Barati from comment #3) > Created attachment 331686 [details] > patch Updated to using dataTempRegister. 1394884 5 saam 2018-01-30 20:19:30 -0800 ping 1394900 6 331686 jfbastien 2018-01-30 21:03:44 -0800 Comment on attachment 331686 patch r=me Since the register doesn't matter it could totally be random... Though I guess it might lead to different GC values getting spilled sometimes? In that case data temp being on the stack is probably better than others. 1394907 7 saam 2018-01-30 21:38:32 -0800 (In reply to JF Bastien from comment #6) > Comment on attachment 331686 [details] > patch > > r=me > > Since the register doesn't matter it could totally be random... Though I > guess it might lead to different GC values getting spilled sometimes? In > that case data temp being on the stack is probably better than others. Yeah it totally could be as long as it’s not a HW reserved register. An earlier incarnation of this patch chose x9 or x19 or something like that 1394950 8 331686 commit-queue 2018-01-31 02:05:02 -0800 Comment on attachment 331686 patch Clearing flags on attachment: 331686 Committed r227897: <https://trac.webkit.org/changeset/227897> 1394951 9 commit-queue 2018-01-31 02:05:03 -0800 All reviewed patches have been landed. Closing bug. 1394952 10 webkit-bug-importer 2018-01-31 02:06:27 -0800 <rdar://problem/37062583> 331570 2018-01-17 18:15:58 -0800 2018-01-17 18:49:39 -0800 patch b-backup.diff text/plain 1809 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3MTA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE4LTAxLTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGNsZWFuIHVwIHB1c2hUb1NhdmVJbW1lZGlhdGVXaXRob3V0VG91Y2hpbmdSZWdpc3RlcnMgYSBi aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTc3 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg ZnVuY3Rpb24gb24gQVJNNjQgd2FzIGNvbnNpZGVyaW5nIHdoYXQgdG8gZG8gd2l0aCB0aGUgc2Ny YXRjaAorICAgICAgICByZWdpc3Rlci4gQW5kIGNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZWQgd2hh dCB3YXMgaW4gaXQuIFRoaXMgaXMgbm90CisgICAgICAgIHJlbGV2YW50IHRob3VnaCwgc2luY2Ug dGhlIGZ1bmN0aW9uIGFsd2F5cyByZWNvdmVycyB3aGF0IHdhcyBpbiB0aGF0CisgICAgICAgIHJl Z2lzdGVyLiBUaGlzIHBhdGNoIGp1c3Qgc3dpdGNoZXMgaXQgdG8geDkgc28gdGhlcmUgaXMgbm8g Y29uZnVzaW9uCisgICAgICAgIGFzIHRvIGhvdyB0aGlzIGZ1bmN0aW9uIGFmZmVjdHMgdGhlIHNj cmF0Y2ggcmVnaXN0ZXIuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02 NC5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTY0OjpwdXNoVG9TYXZlSW1tZWRp YXRlV2l0aG91dFRvdWNoaW5nUmVnaXN0ZXJzKToKKwogMjAxOC0wMS0xNyAgU2FhbSBCYXJhdGkg IDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIEF0b21pY3Mgd2hlbiBTaGFy ZWRBcnJheUJ1ZmZlciBpc27igJl0IGVuYWJsZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oCShyZXZpc2lvbiAy MjcwOTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNNjQuaAkod29ya2luZyBjb3B5KQpAQCAtMjIwMyw4ICsyMjAzLDcgQEAgcHVibGljOgogICAg IAogICAgIHZvaWQgcHVzaFRvU2F2ZUltbWVkaWF0ZVdpdGhvdXRUb3VjaGluZ1JlZ2lzdGVycyhU cnVzdGVkSW1tMzIgaW1tKQogICAgIHsKLSAgICAgICAgLy8gV2UgaW52YWxpZGF0ZSBhbnkgY2Fj aGVkIHZhbHVlcyBpbiBkYXRhVGVtcFJlZ2lzdGVyIGlmIHRlbXAgcmVnaXN0ZXIgY2FjaGluZyBp cyBlbmFibGVkLgotICAgICAgICBSZWdpc3RlcklEIHJlZyA9IG1fYWxsb3dTY3JhdGNoUmVnaXN0 ZXIgPyBnZXRDYWNoZWREYXRhVGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRlKCkgOiBkYXRhVGVt cFJlZ2lzdGVyOworICAgICAgICBSZWdpc3RlcklEIHJlZyA9IEFSTTY0UmVnaXN0ZXJzOjp4OTsK ICAgICAgICAgcHVzaFBhaXIocmVnLCByZWcpOwogICAgICAgICBtb3ZlKGltbSwgcmVnKTsKICAg ICAgICAgc3RvcmU2NChyZWcsIHN0YWNrUG9pbnRlclJlZ2lzdGVyKTsK 331576 2018-01-17 18:49:39 -0800 2018-01-18 18:18:51 -0800 patch b-backup.diff text/plain 1939 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3MTA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE4LTAxLTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGNsZWFuIHVwIHB1c2hUb1NhdmVJbW1lZGlhdGVXaXRob3V0VG91Y2hpbmdSZWdpc3RlcnMgYSBi aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTc3 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg ZnVuY3Rpb24gb24gQVJNNjQgd2FzIGNvbnNpZGVyaW5nIHdoYXQgdG8gZG8gd2l0aCB0aGUgc2Ny YXRjaAorICAgICAgICByZWdpc3Rlci4gQW5kIGNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZWQgd2hh dCB3YXMgaW4gaXQuIFRoaXMgaXMgbm90CisgICAgICAgIHJlbGV2YW50IHRob3VnaCwgc2luY2Ug dGhlIGZ1bmN0aW9uIGFsd2F5cyByZWNvdmVycyB3aGF0IHdhcyBpbiB0aGF0CisgICAgICAgIHJl Z2lzdGVyLiBUaGlzIHBhdGNoIGp1c3Qgc3dpdGNoZXMgaXQgdG8geDkgc28gdGhlcmUgaXMgbm8g Y29uZnVzaW9uCisgICAgICAgIGFzIHRvIGhvdyB0aGlzIGZ1bmN0aW9uIGFmZmVjdHMgdGhlIHNj cmF0Y2ggcmVnaXN0ZXIuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02 NC5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTY0OjpwdXNoVG9TYXZlSW1tZWRp YXRlV2l0aG91dFRvdWNoaW5nUmVnaXN0ZXJzKToKKwogMjAxOC0wMS0xNyAgU2FhbSBCYXJhdGkg IDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIEF0b21pY3Mgd2hlbiBTaGFy ZWRBcnJheUJ1ZmZlciBpc27igJl0IGVuYWJsZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oCShyZXZpc2lvbiAy MjcwOTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNNjQuaAkod29ya2luZyBjb3B5KQpAQCAtMjIwMyw4ICsyMjAzLDEwIEBAIHB1YmxpYzoKICAg ICAKICAgICB2b2lkIHB1c2hUb1NhdmVJbW1lZGlhdGVXaXRob3V0VG91Y2hpbmdSZWdpc3RlcnMo VHJ1c3RlZEltbTMyIGltbSkKICAgICB7Ci0gICAgICAgIC8vIFdlIGludmFsaWRhdGUgYW55IGNh Y2hlZCB2YWx1ZXMgaW4gZGF0YVRlbXBSZWdpc3RlciBpZiB0ZW1wIHJlZ2lzdGVyIGNhY2hpbmcg aXMgZW5hYmxlZC4KLSAgICAgICAgUmVnaXN0ZXJJRCByZWcgPSBtX2FsbG93U2NyYXRjaFJlZ2lz dGVyID8gZ2V0Q2FjaGVkRGF0YVRlbXBSZWdpc3RlcklEQW5kSW52YWxpZGF0ZSgpIDogZGF0YVRl bXBSZWdpc3RlcjsKKyAgICAgICAgLy8gV2UgY2FuIHVzZSBhbnkgbm9uLWhhcmR3YXJlIHJlc2Vy dmVkIHJlZ2lzdGVyIGhlcmUgc2luY2Ugd2UKKyAgICAgICAgLy8gcmVzdG9yZSBpdHMgdmFsdWUu IFdlIHBpY2sgeDkgYXJiaXRyYXJpbHkuCisgICAgICAgIFJlZ2lzdGVySUQgcmVnID0gQVJNNjRS ZWdpc3RlcnM6Ong5OworCiAgICAgICAgIHB1c2hQYWlyKHJlZywgcmVnKTsKICAgICAgICAgbW92 ZShpbW0sIHJlZyk7CiAgICAgICAgIHN0b3JlNjQocmVnLCBzdGFja1BvaW50ZXJSZWdpc3Rlcik7 Cg== 331686 2018-01-18 18:18:51 -0800 2018-01-31 02:05:02 -0800 patch b-backup.diff text/plain 2047 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI3MTA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE4LTAxLTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGNsZWFuIHVwIHB1c2hUb1NhdmVJbW1lZGlhdGVXaXRob3V0VG91Y2hpbmdSZWdpc3RlcnMgYSBi aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTc3 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg ZnVuY3Rpb24gb24gQVJNNjQgd2FzIGNvbnNpZGVyaW5nIHdoYXQgdG8gZG8gd2l0aCB0aGUgc2Ny YXRjaAorICAgICAgICByZWdpc3Rlci4gQW5kIGNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZWQgd2hh dCB3YXMgaW4gaXQuIFRoaXMgaXMgbm90CisgICAgICAgIHJlbGV2YW50IHRob3VnaCwgc2luY2Ug dGhlIGZ1bmN0aW9uIGFsd2F5cyByZWNvdmVycyB3aGF0IHdhcyBpbiB0aGF0CisgICAgICAgIHJl Z2lzdGVyLiBUaGlzIHBhdGNoIGp1c3Qgc3dpdGNoZXMgaXQgdG8gdXNpbmcgZGF0YVRlbXBSZWdp c3RlcgorICAgICAgICBkaXJlY3RseSBhbmQgdXBkYXRlcyB0aGUgY29tbWVudCB0byBkZXNjcmli ZSB3aHkgaXQgY2FuIGRvIHNvIHNhZmVseS4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTTY0Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6OnB1c2hU b1NhdmVJbW1lZGlhdGVXaXRob3V0VG91Y2hpbmdSZWdpc3RlcnMpOgorCiAyMDE4LTAxLTE3ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIERpc2FibGUgQXRvbWlj cyB3aGVuIFNoYXJlZEFycmF5QnVmZmVyIGlzbuKAmXQgZW5hYmxlZApJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgJ KHJldmlzaW9uIDIyNzA5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJBUk02NC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjAzLDggKzIyMDMsMTEgQEAg cHVibGljOgogICAgIAogICAgIHZvaWQgcHVzaFRvU2F2ZUltbWVkaWF0ZVdpdGhvdXRUb3VjaGlu Z1JlZ2lzdGVycyhUcnVzdGVkSW1tMzIgaW1tKQogICAgIHsKLSAgICAgICAgLy8gV2UgaW52YWxp ZGF0ZSBhbnkgY2FjaGVkIHZhbHVlcyBpbiBkYXRhVGVtcFJlZ2lzdGVyIGlmIHRlbXAgcmVnaXN0 ZXIgY2FjaGluZyBpcyBlbmFibGVkLgotICAgICAgICBSZWdpc3RlcklEIHJlZyA9IG1fYWxsb3dT Y3JhdGNoUmVnaXN0ZXIgPyBnZXRDYWNoZWREYXRhVGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRl KCkgOiBkYXRhVGVtcFJlZ2lzdGVyOworICAgICAgICAvLyBXZSBjYW4gdXNlIGFueSBub24taGFy ZHdhcmUgcmVzZXJ2ZWQgcmVnaXN0ZXIgaGVyZSBzaW5jZSB3ZSByZXN0b3JlIGl0cyB2YWx1ZS4K KyAgICAgICAgLy8gV2UgcGljayBkYXRhVGVtcFJlZ2lzdGVyIGFyYml0cmFyaWx5LiBXZSBkb24n dCBuZWVkIHRvIGludmFsaWRhdGUgaXQgaGVyZSBzaW5jZQorICAgICAgICAvLyB3ZSByZXN0b3Jl IGl0cyBvcmlnaW5hbCB2YWx1ZS4KKyAgICAgICAgUmVnaXN0ZXJJRCByZWcgPSBkYXRhVGVtcFJl Z2lzdGVyOworCiAgICAgICAgIHB1c2hQYWlyKHJlZywgcmVnKTsKICAgICAgICAgbW92ZShpbW0s IHJlZyk7CiAgICAgICAgIHN0b3JlNjQocmVnLCBzdGFja1BvaW50ZXJSZWdpc3Rlcik7Cg==