18177 2008-03-28 03:56:51 -0700 m_encoding is used twice in XMLHttpRequest 2008-03-31 15:00:46 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 jchaffraix webkit-unassigned oldest_to_newest 75625 0 jchaffraix 2008-03-28 03:56:51 -0700 As a class attribute: String m_encoding As a method variable in send : TextEncoding m_encoding Patch will follow. 75626 1 20155 jchaffraix 2008-03-28 04:00:39 -0700 Created attachment 20155 First trivial patch Change the 2 variable names to disambiguate them. 75877 2 20155 darin 2008-03-30 16:43:04 -0700 Comment on attachment 20155 First trivial patch r=me 76002 3 jchaffraix 2008-03-31 15:00:46 -0700 Committed in r31483. 20155 2008-03-28 04:00:39 -0700 2008-03-30 16:43:04 -0700 First trivial patch bug18177-CL.patch text/plain 4639 jchaffraix ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWNhYWU4NC4uNWQzZDgxMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOC0wMy0yOCAgSnVsaWVuIENoYWZm cmFpeCAgPGp1bGllbi5jaGFmZnJhaXhAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxODE3NzogbV9lbmNvZGluZyBpcyB1c2Vk IHR3aWNlIGluIFhNTEh0dHBSZXF1ZXN0CisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MTc3CisKKyAgICAgICAgLSBDaGFuZ2UgWE1MSHR0cFJlcXVlc3Qg dmFyaWFibGUgbV9lbmNvZGluZyB0byBtX3Jlc3BvbnNlRW5jb2RpbmcuCisKKyAgICAgICAgLSBD aGFuZ2Ugc2VuZCBsb2NhbCB2YXJpYWJsZSBtX2VuY29kaW5nIHRvIGVuY29kaW5nLgorCisgICAg ICAgIE5vIHRlc3QgY2FzZSAobm8gZnVuY3Rpb25uYWwgY2hhbmdlKS4KKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuaDogUmVtb3ZlZCB1bnVzZWQgdmFy aWFibGUuCisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlhNTEh0dHBSZXF1ZXN0OjpzZW5kKTogQ2hhbmdlZCBsb2NhbCBtX2VuY29kaW5nIHRvIGVu Y29kaW5nLgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OmRpZFJlY2VpdmVSZXNw b25zZSk6IG1fZW5jb2RpbmcgLT4gbV9yZXNwb25zZUVuY29kaW5nLgorICAgICAgICAoV2ViQ29y ZTo6WE1MSHR0cFJlcXVlc3Q6OmRpZFJlY2VpdmVEYXRhKTogRGl0dG8uCisgICAgICAgICogeG1s L1hNTEh0dHBSZXF1ZXN0Lmg6IENoYW5nZSBtX2VuY29kaW5nIHRvIG1fcmVzcG9uc2VFbmNvZGlu ZyB0byBkaXNhbWJpZ3VhdGUKKyAgICAgICAgdGhlIG5hbWUgYXMgaXQgaXMgb25seSB1c2VkIGZv ciByZXNwb25zZS4KKwogMjAwOC0wMy0yOCAgU2ltb24gSGF1c21hbm4gIDxoYXVzbWFubkB3ZWJr aXQub3JnPgogCiAgICAgICAgIEZpeCB0aGUgUXQgYnVpbGQuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuaCBiL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5oCmluZGV4IDUwMzE1NmEuLjI0OWI2YzIg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFz ZS5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5o CkBAIC03OSw4ICs3OSw2IEBAIGNsYXNzIFJlc291cmNlUmVzcG9uc2VCYXNlIHsKIAogICAgIHN0 YXRpYyBib29sIGNvbXBhcmUoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgYSwgY29uc3QgUmVzb3Vy Y2VSZXNwb25zZSYgYik7CiAKLSAgICBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiBhc1Jlc291cmNl UmVzcG9uc2UoKSBjb25zdDsKLQogIHByb3RlY3RlZDoKICAgICBSZXNvdXJjZVJlc3BvbnNlQmFz ZSgpICAKICAgICAgICAgOiBtX2V4cGVjdGVkQ29udGVudExlbmd0aCgwKQpkaWZmIC0tZ2l0IGEv V2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwIGIvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVl c3QuY3BwCmluZGV4IDdlZjJiYTcuLjE2NWIxYmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUveG1sL1hN TEh0dHBSZXF1ZXN0LmNwcAorKysgYi9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAg LTQxOSwxMCArNDE5LDEwIEBAIHZvaWQgWE1MSHR0cFJlcXVlc3Q6OnNlbmQoY29uc3QgU3RyaW5n JiBib2R5LCBFeGNlcHRpb25Db2RlJiBlYykKICAgICAgICAgLy8gRklYTUU6IG11c3QgdXNlIHht bEVuY29kaW5nIGZvciBkb2N1bWVudHMuCiAgICAgICAgIFN0cmluZyBjaGFyc2V0ID0gIlVURi04 IjsKICAgICAgIAotICAgICAgICBUZXh0RW5jb2RpbmcgbV9lbmNvZGluZyhjaGFyc2V0KTsKLSAg ICAgICAgaWYgKCFtX2VuY29kaW5nLmlzVmFsaWQoKSkgLy8gRklYTUU6IHJlcG9ydCBhbiBlcnJv cj8KLSAgICAgICAgICAgIG1fZW5jb2RpbmcgPSBVVEY4RW5jb2RpbmcoKTsKLSAgICAgICAgcmVx dWVzdC5zZXRIVFRQQm9keShGb3JtRGF0YTo6Y3JlYXRlKG1fZW5jb2RpbmcuZW5jb2RlKGJvZHku Y2hhcmFjdGVycygpLCBib2R5Lmxlbmd0aCgpLCBFbnRpdGllc0ZvclVuZW5jb2RhYmxlcykpKTsK KyAgICAgICAgVGV4dEVuY29kaW5nIGVuY29kaW5nKGNoYXJzZXQpOworICAgICAgICBpZiAoIWVu Y29kaW5nLmlzVmFsaWQoKSkgLy8gRklYTUU6IHJlcG9ydCBhbiBlcnJvcj8KKyAgICAgICAgICAg IGVuY29kaW5nID0gVVRGOEVuY29kaW5nKCk7CisgICAgICAgIHJlcXVlc3Quc2V0SFRUUEJvZHko Rm9ybURhdGE6OmNyZWF0ZShlbmNvZGluZy5lbmNvZGUoYm9keS5jaGFyYWN0ZXJzKCksIGJvZHku bGVuZ3RoKCksIEVudGl0aWVzRm9yVW5lbmNvZGFibGVzKSkpOwogICAgIH0KIAogICAgIGlmICht X3JlcXVlc3RIZWFkZXJzLnNpemUoKSA+IDApCkBAIC00NjMsNyArNDYzLDcgQEAgdm9pZCBYTUxI dHRwUmVxdWVzdDo6c2VuZChjb25zdCBTdHJpbmcmIGJvZHksIEV4Y2VwdGlvbkNvZGUmIGVjKQog ICAgIGlmIChtX2xvYWRlcikgewogICAgICAgICBpZiAoRnJhbWUqIGZyYW1lID0gbV9kb2MtPmZy YW1lKCkpIHsKICAgICAgICAgICAgIGlmIChQYWdlKiBwYWdlID0gZnJhbWUtPnBhZ2UoKSkgewot ICAgICAgICAgICAgICAgIHBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+cmVzb3VyY2VSZXRy aWV2ZWRCeVhNTEh0dHBSZXF1ZXN0KG1fbG9hZGVyLT5pZGVudGlmaWVyKCksIG1fbG9hZGVyLT5y ZXNvdXJjZURhdGEoKSwgbV9lbmNvZGluZyk7CisgICAgICAgICAgICAgICAgcGFnZS0+aW5zcGVj dG9yQ29udHJvbGxlcigpLT5yZXNvdXJjZVJldHJpZXZlZEJ5WE1MSHR0cFJlcXVlc3QobV9sb2Fk ZXItPmlkZW50aWZpZXIoKSwgbV9sb2FkZXItPnJlc291cmNlRGF0YSgpLCBtX3Jlc3BvbnNlRW5j b2RpbmcpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQpAQCAtNzIyLDkgKzcyMiw5 IEBAIHZvaWQgWE1MSHR0cFJlcXVlc3Q6OndpbGxTZW5kUmVxdWVzdChTdWJyZXNvdXJjZUxvYWRl ciosIFJlc291cmNlUmVxdWVzdCYgcmVxdWVzCiB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpkaWRSZWNl aXZlUmVzcG9uc2UoU3VicmVzb3VyY2VMb2FkZXIqLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiBy ZXNwb25zZSkKIHsKICAgICBtX3Jlc3BvbnNlID0gcmVzcG9uc2U7Ci0gICAgbV9lbmNvZGluZyA9 IGV4dHJhY3RDaGFyc2V0RnJvbU1lZGlhVHlwZShtX21pbWVUeXBlT3ZlcnJpZGUpOwotICAgIGlm IChtX2VuY29kaW5nLmlzRW1wdHkoKSkKLSAgICAgICAgbV9lbmNvZGluZyA9IHJlc3BvbnNlLnRl eHRFbmNvZGluZ05hbWUoKTsKKyAgICBtX3Jlc3BvbnNlRW5jb2RpbmcgPSBleHRyYWN0Q2hhcnNl dEZyb21NZWRpYVR5cGUobV9taW1lVHlwZU92ZXJyaWRlKTsKKyAgICBpZiAobV9yZXNwb25zZUVu Y29kaW5nLmlzRW1wdHkoKSkKKyAgICAgICAgbV9yZXNwb25zZUVuY29kaW5nID0gcmVzcG9uc2Uu dGV4dEVuY29kaW5nTmFtZSgpOwogCiB9CiAKQEAgLTczOSw4ICs3MzksOCBAQCB2b2lkIFhNTEh0 dHBSZXF1ZXN0OjpkaWRSZWNlaXZlRGF0YShTdWJyZXNvdXJjZUxvYWRlciosIGNvbnN0IGNoYXIq IGRhdGEsIGludCBsZQogICAgICAgICBjaGFuZ2VTdGF0ZShTZW50KTsKICAgCiAgICAgaWYgKCFt X2RlY29kZXIpIHsKLSAgICAgICAgaWYgKCFtX2VuY29kaW5nLmlzRW1wdHkoKSkKLSAgICAgICAg ICAgIG1fZGVjb2RlciA9IG5ldyBUZXh0UmVzb3VyY2VEZWNvZGVyKCJ0ZXh0L3BsYWluIiwgbV9l bmNvZGluZyk7CisgICAgICAgIGlmICghbV9yZXNwb25zZUVuY29kaW5nLmlzRW1wdHkoKSkKKyAg ICAgICAgICAgIG1fZGVjb2RlciA9IG5ldyBUZXh0UmVzb3VyY2VEZWNvZGVyKCJ0ZXh0L3BsYWlu IiwgbV9yZXNwb25zZUVuY29kaW5nKTsKICAgICAgICAgLy8gYWxsb3cgVGV4dFJlc291cmNlRGVj b2RlciB0byBsb29rIGluc2lkZSB0aGUgbV9yZXNwb25zZSBpZiBpdCdzIFhNTCBvciBIVE1MCiAg ICAgICAgIGVsc2UgaWYgKHJlc3BvbnNlSXNYTUwoKSkKICAgICAgICAgICAgIG1fZGVjb2RlciA9 IG5ldyBUZXh0UmVzb3VyY2VEZWNvZGVyKCJhcHBsaWNhdGlvbi94bWwiKTsKZGlmZiAtLWdpdCBh L1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmggYi9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVz dC5oCmluZGV4IGExYzcxMTkuLmY4ODM5NWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUveG1sL1hNTEh0 dHBSZXF1ZXN0LmgKKysrIGIvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaApAQCAtMTI1LDcg KzEyNSw3IEBAIHByaXZhdGU6CiAgICAgWE1MSHR0cFJlcXVlc3RTdGF0ZSBtX3N0YXRlOwogCiAg ICAgUmVzb3VyY2VSZXNwb25zZSBtX3Jlc3BvbnNlOwotICAgIFN0cmluZyBtX2VuY29kaW5nOwor ICAgIFN0cmluZyBtX3Jlc3BvbnNlRW5jb2Rpbmc7CiAKICAgICBSZWZQdHI8VGV4dFJlc291cmNl RGVjb2Rlcj4gbV9kZWNvZGVyOwogCg==