181765 2018-01-17 14:07:14 -0800 Use existing RGB colorspace instead of creating a new one. 2018-01-17 16:04:54 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue dino webkit-bug-importer oldest_to_newest 1390202 0 eric.carlson 2018-01-17 14:07:14 -0800 Address review comments from bug 181333 by using sRGBColorSpaceRef instead of creating a new static colorspace. 1390206 1 webkit-bug-importer 2018-01-17 14:10:22 -0800 <rdar://problem/36595753> 1390231 2 331544 eric.carlson 2018-01-17 15:14:13 -0800 Created attachment 331544 Patch 1390249 3 331544 dino 2018-01-17 15:41:47 -0800 Comment on attachment 331544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331544&action=review > Source/WebCore/ChangeLog:3 > + Use existing RGB colorspace instead of creating a new one You meant sRGB 1390261 4 331544 commit-queue 2018-01-17 16:04:53 -0800 Comment on attachment 331544 Patch Clearing flags on attachment: 331544 Committed r227094: <https://trac.webkit.org/changeset/227094> 1390262 5 commit-queue 2018-01-17 16:04:54 -0800 All reviewed patches have been landed. Closing bug. 331544 2018-01-17 15:14:13 -0800 2018-01-17 16:04:53 -0800 Patch bug-181765-20180117151413.patch text/plain 2300 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDMyNzBiYTM3NzY3MDMy NWVmOGMzODEwOWIzMjhhMjViN2ZlM2M5NC4uOWU1YWI2YmE2MDQ3ZWY2ODQyZDA4ZmIzMGUyOWFi YzRiY2ExNDE5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAxLTE3ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBleGlzdGlu ZyBSR0IgY29sb3JzcGFjZSBpbnN0ZWFkIG9mIGNyZWF0aW5nIGEgbmV3IG9uZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxNzY1CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNjU5NTc1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9TY3JlZW5EaXNwbGF5 Q2FwdHVyZVNvdXJjZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmVlbkRpc3BsYXlDYXB0 dXJlU291cmNlTWFjOjpjcmVhdGVEaXNwbGF5U3RyZWFtKTogVXNlIHNSR0JDb2xvclNwYWNlUmVm IGluc3RlYWQKKyAgICAgICAgb2YgY3JlYXRpbmcgYSBuZXcgc3RhdGljIGNvbG9yc3BhY2UuCisK IDIwMTgtMDEtMTcgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAg IFJFR1JFU1NJT04gKHIyMjYzODU/KTogQ3Jhc2ggaW4gY29tLmFwcGxlLldlYkNvcmU6IFdlYkNv cmU6Ok1lZGlhUXVlcnlFdmFsdWF0b3I6OmV2YWx1YXRlIGNvbnN0ICsgMzIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9TY3JlZW5EaXNwbGF5Q2Fw dHVyZVNvdXJjZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21h Yy9TY3JlZW5EaXNwbGF5Q2FwdHVyZVNvdXJjZU1hYy5tbQppbmRleCAzMTRhMTcyZTRhMGVhNTc1 NGUxMGJiZWQxOWNhNTQ2YjIyYzg4YTVlLi5jZTliY2Y4ODA4NTQ5MGE5ZThjZTYxMWI1Y2U1ZWM5 ZjZhYmEzMjgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9tYWMvU2NyZWVuRGlzcGxheUNhcHR1cmVTb3VyY2VNYWMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1NjcmVlbkRpc3BsYXlDYXB0dXJlU291cmNlTWFj Lm1tCkBAIC0xNDksNyArMTQ5LDYgQEAgYm9vbCBTY3JlZW5EaXNwbGF5Q2FwdHVyZVNvdXJjZU1h Yzo6Y3JlYXRlRGlzcGxheVN0cmVhbSgpCiAgICAgICAgIGlmICghbV9jYXB0dXJlUXVldWUpCiAg ICAgICAgICAgICBtX2NhcHR1cmVRdWV1ZSA9IGFkb3B0T1NPYmplY3QoZGlzcGF0Y2hfcXVldWVf Y3JlYXRlKCJTY3JlZW5EaXNwbGF5Q2FwdHVyZVNvdXJjZU1hYyBDYXB0dXJlIFF1ZXVlIiwgRElT UEFUQ0hfUVVFVUVfU0VSSUFMKSk7CiAKLSAgICAgICAgc3RhdGljIENHQ29sb3JTcGFjZVJlZiBk ZXZpY2VSR0JDb2xvclNwYWNlID0gQ0dDb2xvclNwYWNlQ3JlYXRlRGV2aWNlUkdCKCk7CiAgICAg ICAgIGRvdWJsZSBmcmFtZVRpbWUgPSAxIC8gZnJhbWVSYXRlKCk7CiAgICAgICAgIGF1dG8gZnJh bWVUaW1lQ0YgPSBhZG9wdENGKENGTnVtYmVyQ3JlYXRlKG51bGxwdHIsICBrQ0ZOdW1iZXJEb3Vi bGVUeXBlLCAgJmZyYW1lVGltZSkpOwogICAgICAgICBpbnQgZGVwdGggPSBzY3JlZW5RdWV1ZU1h eGltdW1MZW5ndGg7CkBAIC0xNjMsNyArMTYyLDcgQEAgYm9vbCBTY3JlZW5EaXNwbGF5Q2FwdHVy ZVNvdXJjZU1hYzo6Y3JlYXRlRGlzcGxheVN0cmVhbSgpCiAgICAgICAgIENGVHlwZVJlZiB2YWx1 ZXNbXSA9IHsKICAgICAgICAgICAgIGZyYW1lVGltZUNGLmdldCgpLAogICAgICAgICAgICAgZGVw dGhDRi5nZXQoKSwKLSAgICAgICAgICAgIGRldmljZVJHQkNvbG9yU3BhY2UsCisgICAgICAgICAg ICBzUkdCQ29sb3JTcGFjZVJlZigpLAogICAgICAgICAgICAga0NGQm9vbGVhblRydWUsCiAgICAg ICAgIH07CiAgICAgICAgIGF1dG8gc3RyZWFtT3B0aW9ucyA9IGFkb3B0Q0YoQ0ZEaWN0aW9uYXJ5 Q3JlYXRlKGtDRkFsbG9jYXRvckRlZmF1bHQsIGtleXMsIHZhbHVlcywgV1RGX0FSUkFZX0xFTkdU SChrZXlzKSwgJmtDRlR5cGVEaWN0aW9uYXJ5S2V5Q2FsbEJhY2tzLCAma0NGVHlwZURpY3Rpb25h cnlWYWx1ZUNhbGxCYWNrcykpOwo=