181753 2018-01-17 11:23:20 -0800 Layout Test http/wpt/service-workers/update-service-worker.https.html is flaky 2018-03-15 12:22:03 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 youennf cdumez commit-queue ryanhaddad webkit-bug-importer youennf oldest_to_newest 1390122 0 jlewis3 2018-01-17 11:23:20 -0800 The following layout test is flaky on High Sierra Release WK2 and El Capitan Release WK2 at the moment. http/wpt/service-workers/update-service-worker.https.html Probable cause: https://trac.webkit.org/changeset/226906/webkit Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fupdate-service-worker.https.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227068%20(2302)/results.html Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/update-service-worker.https-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/update-service-worker.https-actual.txt @@ -1,4 +1,5 @@ + PASS Setup worker -PASS Ensure all fetches are intercepted +FAIL Ensure all fetches are intercepted promise_test: Unhandled rejection with value: object "TypeError: Type error" 1390124 1 jlewis3 2018-01-17 11:25:41 -0800 Correction: This is the cause. It looks to have been flaky since being added in https://trac.webkit.org/changeset/226904/webkit 1390335 2 webkit-bug-importer 2018-01-17 18:41:50 -0800 <rdar://problem/36605091> 1391783 3 jlewis3 2018-01-22 13:33:48 -0800 Marked as flaky in: https://trac.webkit.org/changeset/227354/webkit 1406744 4 youennf 2018-03-15 11:43:34 -0700 This is no longer flaky on High Sierra Release. I will update the test expectation. 1406745 5 335871 youennf 2018-03-15 11:44:58 -0700 Created attachment 335871 Patch 1406758 6 335871 commit-queue 2018-03-15 12:22:02 -0700 Comment on attachment 335871 Patch Clearing flags on attachment: 335871 Committed r229636: <https://trac.webkit.org/changeset/229636> 1406759 7 commit-queue 2018-03-15 12:22:03 -0700 All reviewed patches have been landed. Closing bug. 335871 2018-03-15 11:44:58 -0700 2018-03-15 12:22:02 -0700 Patch bug-181753-20180315114457.patch text/plain 1538 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTIyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzc1YjhmZWYwN2QwODE5NDRjOGU3 OTY3MTgyYTRkNmE0MzgyOTM4MC4uMzk0OWI4N2JhMTZkNTZlYjM0MzNmMWY0ZTY3OTEwYWUxZWZm OTM2YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTAzLTE1ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXQgVGVzdCBodHRwL3dwdC9zZXJ2aWNl LXdvcmtlcnMvdXBkYXRlLXNlcnZpY2Utd29ya2VyLmh0dHBzLmh0bWwgaXMgZmxha3kKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTc1MworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzY2MDUwOTE+CisKKyAgICAgICAgVW5yZXZpZXdlZC4KKworICAg ICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczogVGVzdCBpcyBubyBsb25n ZXIgZmxha3kgb24gSGlnaCBTaWVycmEgUmVsZWFzZS4KKwogMjAxOC0wMy0xNSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQmFkIGNvbmZpZ3VyYXRpb24gcGFy YW1ldGVycyBzaG91bGQgbWFrZSBSVENQZWVyQ29ubmVjdGlvbiBjb25zdHJ1Y3RvciB0aHJvdwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25z IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDZh YzhhZTU1NzYxNDkxZjUwZGJiYWEwMWE5ZmFiYjkyMzExOTNiNTAuLmQwZTBjYjFkOGQzNzM3YWJl OTI0MDE2YjMwNjIwZDcxNTk2YmE5ZjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMt d2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTg2Niw4ICs4NjYsNiBAQCB3ZWJraXQub3JnL2IvMTgx NzUwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZp Y2Utd29yawogCiB3ZWJraXQub3JnL2IvMTgxODM5IFsgRGVidWcgXSBpbnNwZWN0b3IvZGVidWdn ZXIvYnJlYWtwb2ludC1hY3Rpb24tbG9nLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogCi13ZWJraXQu b3JnL2IvMTgxNzUzIFsgSGlnaFNpZXJyYSBSZWxlYXNlIF0gaHR0cC93cHQvc2VydmljZS13b3Jr ZXJzL3VwZGF0ZS1zZXJ2aWNlLXdvcmtlci5odHRwcy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQog d2Via2l0Lm9yZy9iLzE4MTk1NyBbIFJlbGVhc2UgXSBodHRwL3Rlc3RzL21pc2MvcmVzb3VyY2Ut dGltaW5nLXJlc29sdXRpb24uaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8x ODE4MzUgd2VicnRjL2NhcHR1cmVDYW52YXMtd2VicnRjLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQo=