181751 2018-01-17 11:19:23 -0800 [GTK] Try even harder not to static link WTF into libwebkit2gtk 2018-01-17 15:16:32 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro achristensen bugs-noreply mcatanzaro oldest_to_newest 1390114 0 mcatanzaro 2018-01-17 11:19:23 -0800 Try even harder not to static link WTF into libwebkit2gtk. We don't want two copies of WTF. It should only be in libjavascriptcoregtk. Yesterday I found it was being linked into PAL. Today I noticed it's being linked directly into WebCore as well. Build systems are full of landmines. 1390115 1 mcatanzaro 2018-01-17 11:20:01 -0800 When we have this fully solved, then I *think* we should be able to turn on -fvisibility=hidden and -fvisibility-inlines=hidden again. 1390117 2 331524 mcatanzaro 2018-01-17 11:21:08 -0800 Created attachment 331524 Patch 1390121 3 mcatanzaro 2018-01-17 11:22:58 -0800 (In reply to Michael Catanzaro from comment #0) > Build systems are full of landmines. An interesting property of CMake build systems is that so long as anyone other than Konstantin is allowed to touch the build files, it will never work entirely as intended. I think I'm making some forward progress here, but perhaps I'm delusional.... 1390233 4 mcatanzaro 2018-01-17 15:16:32 -0800 Committed r227089: <https://trac.webkit.org/changeset/227089> 331524 2018-01-17 11:21:08 -0800 2018-01-17 13:20:17 -0800 Patch bug-181751-20180117132107.patch text/plain 1244 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU4NWM5YTRkYzBjZDUw NWRhMDM4ZjNiYmI2MzczMmQzNjFjYzM4YS4uMzM5NjFlNGI3OTY0ZmIxYmQwZDdjZTZlNjRiYWIx YzZhZGM5MjE0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAxLTE3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBU cnkgZXZlbiBoYXJkZXIgbm90IHRvIHN0YXRpYyBsaW5rIFdURiBpbnRvIGxpYndlYmtpdDJndGsK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTc1MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGRvbid0 IHdhbnQgdHdvIGNvcGllcyBvZiBXVEYuIEl0IHNob3VsZCBvbmx5IGJlIGluIGxpYmphdmFzY3Jp cHRjb3JlZ3RrLgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6CisKIDIwMTgtMDEtMTcg IFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgZm9sbG93LXVwIHRvIHIyMjcwNTEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0 Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IGJk OGIyMjcxNDQxMTNmYTg1YjM0MmJjOWVhY2M4NDhjNTg2NzBmYzQuLjMyYzZjY2NkMjgyMThlNGZk NjM0NTQyZTdlYzVlMmMzZDdiNTVkZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRm b3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0x MTMsMTEgKzExMyw4IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCiAgICAgJHtYMTFf WHJlbmRlcl9MSUJ9CiAgICAgJHtYMTFfWHRfTElCfQogICAgICR7WkxJQl9MSUJSQVJJRVN9Ci0g ICAgV1RGCiApCiAKLWxpc3QoQVBQRU5EIFdlYkNvcmVUZXN0U3VwcG9ydF9MSUJSQVJJRVMgV1RG KQotCiBsaXN0KEFQUEVORCBXZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAg JHtBVEtfSU5DTFVERV9ESVJTfQogICAgICR7Q0FJUk9fSU5DTFVERV9ESVJTfQo=