181713 2018-01-16 18:00:57 -0800 Page.cpp only sees forward declaration of ApplicationStateChangeListener when ENABLE(VIDEO) is off 2018-01-17 09:38:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned achristensen commit-queue darin don.olmstead eric.carlson webkit-bug-importer oldest_to_newest 1389816 0 stephan.szabo 2018-01-16 18:00:57 -0800 The changes in https://bugs.webkit.org/show_bug.cgi?id=181623 to Page.cpp appear to fail when ENABLE(VIDEO) is off. With ENABLE(VIDEO), HTMLMediaElement.h will #include "ApplicationStateChangeListener.h", but without it, Page.cpp appears to only get the forward declaration from Document.h. 1389817 1 331444 stephan.szabo 2018-01-16 18:03:30 -0800 Created attachment 331444 Add #include for ApplicationStateChangeListener 1390046 2 331444 commit-queue 2018-01-17 09:36:23 -0800 Comment on attachment 331444 Add #include for ApplicationStateChangeListener Clearing flags on attachment: 331444 Committed r227069: <https://trac.webkit.org/changeset/227069> 1390047 3 commit-queue 2018-01-17 09:36:24 -0800 All reviewed patches have been landed. Closing bug. 1390049 4 webkit-bug-importer 2018-01-17 09:38:28 -0800 <rdar://problem/36585921> 331444 2018-01-16 18:03:30 -0800 2018-01-17 09:36:23 -0800 Add #include for ApplicationStateChangeListener 181713-1.diff text/plain 1195 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZjI2ZjY4MmM5ZC4uZjBkNjllZjVlNTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wMS0xNiAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29u eS5jb20+CisKKyAgICAgICAgUGFnZS5jcHAgb25seSBzZWVzIGZvcndhcmQgZGVjbGFyYXRpb24g b2YgQXBwbGljYXRpb25TdGF0ZUNoYW5nZUxpc3RlbmVyIHdoZW4gRU5BQkxFKFZJREVPKSBpcyBv ZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTcx MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyAoYnVpbGQgZml4KS4KKworICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6IEFkZCBpbmNs dWRlIGZvciBBcHBsaWNhdGlvblN0YXRlQ2hhbmdlTGlzdGVuZXIKKwogMjAxOC0wMS0xNiAgU2Fp ZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT04ocjIyMTI5Mik6IHN2Zy9hbmltYXRpb25zL2FuaW1hdGVUcmFuc2Zvcm0tcGF0dGVybi10 cmFuc2Zvcm0uaHRtbCBjcmFzaGVzIHdpdGggc2VjdXJpdHkgYXNzZXJ0aW9uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmNwcAppbmRleCBlYzM0NjY5ZjMwZS4uN2ExZGM2ZTk0Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcApA QCAtMjMsNiArMjMsNyBAQAogI2luY2x1ZGUgIkFjdGl2aXR5U3RhdGVDaGFuZ2VPYnNlcnZlci5o IgogI2luY2x1ZGUgIkFsdGVybmF0aXZlVGV4dENsaWVudC5oIgogI2luY2x1ZGUgIkFwcGxpY2F0 aW9uQ2FjaGVTdG9yYWdlLmgiCisjaW5jbHVkZSAiQXBwbGljYXRpb25TdGF0ZUNoYW5nZUxpc3Rl bmVyLmgiCiAjaW5jbHVkZSAiQmFja0ZvcndhcmRDbGllbnQuaCIKICNpbmNsdWRlICJCYWNrRm9y d2FyZENvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJDU1NBbmltYXRpb25Db250cm9sbGVyLmgiCg==