181708 2018-01-16 16:52:17 -0800 Can't scroll iframe after toggling it to display:none and back 2018-01-22 15:13:07 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue ryanhaddad simon.fraser thorton oldest_to_newest 1389791 0 simon.fraser 2018-01-16 16:52:17 -0800 Can't scroll iframe after toggling it to display:none and back 1389793 1 331442 simon.fraser 2018-01-16 16:53:55 -0800 Created attachment 331442 Patch 1389794 2 simon.fraser 2018-01-16 16:54:16 -0800 rdar://problem/13234778 1389806 3 331442 commit-queue 2018-01-16 17:34:47 -0800 Comment on attachment 331442 Patch Clearing flags on attachment: 331442 Committed r227011: <https://trac.webkit.org/changeset/227011> 1389807 4 commit-queue 2018-01-16 17:34:48 -0800 All reviewed patches have been landed. Closing bug. 1390817 5 ryanhaddad 2018-01-18 21:04:14 -0800 This change caused LayoutTest fast/frames/hidpi-position-iframe-on-device-pixel.html to consistently time out macOS Debug WK2 bots: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r227174%20(1674)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fframes%2Fhidpi-position-iframe-on-device-pixel.html 1391055 6 simon.fraser 2018-01-19 11:21:12 -0800 Thanks, will look. 1391792 7 simon.fraser 2018-01-22 13:46:14 -0800 I can't reproduce the timeouts. 1391798 8 simon.fraser 2018-01-22 13:49:51 -0800 The test is pretty slow, though. Maybe I made it slower. 1391825 9 simon.fraser 2018-01-22 14:36:14 -0800 Yeah, now we're adding to the scrollableAreaSet even before we know that the frame is scrollable. 1391847 10 simon.fraser 2018-01-22 15:13:07 -0800 Fixing via bug 181959. 331442 2018-01-16 16:53:55 -0800 2018-01-16 17:34:47 -0800 Patch bug-181708-20180116165354.patch text/plain 6213 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFjMWVmYmE3MTNiZDRh NzhlZDY2NTY0ZDUzMDdjMmJjYWNiNWU5Yy4uN2FjZTFjMThiMTVmOTY3YzAwYjk3ZjlkZWIzN2M4 ZjBkYjQzODFiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTAxLTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENhbid0IHNjcm9s bCBpZnJhbWUgYWZ0ZXIgdG9nZ2xpbmcgaXQgdG8gZGlzcGxheTpub25lIGFuZCBiYWNrCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE3MDgKKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vMTMyMzQ3NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBOb3RoaW5nIHVwZGF0ZWQgdGhlIEZyYW1lVmlldydzIHNldCBv ZiBzY3JvbGxhYmxlIGFyZWFzIHdoZW4gYSBzdWJmcmFtZSBjYW1lIGJhY2sgZnJvbSBkaXNwbGF5 Om5vbmUuCisgICAgICAgIE1pcnJvciB0aGUgZXhpc3RpbmcgdmlydHVhbCByZW1vdmVDaGlsZCgp IGJ5IG1ha2luZyBhZGRDaGlsZCgpIHZpcnR1YWwsIGFuZCB1c2luZyBpdCB0byBtYXJrCisgICAg ICAgIHRoZSBGcmFtZVZpZXcncyBzY3JvbGxhYmxlIGFyZWEgc2V0IGFzIGRpcnR5LgorCisgICAg ICAgIFRlc3Q6IHRpbGVkLWRyYXdpbmcvc2Nyb2xsaW5nL25vbi1mYXN0LXJlZ2lvbi9ub24tZmFz dC1zY3JvbGxhYmxlLXJlZ2lvbi1oaWRlLXNob3ctaWZyYW1lLmh0bWwKKworICAgICAgICAqIHBh Z2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6YWRkQ2hpbGQp OgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xs Vmlldy5oOgorCiAyMDE4LTAxLTEyICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjI2OTI3LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDgxNTRhZTFlOTU4OTllNTg5YWQyMzA2NDQwMzI4Njk5 NWM4ODVjYjcuLjIxMWIzN2I1ZjUxY2Y2ZTdmNjJjNDg2NWM5OTllNGI1YTg4ZWJhOWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTQ2NDUsNiArNDY0NSwxNCBAQCB2b2lkIEZyYW1l Vmlldzo6c2VuZFNjcm9sbEV2ZW50KCkKICNlbmRpZgogfQogCit2b2lkIEZyYW1lVmlldzo6YWRk Q2hpbGQoV2lkZ2V0JiB3aWRnZXQpCit7CisgICAgaWYgKGlzPEZyYW1lVmlldz4od2lkZ2V0KSkK KyAgICAgICAgYWRkU2Nyb2xsYWJsZUFyZWEoJmRvd25jYXN0PEZyYW1lVmlldz4od2lkZ2V0KSk7 CisKKyAgICBTY3JvbGxWaWV3OjphZGRDaGlsZCh3aWRnZXQpOworfQorCiB2b2lkIEZyYW1lVmll dzo6cmVtb3ZlQ2hpbGQoV2lkZ2V0JiB3aWRnZXQpCiB7CiAgICAgaWYgKGlzPEZyYW1lVmlldz4o d2lkZ2V0KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmggYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCmluZGV4IDRiNGQ2Mzk0OTc5YzUzNjViOGFk NzRjMmYzMTJlNjRiYTJiNTBiMTYuLjA1MzI1YzJhZDE1NDkxODJhZjQzMWM1MzVkMWQxZjYzNzE3 M2MxNTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaApAQCAtNTIxLDcgKzUyMSw4IEBAIHB1Ymxp YzoKICAgICBib29sIGNvbnRhaW5zU2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFyZWEqKSBjb25z dDsKICAgICBjb25zdCBTY3JvbGxhYmxlQXJlYVNldCogc2Nyb2xsYWJsZUFyZWFzKCkgY29uc3Qg eyByZXR1cm4gbV9zY3JvbGxhYmxlQXJlYXMuZ2V0KCk7IH0KIAotICAgIHZvaWQgcmVtb3ZlQ2hp bGQoV2lkZ2V0JikgZmluYWw7CisgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBhZGRDaGlsZChXaWRn ZXQmKSBmaW5hbDsKKyAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHJlbW92ZUNoaWxkKFdpZGdldCYp IGZpbmFsOwogCiAgICAgLy8gVGhpcyBmdW5jdGlvbiBleGlzdHMgZm9yIHBvcnRzIHRoYXQgbmVl ZCB0byBoYW5kbGUgd2hlZWwgZXZlbnRzIG1hbnVhbGx5LgogICAgIC8vIE9uIE1hYyBXZWJLaXQx IHRoZSB1bmRlcmx5aW5nIE5TU2Nyb2xsVmlldyBqdXN0IGRvZXMgdGhlIHNjcm9sbGluZywgYnV0 IG9uIG1vc3Qgb3RoZXIgcGxhdGZvcm1zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9TY3JvbGxWaWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmgK aW5kZXggYTg0YmRmZmUxOTZjZTgyMzVkYzMxNWY1NWI3NDJmMTYwZDU0OTAwMC4uNmQxZGE1YmU1 M2ExZTEzY2IzMWMyOTAwOGM0ZmQ5MTlkNjQyOGRlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Nj cm9sbFZpZXcuaApAQCAtODcsOCArODcsOCBAQCBwdWJsaWM6CiAKICAgICAvLyBGdW5jdGlvbnMg Zm9yIGNoaWxkIG1hbmlwdWxhdGlvbiBhbmQgaW5zcGVjdGlvbi4KICAgICBjb25zdCBIYXNoU2V0 PFJlZjxXaWRnZXQ+PiYgY2hpbGRyZW4oKSBjb25zdCB7IHJldHVybiBtX2NoaWxkcmVuOyB9Ci0g ICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBhZGRDaGlsZChXaWRnZXQmKTsKLSAgICB2aXJ0dWFsIHZv aWQgcmVtb3ZlQ2hpbGQoV2lkZ2V0Jik7CisgICAgV0VCQ09SRV9FWFBPUlQgdmlydHVhbCB2b2lk IGFkZENoaWxkKFdpZGdldCYpOworICAgIFdFQkNPUkVfRVhQT1JUIHZpcnR1YWwgdm9pZCByZW1v dmVDaGlsZChXaWRnZXQmKTsKIAogICAgIC8vIElmIHRoZSBzY3JvbGwgdmlldyBkb2VzIG5vdCB1 c2UgYSBuYXRpdmUgd2lkZ2V0LCB0aGVuIGl0IHdpbGwgaGF2ZSBjcm9zcy1wbGF0Zm9ybSBTY3Jv bGxiYXJzLiBUaGVzZSBmdW5jdGlvbnMKICAgICAvLyBjYW4gYmUgdXNlZCB0byBvYnRhaW4gdGhv c2Ugc2Nyb2xsYmFycy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZjAwNmRhM2JiZWNjYzZiYTc0OGQ1OTM2Yzc2M2Q4YWY3 OTYwODJkLi40Zjc3MmI2ZTljYWVhMTk0ZWI2ZjRkMWZhZjcxYWE1ZTkzZTkyNjc0IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTgtMDEtMTYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CisKKyAgICAgICAgQ2FuJ3Qgc2Nyb2xsIGlmcmFtZSBhZnRlciB0b2dnbGluZyBp dCB0byBkaXNwbGF5Om5vbmUgYW5kIGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MTcwOAorICAgICAgICByZGFyOi8vcHJvYmxlbS8xMzIzNDc3 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGls ZWQtZHJhd2luZy9zY3JvbGxpbmcvbm9uLWZhc3QtcmVnaW9uL25vbi1mYXN0LXNjcm9sbGFibGUt cmVnaW9uLWhpZGUtc2hvdy1pZnJhbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiB0 aWxlZC1kcmF3aW5nL3Njcm9sbGluZy9ub24tZmFzdC1yZWdpb24vbm9uLWZhc3Qtc2Nyb2xsYWJs ZS1yZWdpb24taGlkZS1zaG93LWlmcmFtZS5odG1sOiBBZGRlZC4KKwogMjAxOC0wMS0xMiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBUb3VjaCBldmVu dHMgbm90IHJlY2VpdmVkIHdpdGggaW5pdGlhbC1zY2FsZT0xIHZpZXdwb3J0CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy90aWxlZC1kcmF3aW5nL3Njcm9sbGluZy9ub24tZmFzdC1yZWdpb24vbm9u LWZhc3Qtc2Nyb2xsYWJsZS1yZWdpb24taGlkZS1zaG93LWlmcmFtZS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy90aWxlZC1kcmF3aW5nL3Njcm9sbGluZy9ub24tZmFzdC1yZWdpb24vbm9uLWZh c3Qtc2Nyb2xsYWJsZS1yZWdpb24taGlkZS1zaG93LWlmcmFtZS1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uMmQzNzMyMjI5MzYxYTQ1OGJjNTA5M2FmNTQzZjU1OGJmMThlODc4NgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3RpbGVkLWRyYXdpbmcvc2Nyb2xsaW5nL25vbi1mYXN0LXJl Z2lvbi9ub24tZmFzdC1zY3JvbGxhYmxlLXJlZ2lvbi1oaWRlLXNob3ctaWZyYW1lLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDUgQEAKKworYmVmb3JlOiAxMCwgMTAgLSAzMTAsIDE2MAorYWZ0ZXIg aGlkZTogCithZnRlciBzaG93OiAxMCwgMTAgLSAzMTAsIDE2MAorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy90aWxlZC1kcmF3aW5nL3Njcm9sbGluZy9ub24tZmFzdC1yZWdpb24vbm9uLWZhc3Qt c2Nyb2xsYWJsZS1yZWdpb24taGlkZS1zaG93LWlmcmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvdGls ZWQtZHJhd2luZy9zY3JvbGxpbmcvbm9uLWZhc3QtcmVnaW9uL25vbi1mYXN0LXNjcm9sbGFibGUt cmVnaW9uLWhpZGUtc2hvdy1pZnJhbWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zMmQxYmZlNWJkMTNlNGEx YTAyMDUyYjE4MmRlMjBkMjVkNjM5N2FkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv dGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvbm9uLWZhc3QtcmVnaW9uL25vbi1mYXN0LXNjcm9sbGFi bGUtcmVnaW9uLWhpZGUtc2hvdy1pZnJhbWUuaHRtbApAQCAtMCwwICsxLDQwIEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3doZWVsLWhh bmRsZXItcmVnaW9uLWhlbHBlci5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisKKyAg ICBmdW5jdGlvbiBkdW1wUmVnaW9uKHByZWZpeCkKKyAgICB7CisgICAgICAgIGlmICh3aW5kb3cu aW50ZXJuYWxzKSB7CisgICAgICAgICAgICB2YXIgcmVjdHMgPSB3aW5kb3cuaW50ZXJuYWxzLm5v bkZhc3RTY3JvbGxhYmxlUmVjdHMoKTsKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdvdXRwdXQnKS50ZXh0Q29udGVudCArPSBwcmVmaXggKyByZWN0c0FzU3RyaW5nKHJlY3Rz KSArICdcbic7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBmdW5jdGlvbiBkb1Rlc3QoKQorICAg IHsKKyAgICAgICAgdmFyIGZyYW1lID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2ZyYW1lJyk7 CisgICAgICAgIGR1bXBSZWdpb24oJ2JlZm9yZTogJyk7CisgICAgICAgIGZyYW1lLnN0eWxlLmRp c3BsYXkgPSAnbm9uZSc7CisgICAgICAgIGR1bXBSZWdpb24oJ2FmdGVyIGhpZGU6ICcpOworICAg ICAgICAKKyAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIGZyYW1l LnN0eWxlLmRpc3BsYXkgPSAnaW5saW5lJzsKKyAgICAgICAgICAgIGR1bXBSZWdpb24oJ2FmdGVy IHNob3c6ICcpOworCisgICAgICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAg ICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAgIH0sIDApOworICAgIH0K KyAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGRvVGVzdCwgZmFsc2UpOworPC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxpZnJhbWUgaWQ9ImZyYW1lIiBzcmNkb2M9IjxodG1s Pjxib2R5IHN0eWxlPSd3aWR0aDoxMDAwcHg7aGVpZ2h0OjEwMDBweDsnPjwvYm9keT48L2h0bWw+ Ij48L2lmcmFtZT4KKzxwcmUgaWQ9Im91dHB1dCI+PC9wcmU+Cis8L2JvZHk+Cis8L2h0bWw+CisK