181703 2018-01-16 13:40:32 -0800 AX: Do not trigger layout in updateBackingStore() unless it is safe to do so 2018-01-16 15:07:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan aboxhall apinheiro bfulgham cdumez cfleizach commit-queue dbates dmazzoni esprehn+autocc ews-watchlist jcraig jdiggs kangil.han rniwa samuel_white simon.fraser zalan oldest_to_newest 1389727 0 zalan 2018-01-16 13:40:32 -0800 Document::isSafeToUpdateStyleOrLayout() can tell whether it is safe to run layout. 1389728 1 zalan 2018-01-16 13:41:34 -0800 rdar://problem/36365706 1389731 2 331426 zalan 2018-01-16 13:43:28 -0800 Created attachment 331426 Patch 1389767 3 331426 commit-queue 2018-01-16 15:06:59 -0800 Comment on attachment 331426 Patch Clearing flags on attachment: 331426 Committed r227006: <https://trac.webkit.org/changeset/227006> 1389768 4 commit-queue 2018-01-16 15:07:01 -0800 All reviewed patches have been landed. Closing bug. 331426 2018-01-16 13:43:28 -0800 2018-01-16 15:06:59 -0800 Patch bug-181703-20180116134327.patch text/plain 4320 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2OTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFjMWVmYmE3MTNiZDRh NzhlZDY2NTY0ZDUzMDdjMmJjYWNiNWU5Yy4uMzlmZjJiOWQ4OGFmODA1OGJjMDMwMGI2NzIxNTI5 ODgwYjk5ODQ2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTAxLTE2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IERvIG5vdCB0cmlnZ2Vy IGxheW91dCBpbiB1cGRhdGVCYWNraW5nU3RvcmUoKSB1bmxlc3MgaXQgaXMgc2FmZSB0byBkbyBz bworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxNzAz CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjM2NTcwNj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb2N1bWVudDo6aXNTYWZlVG9VcGRhdGVTdHls ZU9yTGF5b3V0KCkgY2FuIHRlbGwgd2hldGhlciBpdCBpcyBzYWZlIHRvIHJ1biBsYXlvdXQuCisK KyAgICAgICAgVW5hYmxlIHRvIGNyZWF0ZSB0ZXN0IHdpdGggV2ViSW5zcGVjdG9yIGludm9sdmVk LiAKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0Ojp1cGRhdGVCYWNraW5nU3RvcmUp OgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVu dDo6aXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6 OkRvY3VtZW50Ojp1cGRhdGVTdHlsZUlmTmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3Vt ZW50Ojp1cGRhdGVMYXlvdXQpOgorICAgICAgICAoV2ViQ29yZTo6aXNTYWZlVG9VcGRhdGVTdHls ZU9yTGF5b3V0KTogRGVsZXRlZC4KKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKwogMjAxOC0w MS0xMiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIyNjkyNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCmluZGV4IGE2MjI4YzdlZjM1 M2RhY2NlMmJmYzgyNzgzNzI1OGUyZjBmMDRmNjQuLjU3MmEyZjAwMWE1NDg2ZmE2NjZlNDI0ZGQx NWNmZGM2MTAzZjgwMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcApAQCAtMTc2OCwxMiArMTc2OCwxMCBAQCB2b2lkIEFj Y2Vzc2liaWxpdHlPYmplY3Q6OnVwZGF0ZUJhY2tpbmdTdG9yZSgpCiB7CiAgICAgLy8gVXBkYXRp bmcgdGhlIGxheW91dCBtYXkgZGVsZXRlIHRoaXMgb2JqZWN0LgogICAgIFJlZlB0cjxBY2Nlc3Np YmlsaXR5T2JqZWN0PiBwcm90ZWN0ZWRUaGlzKHRoaXMpOwotCi0gICAgaWYgKERvY3VtZW50KiBk b2N1bWVudCA9IHRoaXMtPmRvY3VtZW50KCkpIHsKLSAgICAgICAgaWYgKCFkb2N1bWVudC0+dmll dygpLT5sYXlvdXRDb250ZXh0KCkuaXNJblJlbmRlclRyZWVMYXlvdXQoKSAmJiAhZG9jdW1lbnQt PmluUmVuZGVyVHJlZVVwZGF0ZSgpKQorICAgIGlmIChhdXRvKiBkb2N1bWVudCA9IHRoaXMtPmRv Y3VtZW50KCkpIHsKKyAgICAgICAgaWYgKCFkb2N1bWVudC0+dmlldygpLT5sYXlvdXRDb250ZXh0 KCkuaXNJblJlbmRlclRyZWVMYXlvdXQoKSAmJiAhZG9jdW1lbnQtPmluUmVuZGVyVHJlZVVwZGF0 ZSgpICYmIGRvY3VtZW50LT5pc1NhZmVUb1VwZGF0ZVN0eWxlT3JMYXlvdXQoKSkKICAgICAgICAg ICAgIGRvY3VtZW50LT51cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKICAg ICB9Ci0gICAgCiAgICAgdXBkYXRlQ2hpbGRyZW5JZk5lY2Vzc2FyeSgpOwogfQogI2VuZGlmCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCBjN2Q0ODViMzVhODQzN2VlN2M3MjlhNTAyYTRmN2M1 ZTY0NWQzNGIzLi42YTRlMDExOTUwYjk4ZWI4MmQxNjljZjIwMmEzMGJlMTI1NTg2MzBmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTE5MzUsMTAgKzE5MzUsMTAgQEAgYm9vbCBEb2N1bWVu dDo6bmVlZHNTdHlsZVJlY2FsYygpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi1pbmxp bmUgYm9vbCBzdGF0aWMgaXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0KEZyYW1lVmlldyogZnJh bWVWaWV3KQorYm9vbCBEb2N1bWVudDo6aXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0KCkgY29u c3QKIHsKICAgICBib29sIGlzU2FmZVRvRXhlY3V0ZVNjcmlwdCA9IFNjcmlwdERpc2FsbG93ZWRT Y29wZTo6SW5NYWluVGhyZWFkOjppc1NjcmlwdEFsbG93ZWQoKTsKLSAgICBib29sIGlzSW5GcmFt ZUZsYXR0ZW5pbmcgPSBmcmFtZVZpZXcgJiYgZnJhbWVWaWV3LT5pc0luQ2hpbGRGcmFtZVdpdGhG cmFtZUZsYXR0ZW5pbmcoKTsKKyAgICBib29sIGlzSW5GcmFtZUZsYXR0ZW5pbmcgPSB2aWV3KCkg JiYgdmlldygpLT5pc0luQ2hpbGRGcmFtZVdpdGhGcmFtZUZsYXR0ZW5pbmcoKTsKICAgICByZXR1 cm4gaXNTYWZlVG9FeGVjdXRlU2NyaXB0IHx8IGlzSW5GcmFtZUZsYXR0ZW5pbmcgfHwgIWlzSW5X ZWJQcm9jZXNzKCk7CiB9CiAKQEAgLTE5NjAsNyArMTk2MCw3IEBAIGJvb2wgRG9jdW1lbnQ6OnVw ZGF0ZVN0eWxlSWZOZWVkZWQoKQogICAgIH0KIAogICAgIC8vIFRoZSBlYXJseSBleGl0IGFib3Zl IGZvciAhbmVlZHNTdHlsZVJlY2FsYygpIGlzIG5lZWRlZCB3aGVuIHVwZGF0ZVdpZGdldFBvc2l0 aW9ucygpIGlzIGNhbGxlZCBpbiBydW5PclNjaGVkdWxlQXN5bmNocm9ub3VzVGFza3MoKS4KLSAg ICBSRUxFQVNFX0FTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGlzU2FmZVRvVXBkYXRl U3R5bGVPckxheW91dChmcmFtZVZpZXcuZ2V0KCkpKTsKKyAgICBSRUxFQVNFX0FTU0VSVF9XSVRI X1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGlzU2FmZVRvVXBkYXRlU3R5bGVPckxheW91dCgpKTsKIAog ICAgIHJlc29sdmVTdHlsZSgpOwogICAgIHJldHVybiB0cnVlOwpAQCAtMTk3Niw3ICsxOTc2LDcg QEAgdm9pZCBEb2N1bWVudDo6dXBkYXRlTGF5b3V0KCkKICAgICAgICAgQVNTRVJUX05PVF9SRUFD SEVEKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0gICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9T RUNVUklUWV9JTVBMSUNBVElPTihpc1NhZmVUb1VwZGF0ZVN0eWxlT3JMYXlvdXQoZnJhbWVWaWV3 LmdldCgpKSk7CisgICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihp c1NhZmVUb1VwZGF0ZVN0eWxlT3JMYXlvdXQoKSk7CiAKICAgICBSZW5kZXJWaWV3OjpSZXBhaW50 UmVnaW9uQWNjdW11bGF0b3IgcmVwYWludFJlZ2lvbkFjY3VtdWxhdG9yKHJlbmRlclZpZXcoKSk7 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIvU291cmNlL1dl YkNvcmUvZG9tL0RvY3VtZW50LmgKaW5kZXggZmIzNjk3MjQ2MmViYmE2OGNhNDgwZjE2NTMxMmJi NjA5MjU5NmU1Yi4uZjc5YjgxOWJhMmVmOWE3MjI5NjFjYzJlZGY3MWE5ZmM1YmI0MzAwMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmgKQEAgLTEyNTAsNiArMTI1MCw3IEBAIHB1YmxpYzoKIAogICAgIGJv b2wgaW5TdHlsZVJlY2FsYygpIGNvbnN0IHsgcmV0dXJuIG1faW5TdHlsZVJlY2FsYzsgfQogICAg IGJvb2wgaW5SZW5kZXJUcmVlVXBkYXRlKCkgY29uc3QgeyByZXR1cm4gbV9pblJlbmRlclRyZWVV cGRhdGU7IH0KKyAgICBib29sIGlzU2FmZVRvVXBkYXRlU3R5bGVPckxheW91dCgpIGNvbnN0Owog CiAgICAgdm9pZCB1cGRhdGVUZXh0UmVuZGVyZXIoVGV4dCYsIHVuc2lnbmVkIG9mZnNldE9mUmVw bGFjZWRUZXh0LCB1bnNpZ25lZCBsZW5ndGhPZlJlcGxhY2VkVGV4dCk7CiAK