181690 2018-01-16 10:31:00 -0800 [Win] JSC compile error in runtime/DateConversion.cpp. 2018-01-16 11:09:37 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue ews-watchlist oldest_to_newest 1389601 0 pvollan 2018-01-16 10:31:00 -0800 1> JavaScriptCore/runtime/DateConversion.cpp(35): fatal error C1083: Cannot open include file: 'wtf/text/win/WCharStringExtras.h': No such file or directory 1389602 1 pvollan 2018-01-16 10:31:29 -0800 <rdar://problem/36480409> 1389603 2 331400 pvollan 2018-01-16 10:35:50 -0800 Created attachment 331400 Patch 1389604 3 331400 bfulgham 2018-01-16 10:37:41 -0800 Comment on attachment 331400 Patch r=me 1389605 4 ews-watchlist 2018-01-16 10:38:27 -0800 Attachment 331400 did not pass style-queue: ERROR: Source/WTF/wtf/PlatformWin.cmake:3: There should be exactly one empty line instead of 0 between "cf/TypeCastsCF.h" and "text/win/WCharStringExtras.h". [list/emptyline] [5] ERROR: Source/WTF/wtf/PlatformWin.cmake:38: There should be exactly one empty line instead of 0 between "text" and "text/win". [list/emptyline] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1389606 5 331400 pvollan 2018-01-16 10:40:32 -0800 Comment on attachment 331400 Patch Thanks for reviewing! 1389629 6 331400 commit-queue 2018-01-16 11:09:36 -0800 Comment on attachment 331400 Patch Clearing flags on attachment: 331400 Committed r226983: <https://trac.webkit.org/changeset/226983> 1389630 7 commit-queue 2018-01-16 11:09:37 -0800 All reviewed patches have been landed. Closing bug. 331400 2018-01-16 10:35:50 -0800 2018-01-16 11:09:36 -0800 Patch bug-181690-20180116193549.patch text/plain 1147 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjY5NzUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAxLTE2ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBKU0MgY29tcGlsZSBlcnJvciBpbiBy dW50aW1lL0RhdGVDb252ZXJzaW9uLmNwcC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MTY5MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY0ODA0 MDk+CisgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCAndGV4dC93aW4nIGZvbGRlciB0byBsaXN0IG9mIGZvcndhcmRpbmcgaGVhZGVycyBkaXJlY3Rv cmllcy4KKyAKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1XaW4uY21ha2U6CisKIDIwMTgtMDEtMTEg IEphc29uIE1hcmNlbGwgIDxqbWFyY2VsbEBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hlcnJ5LXBp Y2sgcjIyNjc4NC4gcmRhcjovL3Byb2JsZW0vMzY0NTA3NDYKSW5kZXg6IFNvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtV2luLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt V2luLmNtYWtlCShyZXZpc2lvbiAyMjY5NzQpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybVdp bi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDYgQEAKIGxpc3QoQVBQRU5EIFdURl9I RUFERVJTCiAgICAgY2YvVHlwZUNhc3RzQ0YuaAorICAgIHRleHQvd2luL1dDaGFyU3RyaW5nRXh0 cmFzLmgKICkKIAogbGlzdChBUFBFTkQgV1RGX1NPVVJDRVMKQEAgLTM0LDYgKzM1LDcgQEAgc2V0 KFdURl9GT1JXQVJESU5HX0hFQURFUlNfRElSRUNUT1JJRVMKICAgICBwZXJzaXN0ZW5jZQogICAg IHNwaQogICAgIHRleHQKKyAgICB0ZXh0L3dpbgogICAgIHRocmVhZHMKICAgICB1bmljb2RlCiAg ICAgd2luCg==