181683 2018-01-16 08:03:36 -0800 PAL should link to JavaScriptCore rather than WTF 2018-01-16 11:44:57 -0800 1 1 1 Unclassified WebKit Platform Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro annulen bugs-noreply don.olmstead mcatanzaro mmaxfield webkit-bug-importer oldest_to_newest 1389552 0 mcatanzaro 2018-01-16 08:03:36 -0800 Currently we are accidentally linking WTF into both libjavascriptcoregtk and libwebkit2gtk, which could in theory cause problems similar to bug #179914. There are only two possible solutions: * Ensure WTF always built as a shared library if JavaScriptCore is built as a shared library * Change PAL to link to JavaScriptCore instead of WTF The problem here is caused by layer hopping. It can never be a problem if each library only links to the next lowest-layered library. The downside is this allows PAL to use JavaScriptCore symbols, which is not super desirable. I came up with a hack yesterday for PAL to link to WTF usually, but link to JavaScriptCore instead if ${JavaScriptCore_LIBRARY_TYPE} MATCHES "SHARED" AND ${WTF_LIBRARY_TYPE} MATCHES "STATIC". But that is getting too complex and introduces more possibility for platform-dependent build failures. Better to just accept that PAL will depend on JavaScriptCore. Note: I'm not brave enough to update the XCode build. We can use that to enforce that no JavaScriptCore symbols actually get used, I guess. 1389553 1 mcatanzaro 2018-01-16 08:04:38 -0800 (In reply to Michael Catanzaro from comment #0) > The problem here is caused by layer hopping. It can never be a problem if > each library only links to the next lowest-layered library. Note that, to my knowledge, PAL is the only lib we have that violates this rule. 1389556 2 annulen 2018-01-16 08:19:00 -0800 >Note that, to my knowledge, PAL is the only lib we have that violates this rule. Not at all. WebKit links to WebCore and JSC, and there are more examples in Tools 1389557 3 mcatanzaro 2018-01-16 08:20:59 -0800 (In reply to Konstantin Tokarev from comment #2) > >Note that, to my knowledge, PAL is the only lib we have that violates this rule. > > Not at all. WebKit links to WebCore and JSC, and Ah yes, but it shouldn't need to do that. > there are more examples in Tools No doubt :) 1389581 4 331394 mcatanzaro 2018-01-16 09:29:43 -0800 Created attachment 331394 Patch 1389583 5 331394 mcatanzaro 2018-01-16 09:34:17 -0800 Comment on attachment 331394 Patch It's not right, I should change WebCore to not link directly to JSC now. 1389590 6 331396 mcatanzaro 2018-01-16 10:06:55 -0800 Created attachment 331396 Patch 1389597 7 331396 annulen 2018-01-16 10:20:44 -0800 Comment on attachment 331396 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331396&action=review > Source/WebCore/PAL/pal/CMakeLists.txt:26 > + JavaScriptCore${DEBUG_SUFFIX} In the perfect world it should be PUBLIC if JSC is SHARED and PRIVATE otherwise. Or, it could be specified as PRIVATE here and ports who build JSC as shared can add it as INTERFACE in a separate command. But it's ok in this form for now too. 1389652 8 mcatanzaro 2018-01-16 11:41:12 -0800 (In reply to Konstantin Tokarev from comment #7) > In the perfect world it should be PUBLIC if JSC is SHARED and PRIVATE > otherwise. This would be easiest... currently we make almost no use of library dependency visibility, though. Let's explore that in future patches. 1389653 9 mcatanzaro 2018-01-16 11:41:53 -0800 Committed r226989: <https://trac.webkit.org/changeset/226989> 1389654 10 webkit-bug-importer 2018-01-16 11:44:57 -0800 <rdar://problem/36552175> 331394 2018-01-16 09:29:43 -0800 2018-01-16 10:06:53 -0800 Patch bug-181683-20180116112943.patch text/plain 2265 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2OTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAwMThlMGFl MDA0MjRhMmY1MzZlZDAzNzIzZGE4MTExOTI5MjJkYWQ2Li41NTJmMWI2Zjk4ODNiYjQ1NzY5NDA1 OWIxYWY3NzY5NDhhZTU1MDJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAor MjAxOC0wMS0xNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisK KyAgICAgICAgUEFMIHNob3VsZCBsaW5rIHRvIEphdmFTY3JpcHRDb3JlIHJhdGhlciB0aGFuIFdU RgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxNjgz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVu dGx5IHdlIGFyZSBhY2NpZGVudGFsbHkgbGlua2luZyBXVEYgaW50byBib3RoIGxpYmphdmFzY3Jp cHRjb3JlZ3RrIGFuZCBsaWJ3ZWJraXQyZ3RrLAorICAgICAgICB3aGljaCBjb3VsZCBpbiB0aGVv cnkgY2F1c2UgcHJvYmxlbXMgc2ltaWxhciB0byBidWcgIzE3OTkxNC4gVGhlcmUgYXJlIG9ubHkg dHdvIHBvc3NpYmxlCisgICAgICAgIHNvbHV0aW9uczoKKworICAgICAgICAgLSBFbnN1cmUgV1RG IGFsd2F5cyBidWlsdCBhcyBhIHNoYXJlZCBsaWJyYXJ5IGlmIEphdmFTY3JpcHRDb3JlIGlzIGJ1 aWx0IGFzIGEgc2hhcmVkCisgICAgICAgICAgIGxpYnJhcnkKKyAgICAgICAgIC0gQ2hhbmdlIFBB TCB0byBsaW5rIHRvIEphdmFTY3JpcHRDb3JlIGluc3RlYWQgb2YgV1RGCisKKyAgICAgICAgVGhl IHByb2JsZW0gaGVyZSBpcyBjYXVzZWQgYnkgbGF5ZXIgaG9wcGluZy4gSXQgY2FuIG5ldmVyIGJl IGEgcHJvYmxlbSBpZiBlYWNoIGxpYnJhcnkgb25seQorICAgICAgICBsaW5rcyB0byB0aGUgbmV4 dCBsb3dlc3QtbGF5ZXJlZCBsaWJyYXJ5LgorCisgICAgICAgIFRoZSBkb3duc2lkZSBpcyB0aGlz IGFsbG93cyBQQUwgdG8gdXNlIEphdmFTY3JpcHRDb3JlIHN5bWJvbHMsIHdoaWNoIGlzIG5vdCBz dXBlciBkZXNpcmFibGUuCisgICAgICAgIEkgY2FtZSB1cCB3aXRoIGEgaGFjayB5ZXN0ZXJkYXkg Zm9yIFBBTCB0byBsaW5rIHRvIFdURiB1c3VhbGx5LCBidXQgbGluayB0byBKYXZhU2NyaXB0Q29y ZQorICAgICAgICBpbnN0ZWFkIGlmICR7SmF2YVNjcmlwdENvcmVfTElCUkFSWV9UWVBFfSBNQVRD SEVTICJTSEFSRUQiIEFORCAke1dURl9MSUJSQVJZX1RZUEV9IE1BVENIRVMKKyAgICAgICAgIlNU QVRJQyIuIEJ1dCB0aGF0IGlzIGdldHRpbmcgdG9vIGNvbXBsZXggYW5kIGludHJvZHVjZXMgbW9y ZSBwb3NzaWJpbGl0eSBmb3IgcGxhdGZvcm0tCisgICAgICAgIGRlcGVuZGVudCBidWlsZCBmYWls dXJlcy4gQmV0dGVyIHRvIGp1c3QgYWNjZXB0IHRoYXQgUEFMIHdpbGwgZGVwZW5kIG9uIEphdmFT Y3JpcHRDb3JlLgorCisgICAgICAgIE5vdGU6IEknbSBub3QgYnJhdmUgZW5vdWdoIHRvIHVwZGF0 ZSB0aGUgWENvZGUgYnVpbGQuIFdlIGNhbiB1c2UgdGhhdCB0byBlbmZvcmNlIHRoYXQgbm8KKyAg ICAgICAgSmF2YVNjcmlwdENvcmUgc3ltYm9scyBhY3R1YWxseSBnZXQgdXNlZCwgSSBndWVzcy4K KworICAgICAgICAqIHBhbC9DTWFrZUxpc3RzLnR4dDoKKwogMjAxOC0wMS0xNSAgTWljaGFlbCBD YXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgSW1wcm92ZSB1c2Ug b2YgRXhwb3J0TWFjcm9zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL0NNYWtl TGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9DTWFrZUxpc3RzLnR4dAppbmRleCA1 NDRmZmYxNDhhZWNmNDUzNTllMTNkM2UwODk1ZGJmMzEwZmE5M2RlLi41NWIyZjQwZDc4ZTkyOGZj ZmZmY2ExNjlhMzAxNmZjMTU4YTQ0Mzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwv cGFsL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvQ01ha2VMaXN0 cy50eHQKQEAgLTIzLDcgKzIzLDcgQEAgc2V0KFBBTF9TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklF UwogKQogCiBzZXQoUEFMX0xJQlJBUklFUwotICAgIFBSSVZBVEUgV1RGCisgICAgSmF2YVNjcmlw dENvcmUKICkKIAogV0VCS0lUX0ZSQU1FV09SS19ERUNMQVJFKFBBTCkK 331396 2018-01-16 10:06:55 -0800 2018-01-16 10:21:02 -0800 Patch bug-181683-20180116120655.patch text/plain 3353 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2OTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmNmMGQ3ZjFmZWJjNWNk MDAxZDI0ZmI2ZGNmZjcxY2MwNmQ4YTgwZi4uOTM0M2FjODBjOGJhMzgzN2RhOWFkMGU5ZDQwNDM0 ZDNmOWM1MzkyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAxLTE2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBQQUwgc2hv dWxkIGxpbmsgdG8gSmF2YVNjcmlwdENvcmUgcmF0aGVyIHRoYW4gV1RGCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE2ODMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgbGluayBkaXJlY3RseSB0 byBKYXZhU2NyaXB0Q29yZS4gR2V0IGl0IHZpYSBQQUwuCisKKyAgICAgICAgKiBDTWFrZUxpc3Rz LnR4dDoKKwogMjAxOC0wMS0xNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxp YS5jb20+CiAKICAgICAgICAgSW1wcm92ZSB1c2Ugb2YgRXhwb3J0TWFjcm9zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5n ZUxvZwppbmRleCAwMThlMGFlMDA0MjRhMmY1MzZlZDAzNzIzZGE4MTExOTI5MjJkYWQ2Li4yMzEx NThlYjllNzkzNTc5OWRjMjUyNTZjYjU5MjhkZWRhMjUwZDkyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9QQUwvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cK QEAgLTEsMyArMSwzMiBAQAorMjAxOC0wMS0xNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56 YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgUEFMIHNob3VsZCBsaW5rIHRvIEphdmFTY3JpcHRD b3JlIHJhdGhlciB0aGFuIFdURgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgxNjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ3VycmVudGx5IHdlIGFyZSBhY2NpZGVudGFsbHkgbGlua2luZyBXVEYgaW50 byBib3RoIGxpYmphdmFzY3JpcHRjb3JlZ3RrIGFuZCBsaWJ3ZWJraXQyZ3RrLAorICAgICAgICB3 aGljaCBjb3VsZCBpbiB0aGVvcnkgY2F1c2UgcHJvYmxlbXMgc2ltaWxhciB0byBidWcgIzE3OTkx NC4gVGhlcmUgYXJlIG9ubHkgdHdvIHBvc3NpYmxlCisgICAgICAgIHNvbHV0aW9uczoKKworICAg ICAgICAgLSBFbnN1cmUgV1RGIGFsd2F5cyBidWlsdCBhcyBhIHNoYXJlZCBsaWJyYXJ5IGlmIEph dmFTY3JpcHRDb3JlIGlzIGJ1aWx0IGFzIGEgc2hhcmVkCisgICAgICAgICAgIGxpYnJhcnkKKyAg ICAgICAgIC0gQ2hhbmdlIFBBTCB0byBsaW5rIHRvIEphdmFTY3JpcHRDb3JlIGluc3RlYWQgb2Yg V1RGCisKKyAgICAgICAgVGhlIHByb2JsZW0gaGVyZSBpcyBjYXVzZWQgYnkgbGF5ZXIgaG9wcGlu Zy4gSXQgY2FuIG5ldmVyIGJlIGEgcHJvYmxlbSBpZiBlYWNoIGxpYnJhcnkgb25seQorICAgICAg ICBsaW5rcyB0byB0aGUgbmV4dCBsb3dlc3QtbGF5ZXJlZCBsaWJyYXJ5LgorCisgICAgICAgIFRo ZSBkb3duc2lkZSBpcyB0aGlzIGFsbG93cyBQQUwgdG8gdXNlIEphdmFTY3JpcHRDb3JlIHN5bWJv bHMsIHdoaWNoIGlzIG5vdCBzdXBlciBkZXNpcmFibGUuCisgICAgICAgIEkgY2FtZSB1cCB3aXRo IGEgaGFjayB5ZXN0ZXJkYXkgZm9yIFBBTCB0byBsaW5rIHRvIFdURiB1c3VhbGx5LCBidXQgbGlu ayB0byBKYXZhU2NyaXB0Q29yZQorICAgICAgICBpbnN0ZWFkIGlmICR7SmF2YVNjcmlwdENvcmVf TElCUkFSWV9UWVBFfSBNQVRDSEVTICJTSEFSRUQiIEFORCAke1dURl9MSUJSQVJZX1RZUEV9IE1B VENIRVMKKyAgICAgICAgIlNUQVRJQyIuIEJ1dCB0aGF0IGlzIGdldHRpbmcgdG9vIGNvbXBsZXgg YW5kIGludHJvZHVjZXMgbW9yZSBwb3NzaWJpbGl0eSBmb3IgcGxhdGZvcm0tCisgICAgICAgIGRl cGVuZGVudCBidWlsZCBmYWlsdXJlcy4gQmV0dGVyIHRvIGp1c3QgYWNjZXB0IHRoYXQgUEFMIHdp bGwgZGVwZW5kIG9uIEphdmFTY3JpcHRDb3JlLgorCisgICAgICAgIE5vdGU6IEknbSBub3QgYnJh dmUgZW5vdWdoIHRvIHVwZGF0ZSB0aGUgWENvZGUgYnVpbGQuIFdlIGNhbiB1c2UgdGhhdCB0byBl bmZvcmNlIHRoYXQgbm8KKyAgICAgICAgSmF2YVNjcmlwdENvcmUgc3ltYm9scyBhY3R1YWxseSBn ZXQgdXNlZCwgSSBndWVzcy4uLi4KKworICAgICAgICAqIHBhbC9DTWFrZUxpc3RzLnR4dDoKKwog MjAxOC0wMS0xNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAK ICAgICAgICAgSW1wcm92ZSB1c2Ugb2YgRXhwb3J0TWFjcm9zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0Cmlu ZGV4IGRiYmVlZDc0N2EyNmNiOTdlZjIwOWZmNWQxZWQ5YjQyNjg5NWJlOWQuLjAzMmQ2ZWU5OWU1 NTQxYWFiMzFhYWIxYmQ0ODlmYjMzNmU4YzgzMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0x MDc2LDcgKzEwNzYsNiBAQCBzZXQoV2ViQ29yZV9MSUJSQVJJRVMKICAgICAke0xJQlhTTFRfTElC UkFSSUVTfQogICAgICR7U1FMSVRFX0xJQlJBUklFU30KICAgICAke1pMSUJfTElCUkFSSUVTfQot ICAgIEphdmFTY3JpcHRDb3JlJHtERUJVR19TVUZGSVh9CiAgICAgUEFMJHtERUJVR19TVUZGSVh9 CiApCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvQ01ha2VMaXN0cy50eHQg Yi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL0NNYWtlTGlzdHMudHh0CmluZGV4IDU0NGZmZjE0OGFl Y2Y0NTM1OWUxM2QzZTA4OTVkYmYzMTBmYTkzZGUuLjMzYzJkODFjNjM1ZTgwZjZjNjUzY2E2NGJj ODIyYTRmMGRlYjYzYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvQ01ha2VM aXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9DTWFrZUxpc3RzLnR4dApAQCAt MjMsNyArMjMsNyBAQCBzZXQoUEFMX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiApCiAKIHNl dChQQUxfTElCUkFSSUVTCi0gICAgUFJJVkFURSBXVEYKKyAgICBKYXZhU2NyaXB0Q29yZSR7REVC VUdfU1VGRklYfQogKQogCiBXRUJLSVRfRlJBTUVXT1JLX0RFQ0xBUkUoUEFMKQo=