<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>181656</bug_id>
          
          <creation_ts>2018-01-15 13:20:58 -0800</creation_ts>
          <short_desc>WEBKIT_FRAMEWORK should not modify file-global include directories</short_desc>
          <delta_ts>2018-01-17 15:24:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>annulen</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1389366</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-15 13:20:58 -0800</bug_when>
    <thetext>WEBKIT_FRAMEWORK should not modify file-global include directories, it should only modify target include directories.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1389369</commentid>
    <comment_count>1</comment_count>
      <attachid>331354</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-15 13:22:01 -0800</bug_when>
    <thetext>Created attachment 331354
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1389385</commentid>
    <comment_count>2</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-15 14:39:58 -0800</bug_when>
    <thetext>That&apos;s right direction, but WebCore certainly needs to clean up the mess, and maybe not only WebCore</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1389397</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-15 15:24:19 -0800</bug_when>
    <thetext>This broke the WPE EWS, I need to fix that.

GTK EWS seems to have gone crazy, it&apos;s the old &quot;thinks it&apos;s not an ELF system&quot; error we&apos;ve never managed to figure out. I&apos;d ignore that as I&apos;ve tested it locally.

(In reply to Konstantin Tokarev from comment #2)
&gt; That&apos;s right direction, but WebCore certainly needs to clean up the mess,
&gt; and maybe not only WebCore

What do you mean?

I know we have a lot of room to tighten up include directories throughout the build system.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1389400</commentid>
    <comment_count>4</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-15 15:33:20 -0800</bug_when>
    <thetext>I mean these include_directories() were used by other targets in same CMakeListsts.txt, e.g. WebCoreTestSupport, WebCoreDerivedSources, so there may be side effects. But if you tested it locally it&apos;s fine. Also note that as you made these system include directories PUBLIC they may be propagated to targets which weren&apos;t using them before.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1389410</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-15 16:32:56 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #4)
&gt; I mean these include_directories() were used by other targets in same
&gt; CMakeListsts.txt, e.g. WebCoreTestSupport, WebCoreDerivedSources, so there
&gt; may be side effects. But if you tested it locally it&apos;s fine.

Fine except for WPE, yes. ;)

Well, and maybe Mac... who knows about Mac, since there is no CMake EWS.

&gt; Also note that
&gt; as you made these system include directories PUBLIC they may be propagated
&gt; to targets which weren&apos;t using them before.

Hm, I suppose that was not intentional... I had to pick PUBLIC/PRIVATE/INTERFACE, but was thinking &quot;PUBLIC is the default for normal include_directories()&quot;. But that&apos;s wrong: I should have used PRIVATE.

Probably better for me to take the time to do this properly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1389997</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 07:19:31 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #5)
&gt; Probably better for me to take the time to do this properly.

It&apos;s a bit silly how complex it is to decide whether the include directories should be part of the target&apos;s interface or not. And we don&apos;t really want _SYSTEM_INCLUDE_DIRECTORIES to be surprisingly different from normal _INCLUDE_DIRECTORIES is anything but SYSTEM. So I&apos;ll stick with the original plan here, and just try to fix the WPE build error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390007</commentid>
    <comment_count>7</comment_count>
      <attachid>331496</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 08:39:37 -0800</bug_when>
    <thetext>Created attachment 331496
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390008</commentid>
    <comment_count>8</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 08:40:32 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #6)
&gt; It&apos;s a bit silly how complex it is to decide whether the include directories
&gt; should be part of the target&apos;s interface or not.

This could be a big future cleanup, but I don&apos;t want to even think about tackling it in order to fix this obvious issue with WEBKIT_FRAMEWORK. ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390009</commentid>
    <comment_count>9</comment_count>
      <attachid>331496</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-17 08:41:39 -0800</bug_when>
    <thetext>Comment on attachment 331496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331496&amp;action=review

&gt; Source/WebCore/CMakeLists.txt:1951
&gt; +target_include_directories(WebCoreTestSupport PUBLIC ${WebCoreTestSupport_INCLUDE_DIRECTORIES} ${WebCore_INCLUDE_DIRECTORIES} ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})

No, it should be a separate line

target_include_directories(WebCoreTestSupport SYSTEM PUBLIC ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390010</commentid>
    <comment_count>10</comment_count>
      <attachid>331496</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-17 08:42:45 -0800</bug_when>
    <thetext>Comment on attachment 331496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331496&amp;action=review

&gt; Source/cmake/WebKitMacros.cmake:137
&gt; +    target_include_directories(${_target} SYSTEM PUBLIC &quot;$&lt;BUILD_INTERFACE:${${_target}_SYSTEM_INCLUDE_DIRECTORIES}&gt;&quot;)

And I would really use PRIVATE here. If something breaks we&apos;ll see quickly</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390011</commentid>
    <comment_count>11</comment_count>
      <attachid>331496</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-17 08:43:43 -0800</bug_when>
    <thetext>Comment on attachment 331496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331496&amp;action=review

&gt;&gt; Source/WebCore/CMakeLists.txt:1951
&gt;&gt; +target_include_directories(WebCoreTestSupport PUBLIC ${WebCoreTestSupport_INCLUDE_DIRECTORIES} ${WebCore_INCLUDE_DIRECTORIES} ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})
&gt; 
&gt; No, it should be a separate line
&gt; 
&gt; target_include_directories(WebCoreTestSupport SYSTEM PUBLIC ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})

SYSTEM PRIVATE, sorry</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390014</commentid>
    <comment_count>12</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-17 08:48:38 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #6)
&gt; It&apos;s a bit silly how complex it is to decide whether the include directories
&gt; should be part of the target&apos;s interface or not.

All SYSTEM inlcude dirs were &quot;directory-private&quot; before your change, so it should be safe to make them PRIVATE (if satellite targets of WebCore are fixed, and maybe WebKit processes also)

Maybe a few things like ICU and GLib could be made SYSTEM PUBLIC, but most of system libraries will probably stay PRIVATE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390015</commentid>
    <comment_count>13</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-17 08:49:58 -0800</bug_when>
    <thetext>Note that we don&apos;t have to invent new variables anymore, as Platform files can use target-specific commands directly now</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390017</commentid>
    <comment_count>14</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 08:53:03 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #9)
&gt; &gt; Source/WebCore/CMakeLists.txt:1951
&gt; &gt; +target_include_directories(WebCoreTestSupport PUBLIC ${WebCoreTestSupport_INCLUDE_DIRECTORIES} ${WebCore_INCLUDE_DIRECTORIES} ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})
&gt; 
&gt; No, it should be a separate line

Yup, oops.

(In reply to Konstantin Tokarev from comment #10)
&gt; And I would really use PRIVATE here. If something breaks we&apos;ll see quickly

OK....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390019</commentid>
    <comment_count>15</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 08:53:52 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #13)
&gt; Note that we don&apos;t have to invent new variables anymore, as Platform files
&gt; can use target-specific commands directly now

Can you point me to where you changed this? I tried modifying WebCoreTestSupport directly from WebCore/PlatformWPE.cmake but didn&apos;t have access to it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390026</commentid>
    <comment_count>16</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-17 09:00:19 -0800</bug_when>
    <thetext>&gt;Can you point me to where you changed this? 

In https://bugs.webkit.org/show_bug.cgi?id=174557

WebCoreTestSupport is not &quot;forward-declared&quot; with WEBKIT_FRAMEWORK_DECLARE, that&apos;s why it&apos;s inaccessible. Can be fixed easily</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390105</commentid>
    <comment_count>17</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 11:11:19 -0800</bug_when>
    <thetext>Let&apos;s see how this does on EWS....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390109</commentid>
    <comment_count>18</comment_count>
      <attachid>331521</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 11:15:43 -0800</bug_when>
    <thetext>Created attachment 331521
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390181</commentid>
    <comment_count>19</comment_count>
      <attachid>331521</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2018-01-17 13:27:38 -0800</bug_when>
    <thetext>Comment on attachment 331521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331521&amp;action=review

&gt; Source/WebCore/CMakeLists.txt:1952
&gt; +target_include_directories(WebCoreTestSupport SYSTEM PUBLIC ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})

Looks great overall, but couldn&apos;t this be PRIVATE too?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390234</commentid>
    <comment_count>20</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 15:16:54 -0800</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #19)
&gt; Looks great overall, but couldn&apos;t this be PRIVATE too?

Um, yes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390235</commentid>
    <comment_count>21</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 15:18:03 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #20)
&gt; (In reply to Konstantin Tokarev from comment #19)
&gt; &gt; Looks great overall, but couldn&apos;t this be PRIVATE too?
&gt; 
&gt; Um, yes.

But PUBLIC is used on the line above... so I&apos;ll leave it be for now. Lots of room for future cleanups....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390236</commentid>
    <comment_count>22</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-17 15:18:21 -0800</bug_when>
    <thetext>Committed r227090: &lt;https://trac.webkit.org/changeset/227090&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1390242</commentid>
    <comment_count>23</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-01-17 15:24:45 -0800</bug_when>
    <thetext>&lt;rdar://problem/36598424&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>331354</attachid>
            <date>2018-01-15 13:22:01 -0800</date>
            <delta_ts>2018-01-17 08:39:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-181656-20180115152200.patch</filename>
            <type>text/plain</type>
            <size>1803</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQppbmRleCA3
ZTY5NTU3YzAxYjlmMjhlMzZiNmY3OGI2YWZlYzI0ZDA2ZGY2YjdmLi4yZGM5MDM4YjgwNTg5MGU2
NDBkYmY3ZTMzMTc5MTMyN2IzYTg5N2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0
TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTEy
OSwxMiArMTI5LDEyIEBAIG1hY3JvKFdFQktJVF9GUkFNRVdPUktfREVDTEFSRSBfdGFyZ2V0KQog
ZW5kbWFjcm8oKQogCiBtYWNybyhXRUJLSVRfRlJBTUVXT1JLIF90YXJnZXQpCi0gICAgaW5jbHVk
ZV9kaXJlY3RvcmllcyhTWVNURU0gJHske190YXJnZXR9X1NZU1RFTV9JTkNMVURFX0RJUkVDVE9S
SUVTfSkKICAgICB0YXJnZXRfc291cmNlcygke190YXJnZXR9IFBSSVZBVEUKICAgICAgICAgJHsk
e190YXJnZXR9X0hFQURFUlN9CiAgICAgICAgICR7JHtfdGFyZ2V0fV9TT1VSQ0VTfQogICAgICkK
ICAgICB0YXJnZXRfaW5jbHVkZV9kaXJlY3Rvcmllcygke190YXJnZXR9IFBVQkxJQyAiJDxCVUlM
RF9JTlRFUkZBQ0U6JHske190YXJnZXR9X0lOQ0xVREVfRElSRUNUT1JJRVN9PiIpCisgICAgdGFy
Z2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMoJHtfdGFyZ2V0fSBTWVNURU0gUFVCTElDICIkPEJVSUxE
X0lOVEVSRkFDRTokeyR7X3RhcmdldH1fU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVN9PiIpCiAg
ICAgdGFyZ2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMoJHtfdGFyZ2V0fSBQUklWQVRFICIkPEJVSUxE
X0lOVEVSRkFDRTokeyR7X3RhcmdldH1fUFJJVkFURV9JTkNMVURFX0RJUkVDVE9SSUVTfT4iKQog
ICAgIHRhcmdldF9saW5rX2xpYnJhcmllcygke190YXJnZXR9ICR7JHtfdGFyZ2V0fV9MSUJSQVJJ
RVN9KQogICAgIHNldF90YXJnZXRfcHJvcGVydGllcygke190YXJnZXR9IFBST1BFUlRJRVMgQ09N
UElMRV9ERUZJTklUSU9OUyAiQlVJTERJTkdfJHtfdGFyZ2V0fSIpCmRpZmYgLS1naXQgYS9DaGFu
Z2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYTNjNDg4N2VmZDAwZmU0ZGM4OGY2NDU1MDQ2NWU5Y2Yw
M2JmZTFkNS4uMmZiMjE0MDNmN2UxMzBlNWE4YzQwNzg3YWU0YzBmYjYxZjliODBlOSAxMDA2NDQK
LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAx
LTE1ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAg
ICBXRUJLSVRfRlJBTUVXT1JLIHNob3VsZCBub3QgbW9kaWZ5IGZpbGUtZ2xvYmFsIGluY2x1ZGUg
ZGlyZWN0b3JpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE4MTY1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIE9ubHkgbW9kaWZ5IHRoZSBzeXN0ZW0gaW5jbHVkZSBkaXJlY3RvcmllcyBvZiB0aGUgdGFy
Z2V0IHBhc3NlZCB0byBXRUJLSVRfRlJBTUVXT1JLLgorCisgICAgICAgICogU291cmNlL2NtYWtl
L1dlYktpdE1hY3Jvcy5jbWFrZToKKwogMjAxOC0wMS0xNSAgTWljaGFlbCBDYXRhbnphcm8gIDxt
Y2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjI2MjY2KTogW0dU
S10gUkVMRUFTRV9BU1NFUlQocmVzZXJ2ZWRab25lU2l6ZSA+PSBtaW5pbXVtUmVzZXJ2ZWRab25l
U2l6ZSkgaW4gSlNDOjpWTTo6dXBkYXRlU3RhY2tMaW1pdHMK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>331496</attachid>
            <date>2018-01-17 08:39:37 -0800</date>
            <delta_ts>2018-01-17 11:15:41 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-181656-20180117103936.patch</filename>
            <type>text/plain</type>
            <size>3732</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU4NWM5YTRkYzBjZDUw
NWRhMDM4ZjNiYmI2MzczMmQzNjFjYzM4YS4uMTQ4YTU5ZDczZDAwNWFmNjQ3ZjM3NDFkYjhmZTQ0
NWNmZTk4OTZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTAxLTE3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBXRUJLSVRf
RlJBTUVXT1JLIHNob3VsZCBub3QgbW9kaWZ5IGZpbGUtZ2xvYmFsIGluY2x1ZGUgZGlyZWN0b3Jp
ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTY1
NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01h
a2VMaXN0cy50eHQ6CisgICAgICAgICogUGxhdGZvcm1XUEUuY21ha2U6CisKIDIwMTgtMDEtMTcg
IFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3
ZWQgZm9sbG93LXVwIHRvIHIyMjcwNTEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFr
ZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGM5Zjg0Y2Q1
MzE4YjlkNjc4OWE2NDk5YjcxZjVkNGI1YTdkMzRmOTIuLmM3ZGUxY2E3ODA0YWU2YTRjY2U5N2Ew
OTFmNDZjNTA1MTczZDIwZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMu
dHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xOTQ4LDcgKzE5NDgs
NyBAQCBlbmRpZiAoKQogCiBhZGRfbGlicmFyeShXZWJDb3JlVGVzdFN1cHBvcnQgJHtXZWJDb3Jl
VGVzdFN1cHBvcnRfTElCUkFSWV9UWVBFfSAke1dlYkNvcmVUZXN0U3VwcG9ydF9TT1VSQ0VTfSkK
IGFkZF9kZXBlbmRlbmNpZXMoV2ViQ29yZVRlc3RTdXBwb3J0IFdlYkNvcmUgV2ViQ29yZVRlc3RT
dXBwb3J0QmluZGluZ3MpCi10YXJnZXRfaW5jbHVkZV9kaXJlY3RvcmllcyhXZWJDb3JlVGVzdFN1
cHBvcnQgUFVCTElDICR7V2ViQ29yZVRlc3RTdXBwb3J0X0lOQ0xVREVfRElSRUNUT1JJRVN9ICR7
V2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKK3RhcmdldF9pbmNsdWRlX2RpcmVjdG9yaWVz
KFdlYkNvcmVUZXN0U3VwcG9ydCBQVUJMSUMgJHtXZWJDb3JlVGVzdFN1cHBvcnRfSU5DTFVERV9E
SVJFQ1RPUklFU30gJHtXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVN9ICR7V2ViQ29yZV9TWVNU
RU1fSU5DTFVERV9ESVJFQ1RPUklFU30pCiB0YXJnZXRfbGlua19saWJyYXJpZXMoV2ViQ29yZVRl
c3RTdXBwb3J0ICR7V2ViQ29yZVRlc3RTdXBwb3J0X0xJQlJBUklFU30pCiAKIGlmIChXZWJDb3Jl
VGVzdFN1cHBvcnRfT1VUUFVUX05BTUUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0
Zm9ybVdQRS5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IGU4
MTQ1ZmEzNDFjODY1OWQ3ODg4ZWQ1MjIzNGE1NmUwMTUyY2VmOTMuLmM5MTg1NTg2NzcwMTA1MzYw
ZmM2ZjBkM2NhNTRlOTJkODE0NmFiYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRm
b3JtV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtlCkBAIC03
Niw3ICs3Niw3IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCiAgICAgJHtXUEVfTElC
UkFSSUVTfQogKQogCi1saXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKK2xp
c3QoQVBQRU5EIFdlYkNvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0NBSVJP
X0lOQ0xVREVfRElSU30KICAgICAke0dJT19VTklYX0lOQ0xVREVfRElSU30KICAgICAke0dMSUJf
SU5DTFVERV9ESVJTfQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFr
ZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKaW5kZXggN2U2OTU1N2MwMWI5ZjI4
ZTM2YjZmNzhiNmFmZWMyNGQwNmRmNmI3Zi4uMmRjOTAzOGI4MDU4OTBlNjQwZGJmN2UzMzE3OTEz
MjdiM2E4OTdkMiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQor
KysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCkBAIC0xMjksMTIgKzEyOSwxMiBA
QCBtYWNybyhXRUJLSVRfRlJBTUVXT1JLX0RFQ0xBUkUgX3RhcmdldCkKIGVuZG1hY3JvKCkKIAog
bWFjcm8oV0VCS0lUX0ZSQU1FV09SSyBfdGFyZ2V0KQotICAgIGluY2x1ZGVfZGlyZWN0b3JpZXMo
U1lTVEVNICR7JHtfdGFyZ2V0fV9TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklFU30pCiAgICAgdGFy
Z2V0X3NvdXJjZXMoJHtfdGFyZ2V0fSBQUklWQVRFCiAgICAgICAgICR7JHtfdGFyZ2V0fV9IRUFE
RVJTfQogICAgICAgICAkeyR7X3RhcmdldH1fU09VUkNFU30KICAgICApCiAgICAgdGFyZ2V0X2lu
Y2x1ZGVfZGlyZWN0b3JpZXMoJHtfdGFyZ2V0fSBQVUJMSUMgIiQ8QlVJTERfSU5URVJGQUNFOiR7
JHtfdGFyZ2V0fV9JTkNMVURFX0RJUkVDVE9SSUVTfT4iKQorICAgIHRhcmdldF9pbmNsdWRlX2Rp
cmVjdG9yaWVzKCR7X3RhcmdldH0gU1lTVEVNIFBVQkxJQyAiJDxCVUlMRF9JTlRFUkZBQ0U6JHsk
e190YXJnZXR9X1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTfT4iKQogICAgIHRhcmdldF9pbmNs
dWRlX2RpcmVjdG9yaWVzKCR7X3RhcmdldH0gUFJJVkFURSAiJDxCVUlMRF9JTlRFUkZBQ0U6JHsk
e190YXJnZXR9X1BSSVZBVEVfSU5DTFVERV9ESVJFQ1RPUklFU30+IikKICAgICB0YXJnZXRfbGlu
a19saWJyYXJpZXMoJHtfdGFyZ2V0fSAkeyR7X3RhcmdldH1fTElCUkFSSUVTfSkKICAgICBzZXRf
dGFyZ2V0X3Byb3BlcnRpZXMoJHtfdGFyZ2V0fSBQUk9QRVJUSUVTIENPTVBJTEVfREVGSU5JVElP
TlMgIkJVSUxESU5HXyR7X3RhcmdldH0iKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdl
TG9nCmluZGV4IGE2MGE3ODE2MzFjZGMyMDMyYjdhY2JiMTIzNDQ0MDFiYjAyZmU0MTguLjJlNWQw
ODg4YWUyYzIzOWRlNDExZTcxZDgxYjNhMGFhN2Y2ODI3NTcgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxv
ZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wMS0xNyAgTWljaGFlbCBD
YXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgV0VCS0lUX0ZSQU1F
V09SSyBzaG91bGQgbm90IG1vZGlmeSBmaWxlLWdsb2JhbCBpbmNsdWRlIGRpcmVjdG9yaWVzCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE2NTYKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IG1vZGlm
eSB0aGUgc3lzdGVtIGluY2x1ZGUgZGlyZWN0b3JpZXMgb2YgdGhlIHRhcmdldCBwYXNzZWQgdG8g
V0VCS0lUX0ZSQU1FV09SSy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3Mu
Y21ha2U6CisKIDIwMTgtMDEtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs
aWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBPcHRpb25zR1RLLmNtYWtlIGFu
ZCBORVdTIGZvciAyLjE5LjYgcmVsZWFzZS4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>331521</attachid>
            <date>2018-01-17 11:15:43 -0800</date>
            <delta_ts>2018-01-17 13:27:38 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-181656-20180117131542.patch</filename>
            <type>text/plain</type>
            <size>8294</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU4NWM5YTRkYzBjZDUw
NWRhMDM4ZjNiYmI2MzczMmQzNjFjYzM4YS4uMTQ4YTU5ZDczZDAwNWFmNjQ3ZjM3NDFkYjhmZTQ0
NWNmZTk4OTZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTAxLTE3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBXRUJLSVRf
RlJBTUVXT1JLIHNob3VsZCBub3QgbW9kaWZ5IGZpbGUtZ2xvYmFsIGluY2x1ZGUgZGlyZWN0b3Jp
ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTY1
NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01h
a2VMaXN0cy50eHQ6CisgICAgICAgICogUGxhdGZvcm1XUEUuY21ha2U6CisKIDIwMTgtMDEtMTcg
IFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3
ZWQgZm9sbG93LXVwIHRvIHIyMjcwNTEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5n
ZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZiZWFmZGVjMTY1YTRjMDI4OGIx
YmI4ZGY0ZDhjMTFkYzYzZGRhYTcuLjliNTU4ZTFkMzQ3MmIyYmU3NWM5NTE5NTlhYWNmZDUwMDk5
ZjU0NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X
ZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDEtMTcgIE1pY2hhZWwgQ2F0
YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFdFQktJVF9GUkFNRVdP
Uksgc2hvdWxkIG5vdCBtb2RpZnkgZmlsZS1nbG9iYWwgaW5jbHVkZSBkaXJlY3RvcmllcworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxNjU2CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdU
Sy5jbWFrZToKKyAgICAgICAgKiBQbGF0Zm9ybVdQRS5jbWFrZToKKwogMjAxOC0wMS0xNyAgWmFu
IERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NhaXJvXSBEb24n
dCBtaXJyb3IgZ2xvYmFsIGFscGhhIGFuZCBpbWFnZSBpbnRlcnBvbGF0aW9uIHF1YWxpdHkgc3Rh
dGUgdmFsdWVzIGluIFBsYXRmb3JtQ29udGV4dENhaXJvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4
IGM5Zjg0Y2Q1MzE4YjlkNjc4OWE2NDk5YjcxZjVkNGI1YTdkMzRmOTIuLmQ1OTM0NWEzOTgyZjFm
OTYyYTM2NTdhMjQ4ZWE3MzhjYWMxNjhlMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NN
YWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xOTQ5
LDYgKzE5NDksNyBAQCBlbmRpZiAoKQogYWRkX2xpYnJhcnkoV2ViQ29yZVRlc3RTdXBwb3J0ICR7
V2ViQ29yZVRlc3RTdXBwb3J0X0xJQlJBUllfVFlQRX0gJHtXZWJDb3JlVGVzdFN1cHBvcnRfU09V
UkNFU30pCiBhZGRfZGVwZW5kZW5jaWVzKFdlYkNvcmVUZXN0U3VwcG9ydCBXZWJDb3JlIFdlYkNv
cmVUZXN0U3VwcG9ydEJpbmRpbmdzKQogdGFyZ2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMoV2ViQ29y
ZVRlc3RTdXBwb3J0IFBVQkxJQyAke1dlYkNvcmVUZXN0U3VwcG9ydF9JTkNMVURFX0RJUkVDVE9S
SUVTfSAke1dlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFU30pCit0YXJnZXRfaW5jbHVkZV9kaXJl
Y3RvcmllcyhXZWJDb3JlVGVzdFN1cHBvcnQgU1lTVEVNIFBVQkxJQyAke1dlYkNvcmVfU1lTVEVN
X0lOQ0xVREVfRElSRUNUT1JJRVN9KQogdGFyZ2V0X2xpbmtfbGlicmFyaWVzKFdlYkNvcmVUZXN0
U3VwcG9ydCAke1dlYkNvcmVUZXN0U3VwcG9ydF9MSUJSQVJJRVN9KQogCiBpZiAoV2ViQ29yZVRl
c3RTdXBwb3J0X09VVFBVVF9OQU1FKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZv
cm1XUEUuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCBlODE0
NWZhMzQxYzg2NTlkNzg4OGVkNTIyMzRhNTZlMDE1MmNlZjkzLi5jOTE4NTU4Njc3MDEwNTM2MGZj
NmYwZDNjYTU0ZTkyZDgxNDZhYmJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9y
bVdQRS5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtNzYs
NyArNzYsNyBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUwogICAgICR7V1BFX0xJQlJB
UklFU30KICkKIAotbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCitsaXN0
KEFQUEVORCBXZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtDQUlST19J
TkNMVURFX0RJUlN9CiAgICAgJHtHSU9fVU5JWF9JTkNMVURFX0RJUlN9CiAgICAgJHtHTElCX0lO
Q0xVREVfRElSU30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2Ug
Yi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDkzYzk3OGQzMWZkY2U5ZTQ1
OGU3OTY2Y2QyNDNjZTY4YTQ4YjBlNjQuLjEyNzExY2I2YzgwZWUyZTkxZTY3ZDc0ZmNlNTljNzgw
ZDljYTI1ZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKKysr
IGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMTA2MCwyMiArMTA2MCwyMSBA
QCBsaXN0KEFQUEVORCBQbHVnaW5Qcm9jZXNzX1NPVVJDRVMKICkKIAogIyBDb21tYW5kcyBmb3Ig
YnVpbGRpbmcgdGhlIGJ1aWx0LWluIGluamVjdGVkIGJ1bmRsZS4KLWluY2x1ZGVfZGlyZWN0b3Jp
ZXMoCi0gICAgIiR7V0VCS0lUX0RJUn0vUGxhdGZvcm0iCi0gICAgIiR7V0VCS0lUX0RJUn0vU2hh
cmVkIgotICAgICIke1dFQktJVF9ESVJ9L1NoYXJlZC9BUEkvYyIKLSAgICAiJHtXRUJLSVRfRElS
fS9VSVByb2Nlc3MvQVBJL0MiCi0gICAgIiR7V0VCS0lUX0RJUn0vV2ViUHJvY2Vzcy9JbmplY3Rl
ZEJ1bmRsZSIKLSAgICAiJHtXRUJLSVRfRElSfS9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQ
SS9jIgorYWRkX2xpYnJhcnkod2Via2l0Mmd0a2luamVjdGVkYnVuZGxlIE1PRFVMRSAiJHtXRUJL
SVRfRElSfS9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9nbGliL1dlYktpdEluamVjdGVk
QnVuZGxlTWFpbi5jcHAiKQorQUREX1dFQktJVF9QUkVGSVhfSEVBREVSKHdlYmtpdDJndGtpbmpl
Y3RlZGJ1bmRsZSkKK3RhcmdldF9saW5rX2xpYnJhcmllcyh3ZWJraXQyZ3RraW5qZWN0ZWRidW5k
bGUgV2ViS2l0KQorCit0YXJnZXRfaW5jbHVkZV9kaXJlY3Rvcmllcyh3ZWJraXQyZ3RraW5qZWN0
ZWRidW5kbGUgUFJJVkFURQorICAgICR7V2ViS2l0X0lOQ0xVREVfRElSRUNUT1JJRVN9CiAgICAg
IiR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vSW5qZWN0ZWRCdW5kbGUiCiAgICAgIiR7Rk9SV0FSRElO
R19IRUFERVJTX0RJUn0iCiAgICAgIiR7Rk9SV0FSRElOR19IRUFERVJTX1dFQktJVDJHVEtfRElS
fSIKICAgICAiJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19BUElfRElSfSIKICkKIAotYWRk
X2xpYnJhcnkod2Via2l0Mmd0a2luamVjdGVkYnVuZGxlIE1PRFVMRSAiJHtXRUJLSVRfRElSfS9X
ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9nbGliL1dlYktpdEluamVjdGVkQnVuZGxlTWFp
bi5jcHAiKQotQUREX1dFQktJVF9QUkVGSVhfSEVBREVSKHdlYmtpdDJndGtpbmplY3RlZGJ1bmRs
ZSkKLXRhcmdldF9saW5rX2xpYnJhcmllcyh3ZWJraXQyZ3RraW5qZWN0ZWRidW5kbGUgV2ViS2l0
KQordGFyZ2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMod2Via2l0Mmd0a2luamVjdGVkYnVuZGxlIFNZ
U1RFTSBQUklWQVRFCisgICAgJHtXZWJLaXRfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVN9Cisp
CiAKIGlmIChDT01QSUxFUl9JU19HQ0NfT1JfQ0xBTkcpCiAgICAgV0VCS0lUX0FERF9UQVJHRVRf
Q1hYX0ZMQUdTKHdlYmtpdDJndGtpbmplY3RlZGJ1bmRsZSAtV25vLXVudXNlZC1wYXJhbWV0ZXIp
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlIGIvU291cmNlL1dl
YktpdC9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCAwMjNlNzkwMDU5MGFiNmQ4NWU1M2QyYzI5MTYz
NzczMGQzNDlhNDdiLi44YjEwN2E5NWMyOWYzYzM5NGVhYWUzNmJmOWNhZDNkMmI5MTE1YTJlIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9X
ZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTQ4MSw2ICs0ODEsOSBAQCBhZGRfbGlicmFyeShX
UEVJbmplY3RlZEJ1bmRsZSBNT0RVTEUgIiR7V0VCS0lUX0RJUn0vV2ViUHJvY2Vzcy9JbmplY3Rl
ZEJ1bmRsZS9BUAogQUREX1dFQktJVF9QUkVGSVhfSEVBREVSKFdQRUluamVjdGVkQnVuZGxlKQog
dGFyZ2V0X2xpbmtfbGlicmFyaWVzKFdQRUluamVjdGVkQnVuZGxlIFdlYktpdCkKIAordGFyZ2V0
X2luY2x1ZGVfZGlyZWN0b3JpZXMoV1BFSW5qZWN0ZWRCdW5kbGUgUFJJVkFURSAke1dlYktpdF9J
TkNMVURFX0RJUkVDVE9SSUVTfSkKK3RhcmdldF9pbmNsdWRlX2RpcmVjdG9yaWVzKFdQRUluamVj
dGVkQnVuZGxlIFNZU1RFTSBQUklWQVRFICR7V2ViS2l0X1NZU1RFTV9JTkNMVURFX0RJUkVDVE9S
SUVTfSkKKwogaW5zdGFsbChGSUxFUyAiJHtDTUFLRV9CSU5BUllfRElSfS93cGUtd2Via2l0LnBj
IgogICAgIERFU1RJTkFUSU9OICIke0NNQUtFX0lOU1RBTExfTElCRElSfS9wa2djb25maWciCiAg
ICAgQ09NUE9ORU5UICJEZXZlbG9wbWVudCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJL
aXRNYWNyb3MuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCmluZGV4IDdl
Njk1NTdjMDFiOWYyOGUzNmI2Zjc4YjZhZmVjMjRkMDZkZjZiN2YuLmExZTdlOGY1YTc1NWE0M2Mz
MzkxOTQzOGMwYTljNGEwNDlmYTdiYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRN
YWNyb3MuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQpAQCAtMTI5
LDEyICsxMjksMTIgQEAgbWFjcm8oV0VCS0lUX0ZSQU1FV09SS19ERUNMQVJFIF90YXJnZXQpCiBl
bmRtYWNybygpCiAKIG1hY3JvKFdFQktJVF9GUkFNRVdPUksgX3RhcmdldCkKLSAgICBpbmNsdWRl
X2RpcmVjdG9yaWVzKFNZU1RFTSAkeyR7X3RhcmdldH1fU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJ
RVN9KQogICAgIHRhcmdldF9zb3VyY2VzKCR7X3RhcmdldH0gUFJJVkFURQogICAgICAgICAkeyR7
X3RhcmdldH1fSEVBREVSU30KICAgICAgICAgJHske190YXJnZXR9X1NPVVJDRVN9CiAgICAgKQog
ICAgIHRhcmdldF9pbmNsdWRlX2RpcmVjdG9yaWVzKCR7X3RhcmdldH0gUFVCTElDICIkPEJVSUxE
X0lOVEVSRkFDRTokeyR7X3RhcmdldH1fSU5DTFVERV9ESVJFQ1RPUklFU30+IikKKyAgICB0YXJn
ZXRfaW5jbHVkZV9kaXJlY3Rvcmllcygke190YXJnZXR9IFNZU1RFTSBQUklWQVRFICIkPEJVSUxE
X0lOVEVSRkFDRTokeyR7X3RhcmdldH1fU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVN9PiIpCiAg
ICAgdGFyZ2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMoJHtfdGFyZ2V0fSBQUklWQVRFICIkPEJVSUxE
X0lOVEVSRkFDRTokeyR7X3RhcmdldH1fUFJJVkFURV9JTkNMVURFX0RJUkVDVE9SSUVTfT4iKQog
ICAgIHRhcmdldF9saW5rX2xpYnJhcmllcygke190YXJnZXR9ICR7JHtfdGFyZ2V0fV9MSUJSQVJJ
RVN9KQogICAgIHNldF90YXJnZXRfcHJvcGVydGllcygke190YXJnZXR9IFBST1BFUlRJRVMgQ09N
UElMRV9ERUZJTklUSU9OUyAiQlVJTERJTkdfJHtfdGFyZ2V0fSIpCmRpZmYgLS1naXQgYS9Ub29s
cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2M0YjA2YjkyMTU3NmQzM2E4MWVk
MjYyZmQwMjE4NmI2YTg1ZDYzZC4uM2EyZDBjODQ4YTIxNDc3M2FiZTY5YTdlYzQ2NDFmMzg1ZDVh
M2EzYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDEzIEBACisyMDE4LTAxLTE3ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnph
cm9AaWdhbGlhLmNvbT4KKworICAgICAgICBXRUJLSVRfRlJBTUVXT1JLIHNob3VsZCBub3QgbW9k
aWZ5IGZpbGUtZ2xvYmFsIGluY2x1ZGUgZGlyZWN0b3JpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTY1NgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVdQRS5j
bWFrZToKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL2dsaWIvQ01ha2VMaXN0cy50eHQ6CisKIDIw
MTgtMDEtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg
ICAgICAgIFdlYkRyaXZlcjogYWRkIHN1cHBvcnQgZm9yIHRlc3QgZXhwZWN0YXRpb25zCmRpZmYg
LS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtV1BFLmNtYWtlIGIvVG9vbHMvVGVz
dFdlYktpdEFQSS9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCBjNGY0YmIwZDMxMmY1Zjc3ZDA2ZTIz
YTcwZTg5Njg5NzY1M2EyMzAxLi45NmEzNTdmNzYwMGMzZThmMGI1NWJkYTliODI5MjVlZDE0ZWJm
ZTRkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtV1BFLmNtYWtlCisr
KyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTE5LDYgKzE5LDcg
QEAgaW5jbHVkZV9kaXJlY3RvcmllcygKICkKIAogaW5jbHVkZV9kaXJlY3RvcmllcyhTWVNURU0K
KyAgICAke0NBSVJPX0lOQ0xVREVfRElSU30KICAgICAke0dMSUJfSU5DTFVERV9ESVJTfQogICAg
ICR7TElCU09VUF9JTkNMVURFX0RJUlN9CiApCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0
QVBJL2dsaWIvQ01ha2VMaXN0cy50eHQgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvQ01ha2VM
aXN0cy50eHQKaW5kZXggZWIyYmVhMDcyYmU0ZWIzOGQzNGZiZmRmY2M5Y2QxMzk1NmMwMTdlNS4u
ODUwNmYwYWYyODE0MzViOWYzYjg2NjUyZGVlN2Y0ZDRkZmQ3Nzk1ZiAxMDA2NDQKLS0tIGEvVG9v
bHMvVGVzdFdlYktpdEFQSS9nbGliL0NNYWtlTGlzdHMudHh0CisrKyBiL1Rvb2xzL1Rlc3RXZWJL
aXRBUEkvZ2xpYi9DTWFrZUxpc3RzLnR4dApAQCAtMTUsNiArMTUsNyBAQCBzZXQoV2ViS2l0R0xp
YkFQSVRlc3RzX0lOQ0xVREVfRElSRUNUT1JJRVMKICkKIAogc2V0KFdlYktpdEdMaWJBUElUZXN0
c19TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklFUworICAgICR7Q0FJUk9fSU5DTFVERV9ESVJTfQog
ICAgICR7R0xJQl9JTkNMVURFX0RJUlN9CiAgICAgJHtHU1RSRUFNRVJfSU5DTFVERV9ESVJTfQog
ICAgICR7TElCU09VUF9JTkNMVURFX0RJUlN9CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu
Z2VMb2cKaW5kZXggYTYwYTc4MTYzMWNkYzIwMzJiN2FjYmIxMjM0NDQwMWJiMDJmZTQxOC4uMmU1
ZDA4ODhhZTJjMjM5ZGU0MTFlNzFkODFiM2EwYWE3ZjY4Mjc1NyAxMDA2NDQKLS0tIGEvQ2hhbmdl
TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAxLTE3ICBNaWNoYWVs
IENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBXRUJLSVRfRlJB
TUVXT1JLIHNob3VsZCBub3QgbW9kaWZ5IGZpbGUtZ2xvYmFsIGluY2x1ZGUgZGlyZWN0b3JpZXMK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTY1Ngor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgbW9k
aWZ5IHRoZSBzeXN0ZW0gaW5jbHVkZSBkaXJlY3RvcmllcyBvZiB0aGUgdGFyZ2V0IHBhc3NlZCB0
byBXRUJLSVRfRlJBTUVXT1JLLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdE1hY3Jv
cy5jbWFrZToKKwogMjAxOC0wMS0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln
YWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNHVEsuY21ha2Ug
YW5kIE5FV1MgZm9yIDIuMTkuNiByZWxlYXNlLgo=
</data>
<flag name="review"
          id="350491"
          type_id="1"
          status="+"
          setter="annulen"
    />
          </attachment>
      

    </bug>

</bugzilla>