181653 2018-01-15 11:59:44 -0800 Test programs should only be built in developer mode 2018-01-16 07:34:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro annulen bugs-noreply cgarcia commit-queue mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1389347 0 mcatanzaro 2018-01-15 11:59:44 -0800 JSC builds these test programs unconditionally: testmasm testb3 testair testapi But they're not exposed or installed in release mode. Our other tests all depend on developer mode, so let's be consistent. I noticed these recently because having installed binaries that depend on internal symbols of JSC makes it harder to change how we link JSC, though hopefully we'll never have to bother with that again anytime soon.... 1389348 1 331350 mcatanzaro 2018-01-15 12:00:51 -0800 Created attachment 331350 Patch 1389384 2 annulen 2018-01-15 14:37:32 -0800 These are unit tests, and it might make sense to build unit tests in non-developer builds, e.g. packagers could use them for smoke checking... 1389396 3 mcatanzaro 2018-01-15 15:21:46 -0800 You'd think, but our test scripts simply don't support running from tarball builds, and there's not much point in having a bunch of standalone test binaries in the builddir. That might be worth changing, of course. 1389542 4 331350 commit-queue 2018-01-16 07:33:26 -0800 Comment on attachment 331350 Patch Clearing flags on attachment: 331350 Committed r226971: <https://trac.webkit.org/changeset/226971> 1389543 5 commit-queue 2018-01-16 07:33:28 -0800 All reviewed patches have been landed. Closing bug. 1389546 6 webkit-bug-importer 2018-01-16 07:34:18 -0800 <rdar://problem/36543176> 331350 2018-01-15 12:00:51 -0800 2018-01-16 07:33:26 -0800 Patch bug-181653-20180115140050.patch text/plain 1690 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 OGUyOGE1MmM2NzE0Y2FiMjRlZTc4YjYzYTk2OTE4OWE3YzgyYjA5Li5mZGQ2NTM1Y2JmZWNlZGY5 NDBiMTNjYWRlMzY3ZGEwMTNmYTE2OTUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wMS0xNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgVGVzdCBwcm9ncmFtcyBzaG91bGQgb25seSBiZSBidWlsdCBp biBkZXZlbG9wZXIgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTgxNjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQnVpbGQgdGVzdCBwcm9ncmFtcyBvbmx5IGluIGRldmVsb3BlciBtb2RlLCBhbmQg Zml4IGNvZGUgc3R5bGUuCisKKyAgICAgICAgKiBzaGVsbC9DTWFrZUxpc3RzLnR4dDoKKwogMjAx OC0wMS0xNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMjI2MjY2KTogW0dUS10gUkVMRUFTRV9BU1NFUlQocmVzZXJ2ZWRa b25lU2l6ZSA+PSBtaW5pbXVtUmVzZXJ2ZWRab25lU2l6ZSkgaW4gSlNDOjpWTTo6dXBkYXRlU3Rh Y2tMaW1pdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9DTWFrZUxp c3RzLnR4dCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9DTWFrZUxpc3RzLnR4dAppbmRl eCA2ZGNlMDU3ZmNiYTY5Zjc5MmMxZDBlMjBlMWFkYTBjNDgxMGE0YmY2Li42YzUxYWY0YjE1OTY1 NTEyYWUzNDBkMDVkODczNzAyYWViMGIxYzNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvc2hlbGwvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3No ZWxsL0NNYWtlTGlzdHMudHh0CkBAIC01NSwxOSArNTUsMTkgQEAgaWYgKFRBUkdFVCBqc2NMaWIp CiAgICAgYWRkX2RlcGVuZGVuY2llcyhqc2MganNjTGliKQogZW5kaWYgKCkKIAotICAgIHNldChU RVNUTUFTTV9TT1VSQ0VTCi0gICAgICAgIC4uL2Fzc2VtYmxlci90ZXN0bWFzbS5jcHAKLSAgICAp CitzZXQoVEVTVE1BU01fU09VUkNFUworICAgIC4uL2Fzc2VtYmxlci90ZXN0bWFzbS5jcHAKKykK IAotICAgIHNldChURVNUQjNfU09VUkNFUwotICAgICAgICAuLi9iMy90ZXN0YjMuY3BwCi0gICAg KQorc2V0KFRFU1RCM19TT1VSQ0VTCisgICAgLi4vYjMvdGVzdGIzLmNwcAorKQogCi0gICAgc2V0 KFRFU1RBSVJfU09VUkNFUwotICAgICAgICAuLi9iMy9haXIvdGVzdGFpci5jcHAKLSAgICApCitz ZXQoVEVTVEFJUl9TT1VSQ0VTCisgICAgLi4vYjMvYWlyL3Rlc3RhaXIuY3BwCispCiAKLWlmIChO T1QgV0lOMzIpCitpZiAoREVWRUxPUEVSX01PREUgQU5EIE5PVCBXSU4zMikKICAgICBhZGRfZXhl Y3V0YWJsZSh0ZXN0bWFzbSAke1RFU1RNQVNNX1NPVVJDRVN9KQogICAgIHRhcmdldF9saW5rX2xp YnJhcmllcyh0ZXN0bWFzbSAke0pTQ19MSUJSQVJJRVN9KQogCg==