181579 2018-01-11 22:26:52 -0800 Web Inspector: Remove unnecessary raw pointer in InspectorConsoleAgent 2018-01-12 09:33:02 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue ews-watchlist inspector-bugzilla-changes joepeck keith_miller mark.lam mkwst msaboff saam webkit-bug-importer oldest_to_newest 1388700 0 joepeck 2018-01-11 22:26:52 -0800 Remove unnecessary raw pointer in InspectorConsoleAgent 1388701 1 joepeck 2018-01-11 22:27:02 -0800 <rdar://problem/36193759> 1388703 2 331170 joepeck 2018-01-11 22:30:04 -0800 Created attachment 331170 [PATCH] Proposed Fix 1388811 3 331170 bburg 2018-01-12 09:09:49 -0800 Comment on attachment 331170 [PATCH] Proposed Fix r=me 1388814 4 331170 commit-queue 2018-01-12 09:33:01 -0800 Comment on attachment 331170 [PATCH] Proposed Fix Clearing flags on attachment: 331170 Committed r226895: <https://trac.webkit.org/changeset/226895> 1388815 5 commit-queue 2018-01-12 09:33:02 -0800 All reviewed patches have been landed. Closing bug. 331170 2018-01-11 22:30:04 -0800 2018-01-12 09:33:01 -0800 [PATCH] Proposed Fix console-1.patch text/plain 4373 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGIzNGNkYTdhYmNlLi5lNDZkZGYzYWRiNCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDEtMTEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZW1vdmUgdW5uZWNlc3NhcnkgcmF3IHBvaW50ZXIgaW4gSW5zcGVjdG9yQ29uc29sZUFnZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE1NzkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM2MTkzNzU5PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JD b25zb2xlQWdlbnQuaDoKKyAgICAgICAgKiBpbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNvbnNv bGVBZ2VudC5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvckNvbnNvbGVBZ2VudDo6 Y2xlYXJNZXNzYWdlcyk6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvckNvbnNvbGVBZ2Vu dDo6YWRkQ29uc29sZU1lc3NhZ2UpOgorICAgICAgICBTd2l0Y2ggZnJvbSBhIHJhdyBwb2ludGVy IHRvIG1fY29uc29sZU1lc3NhZ2VzLmxhc3QoKS4KKyAgICAgICAgQWxzbyBtb3ZlIHRoZSBleHBp cmF0aW9uIGNoZWNrIGludG8gdGhlIGlmIGJsb2NrIHNpbmNlIGl0IGNhbiBvbmx5CisgICAgICAg IGhhcHBlbiBpbnNpZGUgaGVyZSB3aGVuIHRoZSBudW1iZXIgb2YgY29uc29sZSBtZXNzYWdlcyBj aGFuZ2VzLgorCisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvckNvbnNvbGVBZ2VudDo6ZGlz Y2FyZFZhbHVlcyk6CisgICAgICAgIEFsc28gY2xlYXIgdGhlIGV4cGlyZWQgbWVzc2FnZSBjb3Vu dCB3aGVuIG1lc3NhZ2VzIGFyZSBjbGVhcmVkLgorCiAyMDE4LTAxLTA0ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQ29kZUJsb2NrcyBzaG91bGQgYmUgaW4gSXNv U3Vic3BhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2Fn ZW50cy9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcAppbmRleCA4YTJkZjJiMWY5 Ny4uNWMzYmY3ZDZmMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvYWdlbnRzL0luc3BlY3RvckNvbnNvbGVBZ2VudC5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcApAQCAtNjks NiArNjksNyBAQCB2b2lkIEluc3BlY3RvckNvbnNvbGVBZ2VudDo6d2lsbERlc3Ryb3lGcm9udGVu ZEFuZEJhY2tlbmQoRGlzY29ubmVjdFJlYXNvbikKIHZvaWQgSW5zcGVjdG9yQ29uc29sZUFnZW50 OjpkaXNjYXJkVmFsdWVzKCkKIHsKICAgICBtX2NvbnNvbGVNZXNzYWdlcy5jbGVhcigpOworICAg IG1fZXhwaXJlZENvbnNvbGVNZXNzYWdlQ291bnQgPSAwOwogfQogCiB2b2lkIEluc3BlY3RvckNv bnNvbGVBZ2VudDo6ZW5hYmxlKEVycm9yU3RyaW5nJikKQEAgLTEwMiw3ICsxMDMsNiBAQCB2b2lk IEluc3BlY3RvckNvbnNvbGVBZ2VudDo6Y2xlYXJNZXNzYWdlcyhFcnJvclN0cmluZyYpCiB7CiAg ICAgbV9jb25zb2xlTWVzc2FnZXMuY2xlYXIoKTsKICAgICBtX2V4cGlyZWRDb25zb2xlTWVzc2Fn ZUNvdW50ID0gMDsKLSAgICBtX3ByZXZpb3VzTWVzc2FnZSA9IG51bGxwdHI7CiAKICAgICBtX2lu amVjdGVkU2NyaXB0TWFuYWdlci5yZWxlYXNlT2JqZWN0R3JvdXAoQVNDSUlMaXRlcmFsKCJjb25z b2xlIikpOwogCkBAIC0yMjAsMjAgKzIyMCwyMiBAQCB2b2lkIEluc3BlY3RvckNvbnNvbGVBZ2Vu dDo6YWRkQ29uc29sZU1lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPENvbnNvbGVNZXNzYWdlPiBjbwog ICAgIEFTU0VSVChtX2luamVjdGVkU2NyaXB0TWFuYWdlci5pbnNwZWN0b3JFbnZpcm9ubWVudCgp LmRldmVsb3BlckV4dHJhc0VuYWJsZWQoKSk7CiAgICAgQVNTRVJUX0FSRyhjb25zb2xlTWVzc2Fn ZSwgY29uc29sZU1lc3NhZ2UpOwogCi0gICAgaWYgKG1fcHJldmlvdXNNZXNzYWdlICYmICFpc0dy b3VwTWVzc2FnZShtX3ByZXZpb3VzTWVzc2FnZS0+dHlwZSgpKSAmJiBtX3ByZXZpb3VzTWVzc2Fn ZS0+aXNFcXVhbChjb25zb2xlTWVzc2FnZS5nZXQoKSkpIHsKLSAgICAgICAgbV9wcmV2aW91c01l c3NhZ2UtPmluY3JlbWVudENvdW50KCk7CisgICAgQ29uc29sZU1lc3NhZ2UqIHByZXZpb3VzTWVz c2FnZSA9IG1fY29uc29sZU1lc3NhZ2VzLmlzRW1wdHkoKSA/IG51bGxwdHIgOiBtX2NvbnNvbGVN ZXNzYWdlcy5sYXN0KCkuZ2V0KCk7CisKKyAgICBpZiAocHJldmlvdXNNZXNzYWdlICYmICFpc0dy b3VwTWVzc2FnZShwcmV2aW91c01lc3NhZ2UtPnR5cGUoKSkgJiYgcHJldmlvdXNNZXNzYWdlLT5p c0VxdWFsKGNvbnNvbGVNZXNzYWdlLmdldCgpKSkgeworICAgICAgICBwcmV2aW91c01lc3NhZ2Ut PmluY3JlbWVudENvdW50KCk7CiAgICAgICAgIGlmIChtX2VuYWJsZWQpCi0gICAgICAgICAgICBt X3ByZXZpb3VzTWVzc2FnZS0+dXBkYXRlUmVwZWF0Q291bnRJbkNvbnNvbGUoKm1fZnJvbnRlbmRE aXNwYXRjaGVyKTsKKyAgICAgICAgICAgIHByZXZpb3VzTWVzc2FnZS0+dXBkYXRlUmVwZWF0Q291 bnRJbkNvbnNvbGUoKm1fZnJvbnRlbmREaXNwYXRjaGVyKTsKICAgICB9IGVsc2UgewotICAgICAg ICBtX3ByZXZpb3VzTWVzc2FnZSA9IGNvbnNvbGVNZXNzYWdlLmdldCgpOworICAgICAgICBDb25z b2xlTWVzc2FnZSogbmV3TWVzc2FnZSA9IGNvbnNvbGVNZXNzYWdlLmdldCgpOwogICAgICAgICBt X2NvbnNvbGVNZXNzYWdlcy5hcHBlbmQoV1RGTW92ZShjb25zb2xlTWVzc2FnZSkpOwogICAgICAg ICBpZiAobV9lbmFibGVkKQotICAgICAgICAgICAgbV9wcmV2aW91c01lc3NhZ2UtPmFkZFRvRnJv bnRlbmQoKm1fZnJvbnRlbmREaXNwYXRjaGVyLCBtX2luamVjdGVkU2NyaXB0TWFuYWdlciwgdHJ1 ZSk7Ci0gICAgfQorICAgICAgICAgICAgbmV3TWVzc2FnZS0+YWRkVG9Gcm9udGVuZCgqbV9mcm9u dGVuZERpc3BhdGNoZXIsIG1faW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLCB0cnVlKTsKIAotICAgIGlm IChtX2NvbnNvbGVNZXNzYWdlcy5zaXplKCkgPj0gbWF4aW11bUNvbnNvbGVNZXNzYWdlcykgewot ICAgICAgICBtX2V4cGlyZWRDb25zb2xlTWVzc2FnZUNvdW50ICs9IGV4cGlyZUNvbnNvbGVNZXNz YWdlc1N0ZXA7Ci0gICAgICAgIG1fY29uc29sZU1lc3NhZ2VzLnJlbW92ZSgwLCBleHBpcmVDb25z b2xlTWVzc2FnZXNTdGVwKTsKKyAgICAgICAgaWYgKG1fY29uc29sZU1lc3NhZ2VzLnNpemUoKSA+ PSBtYXhpbXVtQ29uc29sZU1lc3NhZ2VzKSB7CisgICAgICAgICAgICBtX2V4cGlyZWRDb25zb2xl TWVzc2FnZUNvdW50ICs9IGV4cGlyZUNvbnNvbGVNZXNzYWdlc1N0ZXA7CisgICAgICAgICAgICBt X2NvbnNvbGVNZXNzYWdlcy5yZW1vdmUoMCwgZXhwaXJlQ29uc29sZU1lc3NhZ2VzU3RlcCk7Cisg ICAgICAgIH0KICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNvbnNvbGVBZ2VudC5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29sZUFnZW50LmgKaW5kZXggOWY4 YzE5Yjg1NTAuLjE4ODE5NjBkYWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDb25zb2xlQWdlbnQuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDb25zb2xlQWdlbnQuaApAQCAt ODMsNyArODMsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgUmVmUHRyPENvbnNvbGVCYWNrZW5kRGlzcGF0 Y2hlcj4gbV9iYWNrZW5kRGlzcGF0Y2hlcjsKICAgICBJbnNwZWN0b3JIZWFwQWdlbnQqIG1faGVh cEFnZW50OwogCi0gICAgQ29uc29sZU1lc3NhZ2UqIG1fcHJldmlvdXNNZXNzYWdlIHsgbnVsbHB0 ciB9OwogICAgIFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8Q29uc29sZU1lc3NhZ2U+PiBtX2NvbnNv bGVNZXNzYWdlczsKICAgICBpbnQgbV9leHBpcmVkQ29uc29sZU1lc3NhZ2VDb3VudCB7IDAgfTsK ICAgICBIYXNoTWFwPFN0cmluZywgdW5zaWduZWQ+IG1fY291bnRzOwo=