181566 2018-01-11 16:59:38 -0800 Touch events not received with initial-scale=1 viewport 2018-01-12 17:05:03 -0800 1 1 1 Unclassified WebKit UI Events Other iPhone / iPad iOS 11 RESOLVED FIXED InRadar P2 Normal --- 1 john.firebaugh simon.fraser simon.fraser thorton webkit-bug-importer oldest_to_newest 1388569 0 john.firebaugh 2018-01-11 16:59:38 -0800 Summary: In certain circumstances, touch events are not properly dispatched. Steps to Reproduce: Open the following document in Mobile Safari and tap on the blue area: <!DOCTYPE html> <html> <head> <meta name="viewport" content="initial-scale=1"> <style> main { display: flex; } .foo { flex-basis: 0; } .map { flex-grow: 2; overflow: hidden; position: relative; } .canvas { background-color: blue; } </style> </head> <body> <main> <div class="foo"> <h1>Test</h1> </div> <div class="map"> <div class="container"> <div class="canvas" style="position: absolute; width: 100px; height: 800px;"></div> </div> </div> </main> <script> document.querySelector('.container').addEventListener('touchstart', () => console.log('touch')); </script> </body> </html> Expected Results: "touch" is logged to the console. Actual Results: Nothing is logged. Most perturbations to this test case will cause it to have the expected results: * Removing the viewport meta tag * Reducing the height of the .canvas div to 100px * Removing any of the CSS rules 1388693 1 webkit-bug-importer 2018-01-11 21:15:58 -0800 <rdar://problem/36460221> 1388954 2 simon.fraser 2018-01-12 14:05:45 -0800 Our touch event region computation is wrong with <div class="container">. We should be adding a rect for the child <canvas> but are not. <div class="container"> is actually zero height (visible if you put an outline on it), which is why it isn't clickable. 1388955 3 331234 simon.fraser 2018-01-12 14:05:58 -0800 Created attachment 331234 Testcase 1389027 4 331256 simon.fraser 2018-01-12 16:52:23 -0800 Created attachment 331256 Patch 1389030 5 simon.fraser 2018-01-12 17:05:03 -0800 Fixed in internal code. Test added in https://trac.webkit.org/changeset/226932/webkit Thanks for the report! 331234 2018-01-12 14:05:58 -0800 2018-01-12 14:05:58 -0800 Testcase touch-event-dispatch-issue.html text/html 1167 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBj b250ZW50PSJpbml0aWFsLXNjYWxlPTEiPgogICAgPHN0eWxlPgogICAgICAgIG1haW4gewogICAg ICAgICAgICBkaXNwbGF5OiBmbGV4OwogICAgICAgIH0KICAgICAgICAuZm9vIHsKICAgICAgICAg ICAgZmxleC1iYXNpczogMDsKICAgICAgICB9CiAgICAgICAgLm1hcCB7CiAgICAgICAgICAgIGZs ZXgtZ3JvdzogMjsKICAgICAgICAgICAgb3ZlcmZsb3c6IGhpZGRlbjsKICAgICAgICAgICAgcG9z aXRpb246IHJlbGF0aXZlOwogICAgICAgICAgICBvdXRsaW5lOiAycHggc29saWQgZ3JlZW47CiAg ICAgICAgfQogICAgICAgIC5jb250YWluZXIgewogICAgICAgICAgICBoZWlnaHQ6IDEwcHg7CiAg ICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHNpbHZlcjsKICAgICAgICAgICAgb3V0bGluZTog MnB4IHNvbGlkIGJsYWNrOwogICAgICAgIH0KICAgICAgICAuY2FudmFzIHsKICAgICAgICAgICAg YmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKICAgICAgICB9CiAgICA8L3N0eWxlPgo8L2hlYWQ+Cjxi b2R5Pgo8bWFpbj4KICAgIDxkaXYgY2xhc3M9ImZvbyI+CiAgICAgICAgPGgxPlRlc3Q8L2gxPgog ICAgPC9kaXY+CiAgICA8ZGl2IGNsYXNzPSJtYXAiPgogICAgICAgIDxkaXYgY2xhc3M9ImNvbnRh aW5lciI+CiAgICAgICAgICAgIDxkaXYgY2xhc3M9ImNhbnZhcyIgc3R5bGU9InBvc2l0aW9uOiBh YnNvbHV0ZTsgd2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDgwMHB4OyI+PC9kaXY+CiAgICAgICAgPC9k aXY+CiAgICA8L2Rpdj4KPC9tYWluPgo8c2NyaXB0PgogICAgZG9jdW1lbnQucXVlcnlTZWxlY3Rv cignLmNvbnRhaW5lcicpLmFkZEV2ZW50TGlzdGVuZXIoJ3RvdWNoc3RhcnQnLCAoKSA9PiBjb25z b2xlLmxvZygndG91Y2gnKSk7CiAgICBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCcuY29udGFpbmVy JykuYWRkRXZlbnRMaXN0ZW5lcignbW91c2Vkb3duJywgKCkgPT4gY29uc29sZS5sb2coJ21vdXNl ZG93bicpKTsKICAgIGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJy5jb250YWluZXInKS5hZGRFdmVu dExpc3RlbmVyKCdtb3VzZXdoZWVsJywgKCkgPT4gY29uc29sZS5sb2coJ21vdXNld2hlZWwnKSk7 Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 331256 2018-01-12 16:52:23 -0800 2018-01-12 16:58:21 -0800 Patch bug-181566-20180112165223.patch text/plain 4470 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2OTAyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTkxODZiODk4MDc0NjYwMjYxNDE3 N2QwY2QzYzIxMTI1MTJiNWJiZC4uNGUyYmE1OTViNDQ0OTdlZTRiMDFjOTE3ODc4YTY0OTgxM2U5 MWNjNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAxLTEyICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFRvdWNoIGV2ZW50cyBub3QgcmVjZWl2 ZWQgd2l0aCBpbml0aWFsLXNjYWxlPTEgdmlld3BvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTU2NgorICAgICAgICByZGFyOi8vcHJvYmxlbS8z NjQ2MDIyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhIHRlc3RjYXNlIGZvciB0aGlzIHRvdWNoIGV2ZW50IGNhc2UuCisKKyAgICAgICAgKiBm YXN0L2V2ZW50cy90b3VjaC9pb3MvdGFyZ2V0LXRhbGxlci10aGFuLXZpZXctZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9pb3MvdGFyZ2V0LXRhbGxlci10 aGFuLXZpZXcuaHRtbDogQWRkZWQuCisKIDIwMTgtMDEtMTEgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgZmFzdC9ldmVudHMvaW9zL3JvdGF0aW9uL2xh eW91dC12aWV3cG9ydC1kdXJpbmctc2FmYXJpLXR5cGUtcm90YXRpb24uaHRtbCBpcyBmbGFrZXkK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy90YXJnZXQtdGFs bGVyLXRoYW4tdmlldy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3Vj aC9pb3MvdGFyZ2V0LXRhbGxlci10aGFuLXZpZXctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJi YTUwNjIzMmM3Y2NjNzQwZTk4ZjljY2FjYWJkYzcwNjRjODU4NzkKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvdGFyZ2V0LXRhbGxlci10aGFuLXZp ZXctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTYgQEAKK0NoZWNrcyB0aGF0IHRvdWNoZXMgd29y ayBvbiBlbGVtZW50cyB0aGF0IGFyZSB0YWxsZXIgdGhhbiB0aGUgdmlldy4KKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCisKK3RvdWNoc3RhcnQgZmlyZWQuCitQQVNTIGV2ZW50LnRvdWNo ZXMubGVuZ3RoIGlzIDEKK1BBU1MgZXZlbnQudG91Y2hlc1swXS5jbGllbnRYIGlzIDExMworUEFT UyBldmVudC50b3VjaGVzWzBdLmNsaWVudFkgaXMgMTc4Cit0b3VjaGVuZCBmaXJlZC4KK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorVGVzdAorCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy90YXJnZXQtdGFsbGVy LXRoYW4tdmlldy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL3Rhcmdl dC10YWxsZXItdGhhbi12aWV3Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjk1ODlkMTA0NWE1NjRkYTQ2ZGUz NDBhMDE1ZWZlZTc4YTM2OTFhMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL3RvdWNoL2lvcy90YXJnZXQtdGFsbGVyLXRoYW4tdmlldy5odG1sCkBAIC0wLDAgKzEs ODIgQEAKKzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIHVzZUZsZXhp YmxlVmlld3BvcnQ9dHJ1ZSBdIC0tPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8bWV0YSBuYW1lPSJ2 aWV3cG9ydCIgY29udGVudD0iaW5pdGlhbC1zY2FsZT0xIj4KKyAgICA8c3R5bGU+CisgICAgICAg IG1haW4geworICAgICAgICAgICAgZGlzcGxheTogZmxleDsKKyAgICAgICAgfQorICAgICAgICAu Zm9vIHsKKyAgICAgICAgICAgIGZsZXgtYmFzaXM6IDA7CisgICAgICAgIH0KKyAgICAgICAgLm1h cCB7CisgICAgICAgICAgICBmbGV4LWdyb3c6IDI7CisgICAgICAgICAgICBvdmVyZmxvdzogaGlk ZGVuOworICAgICAgICAgICAgcG9zaXRpb246IHJlbGF0aXZlOworICAgICAgICAgICAgb3V0bGlu ZTogMnB4IHNvbGlkIGdyZWVuOworICAgICAgICB9CisgICAgICAgICNjb250YWluZXIgeworICAg ICAgICAgICAgaGVpZ2h0OiAxMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogc2ls dmVyOworICAgICAgICAgICAgb3V0bGluZTogMnB4IHNvbGlkIGJsYWNrOworICAgICAgICB9Cisg ICAgICAgICN0YXJnZXQgeworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKKyAg ICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uLy4uLy4uL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdD4KKyAgICAgICAgZGVz Y3JpcHRpb24oIkNoZWNrcyB0aGF0IHRvdWNoZXMgd29yayBvbiBlbGVtZW50cyB0aGF0IGFyZSB0 YWxsZXIgdGhhbiB0aGUgdmlldy4iKTsKKyAgICAgICAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0 cnVlOworCisgICAgICAgIGZ1bmN0aW9uIGdldFVJU2NyaXB0KHgsIHkpCisgICAgICAgIHsKKyAg ICAgICAgICAgIHJldHVybiBgCisgICAgICAgICAgICAoZnVuY3Rpb24oKSB7CisgICAgICAgICAg ICAgICAgdWlDb250cm9sbGVyLnNpbmdsZVRhcEF0UG9pbnQoJHt4fSwgJHt5fSwgZnVuY3Rpb24o KSB7CisgICAgICAgICAgICAgICAgICAgIHVpQ29udHJvbGxlci51aVNjcmlwdENvbXBsZXRlKCk7 CisgICAgICAgICAgICAgICAgfSk7CisgICAgICAgICAgICB9KSgpO2AKKyAgICAgICAgfQorCisg ICAgICAgIGZ1bmN0aW9uIHJ1blRlc3QoKQorICAgICAgICB7CisgICAgICAgICAgICB2YXIgY29u dGFpbmVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnRhaW5lcicpOworICAgICAgICAg ICAgdGFyZ2V0LmFkZEV2ZW50TGlzdGVuZXIoJ3RvdWNoc3RhcnQnLCBmdW5jdGlvbigpIHsKKyAg ICAgICAgICAgICAgICBkZWJ1ZygidG91Y2hzdGFydCBmaXJlZC4iKTsKKyAgICAgICAgICAgICAg ICBzaG91bGRCZSgiZXZlbnQudG91Y2hlcy5sZW5ndGgiLCAiMSIpOworICAgICAgICAgICAgICAg IHNob3VsZEJlKCJldmVudC50b3VjaGVzWzBdLmNsaWVudFgiLCAiMTEzIik7CisgICAgICAgICAg ICAgICAgc2hvdWxkQmUoImV2ZW50LnRvdWNoZXNbMF0uY2xpZW50WSIsICIxNzgiKTsKKyAgICAg ICAgICAgIH0sIGZhbHNlKTsKKworICAgICAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIo InRvdWNoZW5kIiwgKGV2ZW50KSA9PiB7CisgICAgICAgICAgICAgICAgZGVidWcoInRvdWNoZW5k IGZpcmVkLiIpOworICAgICAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgICAgICAgICAg fSk7CisKKyAgICAgICAgICAgIHZhciB0YXJnZXRSZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3RhcmdldCcpLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOworICAgICAgICAgICAgCisgICAg ICAgICAgICB2YXIgdGFwUG9pbnRYID0gdGFyZ2V0UmVjdC54ICsgdGFyZ2V0UmVjdC53aWR0aCAv IDI7CisgICAgICAgICAgICB2YXIgdGFwUG9pbnRZID0gdGFyZ2V0UmVjdC55ICsgNTA7IC8vIFRh cCBuZWFyIHRoZSB0b3AuCisKKyAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAg ICAgICAgICAgICAgICB0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KGdldFVJU2NyaXB0KHRhcFBvaW50 WCwgdGFwUG9pbnRZKSwgZnVuY3Rpb24ocmVzdWx0KSB7IH0pOworICAgICAgICB9CisgICAgICAg IAorICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIHJ1blRlc3QsIGZhbHNl KTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPG1haW4+CisgICAgPGRpdiBjbGFz cz0iZm9vIj4KKyAgICAgICAgPGgxPlRlc3Q8L2gxPgorICAgIDwvZGl2PgorICAgIDxkaXYgY2xh c3M9Im1hcCI+CisgICAgICAgIDxkaXYgaWQ9ImNvbnRhaW5lciI+CisgICAgICAgICAgICA8ZGl2 IGlkPSJ0YXJnZXQiIHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiAxMDBweDsgaGVp Z2h0OiA4MDBweDsiPjwvZGl2PgorICAgICAgICA8L2Rpdj4KKyAgICA8L2Rpdj4KKzwvbWFpbj4K KzxzY3JpcHQgc3JjPSIuLi8uLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K