181562 2018-01-11 15:40:44 -0800 Each variant of a polymorphic inlined call should be exitOK at the top of the block 2018-01-12 02:15:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien joepeck keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1388504 0 saam 2018-01-11 15:40:44 -0800 Right now, the very first block in the switch will have exitOK at the top. Others won't. That's just a bug. They're all exitOK at the top. This will lead to crashes in FixupPhase because we won't have a node in a block that has ExitOK, so when we fixup various type checks, we assert out. 1388509 1 saam 2018-01-11 15:42:51 -0800 <rdar://problem/36445624> 1388561 2 331139 saam 2018-01-11 16:37:41 -0800 Created attachment 331139 patch 1388724 3 331139 ysuzuki 2018-01-12 00:07:37 -0800 Comment on attachment 331139 patch r=me 1388749 4 331139 commit-queue 2018-01-12 02:15:15 -0800 Comment on attachment 331139 patch Clearing flags on attachment: 331139 Committed r226881: <https://trac.webkit.org/changeset/226881> 1388750 5 commit-queue 2018-01-12 02:15:16 -0800 All reviewed patches have been landed. Closing bug. 331139 2018-01-11 16:37:41 -0800 2018-01-12 02:15:15 -0800 patch b-backup.diff text/plain 3125 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjY4MjEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE4LTAxLTExICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIEVhY2ggdmFyaWFudCBvZiBhIHBvbHltb3JwaGljIGlubGluZWQgY2Fs bCBzaG91bGQgYmUgZXhpdE9LIGF0IHRoZSB0b3Agb2YgdGhlIGJsb2NrCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE1NjIKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzM2NDQ1NjI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogc3RyZXNzL2VhY2gtYmxvY2stYXQtdG9wLW9mLXBvbHltb3JwaGljLWNh bGwtaW5saW5pbmctc2hvdWxkLWJlLWV4aXRPSy5qczogQWRkZWQuCisgICAgICAgIChmKToKKyAg ICAgICAgKGZvbyk6CisKIDIwMTgtMDEtMTEgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5j b20+CiAKICAgICAgICAgV2hlbiBpbnNlcnRpbmcgVW5yZWFjaGFibGUgaW4gYnl0ZSBjb2RlIHBh cnNlciB3ZSBuZWVkIHRvIGZsdXNoIGFsbCB0aGUgcmlnaHQgdGhpbmdzCkluZGV4OiBKU1Rlc3Rz L3N0cmVzcy9lYWNoLWJsb2NrLWF0LXRvcC1vZi1wb2x5bW9ycGhpYy1jYWxsLWlubGluaW5nLXNo b3VsZC1iZS1leGl0T0suanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvZWFjaC1ibG9j ay1hdC10b3Atb2YtcG9seW1vcnBoaWMtY2FsbC1pbmxpbmluZy1zaG91bGQtYmUtZXhpdE9LLmpz CShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2VhY2gtYmxvY2stYXQtdG9wLW9mLXBv bHltb3JwaGljLWNhbGwtaW5saW5pbmctc2hvdWxkLWJlLWV4aXRPSy5qcwkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDE5IEBACisidXNlIHN0cmljdCI7CisKK2Z1bmN0aW9uIGYoKSB7IH07Citu b0lubGluZShmKTsKKworZnVuY3Rpb24gZm9vKG8sIHgpIHsKKyAgICByZXR1cm4gby5nZXQoeCk7 Cit9Citub0lubGluZShmb28pOworCitsZXQgb2JqcyA9IFsKKyAgICBuZXcgTWFwLAorICAgIHsg Z2V0KCkgeyByZXR1cm4gZigpOyB9IH0sCitdOworCisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAw MDAwMDsgKytpKSB7CisgICAgZm9vKG9ianNbaSAlIG9ianMubGVuZ3RoXSwgaSk7Cit9CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNjgxMSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMCBAQAorMjAx OC0wMS0xMSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBFYWNo IHZhcmlhbnQgb2YgYSBwb2x5bW9ycGhpYyBpbmxpbmVkIGNhbGwgc2hvdWxkIGJlIGV4aXRPSyBh dCB0aGUgdG9wIG9mIHRoZSBibG9jaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgxNTYyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjQ0NTYyND4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCZWZvcmUg dGhpcyBwYXRjaCwgdGhlIHZlcnkgZmlyc3QgYmxvY2sgaW4gdGhlIHN3aXRjaCBmb3IgcG9seW1v cnBoaWMgY2FsbAorICAgICAgICBpbmxpbmluZyB3aWxsIGhhdmUgZXhpdE9LIGF0IHRoZSB0b3Au IFRoZSBvdGhlcnMgYXJlIG5vdCBndWFyYW50ZWVkIHRvLgorICAgICAgICBUaGF0IHdhcyBqdXN0 IGEgYnVnLiBUaGV5J3JlIGFsbCBleGl0T0sgYXQgdGhlIHRvcC4gVGhpcyB3aWxsIGxlYWQgdG8g Y3Jhc2hlcworICAgICAgICBpbiBGaXh1cFBoYXNlIGJlY2F1c2Ugd2Ugd29uJ3QgaGF2ZSBhIG5v ZGUgaW4gYSBibG9jayB0aGF0IGhhcyBFeGl0T0ssIHNvCisgICAgICAgIHdoZW4gd2UgZml4dXAg dmFyaW91cyB0eXBlIGNoZWNrcywgd2UgYXNzZXJ0IG91dC4KKworICAgICAgICAqIGRmZy9ERkdC eXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6Omhh bmRsZUlubGluaW5nKToKKwogMjAxOC0wMS0xMSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxl LmNvbT4KIAogICAgICAgICBXaGVuIGluc2VydGluZyBVbnJlYWNoYWJsZSBpbiBieXRlIGNvZGUg cGFyc2VyIHdlIG5lZWQgdG8gZmx1c2ggYWxsIHRoZSByaWdodCB0aGluZ3MKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCShyZXZpc2lv biAyMjY4MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2Vy LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk4NSw2ICsxOTg1LDkgQEAgQnl0ZUNvZGVQYXJzZXI6 OkNhbGxPcHRpbWl6YXRpb25SZXN1bHQgQgogICAgICAgICBCYXNpY0Jsb2NrKiBjYWxsZWVFbnRy eUJsb2NrID0gYWxsb2NhdGVVbnRhcmdldGFibGVCbG9jaygpOwogICAgICAgICBtX2N1cnJlbnRC bG9jayA9IGNhbGxlZUVudHJ5QmxvY2s7CiAgICAgICAgIHByZXBhcmVUb1BhcnNlQmxvY2soKTsK KworICAgICAgICAvLyBBdCB0aGUgdG9wIG9mIGVhY2ggc3dpdGNoIGNhc2UsIHdlIGNhbiBleGl0 LgorICAgICAgICBtX2V4aXRPSyA9IHRydWU7CiAgICAgICAgIAogICAgICAgICBOb2RlKiBteUNh bGxUYXJnZXROb2RlID0gZ2V0RGlyZWN0KGNhbGxlZVJlZyk7CiAgICAgICAgIAo=