181550 2018-01-11 12:32:31 -0800 Don't load inline data when requesting info for an attachment element backed by a file path 2018-01-11 17:16:46 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes cdumez commit-queue esprehn+autocc ews-watchlist gyuyoung.kim mitz thorton webkit-bug-importer oldest_to_newest 1388379 0 wenson_hsieh 2018-01-11 12:32:31 -0800 Work towards making the -[_WKAttachment requestInfo:] API cheaper to run. This doesn't cover optimizations for data-backed attachments. 1388494 1 331123 wenson_hsieh 2018-01-11 15:07:16 -0800 Created attachment 331123 Patch 1388519 2 331123 wenson_hsieh 2018-01-11 16:01:20 -0800 Comment on attachment 331123 Patch Thanks for the review! 1388572 3 331123 commit-queue 2018-01-11 17:13:33 -0800 Comment on attachment 331123 Patch Clearing flags on attachment: 331123 Committed r226824: <https://trac.webkit.org/changeset/226824> 1388573 4 commit-queue 2018-01-11 17:13:35 -0800 All reviewed patches have been landed. Closing bug. 1388574 5 webkit-bug-importer 2018-01-11 17:16:46 -0800 <rdar://problem/36454965> 331123 2018-01-11 15:07:16 -0800 2018-01-11 17:13:33 -0800 Patch bug-181550-20180111150716.patch text/plain 5621 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2ODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE3N2NlYmZkNTBmNjYx ZDQwZmI1NTM2MjAxYTM4ZDU1MmM5NGEzMC4uY2Y5YWU4MjEzOTYxNTM5ZGQwZWRkYmJiZTIwZjUx Y2M2NDQzZjM1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTAxLTExICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGxvYWQg aW5saW5lIGRhdGEgd2hlbiByZXF1ZXN0aW5nIGluZm8gZm9yIGFuIGF0dGFjaG1lbnQgZWxlbWVu dCBiYWNrZWQgYnkgYSBmaWxlIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MTU1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4gcmVxdWVzdGluZyBkYXRhIGZvciBhbiBhdHRhY2htZW50IGVs ZW1lbnQgdGhhdCBpcyBiYWNrZWQgYnkgYSBmaWxlIHBhdGgsIHdlIGN1cnJlbnRseSB0cmlnZ2Vy IGEgbG9hZCBpbiB0aGUKKyAgICAgICAgd2ViIHByb2Nlc3MgdG8gZmV0Y2ggY29udGVudHMgb2Yg dGhlIGF0dGFjaG1lbnQgZGF0YSBhcyBpbmxpbmUgZGF0YSBpbiB0aGUgQXR0YWNobWVudEluZm8u IFRoaXMgaXMgdW5uZWNlc3NhcnksCisgICAgICAgIHNpbmNlIHRoZSBmaWxlIHBhdGggb2YgdGhl IGF0dGFjaG1lbnQgZWxlbWVudCBtdXN0IGhhdmUgY29tZSBmcm9tIHRoZSBVSSBwcm9jZXNzIGFu eXdheXMsIHNvIGl0IGlzIHN1ZmZpY2llbnQgdG8KKyAgICAgICAgc2ltcGx5IHNlbmQgdGhlIGZp bGUgcGF0aCB0byB0aGUgVUkgcHJvY2VzcyBhbmQgaGF2ZSB0aGUgVUkgcHJvY2VzcyByZWFkIHRo ZSBjb250ZW50cyBvZiB0aGUgcGF0aCBhcyBhIG1lbW9yeS0KKyAgICAgICAgbWFwcGVkIE5TRGF0 YS4KKworICAgICAgICBUaGlzIHBhdGNoIGxldHMgSFRNTEF0dGFjaG1lbnRFbGVtZW50IHNraXAg b3ZlciByZXNvdXJjZSBsb2FkaW5nIGNvZGVwYXRocyB3aGVuIGNyZWF0aW5nIGFuIEF0dGFjaG1l bnRJbmZvIGZvcgorICAgICAgICB0aGUgY2xpZW50LCBhbmQgYWxzbyB0ZWFjaGVzIF9XS0F0dGFj aG1lbnQgdG8gcmVhZCBhIEF0dGFjaG1lbnRJbmZvJ3MgZmlsZXBhdGggYXMgbWVtb3J5LW1hcHBl ZCBkYXRhIGlmIGEgZmlsZQorICAgICAgICBwYXRoIGlzIHByZXNlbnQsIGFuZCBubyBpbmxpbmUg ZGF0YSB3YXMgc3BlY2lmaWVkLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgQVBJIHRl c3RzLgorCisgICAgICAgICogaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTEF0dGFjaG1lbnRFbGVtZW50OjpyZXF1ZXN0SW5mbyk6CisKIDIwMTgt MDEtMTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0 IGNhbGwgUmVuZGVyRWxlbWVudDo6c2V0U3R5bGUgd2hlbiBub3RoaW5nIGNoYW5nZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cK aW5kZXggZTQxNWM0YmQ5MjMzYTcwYTJiNzEwMGQxNGEwOGIxZWY5M2ZlYWMxZS4uODNlMTE2MzE2 ZjNmZDY3YjZhNjYyNTFhMGQzZTgxMDBiOTdjMjRjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorMjAxOC0wMS0xMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKwor ICAgICAgICBEb24ndCBsb2FkIGlubGluZSBkYXRhIHdoZW4gcmVxdWVzdGluZyBpbmZvIGZvciBh biBhdHRhY2htZW50IGVsZW1lbnQgYmFja2VkIGJ5IGEgZmlsZSBwYXRoCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE1NTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIFNlZSBXZWJDb3JlL0NoYW5nZUxvZyBm b3IgbW9yZSBpbmZvcm1hdGlvbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dL QXR0YWNobWVudC5tbToKKyAgICAgICAgKC1bX1dLQXR0YWNobWVudEluZm8gaW5pdFdpdGhJbmZv Ol0pOgorICAgICAgICAoLVtfV0tBdHRhY2htZW50SW5mbyBmaWxlTG9hZGluZ0Vycm9yXSk6Cisg ICAgICAgICgtW19XS0F0dGFjaG1lbnQgcmVxdWVzdEluZm86XSk6CisKIDIwMTgtMDEtMTEgIFdl bnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgU2VuZCBQcm9t aXNlZEJsb2JJbmZvIHRvIHRoZSBjbGllbnQgdGhyb3VnaCBEcmFnSXRlbSBpbnN0ZWFkIG9mIERy YWdDbGllbnQ6OnByZXBhcmVUb0RyYWdQcm9taXNlZEJsb2IKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEF0dGFjaG1lbnRFbGVtZW50LmNwcAppbmRleCA2NjE4NWY4OTNlYWYzMGIyMzM1NGU1 YTQyMThhMjE4MzcwMjlhYjkyLi4xODIzZjMzNTVkYjAxYmE0MzljMjBkNGIxZjAwMTIxZGM2ZmQ2 YTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBdHRhY2htZW50RWxlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQuY3Bw CkBAIC0zMDQsOCArMzA0LDE0IEBAIHZvaWQgSFRNTEF0dGFjaG1lbnRFbGVtZW50OjpyZXF1ZXN0 SW5mbyhGdW5jdGlvbjx2b2lkKGNvbnN0IEF0dGFjaG1lbnRJbmZvJik+JiYKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAotICAgIG1fYXR0YWNobWVudFJlYWRlcnMuYXBwZW5kKEF0dGFjaG1lbnRE YXRhUmVhZGVyOjpjcmVhdGUoKnRoaXMsIFtwcm90ZWN0ZWRGaWxlID0gbWFrZVJlZigqbV9maWxl KSwgY2FsbGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKV0gKFJlZlB0cjxTaGFyZWRCdWZmZXI+JiYg ZGF0YSkgewotICAgICAgICBjYWxsYmFjayh7IHByb3RlY3RlZEZpbGUtPnR5cGUoKSwgcHJvdGVj dGVkRmlsZS0+bmFtZSgpLCBwcm90ZWN0ZWRGaWxlLT5wYXRoKCksIFdURk1vdmUoZGF0YSkgfSk7 CisgICAgQXR0YWNobWVudEluZm8gaW5mb1dpdGhvdXREYXRhIHsgbV9maWxlLT50eXBlKCksIG1f ZmlsZS0+bmFtZSgpLCBtX2ZpbGUtPnBhdGgoKSwgbnVsbHB0ciB9OworICAgIGlmICghbV9maWxl LT5wYXRoKCkuaXNFbXB0eSgpKSB7CisgICAgICAgIGNhbGxiYWNrKGluZm9XaXRob3V0RGF0YSk7 CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBtX2F0dGFjaG1lbnRSZWFkZXJzLmFwcGVu ZChBdHRhY2htZW50RGF0YVJlYWRlcjo6Y3JlYXRlKCp0aGlzLCBbaW5mb1dpdGhvdXREYXRhID0g V1RGTW92ZShpbmZvV2l0aG91dERhdGEpLCBwcm90ZWN0ZWRGaWxlID0gbWFrZVJlZigqbV9maWxl KSwgY2FsbGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKV0gKFJlZlB0cjxTaGFyZWRCdWZmZXI+JiYg ZGF0YSkgeworICAgICAgICBjYWxsYmFjayh7IGluZm9XaXRob3V0RGF0YS5jb250ZW50VHlwZSwg aW5mb1dpdGhvdXREYXRhLm5hbWUsIGluZm9XaXRob3V0RGF0YS5maWxlUGF0aCwgV1RGTW92ZShk YXRhKSB9KTsKICAgICB9KSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9fV0tBdHRhY2htZW50Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL19XS0F0dGFjaG1lbnQubW0KaW5kZXggYmFlYjMxM2JhY2VlODljMTQzMzBjNzdi ZDgzMWFmYzMzMDE2ZTg3ZC4uMmRlNTAwY2U5MmM2ZjgwYzg0MTE2ZDJiNmQ4OWUyMGJkZjg3ZDFm NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0F0dGFj aG1lbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0F0dGFj aG1lbnQubW0KQEAgLTc0LDYgKzc0LDcgQEAgQGltcGxlbWVudGF0aW9uIF9XS0F0dGFjaG1lbnRJ bmZvIHsKICAgICBSZXRhaW5QdHI8TlNTdHJpbmc+IF9uYW1lOwogICAgIFJldGFpblB0cjxOU1N0 cmluZz4gX2ZpbGVQYXRoOwogICAgIFJldGFpblB0cjxOU1N0cmluZz4gX2NvbnRlbnRUeXBlOwor ICAgIFJldGFpblB0cjxOU0Vycm9yPiBfZmlsZUxvYWRpbmdFcnJvcjsKIH0KIAogLSAoaW5zdGFu Y2V0eXBlKWluaXRXaXRoSW5mbzooY29uc3QgV2ViQ29yZTo6QXR0YWNobWVudEluZm8mKWluZm8K QEAgLTg1LDYgKzg2LDEzIEBAIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aEluZm86KGNvbnN0IFdl YkNvcmU6OkF0dGFjaG1lbnRJbmZvJilpbmZvCiAgICAgX2NvbnRlbnRUeXBlID0gYWRvcHROUyhb KE5TU3RyaW5nICopaW5mby5jb250ZW50VHlwZSA/OiBAIiIgY29weV0pOwogICAgIF9uYW1lID0g YWRvcHROUyhbKE5TU3RyaW5nICopaW5mby5uYW1lID86IEAiIiBjb3B5XSk7CiAgICAgX2ZpbGVQ YXRoID0gYWRvcHROUyhbKE5TU3RyaW5nICopaW5mby5maWxlUGF0aCA/OiBAIiIgY29weV0pOwor ICAgIF9maWxlTG9hZGluZ0Vycm9yID0gbmlsOworCisgICAgaWYgKCFfZGF0YSAmJiBbX2ZpbGVQ YXRoIGxlbmd0aF0pIHsKKyAgICAgICAgTlNFcnJvciAqZXJyb3IgPSBuaWw7CisgICAgICAgIF9k YXRhID0gW05TRGF0YSBkYXRhV2l0aENvbnRlbnRzT2ZGaWxlOl9maWxlUGF0aC5nZXQoKSBvcHRp b25zOk5TRGF0YVJlYWRpbmdNYXBwZWRJZlNhZmUgZXJyb3I6JmVycm9yXTsKKyAgICAgICAgX2Zp bGVMb2FkaW5nRXJyb3IgPSBlcnJvcjsKKyAgICB9CiAKICAgICByZXR1cm4gc2VsZjsKIH0KQEAg LTEwOSw2ICsxMTcsMTEgQEAgLSAoTlNTdHJpbmcgKiljb250ZW50VHlwZQogICAgIHJldHVybiBf Y29udGVudFR5cGUuZ2V0KCk7CiB9CiAKKy0gKE5TRXJyb3IgKilmaWxlTG9hZGluZ0Vycm9yCit7 CisgICAgcmV0dXJuIF9maWxlTG9hZGluZ0Vycm9yLmdldCgpOworfQorCiBAZW5kCiAKIEBpbXBs ZW1lbnRhdGlvbiBfV0tBdHRhY2htZW50CkBAIC0xMzUsNiArMTQ4LDExIEBAIC0gKHZvaWQpcmVx dWVzdEluZm86KHZvaWQoXikoX1dLQXR0YWNobWVudEluZm8gKiwgTlNFcnJvciAqKSljb21wbGV0 aW9uSGFuZGxlcgogICAgICAgICB9CiAKICAgICAgICAgYXV0byBhdHRhY2htZW50SW5mbyA9IGFk b3B0TlMoW1tfV0tBdHRhY2htZW50SW5mbyBhbGxvY10gaW5pdFdpdGhJbmZvOmluZm9dKTsKKyAg ICAgICAgaWYgKE5TRXJyb3IgKmZpbGVMb2FkaW5nRXJyb3IgPSBbYXR0YWNobWVudEluZm8gZmls ZUxvYWRpbmdFcnJvcl0pIHsKKyAgICAgICAgICAgIGNhcHR1cmVkQmxvY2sobmlsLCBbTlNFcnJv ciBlcnJvcldpdGhEb21haW46V0tFcnJvckRvbWFpbiBjb2RlOldLRXJyb3JVbmtub3duIHVzZXJJ bmZvOkB7IE5TVW5kZXJseWluZ0Vycm9yS2V5IDogZmlsZUxvYWRpbmdFcnJvciB9XSk7CisgICAg ICAgICAgICByZXR1cm47CisgICAgICAgIH0KKwogICAgICAgICBjYXB0dXJlZEJsb2NrKGF0dGFj aG1lbnRJbmZvLmdldCgpLCBuaWwpOwogICAgIH0pOwogfQo=