181546 2018-01-11 11:21:12 -0800 WKWebView.ClearAppCache is a flaky API test failure on High Sierra. 2018-03-19 19:34:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 cdumez aestes ap beidson cdumez commit-queue rniwa ryanhaddad webkit-bug-importer oldest_to_newest 1388324 0 jlewis3 2018-01-11 11:21:12 -0800 WKWebView.ClearAppCache is a flaky API failure on High Sierra. build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/2565/steps/run-api-tests/logs/stdio https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/2565 Error in log: FAIL WKWebView.ClearAppCache /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:183 Value of: 1ul Actual: 1 Expected: websiteDataRecords.count Which is: 2 /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:185 Value of: [record.displayName UTF8String] Actual: "Local documents on your computer" Expected: "127.0.0.1" /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:187 Value of: [type UTF8String] Actual: "WKWebsiteDataTypeLocalStorage" Expected: [WKWebsiteDataTypeOfflineWebApplicationCache UTF8String] Which is: "WKWebsiteDataTypeOfflineWebApplicationCache" I was able to reproduce the failure locally by running this twice: run-api-tests --debug WKWebView --verbose The crash claimed it to be a simulated crash. 1388329 1 webkit-bug-importer 2018-01-11 11:22:21 -0800 <rdar://problem/36444327> 1388672 2 ap 2018-01-11 20:13:40 -0800 I believe that we've been seeing it very frequently on El Capitan as well. 1407468 3 cdumez 2018-03-19 14:59:19 -0700 (In reply to Alexey Proskuryakov from comment #2) > I believe that we've been seeing it very frequently on El Capitan as well. The type of data that remains is localStorage. It remains after the initial call to remove all data :/ 1407481 4 cdumez 2018-03-19 15:25:31 -0700 LocalStorageDatabaseTracker::deleteDatabasesModifiedSince() chooses not to delete file__0 because it is not able to compute the last modified time for path: /Users/chris/Library/WebKit/TestWebKitAPI/WebsiteData/LocalStorage/file__0.localstorage 1407482 5 cdumez 2018-03-19 15:26:15 -0700 (In reply to Chris Dumez from comment #4) > LocalStorageDatabaseTracker::deleteDatabasesModifiedSince() chooses not to > delete file__0 because it is not able to compute the last modified time for > path: > /Users/chris/Library/WebKit/TestWebKitAPI/WebsiteData/LocalStorage/file__0. > localstorage /Users/chris/Library/WebKit/TestWebKitAPI/WebsiteData/LocalStorage/file__0.localstorage does not exist on my machine but I have /Users/chris/Library/WebKit/TestWebKitAPI/WebsiteData/LocalStorage/file__0.localstorage-wal ! 1407488 6 cdumez 2018-03-19 15:35:02 -0700 I suspect it could be related to LocalStorageDatabaseTracker::deleteAllDatabases() using FileSystem::deleteFile() instead of SQLiteFileSystem::deleteDatabaseFile(). 1407490 7 cdumez 2018-03-19 15:39:46 -0700 (In reply to Chris Dumez from comment #6) > I suspect it could be related to > LocalStorageDatabaseTracker::deleteAllDatabases() using > FileSystem::deleteFile() instead of SQLiteFileSystem::deleteDatabaseFile(). Not it, LocalStorageDatabaseTracker::deleteAllDatabases() appears to be unused. 1407491 8 cdumez 2018-03-19 15:41:33 -0700 Looks like we correctly use SQLiteFileSystem::deleteDatabaseFile() in all places. So I suspect the issue could be that we are deleting database files while the database is still open. I guess Sqlite could end up later writing a -wal file as a result. 1407492 9 cdumez 2018-03-19 15:43:42 -0700 e.g. LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier() seems to delete the database file while it is open. 1407495 10 336082 cdumez 2018-03-19 15:55:28 -0700 Created attachment 336082 Patch 1407555 11 336082 commit-queue 2018-03-19 19:34:29 -0700 Comment on attachment 336082 Patch Clearing flags on attachment: 336082 Committed r229736: <https://trac.webkit.org/changeset/229736> 1407556 12 commit-queue 2018-03-19 19:34:31 -0700 All reviewed patches have been landed. Closing bug. 336082 2018-03-19 15:55:28 -0700 2018-03-19 19:34:29 -0700 Patch bug-181546-20180319155528.patch text/plain 2113 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE2ZjhjOTFhM2ZhNTEyOGM4 NTIyZmFlNzdlOTBmYmU4ZDJlNzc4ODQuLmNmN2U1ZmJhZDc0NDdjMWUzZjBkYzJiYmU5MWIxMmFk NjVkYTZjNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDMtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXS1dlYlZpZXcuQ2xlYXJBcHBDYWNo ZSBpcyBhIGZsYWt5IEFQSSB0ZXN0IGZhaWx1cmUgb24gSGlnaCBTaWVycmEuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE1NDYKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzM2NDQ0MzI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGluIExvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlcjo6ZGVsZXRlRGF0 YWJhc2VzTW9kaWZpZWRTaW5jZSgpLCBhZGQgb3JpZ2luCisgICAgICAgIHRvIG9yaWdpbklkZW50 aWZpZXJzVG9EZWxldGUgaWYgd2UgY2Fubm90IGRldGVybWluZSB0aGUgbGFzdCBtb2RpZmljYXRp b24KKyAgICAgICAgdGltZSBvZiB0aGUgZGF0YWJhc2UgZmlsZS4gVGhpcyBsaWtlbHkgbWVhbnMg dGhlIGRhdGFiYXNlIGZpbGUgZG9lcyBub3QKKyAgICAgICAgZXhpc3QuIEhvd2V2ZXIsIHdlIHN0 aWxsIG5lZWRzIHRvIG1ha2Ugc3VyZSB0aGUgb3JpZ2luIGdldHMgcmVtb3ZlZCBmcm9tCisgICAg ICAgIHRoZSBvcmlnaW5zIGRhdGFiYXNlIGFuZCB0aGVyZSBtYXkgYmUgKi53YWwgLyAqLnNobSB2 YXJpYW50cyBvZiB0aGUgZGF0YWJhc2UKKyAgICAgICAgdGhhdCBhcmUgc3RpbGwgb24gZGlzayBh bmQgbmVlZCB0byBiZSBkZWxldGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlN0b3JhZ2Uv TG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TG9jYWxT dG9yYWdlRGF0YWJhc2VUcmFja2VyOjpkZWxldGVEYXRhYmFzZXNNb2RpZmllZFNpbmNlKToKKwog MjAxOC0wMy0xMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1h a2UgcG9saWN5IGRlY2lzaW9ucyBhc3luY2hyb25vdXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VU cmFja2VyLmNwcAppbmRleCAzNjM4ZmRkODcxYzNmOTdiMzg3YWY4OThjZWI1MTg0NjkwNDI3NGYy Li44MjExMDJiN2JlMWY4Mjg4OWY0OGI0ZDBlYjNmYmNkZTk5NGFhZGRmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlVHJh Y2tlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViU3RvcmFnZS9Mb2NhbFN0 b3JhZ2VEYXRhYmFzZVRyYWNrZXIuY3BwCkBAIC0xNTIsMTAgKzE1Miw3IEBAIFZlY3RvcjxTZWN1 cml0eU9yaWdpbkRhdGE+IExvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlcjo6ZGVsZXRlRGF0YWJh c2VzTW9kaWZpZWRTCiAgICAgICAgIFN0cmluZyBmaWxlUGF0aCA9IHBhdGhGb3JEYXRhYmFzZVdp dGhPcmlnaW5JZGVudGlmaWVyKG9yaWdpbik7CiAKICAgICAgICAgYXV0byBtb2RpZmljYXRpb25U aW1lID0gRmlsZVN5c3RlbTo6Z2V0RmlsZU1vZGlmaWNhdGlvblRpbWUoZmlsZVBhdGgpOwotICAg ICAgICBpZiAoIW1vZGlmaWNhdGlvblRpbWUpCi0gICAgICAgICAgICBjb250aW51ZTsKLQotICAg ICAgICBpZiAobW9kaWZpY2F0aW9uVGltZS52YWx1ZSgpID49IHRpbWUpCisgICAgICAgIGlmICgh bW9kaWZpY2F0aW9uVGltZSB8fCBtb2RpZmljYXRpb25UaW1lLnZhbHVlKCkgPj0gdGltZSkKICAg ICAgICAgICAgIG9yaWdpbklkZW50aWZpZXJzVG9EZWxldGUuYXBwZW5kKG9yaWdpbik7CiAgICAg fQogCg==