181515 2018-01-10 19:51:33 -0800 Web Inspector: Incorrect check with WI.debuggableType 2018-01-10 23:05:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1388035 0 joepeck 2018-01-10 19:51:33 -0800 Incorrect check with WI.debuggableType. Should be WI.sharedApp.debuggableType. 1388036 1 webkit-bug-importer 2018-01-10 19:51:55 -0800 <rdar://problem/36425509> 1388039 2 331015 joepeck 2018-01-10 19:59:39 -0800 Created attachment 331015 [PATCH] Proposed Fix 1388050 3 331015 bburg 2018-01-10 20:17:15 -0800 Comment on attachment 331015 [PATCH] Proposed Fix rs=me 1388129 4 331015 commit-queue 2018-01-10 23:05:16 -0800 Comment on attachment 331015 [PATCH] Proposed Fix Clearing flags on attachment: 331015 Committed r226763: <https://trac.webkit.org/changeset/226763> 1388130 5 commit-queue 2018-01-10 23:05:18 -0800 All reviewed patches have been landed. Closing bug. 331015 2018-01-10 19:59:39 -0800 2018-01-10 23:05:16 -0800 [PATCH] Proposed Fix fix-check-1.patch text/plain 1720 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUxODFiNmNhOGUyLi42ZjBkNjNlZTExNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDEtMTAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBJbmNvcnJlY3QgY2hlY2sgd2l0aCBXSS5kZWJ1Z2dhYmxlVHlwZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxNTE1CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8zNjQyNTUwOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kuY29u dGVudExvYWRlZCk6CisgICAgICAgIFRoaXMgbW92ZWQgdG8gV0kuc2hhcmVkQXBwIGEgd2hpbGUg YWdvLgorCiAyMDE4LTAxLTA5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2hvdWxkIG5vdCB0cnkgdG8gYXV0b2NvbXBsZXRl IHN1YnNlY3Rpb25zIG9mIGEgc3RyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggMGI3NWNlYjk2MDguLjIwZmE0YTAxNDkzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4u anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpz CkBAIC0zNzMsNyArMzczLDcgQEAgV0kuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICB0 aGlzLl90b2dnbGVQcmV2aW91c0RvY2tDb25maWd1cmF0aW9uS2V5Ym9hcmRTaG9ydGN1dCA9IG5l dyBXSS5LZXlib2FyZFNob3J0Y3V0KFdJLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFu ZE9yQ29udHJvbCB8IFdJLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuU2hpZnQsICJEIiwgdGhp cy5fdG9nZ2xlUHJldmlvdXNEb2NrQ29uZmlndXJhdGlvbi5iaW5kKHRoaXMpKTsKIAogICAgIGxl dCByZWxvYWRUb29sVGlwOwotICAgIGlmIChXSS5kZWJ1Z2dhYmxlVHlwZSA9PT0gV0kuRGVidWdn YWJsZVR5cGUuSmF2YVNjcmlwdCkKKyAgICBpZiAoV0kuc2hhcmVkQXBwLmRlYnVnZ2FibGVUeXBl ID09PSBXSS5EZWJ1Z2dhYmxlVHlwZS5KYXZhU2NyaXB0KQogICAgICAgICByZWxvYWRUb29sVGlw ID0gV0kuVUlTdHJpbmcoIlJlc3RhcnQgKCVzKSIpLmZvcm1hdCh0aGlzLl9yZWxvYWRQYWdlS2V5 Ym9hcmRTaG9ydGN1dC5kaXNwbGF5TmFtZSk7CiAgICAgZWxzZQogICAgICAgICByZWxvYWRUb29s VGlwID0gV0kuVUlTdHJpbmcoIlJlbG9hZCBwYWdlICglcylcblJlbG9hZCBwYWdlIGlnbm9yaW5n IGNhY2hlICglcykiKS5mb3JtYXQodGhpcy5fcmVsb2FkUGFnZUtleWJvYXJkU2hvcnRjdXQuZGlz cGxheU5hbWUsIHRoaXMuX3JlbG9hZFBhZ2VGcm9tT3JpZ2luS2V5Ym9hcmRTaG9ydGN1dC5kaXNw bGF5TmFtZSk7Cg==