181512 2018-01-10 18:13:11 -0800 Ensure there are no unsafe uses of MacroAssemblerARM64::dataTempRegister 2018-01-11 11:13:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue ews-watchlist keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1387984 0 msaboff 2018-01-10 18:13:11 -0800 A recent bug <https://bugs.webkit.org/show_bug.cgi?id=181467> was found where there was an unsafe use of dataTempRegister in the ARM64 macro assembler. This is to check for any other potentially unsafe uses and fix them. 1387990 1 webkit-bug-importer 2018-01-10 18:16:59 -0800 <rdar://problem/36424103> 1387997 2 331006 msaboff 2018-01-10 18:25:39 -0800 Created attachment 331006 Patch 1388005 3 331006 saam 2018-01-10 18:32:55 -0800 Comment on attachment 331006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331006&action=review > Source/JavaScriptCore/ChangeLog:13 > + fix them if they might be used in elsewhere. In elsewhere => elsewhere 1388295 4 331070 msaboff 2018-01-11 10:37:44 -0800 Created attachment 331070 Patch for landing - took care of review feedback and fixed build failure 1388320 5 331070 commit-queue 2018-01-11 11:13:32 -0800 Comment on attachment 331070 Patch for landing - took care of review feedback and fixed build failure Clearing flags on attachment: 331070 Committed r226788: <https://trac.webkit.org/changeset/226788> 1388321 6 commit-queue 2018-01-11 11:13:34 -0800 All reviewed patches have been landed. Closing bug. 331006 2018-01-10 18:25:39 -0800 2018-01-11 10:37:44 -0800 Patch 181512.patch text/plain 2446 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2NzUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE4LTAxLTEwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEVuc3VyZSB0aGVyZSBhcmUgbm8gdW5zYWZlIHVzZXMgb2YgTWFjcm9Bc3NlbWJsZXJBUk02 NDo6ZGF0YVRlbXBSZWdpc3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgxNTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oOgorICAgICAgICAo SlNDOjpNYWNyb0Fzc2VtYmxlckFSTTY0OjphYm9ydFdpdGhSZWFzb24pOgorICAgICAgICAoSlND OjpNYWNyb0Fzc2VtYmxlckFSTTY0OjpwdXNoVG9TYXZlSW1tZWRpYXRlV2l0aG91dFRvdWNoaW5n UmVnaXN0ZXJzKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6cmVlbWl0SW5p dGlhbE1vdmVXaXRoUGF0Y2gpOgorICAgICAgICBBbGwgY3VycmVudCB1c2VzIG9mIGRhdGFUZW1w UmVnaXN0ZXIgaW4gdGhlc2UgZnVuY3Rpb25zIGFyZSBzYWZlLCBidXQgaXQgbWFrZXMgc2Vuc2Ug dG8KKyAgICAgICAgZml4IHRoZW0gaWYgdGhleSBtaWdodCBiZSB1c2VkIGluIGVsc2V3aGVyZS4K KwogMjAxOC0wMS0xMCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIyNjY2NyBhbmQgcjIyNjY3My4KSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJBUk02NC5oCShyZXZpc2lvbiAyMjY3MzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAkod29ya2luZyBjb3B5KQpAQCAtMTEwNSwx MyArMTEwNSwxMyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFib3J0V2l0aFJlYXNvbihBYm9ydFJl YXNvbiByZWFzb24pCiAgICAgewotICAgICAgICBtb3ZlKFRydXN0ZWRJbW0zMihyZWFzb24pLCBk YXRhVGVtcFJlZ2lzdGVyKTsKKyAgICAgICAgbW92ZShUcnVzdGVkSW1tMzIocmVhc29uKSwgZ2V0 Q2FjaGVkRGF0YVRlbXBSZWdpc3RlcklEQW5kSW52YWxpZGF0ZSgpKTsKICAgICAgICAgYnJlYWtw b2ludCgpOwogICAgIH0KIAogICAgIHZvaWQgYWJvcnRXaXRoUmVhc29uKEFib3J0UmVhc29uIHJl YXNvbiwgaW50cHRyX3QgbWlzYykKICAgICB7Ci0gICAgICAgIG1vdmUoVHJ1c3RlZEltbTY0KG1p c2MpLCBtZW1vcnlUZW1wUmVnaXN0ZXIpOworICAgICAgICBtb3ZlKFRydXN0ZWRJbW02NChtaXNj KSwgZ2V0Q2FjaGVkTWVtb3J5VGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRlKCkpOwogICAgICAg ICBhYm9ydFdpdGhSZWFzb24ocmVhc29uKTsKICAgICB9CiAKQEAgLTIyMDEsNyArMjIwMSw3IEBA IHB1YmxpYzoKICAgICAKICAgICB2b2lkIHB1c2hUb1NhdmVJbW1lZGlhdGVXaXRob3V0VG91Y2hp bmdSZWdpc3RlcnMoVHJ1c3RlZEltbTMyIGltbSkKICAgICB7Ci0gICAgICAgIFJlZ2lzdGVySUQg cmVnID0gZGF0YVRlbXBSZWdpc3RlcjsKKyAgICAgICAgUmVnaXN0ZXJJRCByZWcgPSBnZXRDYWNo ZWREYXRhVGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRlKCk7CiAgICAgICAgIHB1c2hQYWlyKHJl ZywgcmVnKTsKICAgICAgICAgbW92ZShpbW0sIHJlZyk7CiAgICAgICAgIHN0b3JlNjQocmVnLCBz dGFja1BvaW50ZXJSZWdpc3Rlcik7CkBAIC0zMzk4LDcgKzMzOTgsNyBAQCBwdWJsaWM6CiAKICAg ICBzdGF0aWMgdm9pZCByZWVtaXRJbml0aWFsTW92ZVdpdGhQYXRjaCh2b2lkKiBhZGRyZXNzLCB2 b2lkKiB2YWx1ZSkKICAgICB7Ci0gICAgICAgIEFSTTY0QXNzZW1ibGVyOjpzZXRQb2ludGVyKHN0 YXRpY19jYXN0PGludCo+KGFkZHJlc3MpLCB2YWx1ZSwgZGF0YVRlbXBSZWdpc3RlciwgdHJ1ZSk7 CisgICAgICAgIEFSTTY0QXNzZW1ibGVyOjpzZXRQb2ludGVyKHN0YXRpY19jYXN0PGludCo+KGFk ZHJlc3MpLCB2YWx1ZSwgZ2V0Q2FjaGVkRGF0YVRlbXBSZWdpc3RlcklEQW5kSW52YWxpZGF0ZSgp LCB0cnVlKTsKICAgICB9CiAKICAgICAvLyBNaXNjZWxsYW5lb3VzIG9wZXJhdGlvbnM6Cg== 331070 2018-01-11 10:37:44 -0800 2018-01-11 11:13:32 -0800 Patch for landing - took care of review feedback and fixed build failure 181512-2.patch text/plain 1992 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2Nzg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTAxLTEwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEVuc3VyZSB0aGVyZSBhcmUgbm8gdW5zYWZlIHVzZXMgb2YgTWFjcm9Bc3NlbWJsZXJBUk02 NDo6ZGF0YVRlbXBSZWdpc3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgxNTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FhbSBCYXJhdGkuCisK KyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oOgorICAgICAgICAoSlND OjpNYWNyb0Fzc2VtYmxlckFSTTY0OjphYm9ydFdpdGhSZWFzb24pOgorICAgICAgICAoSlNDOjpN YWNyb0Fzc2VtYmxlckFSTTY0OjpwdXNoVG9TYXZlSW1tZWRpYXRlV2l0aG91dFRvdWNoaW5nUmVn aXN0ZXJzKToKKyAgICAgICAgQWxsIGN1cnJlbnQgdXNlcyBvZiBkYXRhVGVtcFJlZ2lzdGVyIGlu IHRoZXNlIGZ1bmN0aW9ucyBhcmUgc2FmZSwgYnV0IGl0IG1ha2VzIHNlbnNlIHRvCisgICAgICAg IGZpeCB0aGVtIGluIGNhc2UgdGhleSBtaWdodCBiZSB1c2VkIGVsc2V3aGVyZS4KKwogMjAxOC0w MS0wNCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIENvZGVCbG9j a3Mgc2hvdWxkIGJlIGluIElzb1N1YnNwYWNlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgJKHJldmlzaW9uIDIy Njc4NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk02NC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTA1LDEzICsxMTA1LDEzIEBAIHB1YmxpYzoKIAog ICAgIHZvaWQgYWJvcnRXaXRoUmVhc29uKEFib3J0UmVhc29uIHJlYXNvbikKICAgICB7Ci0gICAg ICAgIG1vdmUoVHJ1c3RlZEltbTMyKHJlYXNvbiksIGRhdGFUZW1wUmVnaXN0ZXIpOworICAgICAg ICBtb3ZlKFRydXN0ZWRJbW0zMihyZWFzb24pLCBnZXRDYWNoZWREYXRhVGVtcFJlZ2lzdGVySURB bmRJbnZhbGlkYXRlKCkpOwogICAgICAgICBicmVha3BvaW50KCk7CiAgICAgfQogCiAgICAgdm9p ZCBhYm9ydFdpdGhSZWFzb24oQWJvcnRSZWFzb24gcmVhc29uLCBpbnRwdHJfdCBtaXNjKQogICAg IHsKLSAgICAgICAgbW92ZShUcnVzdGVkSW1tNjQobWlzYyksIG1lbW9yeVRlbXBSZWdpc3Rlcik7 CisgICAgICAgIG1vdmUoVHJ1c3RlZEltbTY0KG1pc2MpLCBnZXRDYWNoZWRNZW1vcnlUZW1wUmVn aXN0ZXJJREFuZEludmFsaWRhdGUoKSk7CiAgICAgICAgIGFib3J0V2l0aFJlYXNvbihyZWFzb24p OwogICAgIH0KIApAQCAtMjIwMSw3ICsyMjAxLDcgQEAgcHVibGljOgogICAgIAogICAgIHZvaWQg cHVzaFRvU2F2ZUltbWVkaWF0ZVdpdGhvdXRUb3VjaGluZ1JlZ2lzdGVycyhUcnVzdGVkSW1tMzIg aW1tKQogICAgIHsKLSAgICAgICAgUmVnaXN0ZXJJRCByZWcgPSBkYXRhVGVtcFJlZ2lzdGVyOwor ICAgICAgICBSZWdpc3RlcklEIHJlZyA9IGdldENhY2hlZERhdGFUZW1wUmVnaXN0ZXJJREFuZElu dmFsaWRhdGUoKTsKICAgICAgICAgcHVzaFBhaXIocmVnLCByZWcpOwogICAgICAgICBtb3ZlKGlt bSwgcmVnKTsKICAgICAgICAgc3RvcmU2NChyZWcsIHN0YWNrUG9pbnRlclJlZ2lzdGVyKTsK