181484 2018-01-10 08:53:00 -0800 REGRESSION (r226715): don't re-check number of simulators in child processes 2018-01-10 11:58:31 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180555 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1387687 0 jbedard 2018-01-10 08:53:00 -0800 Checking the number of simulators to be run against the maximum number of simulators a machine can support only makes sense before those simulators have been initialized. 1387688 1 webkit-bug-importer 2018-01-10 08:54:05 -0800 <rdar://problem/36407151> 1387691 2 330916 jbedard 2018-01-10 08:58:27 -0800 Created attachment 330916 Patch 1387739 3 330916 aakash_jain 2018-01-10 10:56:33 -0800 Comment on attachment 330916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330916&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:53 > + if not SimulatedDeviceManager.INITIALIZED_DEVICES and self.get_option('child_processes', self.default_child_processes()) > SimulatedDeviceManager.max_supported_simulators(self.host): Just for future reference, max_supported_simulators seems like a misleading name, it should be something like current_num_supported_simulators. We wouldn't had this issue if max_supported_simulators always return the same value (maximum number of simulators supported by the machine). 1387788 4 330916 commit-queue 2018-01-10 11:58:29 -0800 Comment on attachment 330916 Patch Clearing flags on attachment: 330916 Committed r226726: <https://trac.webkit.org/changeset/226726> 1387789 5 commit-queue 2018-01-10 11:58:31 -0800 All reviewed patches have been landed. Closing bug. 330916 2018-01-10 08:58:27 -0800 2018-01-10 11:58:29 -0800 Patch bug-181484-20180110085827.patch text/plain 1736 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNjcxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTAxLTEwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjI2NzE1KTogZG9uJ3QgcmUtY2hlY2sgbnVtYmVy IG9mIHNpbXVsYXRvcnMgaW4gY2hpbGQgcHJvY2Vzc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE0ODQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzM2NDA3MTUxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3IucHk6CisgICAgICAgIChJ T1NTaW11bGF0b3JQb3J0Ll9faW5pdF9fKTogU2tpcCB0aGUgbnVtYmVyIG9mIHNpbXVsYXRvcnMg Y2hlY2sgaWYgc2ltdWxhdG9ycworICAgICAgICBhcmUgYWxyZWFkeSBpbml0aWFsaXplZC4KKwog MjAxOC0wMS0xMCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAg ICAgd2Via2l0cHk6IFJlZmFjdG9yIHNpbXVsYXRvciBjb2RlIChQYXJ0IDIpCkluZGV4OiBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX3NpbXVsYXRvci5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX3NpbXVsYXRvci5weQkocmV2aXNpb24gMjI2 NzE1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3IucHkJKHdv cmtpbmcgY29weSkKQEAgLTUwLDcgKzUwLDcgQEAgY2xhc3MgSU9TU2ltdWxhdG9yUG9ydChJT1NQ b3J0KToKICAgICAgICAgc2VsZi5fZGV2aWNlX2NsYXNzID0gb3B0aW9uYWxfZGV2aWNlX2NsYXNz IGlmIG9wdGlvbmFsX2RldmljZV9jbGFzcyBlbHNlIHNlbGYuREVGQVVMVF9ERVZJQ0VfQ0xBU1MK ICAgICAgICAgX2xvZy5kZWJ1ZygnSU9TU2ltdWxhdG9yUG9ydCBfZGV2aWNlX2NsYXNzIGlzICVz Jywgc2VsZi5fZGV2aWNlX2NsYXNzKQogCi0gICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignY2hp bGRfcHJvY2Vzc2VzJywgc2VsZi5kZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcygpKSA+IFNpbXVsYXRl ZERldmljZU1hbmFnZXIubWF4X3N1cHBvcnRlZF9zaW11bGF0b3JzKHNlbGYuaG9zdCk6CisgICAg ICAgIGlmIG5vdCBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJQUxJWkVEX0RFVklDRVMgYW5k IHNlbGYuZ2V0X29wdGlvbignY2hpbGRfcHJvY2Vzc2VzJywgc2VsZi5kZWZhdWx0X2NoaWxkX3By b2Nlc3NlcygpKSA+IFNpbXVsYXRlZERldmljZU1hbmFnZXIubWF4X3N1cHBvcnRlZF9zaW11bGF0 b3JzKHNlbGYuaG9zdCk6CiAgICAgICAgICAgICBfbG9nLndhcm4oJ1RoZSBzcGVjaWZpZWQgbnVt YmVyIG9mIFNpbXVsYXRlZCBkZXZpY2VzIHRvIGJlIHVzZWQgaXMgZ3JlYXRlciB0aGFuIHRoZSBu dW1iZXIgc3VwcG9ydGVkIGJ5IHRoaXMgbWFjaGluZS4nKQogCiAgICAgZGVmIF9kZXZpY2VfZm9y X3dvcmtlcl9udW1iZXJfbWFwKHNlbGYpOgo=