181482 2018-01-10 08:48:25 -0800 REGRESSION: Layout Test http/tests/resourceLoadStatistics/grandfathering.html is a flaky timeout 2018-01-29 16:17:06 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181223 InRadar P2 Normal --- 1 ryanhaddad wilander commit-queue jlewis3 webkit-bug-importer wilander oldest_to_newest 1387684 0 ryanhaddad 2018-01-10 08:48:25 -0800 The following layout test is flaky on macOS WK2 http/tests/resourceLoadStatistics/grandfathering.html Probable cause: The first macOS WK2 timeout visible on the dashboard blames this range: https://trac.webkit.org/log/webkit/?action=stop_on_copy&mode=stop_on_copy&rev=226543&stop_rev=226541&limit=100&verbose=on A few commits before that, I skipped the test listed right above this one in TestExpectations: https://trac.webkit.org/changeset/226538/webkit Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fgrandfathering.html 1388428 1 jlewis3 2018-01-11 13:38:45 -0800 Previously the test expectations were [ Pass Failure Timeout ] and were changed with many others in https://trac.webkit.org/changeset/225640/webkit however according to the dashboard as Ryan said, the test seems to have recently become a flaky timeout again. 1388598 2 jlewis3 2018-01-11 17:58:50 -0800 I wonder if another resourceLoadStatistics test was timing out for a similar or an underlying issue in the bug related via see also. diff for this test: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/grandfathering-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/grandfathering-actual.txt @@ -1,2 +1,5 @@ -PASS Grandfathered cookie was not purged. +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 1666) +FAIL: Timed out waiting for notifyDone to be called +#EOF +#EOF 1388821 3 jlewis3 2018-01-12 09:41:55 -0800 Skipped in https://trac.webkit.org/changeset/226896/webkit 1388934 4 ryanhaddad 2018-01-12 13:14:51 -0800 (In reply to Matt Lewis from comment #3) > Skipped in https://trac.webkit.org/changeset/226896/webkit http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html started timing out after this, so something weird is going on: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fnon-prevalent-resource-with-user-interaction.html 1389609 5 webkit-bug-importer 2018-01-16 10:41:02 -0800 <rdar://problem/36549026> 1391115 6 wilander 2018-01-19 12:49:45 -0800 Hopefully resolved in https://trac.webkit.org/changeset/227223, https://bugs.webkit.org/show_bug.cgi?id=181822. 1391319 7 ryanhaddad 2018-01-19 18:04:22 -0800 Still happening. 1391854 8 jlewis3 2018-01-22 16:02:44 -0800 Skipped the test again in https://trac.webkit.org/changeset/227368/webkit Seeing if this is just now only the test or if it is still the same issue as before. 1392162 9 ryanhaddad 2018-01-23 11:50:25 -0800 (In reply to Matt Lewis from comment #8) > Skipped the test again in https://trac.webkit.org/changeset/227368/webkit > > Seeing if this is just now only the test or if it is still the same issue as > before. http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html is timing out frequently, so this requires more investigation. John, can you take a look? 1394266 10 332581 wilander 2018-01-29 14:30:07 -0800 Created attachment 332581 Patch for landing 1394267 11 wilander 2018-01-29 14:30:38 -0800 Here's to hoping. 100 iterations on my laptop without timeout. 1394322 12 wilander 2018-01-29 16:16:48 -0800 Committed r227761: <https://trac.webkit.org/changeset/227761> 332581 2018-01-29 14:30:07 -0800 2018-01-29 16:17:06 -0800 Patch for landing bug-181482-20180129143006.patch text/plain 2278 wilander SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyNzc1NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAxLTI5ICBKb2huIFdpbGFuZGVyICA8 d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFN3aXRjaCBncmFuZGZhdGhlcmluZyBsYXlv dXQgdGVzdCB0byB0cmlnZ2VyIG9uIGRhdGEgcmVjb3JkIHNjYW5uaW5nIGluc3RlYWQgb2YgZGF0 YSByZWNvcmQgbW9kaWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODE0ODIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM2NTQ5MDI2Pgor CisgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcuCisKKyAgICAgICAgKiBodHRwL3Rl c3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvZ3JhbmRmYXRoZXJpbmcuaHRtbDoKKyAgICAgICAg ICAgIFN3aXRjaGVkIGZyb20KKyAgICAgICAgICAgIHRlc3RSdW5uZXIuaW5zdGFsbFN0YXRpc3Rp Y3NEaWRNb2RpZnlEYXRhUmVjb3Jkc0NhbGxiYWNrKCkKKyAgICAgICAgICAgIHRvCisgICAgICAg ICAgICB0ZXN0UnVubmVyLmluc3RhbGxTdGF0aXN0aWNzRGlkU2NhbkRhdGFSZWNvcmRzQ2FsbGJh Y2soKS4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAg ICAgICAgICBNYXJrZWQgYXMgWyBQYXNzIF0gYWdhaW4uCisKIDIwMTgtMDEtMjkgIE1hdHQgTGV3 aXMgIDxqbGV3aXMzQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMjI3NzMxLgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0 aXN0aWNzL2dyYW5kZmF0aGVyaW5nLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL2dyYW5kZmF0aGVyaW5nLmh0bWwJKHJldmlz aW9uIDIyNzc1MikKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlz dGljcy9ncmFuZGZhdGhlcmluZy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw3IEBA CiAgICAgfQogCiAgICAgZnVuY3Rpb24gZmlyZURhdGFNb2RpZmljYXRpb25IYW5kbGVyQW5kQ29u dGludWUoKSB7Ci0gICAgICAgIHRlc3RSdW5uZXIuaW5zdGFsbFN0YXRpc3RpY3NEaWRNb2RpZnlE YXRhUmVjb3Jkc0NhbGxiYWNrKGZ1bmN0aW9uKCkgeworICAgICAgICB0ZXN0UnVubmVyLmluc3Rh bGxTdGF0aXN0aWNzRGlkU2NhbkRhdGFSZWNvcmRzQ2FsbGJhY2soZnVuY3Rpb24oKSB7CiAgICAg ICAgICAgICBydW5UZXN0KCk7CiAgICAgICAgIH0pOwogICAgICAgICB0ZXN0UnVubmVyLnN0YXRp c3RpY3NQcm9jZXNzU3RhdGlzdGljc0FuZERhdGFSZWNvcmRzKCk7CkluZGV4OiBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAyMjc3NTIp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtp bmcgY29weSkKQEAgLTg3NSw3ICs4NzUsNyBAQCB3ZWJraXQub3JnL2IvMTgxODM5IFsgRGVidWcg XSBpbnNwZWN0b3IvCiAKIHdlYmtpdC5vcmcvYi8xODE3NTMgWyBIaWdoU2llcnJhIFJlbGVhc2Ug XSBodHRwL3dwdC9zZXJ2aWNlLXdvcmtlcnMvdXBkYXRlLXNlcnZpY2Utd29ya2VyLmh0dHBzLmh0 bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTgxNDgyIGh0dHAvdGVzdHMvcmVz b3VyY2VMb2FkU3RhdGlzdGljcy9ncmFuZGZhdGhlcmluZy5odG1sIFsgU2tpcCBdCit3ZWJraXQu b3JnL2IvMTgxNDgyIGh0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9ncmFuZGZhdGhl cmluZy5odG1sIFsgUGFzcyBdCiAKIHdlYmtpdC5vcmcvYi8xODE4MzEgWyBIaWdoU2llcnJhIF0g ZmFzdC9mb3Jtcy9zZWFyY2hmaWVsZC1oZWlnaHRzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCg==