18148 2008-03-27 10:04:42 -0700 REGRESSION(r31246): Cairo backend build broken 2008-03-31 14:51:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Regression P2 Normal --- 1 bfulgham webkit-unassigned oldest_to_newest 75472 0 bfulgham 2008-03-27 10:04:42 -0700 Changes in r31246 to GraphicsContext were not carried over to the Cairo version, resulting in a broken build. * Changes to GraphicsContextCGWin.cpp were not made to GraphicsContextCairoWin.cpp (specifically the changes to the method signatures for getWindowsContext and releaseWindowsContext. Some analog to the new 'createPathForGlyph' may be necessary, but it is not immediately obvious to me how this should work with Cairo. 75486 1 20129 bfulgham 2008-03-27 11:04:51 -0700 Created attachment 20129 Correct build regression Patch to correct build regression due to change in GraphicsContext method signature changes. 75650 2 20129 mjs 2008-03-28 10:15:05 -0700 Comment on attachment 20129 Correct build regression r=me 75995 3 jchaffraix 2008-03-31 14:51:23 -0700 Closing bug as it has been committed in r31403. 20129 2008-03-27 11:04:51 -0700 2008-03-28 10:15:05 -0700 Correct build regression cairo-build-fix.patch text/plain 2531 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMTM3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDMtMjcgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29ycmVjdCBidWlsZCByZWdyZXNzaW9uIChodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODE0OCkKKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9S IENIQU5HRUQKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRl eHRDYWlyb1dpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmdldFdp bmRvd3NDb250ZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6cmVsZWFz ZVdpbmRvd3NDb250ZXh0KToKKwogMjAwOC0wMy0yNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3Ro eUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIHNvbWUgSW5zcGVjdG9yIGZpbGVzIHRvIGZh Y2lsaXRhdGUgdGhlIHVwLWNvbWluZyBVSSByZWZyZXNoIGNoYW5nZXMuCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRDYWlyb1dpbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250ZXh0Q2Fp cm9XaW4uY3BwCShyZXZpc2lvbiAzMTM3MSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d2luL0dyYXBoaWNzQ29udGV4dENhaXJvV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgsOCAr NTgsMTMgQEAgR3JhcGhpY3NDb250ZXh0OjpHcmFwaGljc0NvbnRleHQoSERDIGRjKQogICAgIH0K IH0KIAotSERDIEdyYXBoaWNzQ29udGV4dDo6Z2V0V2luZG93c0NvbnRleHQoY29uc3QgSW50UmVj dCYgZHN0UmVjdCwgYm9vbCBzdXBwb3J0QWxwaGFCbGVuZCkKK0hEQyBHcmFwaGljc0NvbnRleHQ6 OmdldFdpbmRvd3NDb250ZXh0KGNvbnN0IEludFJlY3QmIGRzdFJlY3QsIGJvb2wgc3VwcG9ydEFs cGhhQmxlbmQsIGJvb2wgbWF5Q3JlYXRlQml0bWFwKQogeworICAgIC8vIEZJWE1FOiAgV2UgYXJl bid0IHJlYWxseSBkb2luZyBhbnl0aGluZyB3aXRoIHRoZSAnbWF5Q3JlYXRlQml0bWFwJyBmbGFn LiAgVGhpcyBuZWVkcworICAgIC8vIHRvIGJlIGFkZHJlc3NlZC4KKyAgICBpZiAoZHN0UmVjdC5p c0VtcHR5KCkpCisgICAgICAgcmV0dXJuIDA7CisKICAgICAvLyBUaGlzIGlzIHByb2JhYmx5IHdy b25nLCBhbmQgZGVmaW5pdGVseSBvdXQgb2YgZGF0ZS4gIFB1bGxlZCBmcm9tIG9sZCBTVk4KICAg ICBjYWlyb19zdXJmYWNlX3QqIHN1cmZhY2UgPSBjYWlyb19nZXRfdGFyZ2V0KHBsYXRmb3JtQ29u dGV4dCgpKTsKICAgICBIREMgaGRjID0gY2Fpcm9fd2luMzJfc3VyZmFjZV9nZXRfZGMoc3VyZmFj ZSk7ICAgCkBAIC03NywxNSArODIsMjAgQEAgSERDIEdyYXBoaWNzQ29udGV4dDo6Z2V0V2luZG93 c0NvbnRleHQoYwogICAgIHhmb3JtLmVNMjIgPSBtYXQueXk7CiAgICAgeGZvcm0uZUR4ID0gbWF0 LngwOwogICAgIHhmb3JtLmVEeSA9IG1hdC55MDsKLSAgICBTZXRXb3JsZFRyYW5zZm9ybShoZGMs ICZ4Zm9ybSk7CisgICAgOjpTZXRXb3JsZFRyYW5zZm9ybShoZGMsICZ4Zm9ybSk7CiAKICAgICBy ZXR1cm4gaGRjOwogfQogCiBib29sIEdyYXBoaWNzQ29udGV4dDo6aW5UcmFuc3BhcmVuY3lMYXll cigpIGNvbnN0IHsgcmV0dXJuIG1fZGF0YS0+bV90cmFuc3BhcmVuY3lDb3VudDsgfQogCi12b2lk IEdyYXBoaWNzQ29udGV4dDo6cmVsZWFzZVdpbmRvd3NDb250ZXh0KEhEQyBoZGMsIGNvbnN0IElu dFJlY3QmIGRzdFJlY3QsIGJvb2wgc3VwcG9ydEFscGhhQmxlbmQpCit2b2lkIEdyYXBoaWNzQ29u dGV4dDo6cmVsZWFzZVdpbmRvd3NDb250ZXh0KEhEQyBoZGMsIGNvbnN0IEludFJlY3QmIGRzdFJl Y3QsIGJvb2wgc3VwcG9ydEFscGhhQmxlbmQsIGJvb2wgbWF5Q3JlYXRlQml0bWFwKQogeworICAg IC8vIEZJWE1FOiAgV2UgYXJlbid0IHJlYWxseSBkb2luZyBhbnl0aGluZyB3aXRoIHRoZSAnbWF5 Q3JlYXRlQml0bWFwJyBmbGFnLiAgVGhpcyBuZWVkcworICAgIC8vIHRvIGJlIGFkZHJlc3NlZC4K KyAgICBpZiAoZHN0UmVjdC5pc0VtcHR5KCkpCisgICAgICAgcmV0dXJuOworCiAgICAgY2Fpcm9f c3VyZmFjZV90KiBzdXJmYWNlID0gY2Fpcm9fZ2V0X3RhcmdldChwbGF0Zm9ybUNvbnRleHQoKSk7 CiAgICAgSERDIGhkYzIgPSBjYWlyb193aW4zMl9zdXJmYWNlX2dldF9kYyhzdXJmYWNlKTsKICAg ICBSZXN0b3JlREMoaGRjMiwgLTEpOwo=