181474 2018-01-10 04:26:58 -0800 WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly 2018-01-10 06:46:29 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez cturner ews-watchlist glenn webkit-bug-importer oldest_to_newest 1387606 0 cgarcia 2018-01-10 04:26:58 -0800 We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest name as the name. For example: find_element.py::test_xhtml_namespace[xpath-//*[name()='a']] -> *[name()='a']] 1387607 1 330892 cgarcia 2018-01-10 04:29:05 -0800 Created attachment 330892 Patch 1387612 2 330892 cturner 2018-01-10 04:35:02 -0800 Comment on attachment 330892 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330892&action=review > Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:82 > + def _subtest_name(self, subtest): Looks like this could be a free function, self isn't referenced in the body. 1387631 3 330892 clopez 2018-01-10 06:36:29 -0800 Comment on attachment 330892 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330892&action=review >> Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:82 >> + def _subtest_name(self, subtest): > > Looks like this could be a free function, self isn't referenced in the body. I think its ok to have it as part of the object if it is related to it. 1387637 4 cgarcia 2018-01-10 06:45:06 -0800 Committed r226711: <https://trac.webkit.org/changeset/226711> 1387640 5 webkit-bug-importer 2018-01-10 06:46:29 -0800 <rdar://problem/36405305> 330892 2018-01-10 04:29:05 -0800 2018-01-10 06:36:29 -0800 Patch wd-subtest-names.diff text/plain 2148 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMmM3 MGY5ZTZmOC4uMGVmODRjZWYxM2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wMS0xMCAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViRHJpdmVyOiBydW4t d2ViZHJpdmVyLXRlc3RzIGRvZXNuJ3QgaGFuZGxlIHRlc3QgbmFtZXMgd2l0aCBhICcvJyBjb3Jy ZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 MTQ3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IHVzZSBvcy5wYXRoLmJhc2VuYW1lKCkgdG8gZ2V0IHRoZSBzdWJ0ZXN0IG5hbWUuIElmIHRoZSB0 ZXN0IG5hbWUgY29udGFpbnMgYSBzbGFzaCB3ZSBnZXQgcGFydCBvZiB0aGUgc3VidGVzdAorICAg ICAgICBuYW1lIGFzIHRoZSBuYW1lLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS93ZWJk cml2ZXJfdGVzdHMvd2ViZHJpdmVyX3Rlc3RfcnVubmVyX3czYy5weToKKyAgICAgICAgKFdlYkRy aXZlclRlc3RSdW5uZXJXM0MuX3N1YnRlc3RfbmFtZSk6IEhlbHBlciBmdW5jdGlvbiB0byBnZXQg dGhlIHN1YnRlc3QgbmFtZS4KKyAgICAgICAgKFdlYkRyaXZlclRlc3RSdW5uZXJXM0MucnVuKTog VXNlIF9zdWJ0ZXN0X25hbWUoKSBpbnN0ZWFkIG9mIG9zLnBhdGguYmFzZW5hbWUoKS4KKwogMjAx OC0wMS0wOSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1hjb2Rl XSBVc2UgdGhlIEFwcGxlIEludGVybmFsIFNESyBpZiBhdmFpbGFibGUgd2hlbiBidWlsZGluZyBJ bWFnZURpZmYKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvd2ViZHJpdmVyX3Rl c3RzL3dlYmRyaXZlcl90ZXN0X3J1bm5lcl93M2MucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3dlYmRyaXZlcl90ZXN0cy93ZWJkcml2ZXJfdGVzdF9ydW5uZXJfdzNjLnB5CmluZGV4IGE0NmM4 NzdlYmVmLi41MjY4YzI5ODJkYyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93 ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX3Rlc3RfcnVubmVyX3czYy5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3dlYmRyaXZlcl90ZXN0cy93ZWJkcml2ZXJfdGVzdF9ydW5uZXJfdzNj LnB5CkBAIC03OSw2ICs3OSwxMCBAQCBjbGFzcyBXZWJEcml2ZXJUZXN0UnVubmVyVzNDKG9iamVj dCk6CiAgICAgICAgICAgICAgICAgdGVzdHMuYXBwZW5kKHBhdGgpCiAgICAgICAgIHJldHVybiB0 ZXN0cwogCisgICAgZGVmIF9zdWJ0ZXN0X25hbWUoc2VsZiwgc3VidGVzdCk6CisgICAgICAgIHBh dGgsIHRlc3QgPSBzdWJ0ZXN0LnNwbGl0KCc6OicsIDEpCisgICAgICAgIHJldHVybiBvcy5wYXRo LmJhc2VuYW1lKHBhdGgpICsgJzo6JyArIHRlc3QKKwogICAgIGRlZiBydW4oc2VsZiwgdGVzdHM9 W10pOgogICAgICAgICBzZWxmLl9zZXJ2ZXIuc3RhcnQoKQogCkBAIC05Miw3ICs5Niw3IEBAIGNs YXNzIFdlYkRyaXZlclRlc3RSdW5uZXJXM0Mob2JqZWN0KToKICAgICAgICAgICAgICAgICByZXN1 bHQgPSBXZWJEcml2ZXJUZXN0UmVzdWx0KHRlc3RfbmFtZSwgKmhhcm5lc3NfcmVzdWx0KQogICAg ICAgICAgICAgICAgIGlmIGhhcm5lc3NfcmVzdWx0WzBdID09ICdPSyc6CiAgICAgICAgICAgICAg ICAgICAgIGZvciBzdWJ0ZXN0LCBzdGF0dXMsIG1lc3NhZ2UsIGJhY2t0cmFjZSBpbiB0ZXN0X3Jl c3VsdHM6Ci0gICAgICAgICAgICAgICAgICAgICAgICByZXN1bHQuYWRkX3N1YnRlc3RfcmVzdWx0 cyhvcy5wYXRoLmJhc2VuYW1lKHN1YnRlc3QpLCBzdGF0dXMsIG1lc3NhZ2UsIGJhY2t0cmFjZSkK KyAgICAgICAgICAgICAgICAgICAgICAgIHJlc3VsdC5hZGRfc3VidGVzdF9yZXN1bHRzKHNlbGYu X3N1YnRlc3RfbmFtZShzdWJ0ZXN0KSwgc3RhdHVzLCBtZXNzYWdlLCBiYWNrdHJhY2UpCiAgICAg ICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICAgICAgIyBGSVhNRTogaGFuZGxlIG90 aGVyIHJlc3VsdHMuCiAgICAgICAgICAgICAgICAgICAgIHBhc3MK