181473 2018-01-10 03:32:06 -0800 WebDriver: deserializeTimeouts() shouldn't reject double timeout values 2018-01-10 08:17:17 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan bburg cgarcia webkit-bug-importer oldest_to_newest 1387595 0 zan 2018-01-10 03:32:06 -0800 WebDriver: deserializeTimeouts() shouldn't reject double timeout values 1387605 1 330891 zan 2018-01-10 04:25:48 -0800 Created attachment 330891 Patch 1387611 2 cgarcia 2018-01-10 04:34:42 -0800 8.5 Set Timeouts The steps to deserialize as a timeout with argument parameters are: 2.4. If value is not an integer, or it is less than 0 or greater than 264 – 1, return error with error code invalid argument. 1387620 3 330891 cgarcia 2018-01-10 05:21:56 -0800 Comment on attachment 330891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330891&action=review We should check that in case of being a double, it's an integer as the spec says. It's probably worht it adding a helper function isIntegerValue() since there are more integers mentioned in the spec > Source/WebDriver/WebDriverService.cpp:284 > - if (it->value->type() != JSON::Value::Type::Integer || !it->value->asInteger(timeoutMS) || timeoutMS < 0 || timeoutMS > INT_MAX) > + if (!it->value->asInteger(timeoutMS) || timeoutMS < 0 || timeoutMS > INT_MAX) I didn't know the spec also says: "An integer is a Number that is unchanged under the ToInteger operation." But this would allow any double which would break imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_values 1387646 4 330902 zan 2018-01-10 06:58:21 -0800 Created attachment 330902 Patch 1387647 5 330902 cgarcia 2018-01-10 07:02:49 -0800 Comment on attachment 330902 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330902&action=review Excellent, thanks! > Source/WebDriver/ChangeLog:7 > + Please, mention here the tests fixed. > Source/WebDriver/WebDriverService.cpp:280 > + // value, i.e. if the double value was not originally in integer form. Add also a link to the spec https://w3c.github.io/webdriver/webdriver-spec.html#dfn-integer 1387663 6 330907 zan 2018-01-10 08:12:16 -0800 Created attachment 330907 Patch for landing 1387666 7 330907 zan 2018-01-10 08:16:24 -0800 Comment on attachment 330907 Patch for landing Clearing flags on attachment: 330907 Committed r226716: <https://trac.webkit.org/changeset/226716> 1387667 8 zan 2018-01-10 08:16:28 -0800 All reviewed patches have been landed. Closing bug. 1387670 9 webkit-bug-importer 2018-01-10 08:17:17 -0800 <rdar://problem/36406613> 330891 2018-01-10 04:25:48 -0800 2018-01-10 06:58:18 -0800 Patch bug-181473-20180110132546.patch text/plain 1785 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IGU4MTRmYWQzZjc3 ODc1NmI1NDk2MTY0MmU3ODAyMjUwN2YxZWJiMTkuLmY1NmJmMjY0OTMxM2MwNjc2NzVhNDE5ODll YzQxYjc1ZGM1MTM1ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDEt MTAgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYkRy aXZlcjogZGVzZXJpYWxpemVUaW1lb3V0cygpIHNob3VsZG4ndCByZWplY3QgZG91YmxlIHRpbWVv dXQgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODE0NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYkRyaXZlclNlcnZpY2UuY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpkZXNlcmlhbGl6 ZVRpbWVvdXRzKTogVGltZW91dCBKU09OIHZhbHVlIGhhcyB0byBiZSBjb252ZXJ0ZWQKKyAgICAg ICAgdG8gYW4gaW50ZWdlciwgd2hpY2ggaXMgYWxsb3dlZCBpZiB0aGUgdmFsdWUgaXMgb2YgZWl0 aGVyIEludGVnZXIgb3IKKyAgICAgICAgRG91YmxlIHR5cGUuIFRoaXMgaXMgYWxyZWFkeSBjb3Zl cmVkIGJ5IEpTT046OlZhbHVlOjphc0ludGVnZXIoKSwgd2hpY2gKKyAgICAgICAgcmV0dXJucyBm YWxzZSBpbiBjYXNlIHRoZSB2YWx1ZSBpcyBvZiBhbnkgb3RoZXIgdHlwZSwgc28gd2Ugb25seSBu ZWVkIHRvCisgICAgICAgIGRyb3AgdGhlIEludGVnZXIgdHlwZSBjaGVjayBmb3IgdGhlc2UgdmFs dWVzLgorCiAyMDE3LTEyLTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IGFkZCBzdXBwb3J0IGZvciBhY2NlcHQvZGlzbWlz cyBhbmQgbm90aWZ5IHVuaGFuZGxlZCBwcm9tcHQgYmVoYXZpb3IKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRy aXZlclNlcnZpY2UuY3BwCmluZGV4IDYzMTE4Y2IxMmU3MjQzZmYyNzA1MGVjOTI1YWFjZjI0MzM5 ZDZhZGUuLjgxYzI4ZTgzNjNkZGRkOWM0OTYzMGNiZDUxZmRlN2ZmN2Q2ODRlYmEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAKKysrIGIvU291cmNlL1dl YkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcApAQCAtMjgxLDcgKzI4MSw3IEBAIHN0YXRpYyBz dGQ6Om9wdGlvbmFsPFRpbWVvdXRzPiBkZXNlcmlhbGl6ZVRpbWVvdXRzKEpTT046Ok9iamVjdCYg dGltZW91dHNPYmplY3QpCiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICBpbnQgdGlt ZW91dE1TOwotICAgICAgICBpZiAoaXQtPnZhbHVlLT50eXBlKCkgIT0gSlNPTjo6VmFsdWU6OlR5 cGU6OkludGVnZXIgfHwgIWl0LT52YWx1ZS0+YXNJbnRlZ2VyKHRpbWVvdXRNUykgfHwgdGltZW91 dE1TIDwgMCB8fCB0aW1lb3V0TVMgPiBJTlRfTUFYKQorICAgICAgICBpZiAoIWl0LT52YWx1ZS0+ YXNJbnRlZ2VyKHRpbWVvdXRNUykgfHwgdGltZW91dE1TIDwgMCB8fCB0aW1lb3V0TVMgPiBJTlRf TUFYKQogICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKIAogICAgICAgICBpZiAoaXQt PmtleSA9PSAic2NyaXB0IikK 330902 2018-01-10 06:58:21 -0800 2018-01-10 08:12:12 -0800 Patch bug-181473-20180110155820.patch text/plain 2763 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IGU4MTRmYWQzZjc3 ODc1NmI1NDk2MTY0MmU3ODAyMjUwN2YxZWJiMTkuLjNjOWYwOGNhYTY1YjExM2NkMWFiNzIyNWY2 MzE2YmYyODEwYzdhZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDEt MTAgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYkRy aXZlcjogZGVzZXJpYWxpemVUaW1lb3V0cygpIHNob3VsZG4ndCByZWplY3QgZG91YmxlIHRpbWVv dXQgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODE0NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYkRyaXZlclNlcnZpY2UuY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjppbnRlZ2VyVmFs dWUpOiBIZWxwZXIgZnVuY3Rpb24gdGhhdCByZXRyaWV2ZXMgYW4gaW50ZWdlciB2YWx1ZQorICAg ICAgICBmcm9tIGEgZ2l2ZW4gSlNPTjo6VmFsdWUgb2JqZWN0LCBpZiBwb3NzaWJsZS4KKyAgICAg ICAgKFdlYkRyaXZlcjo6ZGVzZXJpYWxpemVUaW1lb3V0cyk6IFRpbWVvdXQgSlNPTiB2YWx1ZSBo YXMgdG8gYmUgY29udmVydGVkIHRvCisgICAgICAgIGFuIGludGVnZXIsIHdoaWNoIGlzIGFsbG93 ZWQgaWYgdGhlIHZhbHVlIGlzIG9mIGVpdGhlciBJbnRlZ2VyIG9yIERvdWJsZSB0eXBlLgorICAg ICAgICBIZWxwZXIgaW50ZWdlclZhbHVlKCkgZnVuY3Rpb24gcmV0cmlldmVzIHRoZSBpbnRlZ2Vy IHZhbHVlLCBpbiBhZGRpdGlvbiB0bworICAgICAgICBlbnN1cmluZyB0aGF0IHBvc3NpYmxlIGRv dWJsZSB2YWx1ZSB0aGF0IHdlIGNvbnZlcnQgdG8gYW4gaW50ZWdlciBpcyBhbHJlYWR5CisgICAg ICAgIGluIGludGVnZXIgZm9ybSB0byBiZWdpbiB3aXRoLgorCiAyMDE3LTEyLTE1ICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6 IGFkZCBzdXBwb3J0IGZvciBhY2NlcHQvZGlzbWlzcyBhbmQgbm90aWZ5IHVuaGFuZGxlZCBwcm9t cHQgYmVoYXZpb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2Vydmlj ZS5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCmluZGV4IDYzMTE4 Y2IxMmU3MjQzZmYyNzA1MGVjOTI1YWFjZjI0MzM5ZDZhZGUuLjdkZjMyYWU5ZGU1NDc3MDU5ODAy MjY4M2QzMTZlNGI1NTk3YTdmZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJp dmVyU2VydmljZS5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNw cApAQCAtMjcwLDYgKzI3MCwyMSBAQCB2b2lkIFdlYkRyaXZlclNlcnZpY2U6OnNlbmRSZXNwb25z ZShGdW5jdGlvbjx2b2lkIChIVFRQUmVxdWVzdEhhbmRsZXI6OlJlc3BvbnNlJgogICAgIHJlcGx5 SGFuZGxlcih7IHJlc3VsdC5odHRwU3RhdHVzQ29kZSgpLCByZXNwb25zZU9iamVjdC0+dG9KU09O U3RyaW5nKCkudXRmOCgpLCBBU0NJSUxpdGVyYWwoImFwcGxpY2F0aW9uL2pzb247IGNoYXJzZXQ9 dXRmLTgiKSB9KTsKIH0KIAorc3RhdGljIGJvb2wgaW50ZWdlclZhbHVlKEpTT046OlZhbHVlJiB2 YWx1ZSwgaW50JiBvdXRwdXQpCit7CisgICAgLy8gQmFpbCBpZiBhbiBpbnRlZ2VyIHZhbHVlIGNh bm5vdCBiZSByZXRyaWV2ZWQuCisgICAgaWYgKCF2YWx1ZS5hc0ludGVnZXIob3V0cHV0KSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gSWYgdGhlIGNvbnRhaW5lZCB2YWx1ZSBpcyBh IGRvdWJsZSwgYmFpbCBpbiBjYXNlIGl0IGRvZXNuJ3QgbWF0Y2ggdGhlIGludGVnZXIKKyAgICAv LyB2YWx1ZSwgaS5lLiBpZiB0aGUgZG91YmxlIHZhbHVlIHdhcyBub3Qgb3JpZ2luYWxseSBpbiBp bnRlZ2VyIGZvcm0uCisgICAgZG91YmxlIGRvdWJsZVZhbHVlOworICAgIGlmICh2YWx1ZS5hc0Rv dWJsZShkb3VibGVWYWx1ZSkgJiYgZG91YmxlVmFsdWUgIT0gb3V0cHV0KQorICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogc3RhdGljIHN0ZDo6b3B0aW9uYWw8 VGltZW91dHM+IGRlc2VyaWFsaXplVGltZW91dHMoSlNPTjo6T2JqZWN0JiB0aW1lb3V0c09iamVj dCkKIHsKICAgICAvLyDCpzguNSBTZXQgVGltZW91dHMuCkBAIC0yODEsNyArMjk2LDcgQEAgc3Rh dGljIHN0ZDo6b3B0aW9uYWw8VGltZW91dHM+IGRlc2VyaWFsaXplVGltZW91dHMoSlNPTjo6T2Jq ZWN0JiB0aW1lb3V0c09iamVjdCkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIGlu dCB0aW1lb3V0TVM7Ci0gICAgICAgIGlmIChpdC0+dmFsdWUtPnR5cGUoKSAhPSBKU09OOjpWYWx1 ZTo6VHlwZTo6SW50ZWdlciB8fCAhaXQtPnZhbHVlLT5hc0ludGVnZXIodGltZW91dE1TKSB8fCB0 aW1lb3V0TVMgPCAwIHx8IHRpbWVvdXRNUyA+IElOVF9NQVgpCisgICAgICAgIGlmICghaW50ZWdl clZhbHVlKCppdC0+dmFsdWUsIHRpbWVvdXRNUykgfHwgdGltZW91dE1TIDwgMCB8fCB0aW1lb3V0 TVMgPiBJTlRfTUFYKQogICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKIAogICAgICAg ICBpZiAoaXQtPmtleSA9PSAic2NyaXB0IikK 330907 2018-01-10 08:12:16 -0800 2018-01-10 08:12:16 -0800 Patch for landing bug-181473-20180110171215.patch text/plain 4994 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IGU4MTRmYWQzZjc3 ODc1NmI1NDk2MTY0MmU3ODAyMjUwN2YxZWJiMTkuLjVjNDU5ZmZjZmQzOTJmZDY3YWMxOTNjMjNm OGM0OGNkZGU2YmI3NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzcgQEAKKzIwMTgtMDEt MTAgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYkRy aXZlcjogZGVzZXJpYWxpemVUaW1lb3V0cygpIHNob3VsZG4ndCByZWplY3QgZG91YmxlIHRpbWVv dXQgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODE0NzMKKworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENhbXBvcy4KKwor ICAgICAgICBXaXRoIHRoZXNlIGNoYW5nZXMsIHRoZSBmb2xsb3dpbmcgdGVzdHMgYXJlIGZpeGVk OgorICAgICAgICAgICAgaW1wb3J0ZWQvc2VsZW5pdW0vcHkvdGVzdC9zZWxlbml1bS93ZWJkcml2 ZXIvY29tbW9uL2V4ZWN1dGluZ19hc3luY19qYXZhc2NyaXB0X3Rlc3RzLnB5Ojp0ZXN0U2hvdWxk VGltZW91dElmU2NyaXB0RG9lc05vdEludm9rZUNhbGxiYWNrV2l0aExvbmdUaW1lb3V0CisgICAg ICAgICAgICBpbXBvcnRlZC9zZWxlbml1bS9weS90ZXN0L3NlbGVuaXVtL3dlYmRyaXZlci9jb21t b24vZXhlY3V0aW5nX2FzeW5jX2phdmFzY3JpcHRfdGVzdHMucHk6OnRlc3RTaG91bGREZXRlY3RQ YWdlTG9hZHNXaGlsZVdhaXRpbmdPbkFuQXN5bmNTY3JpcHRBbmRSZXR1cm5BbkVycm9yCisgICAg ICAgICAgICBpbXBvcnRlZC9zZWxlbml1bS9weS90ZXN0L3NlbGVuaXVtL3dlYmRyaXZlci9jb21t b24vZXhlY3V0aW5nX2FzeW5jX2phdmFzY3JpcHRfdGVzdHMucHk6OnRlc3RTaG91bGRCZUFibGVU b0V4ZWN1dGVBc3luY2hyb25vdXNTY3JpcHRzCisgICAgICAgICAgICBpbXBvcnRlZC9zZWxlbml1 bS9weS90ZXN0L3NlbGVuaXVtL3dlYmRyaXZlci9jb21tb24vaW1wbGljaXRfd2FpdHNfdGVzdHMu cHk6OnRlc3RTaG91bGRJbXBsaWNpdGx5V2FpdEZvckFTaW5nbGVFbGVtZW50CisgICAgICAgICAg ICBpbXBvcnRlZC9zZWxlbml1bS9weS90ZXN0L3NlbGVuaXVtL3dlYmRyaXZlci9jb21tb24vaW1w bGljaXRfd2FpdHNfdGVzdHMucHk6OnRlc3RTaG91bGRTdGlsbEZhaWxUb0ZpbmRBbkVsZW1lbnRX aGVuSW1wbGljaXRXYWl0c0FyZUVuYWJsZWQKKyAgICAgICAgICAgIGltcG9ydGVkL3NlbGVuaXVt L3B5L3Rlc3Qvc2VsZW5pdW0vd2ViZHJpdmVyL2NvbW1vbi9pbXBsaWNpdF93YWl0c190ZXN0cy5w eTo6dGVzdFNob3VsZFJldHVybkFmdGVyRmlyc3RBdHRlbXB0VG9GaW5kT25lQWZ0ZXJEaXNhYmxp bmdJbXBsaWNpdFdhaXRzCisgICAgICAgICAgICBpbXBvcnRlZC9zZWxlbml1bS9weS90ZXN0L3Nl bGVuaXVtL3dlYmRyaXZlci9jb21tb24vaW1wbGljaXRfd2FpdHNfdGVzdHMucHk6OnRlc3RTaG91 bGRJbXBsaWNpdGx5V2FpdFVudGlsQXRMZWFzdE9uZUVsZW1lbnRJc0ZvdW5kV2hlblNlYXJjaGlu Z0Zvck1hbnkKKyAgICAgICAgICAgIGltcG9ydGVkL3NlbGVuaXVtL3B5L3Rlc3Qvc2VsZW5pdW0v d2ViZHJpdmVyL2NvbW1vbi9pbXBsaWNpdF93YWl0c190ZXN0cy5weTo6dGVzdFNob3VsZFN0aWxs RmFpbFRvRmluZEFuRWxlbWVuc3RXaGVuSW1wbGljaXRXYWl0c0FyZUVuYWJsZWQKKyAgICAgICAg ICAgIGltcG9ydGVkL3NlbGVuaXVtL3B5L3Rlc3Qvc2VsZW5pdW0vd2ViZHJpdmVyL2NvbW1vbi9p bXBsaWNpdF93YWl0c190ZXN0cy5weTo6dGVzdFNob3VsZFJldHVybkFmdGVyRmlyc3RBdHRlbXB0 VG9GaW5kTWFueUFmdGVyRGlzYWJsaW5nSW1wbGljaXRXYWl0cworICAgICAgICAgICAgaW1wb3J0 ZWQvc2VsZW5pdW0vcHkvdGVzdC9zZWxlbml1bS93ZWJkcml2ZXIvY29tbW9uL3BhZ2VfbG9hZF90 aW1lb3V0X3Rlc3RzLnB5Ojp0ZXN0U2hvdWxkVGltZW91dE9uUGFnZUxvYWRUYWtpbmdUb29Mb25n CisgICAgICAgICAgICBpbXBvcnRlZC9zZWxlbml1bS9weS90ZXN0L3NlbGVuaXVtL3dlYmRyaXZl ci9jb21tb24vcGFnZV9sb2FkX3RpbWVvdXRfdGVzdHMucHk6OnRlc3RTaG91bGRUaW1lb3V0T25Q YWdlTG9hZFRha2luZ1Rvb0xvbmcKKyAgICAgICAgICAgIGltcG9ydGVkL3NlbGVuaXVtL3B5L3Rl c3Qvc2VsZW5pdW0vd2ViZHJpdmVyL2NvbW1vbi93ZWJkcml2ZXJ3YWl0X3Rlc3RzLnB5Ojp0ZXN0 U2hvdWxkV2FpdE9ubHlBc0xvbmdBc1RpbWVvdXRTcGVjaWZpZWRXaGVuSW1wbGljaXRXYWl0c0Fy ZVNldAorCisgICAgICAgIFRoZSBmb2xsb3dpbmcgdHdvIHRlc3RzIHJlZ3Jlc3MsIGFuZCB3aWxs IGJlIGxvb2tlZCBpbnRvIHNlcGFyYXRlbHk6CisgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2Vi ZHJpdmVyL3Rlc3RzL3Nlc3Npb25zL25ld19zZXNzaW9uL21lcmdlLnB5Ojp0ZXN0X21lcmdlX2lu dmFsaWQKKyAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvc2Vzc2lvbnMv bmV3X3Nlc3Npb24vbWVyZ2UucHk6OnRlc3RfbWVyZ2VfaW52YWxpZAorCisgICAgICAgICogV2Vi RHJpdmVyU2VydmljZS5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6OmludGVnZXJWYWx1ZSk6IEhl bHBlciBmdW5jdGlvbiB0aGF0IHJldHJpZXZlcyBhbiBpbnRlZ2VyIHZhbHVlCisgICAgICAgIGZy b20gYSBnaXZlbiBKU09OOjpWYWx1ZSBvYmplY3QsIGlmIHBvc3NpYmxlLgorICAgICAgICAoV2Vi RHJpdmVyOjpkZXNlcmlhbGl6ZVRpbWVvdXRzKTogVGltZW91dCBKU09OIHZhbHVlIGhhcyB0byBi ZSBjb252ZXJ0ZWQgdG8KKyAgICAgICAgYW4gaW50ZWdlciwgd2hpY2ggaXMgYWxsb3dlZCBpZiB0 aGUgdmFsdWUgaXMgb2YgZWl0aGVyIEludGVnZXIgb3IgRG91YmxlIHR5cGUuCisgICAgICAgIEhl bHBlciBpbnRlZ2VyVmFsdWUoKSBmdW5jdGlvbiByZXRyaWV2ZXMgdGhlIGludGVnZXIgdmFsdWUs IGluIGFkZGl0aW9uIHRvCisgICAgICAgIGVuc3VyaW5nIHRoYXQgcG9zc2libGUgZG91YmxlIHZh bHVlIHRoYXQgd2UgY29udmVydCB0byBhbiBpbnRlZ2VyIGlzIGFscmVhZHkKKyAgICAgICAgaW4g aW50ZWdlciBmb3JtIHRvIGJlZ2luIHdpdGguCisKIDIwMTctMTItMTUgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFdlYkRyaXZlcjogYWRkIHN1 cHBvcnQgZm9yIGFjY2VwdC9kaXNtaXNzIGFuZCBub3RpZnkgdW5oYW5kbGVkIHByb21wdCBiZWhh dmlvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcCBi L1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAKaW5kZXggNjMxMThjYjEyZTcy NDNmZjI3MDUwZWM5MjVhYWNmMjQzMzlkNmFkZS4uZGM0MTFiZjQyYWQ1NDFlY2FmNDI1YzBjMzQx YjJlMjM1ODE1NjhhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2 aWNlLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCkBAIC0y NzAsNiArMjcwLDIyIEBAIHZvaWQgV2ViRHJpdmVyU2VydmljZTo6c2VuZFJlc3BvbnNlKEZ1bmN0 aW9uPHZvaWQgKEhUVFBSZXF1ZXN0SGFuZGxlcjo6UmVzcG9uc2UmCiAgICAgcmVwbHlIYW5kbGVy KHsgcmVzdWx0Lmh0dHBTdGF0dXNDb2RlKCksIHJlc3BvbnNlT2JqZWN0LT50b0pTT05TdHJpbmco KS51dGY4KCksIEFTQ0lJTGl0ZXJhbCgiYXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOCIp IH0pOwogfQogCitzdGF0aWMgYm9vbCBpbnRlZ2VyVmFsdWUoSlNPTjo6VmFsdWUmIHZhbHVlLCBp bnQmIG91dHB1dCkKK3sKKyAgICAvLyBCYWlsIGlmIGFuIGludGVnZXIgdmFsdWUgY2Fubm90IGJl IHJldHJpZXZlZC4KKyAgICBpZiAoIXZhbHVlLmFzSW50ZWdlcihvdXRwdXQpKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisKKyAgICAvLyBJZiB0aGUgY29udGFpbmVkIHZhbHVlIGlzIGEgZG91Ymxl LCBiYWlsIGluIGNhc2UgaXQgZG9lc24ndCBtYXRjaCB0aGUgaW50ZWdlcgorICAgIC8vIHZhbHVl LCBpLmUuIGlmIHRoZSBkb3VibGUgdmFsdWUgd2FzIG5vdCBvcmlnaW5hbGx5IGluIGludGVnZXIg Zm9ybS4KKyAgICAvLyBodHRwczovL3czYy5naXRodWIuaW8vd2ViZHJpdmVyL3dlYmRyaXZlci1z cGVjLmh0bWwjZGZuLWludGVnZXIKKyAgICBkb3VibGUgZG91YmxlVmFsdWU7CisgICAgaWYgKHZh bHVlLmFzRG91YmxlKGRvdWJsZVZhbHVlKSAmJiBkb3VibGVWYWx1ZSAhPSBvdXRwdXQpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiB0cnVlOworfQorCiBzdGF0aWMgc3RkOjpv cHRpb25hbDxUaW1lb3V0cz4gZGVzZXJpYWxpemVUaW1lb3V0cyhKU09OOjpPYmplY3QmIHRpbWVv dXRzT2JqZWN0KQogewogICAgIC8vIMKnOC41IFNldCBUaW1lb3V0cy4KQEAgLTI4MSw3ICsyOTcs NyBAQCBzdGF0aWMgc3RkOjpvcHRpb25hbDxUaW1lb3V0cz4gZGVzZXJpYWxpemVUaW1lb3V0cyhK U09OOjpPYmplY3QmIHRpbWVvdXRzT2JqZWN0KQogICAgICAgICAgICAgY29udGludWU7CiAKICAg ICAgICAgaW50IHRpbWVvdXRNUzsKLSAgICAgICAgaWYgKGl0LT52YWx1ZS0+dHlwZSgpICE9IEpT T046OlZhbHVlOjpUeXBlOjpJbnRlZ2VyIHx8ICFpdC0+dmFsdWUtPmFzSW50ZWdlcih0aW1lb3V0 TVMpIHx8IHRpbWVvdXRNUyA8IDAgfHwgdGltZW91dE1TID4gSU5UX01BWCkKKyAgICAgICAgaWYg KCFpbnRlZ2VyVmFsdWUoKml0LT52YWx1ZSwgdGltZW91dE1TKSB8fCB0aW1lb3V0TVMgPCAwIHx8 IHRpbWVvdXRNUyA+IElOVF9NQVgpCiAgICAgICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0Owog CiAgICAgICAgIGlmIChpdC0+a2V5ID09ICJzY3JpcHQiKQo=