181462 2018-01-09 16:40:14 -0800 REGRESSION(r201855): Web Inspector: Should see "length" autocompletion suggestion on a string literal 2018-01-10 11:33:06 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1387461 0 joepeck 2018-01-09 16:40:14 -0800 Should see "length" autocompletion suggestion on a string literal Steps to Reproduce: 1. Inspect about:blank 2. js> "foo".len| => Expected a "length" autocompletion suggestion, but there is none 1387462 1 webkit-bug-importer 2018-01-09 16:40:43 -0800 <rdar://problem/36390699> 1387468 2 330862 joepeck 2018-01-09 16:51:57 -0800 Created attachment 330862 [PATCH] Proposed Fix 1387494 3 330862 mattbaker 2018-01-09 18:08:15 -0800 Comment on attachment 330862 [PATCH] Proposed Fix r=me 1387527 4 330862 commit-queue 2018-01-09 19:17:32 -0800 Comment on attachment 330862 [PATCH] Proposed Fix Clearing flags on attachment: 330862 Committed r226674: <https://trac.webkit.org/changeset/226674> 1387528 5 commit-queue 2018-01-09 19:17:33 -0800 All reviewed patches have been landed. Closing bug. 1387744 6 330862 bburg 2018-01-10 11:04:20 -0800 Comment on attachment 330862 [PATCH] Proposed Fix Is there no way to test this code? 1387767 7 joepeck 2018-01-10 11:33:06 -0800 (In reply to Brian Burg from comment #6) > Comment on attachment 330862 [details] > [PATCH] Proposed Fix > > Is there no way to test this code? In the frontend this is several levels deep in UI related code: CodeMirror CodeMirrorCompletionController JavaScriptRuntimeCompletionProvider We could mock some things and directly test methods with mock values on JavaScriptRuntimeCompletionProvider. 330862 2018-01-09 16:51:57 -0800 2018-01-09 19:17:32 -0800 [PATCH] Proposed Fix autocomplete-string-1.patch text/plain 3247 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZjMjlkYjIyYWZkLi4zMjRkZTBhMjAyNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTgtMDEtMDkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBSRUdSRVNTSU9OKHIy MDE4NTUpOiBXZWIgSW5zcGVjdG9yOiBTaG91bGQgc2VlICJsZW5ndGgiIGF1dG9jb21wbGV0aW9u IHN1Z2dlc3Rpb24gb24gYSBzdHJpbmcgbGl0ZXJhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxNDYyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8z NjM5MDY5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGV0aW9u UHJvdmlkZXIuanM6CisgICAgICAgIChXSS5KYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92 aWRlci5wcm90b3R5cGUuY29tcGxldGlvbkNvbnRyb2xsZXJDb21wbGV0aW9uc05lZWRlZC5pbnNw ZWN0ZWRQYWdlX2V2YWxSZXN1bHRfZ2V0Q29tcGxldGlvbnMpOgorICAgICAgICBUaGlzIGlzIGNv ZGUgdGhhdCBydW5zIG9uIHRoZSBpbnNwZWN0ZWQgdGFyZ2V0LCB3aGljaCBtYXkgaGF2ZSBhbiBv bGQgdmVyc2lvbiBvZgorICAgICAgICBXZWJLaXQvSmF2YVNjcmlwdENvcmUsIHNvIGRvbid0IHVz ZSBuZXcgc3ludGF4IGxpa2UgdGhpcy4KKworICAgICAgICAoV0kuSmF2YVNjcmlwdFJ1bnRpbWVD b21wbGV0aW9uUHJvdmlkZXIucHJvdG90eXBlLmNvbXBsZXRpb25Db250cm9sbGVyQ29tcGxldGlv bnNOZWVkZWQpOgorICAgICAgICBXZSBpbnRlbmRlZCB0byByZXR1cm4gdGhlIHJlc3VsdCBieSBh cyBhIEpTT04gdmFsdWUgaW5zdGVhZCBvZiBhIFJlbW90ZU9iamVjdC4KKworMjAxOC0wMS0wOSAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFNob3VsZCBub3QgdHJ5IHRvIGF1dG9jb21wbGV0ZSBzdWJzZWN0aW9ucyBvZiBhIHN0 cmluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgx NDYxCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjM2OTQyMT4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50 aW1lQ29tcGxldGlvblByb3ZpZGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQ29udHJvbGxlcnMvSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGV0aW9uUHJvdmlkZXIuanMK aW5kZXggNjljYjNmN2E5NTcuLmFlYmQ0NTZjYTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2NyaXB0UnVudGltZUNvbXBs ZXRpb25Qcm92aWRlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Db250cm9sbGVycy9KYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWRlci5qcwpAQCAt MTczLDcgKzE3Myw3IEBAIFdJLkphdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3ZpZGVyID0g Y2xhc3MgSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGV0aW9uUHJvdmlkCiAgICAgICAgICAgICAgICAg ICAgICAgICB2YXIgbmFtZXMgPSBPYmplY3QuZ2V0T3duUHJvcGVydHlOYW1lcyhvKTsKICAgICAg ICAgICAgICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbmFtZXMubGVuZ3RoOyArK2kp CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0U2V0W25hbWVzW2ldXSA9IHRydWU7 Ci0gICAgICAgICAgICAgICAgICAgIH0gY2F0Y2ggeyB9CisgICAgICAgICAgICAgICAgICAgIH0g Y2F0Y2ggKGUpIHsgfQogICAgICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgICAgIHJldHVy biByZXN1bHRTZXQ7CkBAIC0xODQsNyArMTg0LDcgQEAgV0kuSmF2YVNjcmlwdFJ1bnRpbWVDb21w bGV0aW9uUHJvdmlkZXIgPSBjbGFzcyBKYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWQK ICAgICAgICAgICAgIGVsc2UgaWYgKHJlc3VsdC50eXBlID09PSAib2JqZWN0IiB8fCByZXN1bHQu dHlwZSA9PT0gImZ1bmN0aW9uIikKICAgICAgICAgICAgICAgICByZXN1bHQuY2FsbEZ1bmN0aW9u SlNPTihpbnNwZWN0ZWRQYWdlX2V2YWxSZXN1bHRfZ2V0Q29tcGxldGlvbnMsIHVuZGVmaW5lZCwg cmVjZWl2ZWRQcm9wZXJ0eU5hbWVzLmJpbmQodGhpcykpOwogICAgICAgICAgICAgZWxzZSBpZiAo cmVzdWx0LnR5cGUgPT09ICJzdHJpbmciIHx8IHJlc3VsdC50eXBlID09PSAibnVtYmVyIiB8fCBy ZXN1bHQudHlwZSA9PT0gImJvb2xlYW4iIHx8IHJlc3VsdC50eXBlID09PSAic3ltYm9sIikgewot ICAgICAgICAgICAgICAgIGxldCBvcHRpb25zID0ge29iamVjdEdyb3VwOiAiY29tcGxldGlvbiIs IGluY2x1ZGVDb21tYW5kTGluZUFQSTogZmFsc2UsIGRvTm90UGF1c2VPbkV4Y2VwdGlvbnNBbmRN dXRlQ29uc29sZTogdHJ1ZSwgcmV0dXJuQnlWYWx1ZTogZmFsc2UsIGdlbmVyYXRlUHJldmlldzog ZmFsc2UsIHNhdmVSZXN1bHQ6IGZhbHNlfTsKKyAgICAgICAgICAgICAgICBsZXQgb3B0aW9ucyA9 IHtvYmplY3RHcm91cDogImNvbXBsZXRpb24iLCBpbmNsdWRlQ29tbWFuZExpbmVBUEk6IGZhbHNl LCBkb05vdFBhdXNlT25FeGNlcHRpb25zQW5kTXV0ZUNvbnNvbGU6IHRydWUsIHJldHVybkJ5VmFs dWU6IHRydWUsIGdlbmVyYXRlUHJldmlldzogZmFsc2UsIHNhdmVSZXN1bHQ6IGZhbHNlfTsKICAg ICAgICAgICAgICAgICBXSS5ydW50aW1lTWFuYWdlci5ldmFsdWF0ZUluSW5zcGVjdGVkV2luZG93 KCIoIiArIGluc3BlY3RlZFBhZ2VfZXZhbFJlc3VsdF9nZXRDb21wbGV0aW9ucyArICIpKFwiIiAr IHJlc3VsdC50eXBlICsgIlwiKSIsIG9wdGlvbnMsIHJlY2VpdmVkUHJvcGVydHlOYW1lc0Zyb21F dmFsdWF0ZS5iaW5kKHRoaXMpKTsKICAgICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAg IGNvbnNvbGUuZXJyb3IoIlVua25vd24gcmVzdWx0IHR5cGU6ICIgKyByZXN1bHQudHlwZSk7Cg==