181452 2018-01-09 14:45:56 -0800 Use protectedThis for the 'updatePrevalentDomainsToPartitionOrBlockCookies' lambda 2018-01-10 16:06:57 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin bfulgham bfulgham cdumez krollin webkit-bug-importer wilander oldest_to_newest 1387406 0 krollin 2018-01-09 14:45:56 -0800 WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback has code that looks as follows (reformatted here to make the possible issue more apparent): m_resourceLoadStatistics = WebResourceLoadStatisticsStore::create(..., ..., [this] (...) { ... }, [this, protectedThis = makeRef(*this)] (...) { ... }, [this, protectedThis = makeRef(*this)] (...) { ... }, [this, protectedThis = makeRef(*this)] (...) { ... }); The possible issue is that the first lambda does not create a protectedThis. The bodies of all four lambdas just call member functions that all have similar forms. This would argue for their having the same calling/context requirements, so it seems like the first lambda should also create a protectedThis. Looking at the history of the function, it looks like the lack of a protectedThis may just be due to the way the function evolved. 1387860 1 bfulgham 2018-01-10 14:21:31 -0800 I think you are right! 1387861 2 webkit-bug-importer 2018-01-10 14:24:46 -0800 <rdar://problem/36416912> 1387866 3 330965 bfulgham 2018-01-10 14:36:27 -0800 Created attachment 330965 Patch 1387867 4 330965 cdumez 2018-01-10 14:39:08 -0800 Comment on attachment 330965 Patch r=me 1387923 5 bfulgham 2018-01-10 16:06:57 -0800 Committed r226742: <https://trac.webkit.org/changeset/226742> 330965 2018-01-10 14:36:27 -0800 2018-01-10 14:39:08 -0800 Patch bug-181452-20180110143627.patch text/plain 2440 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjY3MzQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTEwICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBwcm90ZWN0ZWRUaGlzIGZv ciB0aGUgJ3VwZGF0ZVByZXZhbGVudERvbWFpbnNUb1BhcnRpdGlvbk9yQmxvY2tDb29raWVzJyBs YW1iZGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 MTQ1MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY0MTY5MTI+CisgICAgICAgIAorICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBmb3Jnb3QgdG8gdXNl IGEgJ3Byb3RlY3RlZFRoaXMnIGJhY2sgaW4gcjIyNTAwNiBmb3Igb25lIG9mIHRoZSBsYW1iZGFz IHVzZWQgYnkKKyAgICAgICAgdGhlIFdlYnNpdGVEYXRhU3RvcmUgZm9yIHByb2Nlc3NpbmcuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmU6OmVuYWJsZVJlc291cmNlTG9hZFN0YXRp c3RpY3NBbmRTZXRUZXN0aW5nQ2FsbGJhY2spOgorCiAyMDE4LTAxLTA5ICBKb2huIFdpbGFuZGVy ICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3JhZ2UgQWNjZXNzIEFQSTogVHVy biBmZWF0dXJlIG9uIGJ5IGRlZmF1bHQgaW4gV2ViUHJlZmVyZW5jZXMueWFtbApJbmRleDogU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURh dGFTdG9yZS5jcHAJKHJldmlzaW9uIDIyNjYzOSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDAx LDcgKzE0MDEsNyBAQCB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OmVuYWJsZVJlc291cmNlTG9hCiAg ICAgfQogCiAjaWYgSEFWRShDRk5FVFdPUktfU1RPUkFHRV9QQVJUSVRJT05JTkcpCi0gICAgbV9y ZXNvdXJjZUxvYWRTdGF0aXN0aWNzID0gV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpj cmVhdGUobV9jb25maWd1cmF0aW9uLnJlc291cmNlTG9hZFN0YXRpc3RpY3NEaXJlY3RvcnksIFdU Rk1vdmUoY2FsbGJhY2spLCBbdGhpc10gKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBkb21haW5zVG9Q YXJ0aXRpb24sIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBkb21haW5zVG9CbG9jaywgY29uc3QgVmVj dG9yPFN0cmluZz4mIGRvbWFpbnNUb05laXRoZXJQYXJ0aXRpb25Ob3JCbG9jaywgU2hvdWxkQ2xl YXJGaXJzdCBzaG91bGRDbGVhckZpcnN0KSB7CisgICAgbV9yZXNvdXJjZUxvYWRTdGF0aXN0aWNz ID0gV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpjcmVhdGUobV9jb25maWd1cmF0aW9u LnJlc291cmNlTG9hZFN0YXRpc3RpY3NEaXJlY3RvcnksIFdURk1vdmUoY2FsbGJhY2spLCBbdGhp cywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpXSAoY29uc3QgVmVjdG9yPFN0cmluZz4m IGRvbWFpbnNUb1BhcnRpdGlvbiwgY29uc3QgVmVjdG9yPFN0cmluZz4mIGRvbWFpbnNUb0Jsb2Nr LCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgZG9tYWluc1RvTmVpdGhlclBhcnRpdGlvbk5vckJsb2Nr LCBTaG91bGRDbGVhckZpcnN0IHNob3VsZENsZWFyRmlyc3QpIHsKICAgICAgICAgdXBkYXRlUHJl dmFsZW50RG9tYWluc1RvUGFydGl0aW9uT3JCbG9ja0Nvb2tpZXMoZG9tYWluc1RvUGFydGl0aW9u LCBkb21haW5zVG9CbG9jaywgZG9tYWluc1RvTmVpdGhlclBhcnRpdGlvbk5vckJsb2NrLCBzaG91 bGRDbGVhckZpcnN0KTsKICAgICB9LCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRo aXMpXSAoY29uc3QgU3RyaW5nJiByZXNvdXJjZURvbWFpbiwgY29uc3QgU3RyaW5nJiBmaXJzdFBh cnR5RG9tYWluLCB1aW50NjRfdCBmcmFtZUlELCB1aW50NjRfdCBwYWdlSUQsIFdURjo6Q29tcGxl dGlvbkhhbmRsZXI8dm9pZChib29sIGhhc0FjY2Vzcyk+JiYgY2FsbGJhY2spIHsKICAgICAgICAg aGFzU3RvcmFnZUFjY2Vzc0ZvckZyYW1lSGFuZGxlcihyZXNvdXJjZURvbWFpbiwgZmlyc3RQYXJ0 eURvbWFpbiwgZnJhbWVJRCwgcGFnZUlELCBXVEZNb3ZlKGNhbGxiYWNrKSk7Cg==