181433 2018-01-09 05:19:26 -0800 [GTK] Missing symbols exported in 2.19.4 2018-01-09 07:53:49 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply ews-watchlist gustavo mcatanzaro oldest_to_newest 1387209 0 cgarcia 2018-01-09 05:19:26 -0800 Berto has just reported that some symbols are no longer exported in 2.19.4, see: - webkit_authentication_dialog_get_type@Base 2.5.3 +#MISSING: 2.19.4-1# webkit_authentication_dialog_get_type@Base 2.5.3 - webkit_dom_dom_window_webkit_message_handlers_post_message@Base 2.8.1 +#MISSING: 2.19.4-1# webkit_dom_dom_window_webkit_message_handlers_post_message@Base 2.8.1 - webkit_inspector_window_get_type@Base 2.17.3 +#MISSING: 2.19.4-1# webkit_inspector_window_get_type@Base 2.17.3 - webkit_web_view_base_accessible_get_type@Base 2.5.3 +#MISSING: 2.19.4-1# webkit_web_view_base_accessible_get_type@Base 2.5.3 These are symbols were we forgot to add WEBKIT_API macros, but were always exported before by the filter script (webkit_*) There are others affected by this, but because we never wanted to expose them: - webkit_media_src_get_type@Base 2.19.3-2~ +#MISSING: 2.19.4-1# webkit_media_src_get_type@Base 2.19.3-2~ - webkit_mse_debug@Base 2.19.3-2~ +#MISSING: 2.19.4-1# webkit_mse_debug@Base 2.19.3-2~ - (optional)webkit_soup_request_generic_get_type@Base 2.5.3 - (optional)webkit_soup_request_input_stream_get_type@Base 2.5.3 +#MISSING: 2.19.4-1# (optional)webkit_soup_request_generic_get_type@Base 2.5.3 +#MISSING: 2.19.4-1# (optional)webkit_soup_request_input_stream_get_type@Base 2.5.3 - webkit_web_src_get_type@Base 2.5.3 +#MISSING: 2.19.4-1# webkit_web_view_base_accessible_get_type@Base 2.5.3 So, we should make the filter script work again, add the missing WEBKIT_API and stop exposing private symbols even when using the filter script. 1387210 1 cgarcia 2018-01-09 05:21:20 -0800 Michael, could it be that when using hidden visibility the filter is script is not used? 1387217 2 cgarcia 2018-01-09 05:49:17 -0800 I've checked that using hidden visiblity takes precedence. This is actually a good thing, because it means that only webkit_ symbols will be exported thanks to the filter script, but also that webkit_ symbols not marked as public will not be exported either. So, we only need to add the missing WEBKIT_API macros. 1387219 3 cgarcia 2018-01-09 05:56:57 -0800 Just in case you are curious, this is my experiment: test.c int __attribute__((visibility("default"))) p_foo() { return 1; } int bar() { return 2; } int __attribute__((visibility("default"))) exported() { return 3; } int __attribute__((visibility("default"))) p_bar() { return 4; } int p_baz() { return 5; } filter { global: p_*; local: *; }; $ gcc test.c -Wl,--version-script=filter -fPIC -shared -o libtest.so 0000000000000555 l F .text 000000000000000b bar 0000000000000560 l F .text 000000000000000b exported 000000000000054a g F .text 000000000000000b p_foo 000000000000056b g F .text 000000000000000b p_bar 0000000000000576 g F .text 000000000000000b p_baz Only p_ symbols are exported, as set in the version script, no matter what mark they have in the code. $ gcc test.c -fvisibility=hidden -fPIC -shared -o libtest.so 0000000000000615 l F .text 000000000000000b bar 0000000000000636 l F .text 000000000000000b p_baz 000000000000060a g F .text 000000000000000b p_foo 0000000000000620 g F .text 000000000000000b exported 000000000000062b g F .text 000000000000000b p_bar Only symbols marked as public in the code are exported. $ gcc test.c -Wl,--version-script=filter -fvisibility=hidden -fPIC -shared -o libtest.so 0000000000000535 l F .text 000000000000000b bar 0000000000000540 l F .text 000000000000000b exported 0000000000000556 l F .text 000000000000000b p_baz 000000000000052a g F .text 000000000000000b p_foo 000000000000054b g F .text 000000000000000b p_bar Only symbols with p_ prefix and marked as public in the code are exported. Which is exactly what we want in WebKit :-) 1387226 4 cgarcia 2018-01-09 06:01:27 -0800 Only webkit_dom_dom_window_webkit_message_handlers_post_message() is meant to be public and is missing the WEBKIT_API, not exposing all others now is actually and improvement, not a bug. It shouldn't break any application, and it's not an ABI break because those have always been private even exported. 1387227 5 330816 cgarcia 2018-01-09 06:04:43 -0800 Created attachment 330816 Patch 1387228 6 cgarcia 2018-01-09 06:05:12 -0800 webkit_dom_dom_window_webkit_message_handlers_post_message(9 is used by ephy, so I'll have to make another release when this patch lands. 1387229 7 ews-watchlist 2018-01-09 06:07:37 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1387236 8 330816 mcatanzaro 2018-01-09 06:44:30 -0800 Comment on attachment 330816 Patch Yes, this is caused by -fvisibility=hidden. 1387239 9 mcatanzaro 2018-01-09 06:46:24 -0800 Carlos, in the linker version script, Source/WebKit/webkitglib-symbols.map, please remove line 13: webkit_media_player_debug; There's no point in having it anymore since it is not marked with WEBKIT_API. I didn't consider that when modifying the script. 1387256 10 cgarcia 2018-01-09 07:53:49 -0800 Committed r226633: <https://trac.webkit.org/changeset/226633> 330816 2018-01-09 06:04:43 -0800 2018-01-09 06:44:30 -0800 Patch wk-missing-symbols.diff text/plain 1466 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTVkOGI4YWRhNmEuLjIyYzRhNTNjNzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE4LTAxLTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBNaXNzaW5nIHN5bWJvbHMgZXhwb3J0ZWQgaW4gMi4xOS40 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE0MzMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlz c2luZyBXRUJLSVRfQVBJIHRvIHdlYmtpdF9kb21fZG9tX3dpbmRvd193ZWJraXRfbWVzc2FnZV9o YW5kbGVyc19wb3N0X21lc3NhZ2UoKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvQVBJL2d0ay9ET00vV2ViS2l0RE9NRE9NV2luZG93Lmg6CisKIDIwMTgtMDEtMDkgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQuIFVwZGF0ZSBPcHRpb25zR1RLLmNtYWtlIGFuZCBORVdTIGZvciAyLjE5LjQgcmVsZWFz ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvZ3RrL0RPTS9XZWJLaXRET01ET01XaW5kb3cuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL0RPTS9XZWJLaXRET01ET01XaW5kb3cuaAppbmRleCBm NWNhODUwNzc5Ni4uYjU0OGZjYjJmNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL0RPTS9XZWJLaXRET01ET01XaW5kb3cuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9ET00vV2Vi S2l0RE9NRE9NV2luZG93LmgKQEAgLTYwMiw3ICs2MDIsOCBAQCB3ZWJraXRfZG9tX2RvbV93aW5k b3dfZ2V0X29yaWVudGF0aW9uKFdlYktpdERPTURPTVdpbmRvdyogc2VsZik7CiAgKgogICogU2lu Y2U6IDIuOAogICovCi1nYm9vbGVhbiB3ZWJraXRfZG9tX2RvbV93aW5kb3dfd2Via2l0X21lc3Nh Z2VfaGFuZGxlcnNfcG9zdF9tZXNzYWdlKFdlYktpdERPTURPTVdpbmRvdyogd2luZG93LCBjb25z dCBnY2hhciogaGFuZGxlciwgY29uc3QgZ2NoYXIqIG1lc3NhZ2UpOworV0VCS0lUX0FQSSBnYm9v bGVhbgord2Via2l0X2RvbV9kb21fd2luZG93X3dlYmtpdF9tZXNzYWdlX2hhbmRsZXJzX3Bvc3Rf bWVzc2FnZShXZWJLaXRET01ET01XaW5kb3cqIHdpbmRvdywgY29uc3QgZ2NoYXIqIGhhbmRsZXIs IGNvbnN0IGdjaGFyKiBtZXNzYWdlKTsKIAogR19FTkRfREVDTFMKIAo=