<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>181420</bug_id>
          
          <creation_ts>2018-01-08 17:30:41 -0800</creation_ts>
          <short_desc>[Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings</short_desc>
          <delta_ts>2018-01-08 20:08:27 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>181390</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Wenson Hsieh">wenson_hsieh</reporter>
          <assigned_to name="Wenson Hsieh">wenson_hsieh</assigned_to>
          <cc>achristensen</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1387021</commentid>
    <comment_count>0</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2018-01-08 17:30:41 -0800</bug_when>
    <thetext>This is needed to allow internal JavaScript clients (e.g. Mail) in order to associate attachment elements in the DOM to _WKAttachments.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1387026</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-01-08 17:45:44 -0800</bug_when>
    <thetext>&lt;rdar://problem/36365827&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1387028</commentid>
    <comment_count>2</comment_count>
      <attachid>330769</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2018-01-08 17:50:12 -0800</bug_when>
    <thetext>Created attachment 330769
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1387057</commentid>
    <comment_count>3</comment_count>
      <attachid>330773</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2018-01-08 18:35:04 -0800</bug_when>
    <thetext>Created attachment 330773
Rebase on master</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1387087</commentid>
    <comment_count>4</comment_count>
      <attachid>330773</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2018-01-08 19:46:54 -0800</bug_when>
    <thetext>Comment on attachment 330773
Rebase on master

Thanks Alex!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1387095</commentid>
    <comment_count>5</comment_count>
      <attachid>330773</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-08 20:08:25 -0800</bug_when>
    <thetext>Comment on attachment 330773
Rebase on master

Clearing flags on attachment: 330773

Committed r226612: &lt;https://trac.webkit.org/changeset/226612&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1387096</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-08 20:08:27 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>330769</attachid>
            <date>2018-01-08 17:50:12 -0800</date>
            <delta_ts>2018-01-08 18:35:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-181420-20180108175011.patch</filename>
            <type>text/plain</type>
            <size>6846</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmEyNDJiYzE1ZTIyNmIx
ZGRkYTUzY2E3ZDc4NzAwM2FlYjdiZTE0ZS4uODQ3NjM1YjAwZGVhNTI0NmFjYWQyODY2ZmFhMmEw
OTg4ZWNjYTI4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAxLTA4ICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtBdHRhY2htZW50
IFN1cHBvcnRdIEV4cG9zZSBIVE1MQXR0YWNobWVudEVsZW1lbnQudW5pcXVlSWRlbnRpZmllciB0
byBiaW5kaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTgxNDIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjM2NTgyNz4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBuZXcgSURMIGRlZmlu
aXRpb24gZm9yIHVuaXF1ZUlkZW50aWZpZXIgb24gSFRNTEF0dGFjaG1lbnRFbGVtZW50LiBUaGlz
IGFsbG93cyBjbGllbnRzIHRvIHJlbGF0ZSBhdHRhY2htZW50CisgICAgICAgIGVsZW1lbnRzIGlu
IHRoZSBET00gdG8gX1dLQXR0YWNobWVudHMgZGVsaXZlcmVkIHZpYSBPYmplY3RpdmUtQyBTUEku
CisKKyAgICAgICAgQWRqdXN0ZWQgZXhpc3RpbmcgdGVzdHMgaW4gV0tBdHRhY2htZW50VGVzdHMu
CisKKyAgICAgICAgKiBodG1sL0hUTUxBdHRhY2htZW50RWxlbWVudC5pZGw6CisKIDIwMTgtMDEt
MDggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW0F0
dGFjaG1lbnQgU3VwcG9ydF0gRXhwb3NlIGZpbGUgbmFtZSBhbmQgY29udGVudCB0eXBlIG9mIFdL
QXR0YWNobWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQXR0YWNobWVu
dEVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQu
aWRsCmluZGV4IDQxNzhiNGJmYmU1NTA2N2VlZGI3ZWYwYzcxMmU4Zjc2NDZlZjQ3ZmQuLmQyZjcw
OWYxMjI0MTA0NmU1ODdiYjE5OTk2NzRiY2Q2Mjc1NGE1MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRFbGVtZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9odG1sL0hUTUxBdHRhY2htZW50RWxlbWVudC5pZGwKQEAgLTI4LDQgKzI4LDUgQEAKICAgICBF
bmFibGVkQXRSdW50aW1lPUF0dGFjaG1lbnRFbGVtZW50LAogXSBpbnRlcmZhY2UgSFRNTEF0dGFj
aG1lbnRFbGVtZW50IDogSFRNTEVsZW1lbnQgewogICAgIGF0dHJpYnV0ZSBGaWxlPyBmaWxlOwor
ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgdW5pcXVlSWRlbnRpZmllcjsKIH07CmRp
ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTVlOTE5
Mjk1MjZjOTM4ZTVmOTgzNWQ1Mjc1NzAzNmE5YTM3Yzk2Mi4uZmRlYWFiNmNjZjZlOGY2ZmM2MTkw
MjkxMDIzY2UyMmUzZDgxYThiOCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv
b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAxLTA4ICBXZW5zb24gSHNpZWgg
IDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtBdHRhY2htZW50IFN1cHBvcnRd
IEV4cG9zZSBIVE1MQXR0YWNobWVudEVsZW1lbnQudW5pcXVlSWRlbnRpZmllciB0byBiaW5kaW5n
cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxNDIw
CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjM2NTgyNz4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGp1c3RzIHNvbWUgZXhpc3RpbmcgQVBJIHRl
c3RzIHRvIHZlcmlmeSB0aGF0IGF0dGFjaG1lbnQgZWxlbWVudHMnIHVuaXF1ZUlkZW50aWZpZXJz
IG1hdGNoIHRoZSB1bmlxdWVJZGVudGlmaWVyCisgICAgICAgIG9mIGNvcnJlc3BvbmRpbmcgX1dL
QXR0YWNobWVudHMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h
L1dLQXR0YWNobWVudFRlc3RzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisK
IDIwMTgtMDEtMDggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg
ICAgICAgW0F0dGFjaG1lbnQgU3VwcG9ydF0gRXhwb3NlIGZpbGUgbmFtZSBhbmQgY29udGVudCB0
eXBlIG9mIFdLQXR0YWNobWVudApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0
cy9XZWJLaXRDb2NvYS9XS0F0dGFjaG1lbnRUZXN0cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv
VGVzdHMvV2ViS2l0Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0KaW5kZXggOGRkMzg2Njk4YTM0
Yjk0Nzk3ZTk0NmI4YTA3N2I0Zjk3ZDBlNGMyOC4uYmE0NTUzNmM1MmYwYTdlNmRjMmYyMDIzNTA2
M2QyNDlkZWZiOTZkNyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL
aXRDb2NvYS9XS0F0dGFjaG1lbnRUZXN0cy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl
c3RzL1dlYktpdENvY29hL1dLQXR0YWNobWVudFRlc3RzLm1tCkBAIC01NzAsNiArNTcwLDcgQEAg
VEVTVChXS0F0dGFjaG1lbnRUZXN0cywgQXR0YWNobWVudFVwZGF0ZXNXaGVuSW5zZXJ0aW5nUmlj
aE1hcmt1cCkKICAgICBFWFBFQ1RfRkFMU0UoW3dlYlZpZXcgaGFzQXR0cmlidXRlOkAid2Via2l0
YXR0YWNobWVudGJsb2J1cmwiIGZvclF1ZXJ5U2VsZWN0b3I6QCJhdHRhY2htZW50Il0pOwogICAg
IEVYUEVDVF9GQUxTRShbd2ViVmlldyBoYXNBdHRyaWJ1dGU6QCJ3ZWJraXRhdHRhY2htZW50cGF0
aCIgZm9yUXVlcnlTZWxlY3RvcjpAImF0dGFjaG1lbnQiXSk7CiAgICAgRVhQRUNUX0ZBTFNFKFt3
ZWJWaWV3IGhhc0F0dHJpYnV0ZTpAIndlYmtpdGF0dGFjaG1lbnRpZCIgZm9yUXVlcnlTZWxlY3Rv
cjpAImF0dGFjaG1lbnQiXSk7CisgICAgRVhQRUNUX1dLX1NUUkVRKFthdHRhY2htZW50IHVuaXF1
ZUlkZW50aWZpZXJdLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZG9j
dW1lbnQucXVlcnlTZWxlY3RvcignYXR0YWNobWVudCcpIl0pOwogICAgIHsKICAgICAgICAgT2Jz
ZXJ2ZUF0dGFjaG1lbnRVcGRhdGVzRm9yU2NvcGUgb2JzZXJ2ZXIod2ViVmlldy5nZXQoKSk7CiAg
ICAgICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5x
dWVyeVNlbGVjdG9yKCdhdHRhY2htZW50JykucmVtb3ZlKCkiXTsKQEAgLTU4OSw2ICs1OTAsNyBA
QCBURVNUKFdLQXR0YWNobWVudFRlc3RzLCBBdHRhY2htZW50VXBkYXRlc1doZW5DdXR0aW5nQW5k
UGFzdGluZykKICAgICAgICAgb2JzZXJ2ZXIuZXhwZWN0QXR0YWNobWVudFVwZGF0ZXMoQFtdLCBA
W2F0dGFjaG1lbnQuZ2V0KCldKTsKICAgICB9CiAgICAgW2F0dGFjaG1lbnQgZXhwZWN0UmVxdWVz
dGVkRGF0YVRvQmU6dGVzdEhUTUxEYXRhKCldOworICAgIEVYUEVDVF9XS19TVFJFUShbYXR0YWNo
bWVudCB1bmlxdWVJZGVudGlmaWVyXSwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNj
cmlwdDpAImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2F0dGFjaG1lbnQnKSJdKTsKICAgICBbd2Vi
VmlldyBfc3luY2hyb25vdXNseUV4ZWN1dGVFZGl0Q29tbWFuZDpAIlNlbGVjdEFsbCIgYXJndW1l
bnQ6bmlsXTsKICAgICB7CiAgICAgICAgIE9ic2VydmVBdHRhY2htZW50VXBkYXRlc0ZvclNjb3Bl
IG9ic2VydmVyKHdlYlZpZXcuZ2V0KCkpOwpAQCAtNjE3LDYgKzYxOSw3IEBAIFRFU1QoV0tBdHRh
Y2htZW50VGVzdHMsIEF0dGFjaG1lbnREYXRhRm9yRW1wdHlGaWxlKQogICAgICAgICBvYnNlcnZl
ci5leHBlY3RBdHRhY2htZW50VXBkYXRlcyhAW10sIEBbYXR0YWNobWVudC5nZXQoKV0pOwogICAg
IH0KICAgICBbYXR0YWNobWVudCBleHBlY3RSZXF1ZXN0ZWREYXRhVG9CZTpbTlNEYXRhIGRhdGFd
XTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEoW2F0dGFjaG1lbnQgdW5pcXVlSWRlbnRpZmllcl0sIFt3
ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5xdWVyeVNlbGVj
dG9yKCdhdHRhY2htZW50JykiXSk7CiAgICAgewogICAgICAgICBPYnNlcnZlQXR0YWNobWVudFVw
ZGF0ZXNGb3JTY29wZSBzY29wZSh3ZWJWaWV3LmdldCgpKTsKICAgICAgICAgW3dlYlZpZXcgX3N5
bmNocm9ub3VzbHlFeGVjdXRlRWRpdENvbW1hbmQ6QCJEZWxldGVCYWNrd2FyZCIgYXJndW1lbnQ6
bmlsXTsKQEAgLTY5Nyw2ICs3MDAsNyBAQCBURVNUKFdLQXR0YWNobWVudFRlc3RzLCBJblBsYWNl
SW1hZ2VBdHRhY2htZW50UGFyYWdyYXBoSW5zZXJ0aW9uKQogICAgIFt3ZWJWaWV3IGV4cGVjdFVw
ZGF0ZXNBZnRlckNvbW1hbmQ6QCJEZWxldGVCYWNrd2FyZCIgd2l0aEFyZ3VtZW50Om5pbCBleHBl
Y3RlZFJlbW92YWxzOkBbXSBleHBlY3RlZEluc2VydGlvbnM6QFtdXTsKIAogICAgIFthdHRhY2ht
ZW50IGV4cGVjdFJlcXVlc3RlZERhdGFUb0JlOmltYWdlRGF0YS5nZXQoKV07CisgICAgRVhQRUNU
X1dLX1NUUkVRKFthdHRhY2htZW50IHVuaXF1ZUlkZW50aWZpZXJdLCBbd2ViVmlldyBzdHJpbmdC
eUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZG9jdW1lbnQucXVlcnlTZWxlY3RvcignYXR0YWNobWVu
dCcpIl0pOwogICAgIFt3ZWJWaWV3IHdhaXRGb3JBdHRhY2htZW50RWxlbWVudFNpemVUb0JlY29t
ZTpDR1NpemVNYWtlKDIxNSwgMTc0KV07CiAKICAgICBbd2ViVmlldyBleHBlY3RVcGRhdGVzQWZ0
ZXJDb21tYW5kOkAiRGVsZXRlRm9yd2FyZCIgd2l0aEFyZ3VtZW50Om5pbCBleHBlY3RlZFJlbW92
YWxzOkBbYXR0YWNobWVudC5nZXQoKV0gZXhwZWN0ZWRJbnNlcnRpb25zOkBbXV07CkBAIC04NDMs
NiArODQ3LDcgQEAgVEVTVChXS0F0dGFjaG1lbnRUZXN0cywgSW5zZXJ0UGFzdGVkSW1hZ2VBc0F0
dGFjaG1lbnQpCiAgICAgYXV0byBzaXplID0gcGxhdGZvcm1JbWFnZVdpdGhEYXRhKFthdHRhY2ht
ZW50IHN5bmNocm9ub3VzbHlSZXF1ZXN0RGF0YTpuaWxdKS5zaXplOwogICAgIEVYUEVDVF9FUSgy
MTUuLCBzaXplLndpZHRoKTsKICAgICBFWFBFQ1RfRVEoMTc0Liwgc2l6ZS5oZWlnaHQpOworICAg
IEVYUEVDVF9XS19TVFJFUShbYXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVyXSwgW3dlYlZpZXcg
c3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2F0
dGFjaG1lbnQnKSJdKTsKIAogICAgIHsKICAgICAgICAgT2JzZXJ2ZUF0dGFjaG1lbnRVcGRhdGVz
Rm9yU2NvcGUgb2JzZXJ2ZXIod2ViVmlldy5nZXQoKSk7CkBAIC04NjksNiArODc0LDcgQEAgVEVT
VChXS0F0dGFjaG1lbnRUZXN0cywgSW5zZXJ0UGFzdGVkQXR0cmlidXRlZFN0cmluZ0NvbnRhaW5p
bmdJbWFnZSkKICAgICBbYXR0YWNobWVudCBleHBlY3RSZXF1ZXN0ZWREYXRhVG9CZTp0ZXN0SW1h
Z2VEYXRhKCldOwogICAgIEVYUEVDVF9XS19TVFJFUSgiTG9yZW0gaXBzdW0gIGRvbG9yIHNpdCBh
bWV0LiIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5i
b2R5LnRleHRDb250ZW50Il0pOwogICAgIEVYUEVDVF9XS19TVFJFUSgiaW1hZ2UvcG5nIiwgW3dl
YlZpZXcgdmFsdWVPZkF0dHJpYnV0ZTpAInR5cGUiIGZvclF1ZXJ5U2VsZWN0b3I6QCJhdHRhY2ht
ZW50Il0pOworICAgIEVYUEVDVF9XS19TVFJFUShbYXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVy
XSwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5
U2VsZWN0b3IoJ2F0dGFjaG1lbnQnKSJdKTsKIAogICAgIHsKICAgICAgICAgT2JzZXJ2ZUF0dGFj
aG1lbnRVcGRhdGVzRm9yU2NvcGUgb2JzZXJ2ZXIod2ViVmlldy5nZXQoKSk7CkBAIC05MTQsNiAr
OTIwLDEwIEBAIFRFU1QoV0tBdHRhY2htZW50VGVzdHMsIEluc2VydFBhc3RlZEF0dHJpYnV0ZWRT
dHJpbmdDb250YWluaW5nTXVsdGlwbGVBdHRhY2htZW50CiAgICAgRVhQRUNUX1dLX1NUUkVRKCJh
cHBsaWNhdGlvbi9vY3RldC1zdHJlYW0iLCB6aXBBdHRhY2htZW50VHlwZSk7CiAjZW5kaWYKIAor
ICAgIEVYUEVDVF9XS19TVFJFUShbaW1hZ2VBdHRhY2htZW50IHVuaXF1ZUlkZW50aWZpZXJdLCBb
d2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZG9jdW1lbnQucXVlcnlTZWxl
Y3RvckFsbCgnYXR0YWNobWVudCcpWzBdLnVuaXF1ZUlkZW50aWZpZXIiXSk7CisgICAgRVhQRUNU
X1dLX1NUUkVRKFtwZGZBdHRhY2htZW50IHVuaXF1ZUlkZW50aWZpZXJdLCBbd2ViVmlldyBzdHJp
bmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnYXR0
YWNobWVudCcpWzFdLnVuaXF1ZUlkZW50aWZpZXIiXSk7CisgICAgRVhQRUNUX1dLX1NUUkVRKFt6
aXBBdHRhY2htZW50IHVuaXF1ZUlkZW50aWZpZXJdLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRp
bmdKYXZhU2NyaXB0OkAiZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnYXR0YWNobWVudCcpWzJd
LnVuaXF1ZUlkZW50aWZpZXIiXSk7CisKICAgICB7CiAgICAgICAgIE9ic2VydmVBdHRhY2htZW50
VXBkYXRlc0ZvclNjb3BlIG9ic2VydmVyKHdlYlZpZXcuZ2V0KCkpOwogICAgICAgICBbd2ViVmll
dyBfc3luY2hyb25vdXNseUV4ZWN1dGVFZGl0Q29tbWFuZDpAIlNlbGVjdEFsbCIgYXJndW1lbnQ6
bmlsXTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>330773</attachid>
            <date>2018-01-08 18:35:04 -0800</date>
            <delta_ts>2018-01-08 20:08:25 -0800</delta_ts>
            <desc>Rebase on master</desc>
            <filename>bug-181420-20180108183503.patch</filename>
            <type>text/plain</type>
            <size>6946</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzZkZjM1NDM4YjE3MTZm
NmFmMDczMTk5MGMyYWQ4ZjBkNzM4N2M4NC4uNzBmYTVkMjc5YTUyYTE4ZDE5MTdkMDhjZTI1NDYz
ZDk4OGQxMTExMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAxLTA4ICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtBdHRhY2htZW50
IFN1cHBvcnRdIEV4cG9zZSBIVE1MQXR0YWNobWVudEVsZW1lbnQudW5pcXVlSWRlbnRpZmllciB0
byBiaW5kaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTgxNDIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjM2NTgyNz4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBuZXcgSURMIGRlZmlu
aXRpb24gZm9yIHVuaXF1ZUlkZW50aWZpZXIgb24gSFRNTEF0dGFjaG1lbnRFbGVtZW50LiBUaGlz
IGFsbG93cyBjbGllbnRzIHRvIHJlbGF0ZSBhdHRhY2htZW50CisgICAgICAgIGVsZW1lbnRzIGlu
IHRoZSBET00gdG8gX1dLQXR0YWNobWVudHMgZGVsaXZlcmVkIHZpYSBPYmplY3RpdmUtQyBTUEku
CisKKyAgICAgICAgQWRqdXN0ZWQgZXhpc3RpbmcgdGVzdHMgaW4gV0tBdHRhY2htZW50VGVzdHMu
CisKKyAgICAgICAgKiBodG1sL0hUTUxBdHRhY2htZW50RWxlbWVudC5pZGw6CisKIDIwMTgtMDEt
MDggIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBBY2Nl
c3NpYmlsaXR5QVJJQUdyaWQgZG9lcyBub3QgY29tcGlsZSB3aGVuIGFjY2Vzc2liaWxpdHkgaXMg
ZGlzYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRF
bGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRFbGVtZW50Lmlk
bAppbmRleCA0MTc4YjRiZmJlNTUwNjdlZWRiN2VmMGM3MTJlOGY3NjQ2ZWY0N2ZkLi5kMmY3MDlm
MTIyNDEwNDZlNTg3YmIxOTk5Njc0YmNkNjI3NTRhNTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9odG1sL0hUTUxBdHRhY2htZW50RWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv
aHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQuaWRsCkBAIC0yOCw0ICsyOCw1IEBACiAgICAgRW5h
YmxlZEF0UnVudGltZT1BdHRhY2htZW50RWxlbWVudCwKIF0gaW50ZXJmYWNlIEhUTUxBdHRhY2ht
ZW50RWxlbWVudCA6IEhUTUxFbGVtZW50IHsKICAgICBhdHRyaWJ1dGUgRmlsZT8gZmlsZTsKKyAg
ICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHVuaXF1ZUlkZW50aWZpZXI7CiB9OwpkaWZm
IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGE1ZTkxOTI5
NTI2YzkzOGU1Zjk4MzVkNTI3NTcwMzZhOWEzN2M5NjIuLmZkZWFhYjZjY2Y2ZThmNmZjNjE5MDI5
MTAyM2NlMjJlM2Q4MWE4YjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s
cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wMS0wOCAgV2Vuc29uIEhzaWVoICA8
d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAgICBbQXR0YWNobWVudCBTdXBwb3J0XSBF
eHBvc2UgSFRNTEF0dGFjaG1lbnRFbGVtZW50LnVuaXF1ZUlkZW50aWZpZXIgdG8gYmluZGluZ3MK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTQyMAor
ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYzNjU4Mjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRqdXN0cyBzb21lIGV4aXN0aW5nIEFQSSB0ZXN0
cyB0byB2ZXJpZnkgdGhhdCBhdHRhY2htZW50IGVsZW1lbnRzJyB1bmlxdWVJZGVudGlmaWVycyBt
YXRjaCB0aGUgdW5pcXVlSWRlbnRpZmllcgorICAgICAgICBvZiBjb3JyZXNwb25kaW5nIF9XS0F0
dGFjaG1lbnRzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9X
S0F0dGFjaG1lbnRUZXN0cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAy
MDE4LTAxLTA4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAg
ICAgIFtBdHRhY2htZW50IFN1cHBvcnRdIEV4cG9zZSBmaWxlIG5hbWUgYW5kIGNvbnRlbnQgdHlw
ZSBvZiBXS0F0dGFjaG1lbnQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv
V2ViS2l0Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl
c3RzL1dlYktpdENvY29hL1dLQXR0YWNobWVudFRlc3RzLm1tCmluZGV4IDhkZDM4NjY5OGEzNGI5
NDc5N2U5NDZiOGEwNzdiNGY5N2QwZTRjMjguLjdhZjc4NGNiNjNkN2EzZTU2YzQ4YTE4Yjg4Mjdh
ZmI4Y2ZhNTU3NTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0
Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0
cy9XZWJLaXRDb2NvYS9XS0F0dGFjaG1lbnRUZXN0cy5tbQpAQCAtNTcwLDYgKzU3MCw3IEBAIFRF
U1QoV0tBdHRhY2htZW50VGVzdHMsIEF0dGFjaG1lbnRVcGRhdGVzV2hlbkluc2VydGluZ1JpY2hN
YXJrdXApCiAgICAgRVhQRUNUX0ZBTFNFKFt3ZWJWaWV3IGhhc0F0dHJpYnV0ZTpAIndlYmtpdGF0
dGFjaG1lbnRibG9idXJsIiBmb3JRdWVyeVNlbGVjdG9yOkAiYXR0YWNobWVudCJdKTsKICAgICBF
WFBFQ1RfRkFMU0UoW3dlYlZpZXcgaGFzQXR0cmlidXRlOkAid2Via2l0YXR0YWNobWVudHBhdGgi
IGZvclF1ZXJ5U2VsZWN0b3I6QCJhdHRhY2htZW50Il0pOwogICAgIEVYUEVDVF9GQUxTRShbd2Vi
VmlldyBoYXNBdHRyaWJ1dGU6QCJ3ZWJraXRhdHRhY2htZW50aWQiIGZvclF1ZXJ5U2VsZWN0b3I6
QCJhdHRhY2htZW50Il0pOworICAgIEVYUEVDVF9XS19TVFJFUShbYXR0YWNobWVudCB1bmlxdWVJ
ZGVudGlmaWVyXSwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3Vt
ZW50LnF1ZXJ5U2VsZWN0b3IoJ2F0dGFjaG1lbnQnKS51bmlxdWVJZGVudGlmaWVyIl0pOwogICAg
IHsKICAgICAgICAgT2JzZXJ2ZUF0dGFjaG1lbnRVcGRhdGVzRm9yU2NvcGUgb2JzZXJ2ZXIod2Vi
Vmlldy5nZXQoKSk7CiAgICAgICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3Jp
cHQ6QCJkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdhdHRhY2htZW50JykucmVtb3ZlKCkiXTsKQEAg
LTU4OSw2ICs1OTAsNyBAQCBURVNUKFdLQXR0YWNobWVudFRlc3RzLCBBdHRhY2htZW50VXBkYXRl
c1doZW5DdXR0aW5nQW5kUGFzdGluZykKICAgICAgICAgb2JzZXJ2ZXIuZXhwZWN0QXR0YWNobWVu
dFVwZGF0ZXMoQFtdLCBAW2F0dGFjaG1lbnQuZ2V0KCldKTsKICAgICB9CiAgICAgW2F0dGFjaG1l
bnQgZXhwZWN0UmVxdWVzdGVkRGF0YVRvQmU6dGVzdEhUTUxEYXRhKCldOworICAgIEVYUEVDVF9X
S19TVFJFUShbYXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVyXSwgW3dlYlZpZXcgc3RyaW5nQnlF
dmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2F0dGFjaG1lbnQn
KS51bmlxdWVJZGVudGlmaWVyIl0pOwogICAgIFt3ZWJWaWV3IF9zeW5jaHJvbm91c2x5RXhlY3V0
ZUVkaXRDb21tYW5kOkAiU2VsZWN0QWxsIiBhcmd1bWVudDpuaWxdOwogICAgIHsKICAgICAgICAg
T2JzZXJ2ZUF0dGFjaG1lbnRVcGRhdGVzRm9yU2NvcGUgb2JzZXJ2ZXIod2ViVmlldy5nZXQoKSk7
CkBAIC02MTcsNiArNjE5LDcgQEAgVEVTVChXS0F0dGFjaG1lbnRUZXN0cywgQXR0YWNobWVudERh
dGFGb3JFbXB0eUZpbGUpCiAgICAgICAgIG9ic2VydmVyLmV4cGVjdEF0dGFjaG1lbnRVcGRhdGVz
KEBbXSwgQFthdHRhY2htZW50LmdldCgpXSk7CiAgICAgfQogICAgIFthdHRhY2htZW50IGV4cGVj
dFJlcXVlc3RlZERhdGFUb0JlOltOU0RhdGEgZGF0YV1dOworICAgIEVYUEVDVF9XS19TVFJFUShb
YXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVyXSwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5n
SmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2F0dGFjaG1lbnQnKS51bmlxdWVJ
ZGVudGlmaWVyIl0pOwogICAgIHsKICAgICAgICAgT2JzZXJ2ZUF0dGFjaG1lbnRVcGRhdGVzRm9y
U2NvcGUgc2NvcGUod2ViVmlldy5nZXQoKSk7CiAgICAgICAgIFt3ZWJWaWV3IF9zeW5jaHJvbm91
c2x5RXhlY3V0ZUVkaXRDb21tYW5kOkAiRGVsZXRlQmFja3dhcmQiIGFyZ3VtZW50Om5pbF07CkBA
IC02OTcsNiArNzAwLDcgQEAgVEVTVChXS0F0dGFjaG1lbnRUZXN0cywgSW5QbGFjZUltYWdlQXR0
YWNobWVudFBhcmFncmFwaEluc2VydGlvbikKICAgICBbd2ViVmlldyBleHBlY3RVcGRhdGVzQWZ0
ZXJDb21tYW5kOkAiRGVsZXRlQmFja3dhcmQiIHdpdGhBcmd1bWVudDpuaWwgZXhwZWN0ZWRSZW1v
dmFsczpAW10gZXhwZWN0ZWRJbnNlcnRpb25zOkBbXV07CiAKICAgICBbYXR0YWNobWVudCBleHBl
Y3RSZXF1ZXN0ZWREYXRhVG9CZTppbWFnZURhdGEuZ2V0KCldOworICAgIEVYUEVDVF9XS19TVFJF
UShbYXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVyXSwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0
aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2F0dGFjaG1lbnQnKS51bmlx
dWVJZGVudGlmaWVyIl0pOwogICAgIFt3ZWJWaWV3IHdhaXRGb3JBdHRhY2htZW50RWxlbWVudFNp
emVUb0JlY29tZTpDR1NpemVNYWtlKDIxNSwgMTc0KV07CiAKICAgICBbd2ViVmlldyBleHBlY3RV
cGRhdGVzQWZ0ZXJDb21tYW5kOkAiRGVsZXRlRm9yd2FyZCIgd2l0aEFyZ3VtZW50Om5pbCBleHBl
Y3RlZFJlbW92YWxzOkBbYXR0YWNobWVudC5nZXQoKV0gZXhwZWN0ZWRJbnNlcnRpb25zOkBbXV07
CkBAIC04NDMsNiArODQ3LDcgQEAgVEVTVChXS0F0dGFjaG1lbnRUZXN0cywgSW5zZXJ0UGFzdGVk
SW1hZ2VBc0F0dGFjaG1lbnQpCiAgICAgYXV0byBzaXplID0gcGxhdGZvcm1JbWFnZVdpdGhEYXRh
KFthdHRhY2htZW50IHN5bmNocm9ub3VzbHlSZXF1ZXN0RGF0YTpuaWxdKS5zaXplOwogICAgIEVY
UEVDVF9FUSgyMTUuLCBzaXplLndpZHRoKTsKICAgICBFWFBFQ1RfRVEoMTc0Liwgc2l6ZS5oZWln
aHQpOworICAgIEVYUEVDVF9XS19TVFJFUShbYXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVyXSwg
W3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2Vs
ZWN0b3IoJ2F0dGFjaG1lbnQnKS51bmlxdWVJZGVudGlmaWVyIl0pOwogCiAgICAgewogICAgICAg
ICBPYnNlcnZlQXR0YWNobWVudFVwZGF0ZXNGb3JTY29wZSBvYnNlcnZlcih3ZWJWaWV3LmdldCgp
KTsKQEAgLTg2OSw2ICs4NzQsNyBAQCBURVNUKFdLQXR0YWNobWVudFRlc3RzLCBJbnNlcnRQYXN0
ZWRBdHRyaWJ1dGVkU3RyaW5nQ29udGFpbmluZ0ltYWdlKQogICAgIFthdHRhY2htZW50IGV4cGVj
dFJlcXVlc3RlZERhdGFUb0JlOnRlc3RJbWFnZURhdGEoKV07CiAgICAgRVhQRUNUX1dLX1NUUkVR
KCJMb3JlbSBpcHN1bSAgZG9sb3Igc2l0IGFtZXQuIiwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0
aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LmJvZHkudGV4dENvbnRlbnQiXSk7CiAgICAgRVhQRUNU
X1dLX1NUUkVRKCJpbWFnZS9wbmciLCBbd2ViVmlldyB2YWx1ZU9mQXR0cmlidXRlOkAidHlwZSIg
Zm9yUXVlcnlTZWxlY3RvcjpAImF0dGFjaG1lbnQiXSk7CisgICAgRVhQRUNUX1dLX1NUUkVRKFth
dHRhY2htZW50IHVuaXF1ZUlkZW50aWZpZXJdLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdK
YXZhU2NyaXB0OkAiZG9jdW1lbnQucXVlcnlTZWxlY3RvcignYXR0YWNobWVudCcpLnVuaXF1ZUlk
ZW50aWZpZXIiXSk7CiAKICAgICB7CiAgICAgICAgIE9ic2VydmVBdHRhY2htZW50VXBkYXRlc0Zv
clNjb3BlIG9ic2VydmVyKHdlYlZpZXcuZ2V0KCkpOwpAQCAtOTE0LDYgKzkyMCwxMCBAQCBURVNU
KFdLQXR0YWNobWVudFRlc3RzLCBJbnNlcnRQYXN0ZWRBdHRyaWJ1dGVkU3RyaW5nQ29udGFpbmlu
Z011bHRpcGxlQXR0YWNobWVudAogICAgIEVYUEVDVF9XS19TVFJFUSgiYXBwbGljYXRpb24vb2N0
ZXQtc3RyZWFtIiwgemlwQXR0YWNobWVudFR5cGUpOwogI2VuZGlmCiAKKyAgICBFWFBFQ1RfV0tf
U1RSRVEoW2ltYWdlQXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVyXSwgW3dlYlZpZXcgc3RyaW5n
QnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoJ2F0dGFj
aG1lbnQnKVswXS51bmlxdWVJZGVudGlmaWVyIl0pOworICAgIEVYUEVDVF9XS19TVFJFUShbcGRm
QXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVyXSwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5n
SmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoJ2F0dGFjaG1lbnQnKVsxXS51
bmlxdWVJZGVudGlmaWVyIl0pOworICAgIEVYUEVDVF9XS19TVFJFUShbemlwQXR0YWNobWVudCB1
bmlxdWVJZGVudGlmaWVyXSwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpA
ImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoJ2F0dGFjaG1lbnQnKVsyXS51bmlxdWVJZGVudGlm
aWVyIl0pOworCiAgICAgewogICAgICAgICBPYnNlcnZlQXR0YWNobWVudFVwZGF0ZXNGb3JTY29w
ZSBvYnNlcnZlcih3ZWJWaWV3LmdldCgpKTsKICAgICAgICAgW3dlYlZpZXcgX3N5bmNocm9ub3Vz
bHlFeGVjdXRlRWRpdENvbW1hbmQ6QCJTZWxlY3RBbGwiIGFyZ3VtZW50Om5pbF07Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>