181400 2018-01-08 13:43:08 -0800 REGRESSION (r226485): Many new wasm leaks detected by the leaks bot 2018-01-24 12:49:53 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue ews-watchlist fpizlo glenn jfbastien jlewis3 joepeck lforschler mark.lam ryanhaddad sam webkit-bug-importer oldest_to_newest 1386894 0 ap 2018-01-08 13:43:08 -0800 The number of leaks detected has substantially increased with r226485. Perhaps leaks checking doesn't work with poisoning? 1386896 1 webkit-bug-importer 2018-01-08 13:44:21 -0800 <rdar://problem/36358768> 1391689 2 331941 ap 2018-01-22 10:08:58 -0800 Created attachment 331941 disable poisoning on the bot Sounds like the short term solution is to disable poisoning on the bot. JF, is this likely to continue working for now? 1391692 3 331941 jfbastien 2018-01-22 10:13:22 -0800 Comment on attachment 331941 disable poisoning on the bot (In reply to Alexey Proskuryakov from comment #2) > Created attachment 331941 [details] > disable poisoning on the bot > > Sounds like the short term solution is to disable poisoning on the bot. JF, > is this likely to continue working for now? Disabling poisoning should remain a reliable manner to avoid leaks. It looks like you're disabling it only for the leaks bots, which is important since we want to test with poisoning elsewhere. If the leaks program changes in the future, say to ignore the WebKit zones, we should make sure that with JSC_usePoisoning=0 they do detect leaks properly (otherwise we'd just ignore the leaks). 1391714 4 331941 commit-queue 2018-01-22 10:42:54 -0800 Comment on attachment 331941 disable poisoning on the bot Clearing flags on attachment: 331941 Committed r227342: <https://trac.webkit.org/changeset/227342> 1391715 5 commit-queue 2018-01-22 10:42:56 -0800 All reviewed patches have been landed. Closing bug. 1392389 6 ap 2018-01-23 17:56:18 -0800 This did not work, I needed to wrap the additional argument. 1392590 7 332169 ap 2018-01-24 09:00:44 -0800 Created attachment 332169 do it right 1392600 8 332169 sam 2018-01-24 09:35:06 -0800 Comment on attachment 332169 do it right View in context: https://bugs.webkit.org/attachment.cgi?id=332169&action=review > Tools/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=181400 > + https://bugs.webkit.org/show_bug.cgi?id=181400 > + Double URL 1392606 9 332169 ap 2018-01-24 09:47:42 -0800 Comment on attachment 332169 do it right Wait, this still doesn't make sense. This should be built into run-webkit-tests, so that checking for leaks works for engineers. 1392614 10 332176 ap 2018-01-24 10:03:17 -0800 Created attachment 332176 do it right Okay, I hope that it finally makes sense. 1392630 11 332176 joepeck 2018-01-24 10:36:29 -0800 Comment on attachment 332176 do it right View in context: https://bugs.webkit.org/attachment.cgi?id=332176&action=review rs=me > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:133 > { "name": "Apple High Sierra (Leaks)", "type": "TestWebKit1Leaks", "builddir": "highsierra-leaks", > "platform": "mac-highsierra", "configuration": "release", "architectures": ["x86_64"], > - "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout", "--JSC_usePoisoning=0"], > + "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout"], > "slavenames": ["bot121"] Wondering why I don't see the obvious --leaks and -1 on this "TestWebKit1Leaks" bot. Must be buried somewhere else? > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:433 > + if options.leaks: > + options.additional_env_var.append("JSC_usePoisoning=0") Is leaks intended to work with WebKit2? If so, you should probably also include "__XPC_JSC_usePoisoning=0" as well, so that WebContentProcesses would get it. In practice I think we only run --leaks with -1 right now. 1392672 12 ap 2018-01-24 12:45:06 -0800 > Wondering why I don't see the obvious --leaks and -1 on this "TestWebKit1Leaks" bot. Must be buried somewhere else? Correct, all bots with type TestWebKit1Leaks get that. Maybe "--no-retry-failures", "--no-sample-on-timeout" should be there too, not sure. > Is leaks intended to work with WebKit2? It doesn't work with multi-process in a meaningful way (cf. bug 167851). But I'll add the XPC variant, so that we have fewer things to fix for WebKit2 in the future. 1392682 13 ap 2018-01-24 12:49:53 -0800 Committed http://trac.webkit.org/r227547 331941 2018-01-22 10:08:58 -0800 2018-01-22 10:42:54 -0800 disable poisoning on the bot DisablePoisoning.txt text/plain 1663 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNzMzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTAxLTIyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMjY0ODUpOiBNYW55IG5ldyB3YXNtIGxlYWtzIGRl dGVjdGVkIGJ5IHRoZSBsZWFrcyBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MTQwMAorICAgICAgICByZGFyOi8vcHJvYmxlbS8zNjM1ODc2OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb246IERpc2FibGUg cG9pc29uaW5nIG9uIHRoZSBsZWFrcyBib3QuCisKIDIwMTgtMDEtMjIgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtp dC9XZWJLaXRXZWJzaXRlRGF0YS9yZXNvdXJjZS1sb2FkLXN0YXRpc3RpY3MgaXMgZmFpbGluZyBz aW5jZSByMjI3MjIzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9jb25maWcuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNvbgkocmV2aXNpb24gMjI2NjY4 KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29u ZmlnLmpzb24JKHdvcmtpbmcgY29weSkKQEAgLTE0Nyw3ICsxNDcsNyBAQAogICAgICAgICAgICAg ICAgICAgICB9LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxlIEhpZ2ggU2ll cnJhIChMZWFrcykiLCAidHlwZSI6ICJUZXN0V2ViS2l0MUxlYWtzIiwgImJ1aWxkZGlyIjogImhp Z2hzaWVycmEtbGVha3MiLAogICAgICAgICAgICAgICAgICAgICAgICJwbGF0Zm9ybSI6ICJtYWMt aGlnaHNpZXJyYSIsICJjb25maWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0ZWN0dXJlcyI6 IFsieDg2XzY0Il0sCi0gICAgICAgICAgICAgICAgICAgICAgImFkZGl0aW9uYWxBcmd1bWVudHMi OiBbIi0tbm8tcmV0cnktZmFpbHVyZXMiLCAiLS1uby1zYW1wbGUtb24tdGltZW91dCJdLAorICAg ICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsQXJndW1lbnRzIjogWyItLW5vLXJldHJ5LWZh aWx1cmVzIiwgIi0tbm8tc2FtcGxlLW9uLXRpbWVvdXQiLCAiLS1KU0NfdXNlUG9pc29uaW5nPTAi XSwKICAgICAgICAgICAgICAgICAgICAgICAic2xhdmVuYW1lcyI6IFsiYm90MTIxIl0KICAgICAg ICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJBcHBsZSBT aWVycmEgRGVidWcgKEJ1aWxkKSIsICJ0eXBlIjogIkJ1aWxkIiwgImJ1aWxkZGlyIjogInNpZXJy YS1kZWJ1ZyIsCg== 332169 2018-01-24 09:00:44 -0800 2018-01-24 10:03:17 -0800 do it right UsePoisoning.txt text/plain 1712 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNzUyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTAxLTI0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMjY0ODUpOiBNYW55IG5ldyB3YXNtIGxlYWtzIGRl dGVjdGVkIGJ5IHRoZSBsZWFrcyBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MTQwMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTgxNDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9jb25maWcuanNvbjogUGFzcyB0aGUgZW52aXJvbm1lbnQKKyAgICAgICAgdmFyaWFibGUgaW4g YSBwcm9wZXIgbWFubmVyLgorCiAyMDE4LTAxLTE4ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3Zp bGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXZWJWUl0gQWRkIE9wZW5WUiB0byB0aGUgdHJl ZSBhbmQgdG8gdGhlIGJ1aWxkCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNvbgkocmV2aXNpb24g MjI3NDc4KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvY29uZmlnLmpzb24JKHdvcmtpbmcgY29weSkKQEAgLTEyOSw3ICsxMjksNyBAQAogICAgICAg ICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxlIEhp Z2ggU2llcnJhIChMZWFrcykiLCAidHlwZSI6ICJUZXN0V2ViS2l0MUxlYWtzIiwgImJ1aWxkZGly IjogImhpZ2hzaWVycmEtbGVha3MiLAogICAgICAgICAgICAgICAgICAgICAgICJwbGF0Zm9ybSI6 ICJtYWMtaGlnaHNpZXJyYSIsICJjb25maWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0ZWN0 dXJlcyI6IFsieDg2XzY0Il0sCi0gICAgICAgICAgICAgICAgICAgICAgImFkZGl0aW9uYWxBcmd1 bWVudHMiOiBbIi0tbm8tcmV0cnktZmFpbHVyZXMiLCAiLS1uby1zYW1wbGUtb24tdGltZW91dCIs ICItLUpTQ191c2VQb2lzb25pbmc9MCJdLAorICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlv bmFsQXJndW1lbnRzIjogWyItLW5vLXJldHJ5LWZhaWx1cmVzIiwgIi0tbm8tc2FtcGxlLW9uLXRp bWVvdXQiLCAiLS1hZGRpdGlvbmFsLWVudi12YXI9SlNDX3VzZVBvaXNvbmluZz0wIl0sCiAgICAg ICAgICAgICAgICAgICAgICAgInNsYXZlbmFtZXMiOiBbImJvdDEyMSJdCiAgICAgICAgICAgICAg ICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiQXBwbGUgU2llcnJhIERl YnVnIChCdWlsZCkiLCAidHlwZSI6ICJCdWlsZCIsICJidWlsZGRpciI6ICJzaWVycmEtZGVidWci LAo= 332176 2018-01-24 10:03:17 -0800 2018-01-24 10:36:29 -0800 do it right UsePoisoning.txt text/plain 2441 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNzUyNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTAxLTI0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMjY0ODUpOiBNYW55IG5ldyB3YXNtIGxlYWtzIGRl dGVjdGVkIGJ5IHRoZSBsZWFrcyBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MTQwMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYzNTg3Njg+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNvbjogUmVtb3Zl IGluY29ycmVjdCBvcHRpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5OiAoX3NldF91cF9kZXJpdmVkX29wdGlvbnMpOgorICAg ICAgICBBbHdheXMgZGlzYWJsZSBwb2lzb25pbmcgd2hlbiBydW5uaW5nIHdpdGggLS1sZWFrcywg YXMgdGhpcyBzaG91bGQgd29yayBsb2NhbGx5LAorICAgICAgICBub3QganVzdCBvbiBib3RzLgor CiAyMDE4LTAxLTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBV cGRhdGUgUG9pc29uZWQgcG9pbnRlcnMgdG8gdGFrZSBhIFBvaXNvbiBjbGFzcyBpbnN0ZWFkIG9m IGEgdWludHB0cl90Ji4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL2NvbmZpZy5qc29uCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL2NvbmZpZy5qc29uCShyZXZpc2lvbiAyMjc0 NzgpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9j b25maWcuanNvbgkod29ya2luZyBjb3B5KQpAQCAtMTI5LDcgKzEyOSw3IEBACiAgICAgICAgICAg ICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiQXBwbGUgSGlnaCBT aWVycmEgKExlYWtzKSIsICJ0eXBlIjogIlRlc3RXZWJLaXQxTGVha3MiLCAiYnVpbGRkaXIiOiAi aGlnaHNpZXJyYS1sZWFrcyIsCiAgICAgICAgICAgICAgICAgICAgICAgInBsYXRmb3JtIjogIm1h Yy1oaWdoc2llcnJhIiwgImNvbmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsICJhcmNoaXRlY3R1cmVz IjogWyJ4ODZfNjQiXSwKLSAgICAgICAgICAgICAgICAgICAgICAiYWRkaXRpb25hbEFyZ3VtZW50 cyI6IFsiLS1uby1yZXRyeS1mYWlsdXJlcyIsICItLW5vLXNhbXBsZS1vbi10aW1lb3V0IiwgIi0t SlNDX3VzZVBvaXNvbmluZz0wIl0sCisgICAgICAgICAgICAgICAgICAgICAgImFkZGl0aW9uYWxB cmd1bWVudHMiOiBbIi0tbm8tcmV0cnktZmFpbHVyZXMiLCAiLS1uby1zYW1wbGUtb24tdGltZW91 dCJdLAogICAgICAgICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJib3QxMjEiXQogICAg ICAgICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxl IFNpZXJyYSBEZWJ1ZyAoQnVpbGQpIiwgInR5cGUiOiAiQnVpbGQiLCAiYnVpbGRkaXIiOiAic2ll cnJhLWRlYnVnIiwKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkocmV2aXNpb24gMjI3NDc4KQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkod29y a2luZyBjb3B5KQpAQCAtNDI5LDYgKzQyOSw4IEBAIGRlZiBfc2V0X3VwX2Rlcml2ZWRfb3B0aW9u cyhwb3J0LCBvcHRpb24KICAgICBpZiBvcHRpb25zLnBsYXRmb3JtIGluIFsiZ3RrIiwgIndwZSJd OgogICAgICAgICBvcHRpb25zLndlYmtpdF90ZXN0X3J1bm5lciA9IFRydWUKIAorICAgIGlmIG9w dGlvbnMubGVha3M6CisgICAgICAgIG9wdGlvbnMuYWRkaXRpb25hbF9lbnZfdmFyLmFwcGVuZCgi SlNDX3VzZVBvaXNvbmluZz0wIikKIAogZGVmIHJ1bihwb3J0LCBvcHRpb25zLCBhcmdzLCBsb2dn aW5nX3N0cmVhbSk6CiAgICAgbG9nZ2VyID0gbG9nZ2luZy5nZXRMb2dnZXIoKQo=