181396 2018-01-08 12:49:42 -0800 Many CVDisplayLink threads created and destroyed while watching a YouTube video 2020-09-04 15:27:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216195 InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1386866 0 jer.noble 2018-01-08 12:49:42 -0800 Many CVDisplayLink threads created and destroyed while watching YouTube video 1386867 1 jer.noble 2018-01-08 13:01:19 -0800 YouTube's media controls (and the default media controls on Mac & iOS) appear to use requestAnimationFrame() to implement layout changes during playback. The most common event which triggers layout changes is the 'timeupdate' event, which according to the HTML spec, should fire every 15 to 250ms. WebKit picks the slowest update value, 250ms. The DisplayRefreshMonitor implements the timer which triggers rAF, and it will currently destroy the underlying platform object which handles the display refresh notification if there are no rAF clients for 10 consecutive display refresh intervals, or: 10 / 60hz = 166ms. So a naive client that does something like: video.addEventListener('timeupdate', event => { doUpdate(event); }) will cause the platform rAF object to be created and destroyed 4x a second. Lets update the constant in DisplayRefreshMonitor to, e.g., 22 consecutive display intervals without a client (or 366ms), so that clients of "slow" firing consistently events like 'timeupdate' and 'progress' don't inadvertently cause a lot of tear-down/bring-up overhead. 1386938 2 330739 jer.noble 2018-01-08 14:50:20 -0800 Created attachment 330739 Patch 1386957 3 330739 simon.fraser 2018-01-08 15:20:15 -0800 Comment on attachment 330739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330739&action=review > Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:59 > + const int maxInactiveFireCount = 20; I wonder if we should make this a Seconds and do it based on time, rather than fire count? > Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp:110 > + LOG(RequestAnimationFrame, "DisplayRefreshMonitorManager::displayDidRefresh() - destroying monitor %p", &monitor); You should log when the rAF fires too. 1386969 4 jer.noble 2018-01-08 15:51:54 -0800 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 330739 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330739&action=review > > > Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:59 > > + const int maxInactiveFireCount = 20; > > I wonder if we should make this a Seconds and do it based on time, rather > than fire count? That would definitely future proof us against future non-60fps monitor refresh rates. I'll file a follow-up bug. > > Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp:110 > > + LOG(RequestAnimationFrame, "DisplayRefreshMonitorManager::displayDidRefresh() - destroying monitor %p", &monitor); > > You should log when the rAF fires too. 1386971 5 330749 jer.noble 2018-01-08 15:52:37 -0800 Created attachment 330749 Patch for landing 1386973 6 jer.noble 2018-01-08 15:55:59 -0800 (In reply to Jer Noble from comment #4) > (In reply to Simon Fraser (smfr) from comment #3) > > Comment on attachment 330739 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=330739&action=review > > > > > Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:59 > > > + const int maxInactiveFireCount = 20; > > > > I wonder if we should make this a Seconds and do it based on time, rather > > than fire count? > > That would definitely future proof us against future non-60fps monitor > refresh rates. I'll file a follow-up bug. Filed bug# 181411. 1386989 7 330749 commit-queue 2018-01-08 16:47:09 -0800 Comment on attachment 330749 Patch for landing Rejecting attachment 330749 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 330749, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/5980111 1387342 8 330838 jer.noble 2018-01-09 11:11:17 -0800 Created attachment 330838 Patch for landing 1387435 9 330838 commit-queue 2018-01-09 15:47:40 -0800 Comment on attachment 330838 Patch for landing Clearing flags on attachment: 330838 Committed r226664: <https://trac.webkit.org/changeset/226664> 1387436 10 commit-queue 2018-01-09 15:47:42 -0800 All reviewed patches have been landed. Closing bug. 1387437 11 webkit-bug-importer 2018-01-09 15:51:14 -0800 <rdar://problem/36388728> 330739 2018-01-08 14:50:20 -0800 2018-01-08 15:52:35 -0800 Patch bug-181396-20180108145020.patch text/plain 3979 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZiNGYwMjkxNWNiZTc1 NmM2MTBmMjNlYWUxMmNhYTI5NWM4MmI1My4uMTBiMjYzN2RjMjBkNTU1M2RmYjBmZTU5N2RmZjkx ZmQxODRmZTI5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTAxLTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE1hbnkgQ1ZEaXNwbGF5TGlu ayB0aHJlYWRzIGNyZWF0ZWQgYW5kIGRlc3Ryb3llZCB3aGlsZSB3YXRjaGluZyBhIFlvdVR1YmUg dmlkZW8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 MTM5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo ZW4gd2F0Y2hpbmcgc29tZSBZb3VUdWJlIHZpZGVvcyAob3IgYW55IHZpZGVvIHdpdGggZGVmYXVs dCBjb250cm9scyksIGV2ZW50IGhhbmRsZXJzIGZvcgorICAgICAgICB0aGUgInRpbWV1cGRhdGUi IGV2ZW50IHdoaWNoIHVzZSByQUYgd2lsbCBjYXVzZSB0aGUgdW5kZXJseWluZyBwbGF0Zm9ybSBv YmplY3RzIHRvIGJlCisgICAgICAgIGRlc3Ryb3llZCBpbiBiZXR3ZWVuICJ0aW1ldXBkYXRlIiBl dmVudHMgYmVpbmcgZmlyZWQsIHNpbmNlIHRoZXkgb2NjdXIgZXZlcnkgMjUwbXMsIGFuZCByQUYK KyAgICAgICAgb2JqZWN0cyBhcmUgZGVzdHJveWVkIGV2ZXJ5IDE2Nm1zIChvciAxMC82MGh6KS4g VXBkYXRlIHRoaXMgY29uc3RhbnQgdG8gZGVzdHJveSB0aGUKKyAgICAgICAgdW5kZXJseWluZyBv YmplY3RzIGV2ZXJ5IDMzM21zIChvciAyMC82MGh6KSBzbyB0aGF0IHRoaXMgY29tbW9uIHBhdHRl cm4gZG9lc24ndCBsZWFkIHRvCisgICAgICAgIGV4Y2Vzc2l2ZSByQUYgcGxhdGZvcm0gb2JqZWN0 IHR1cm5vdmVyLgorCisgICAgICAgICogcGxhdGZvcm0vTG9nZ2luZy5oOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oOgorICAgICAgICAoV2ViQ29y ZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yOjpzaG91bGRCZVRlcm1pbmF0ZWQgY29uc3QpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlcjo6Y3JlYXRl TW9uaXRvckZvckNsaWVudCk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5UmVmcmVzaE1vbml0 b3JNYW5hZ2VyOjpkaXNwbGF5RGlkUmVmcmVzaCk6CisKIDIwMTctMTItMjEgIEplciBOb2JsZSAg PGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gQVNTRVJU SU9OIEZBSUxFRDogIW5vZGUuaXNDb25uZWN0ZWQoKSBpbiBXZWJDb3JlOjpub3RpZnlOb2RlSW5z ZXJ0ZWRJbnRvRG9jdW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xv Z2dpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaAppbmRleCBiYWQ4YWUw ODkyMGQ2NzhlNWE0MzA1Y2U1MWJkYWIwMTQyZDBlNDUxLi5jZjcwMjBjNDg1MTI1OTBkMWQwNTcy ZDE5YWI2YTAzM2NjMDBjMzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9M b2dnaW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCkBAIC03OCw2 ICs3OCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBNKFBvcHVwQmxvY2tpbmcpIFwKICAg ICBNKFByb2dyZXNzKSBcCiAgICAgTShSZW1vdGVJbnNwZWN0b3IpIFwKKyAgICBNKFJlcXVlc3RB bmltYXRpb25GcmFtZSkgXAogICAgIE0oUmVzb3VyY2VMb2FkaW5nKSBcCiAgICAgTShSZXNvdXJj ZUxvYWRPYnNlcnZlcikgXAogICAgIE0oUmVzb3VyY2VMb2FkU3RhdGlzdGljcykgXApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25p dG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1v bml0b3IuaAppbmRleCBjY2M2MDY1ZWZhMzgxNjViNDkxYzkyZGU1ZGQ0NjhiYTAzOTM5NzNjLi4x ZTcwNWMwYWM3NDdiYjBjMTRiZGFmOTAwMmFjNDE5NDNhZGZlZDAxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3IuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3Iu aApAQCAtNTYsNyArNTYsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIHNob3VsZEJlVGVybWluYXRl ZCgpIGNvbnN0CiAgICAgewotICAgICAgICBjb25zdCBpbnQgbWF4SW5hY3RpdmVGaXJlQ291bnQg PSAxMDsKKyAgICAgICAgY29uc3QgaW50IG1heEluYWN0aXZlRmlyZUNvdW50ID0gMjA7CiAgICAg ICAgIHJldHVybiAhbV9zY2hlZHVsZWQgJiYgbV91bnNjaGVkdWxlZEZpcmVDb3VudCA+IG1heElu YWN0aXZlRmlyZUNvdW50OwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyLmNw cAppbmRleCA1OTRkMWYwNGFmMDUwNTBkNWYyZTk1Y2Y2Y2VjZTI1YmYxMjkwMzdjLi5mODI4ZGM1 ZjY5MTllNzdjZTg4MDAxOTg5ODRiYzJlZmRjMjA4MDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0 b3JNYW5hZ2VyLmNwcApAQCAtMzAsNiArMzAsNyBAQAogCiAjaW5jbHVkZSAiRGlzcGxheVJlZnJl c2hNb25pdG9yLmgiCiAjaW5jbHVkZSAiRGlzcGxheVJlZnJlc2hNb25pdG9yQ2xpZW50LmgiCisj aW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CkBAIC01Niw2ICs1Nyw3IEBAIERpc3BsYXlSZWZyZXNoTW9uaXRvciog RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlcjo6Y3JlYXRlTW9uaXRvckZvckNsaWVudChEaXNw CiAgICAgaWYgKCFtb25pdG9yKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAorICAgIExPRyhS ZXF1ZXN0QW5pbWF0aW9uRnJhbWUsICJEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpjcmVh dGVNb25pdG9yRm9yQ2xpZW50KCkgLSBjcmVhdGVkIG1vbml0b3IgJXAiLCBtb25pdG9yLmdldCgp KTsKICAgICBtb25pdG9yLT5hZGRDbGllbnQoY2xpZW50KTsKICAgICBEaXNwbGF5UmVmcmVzaE1v bml0b3IqIHJlc3VsdCA9IG1vbml0b3IuZ2V0KCk7CiAgICAgbV9tb25pdG9ycy5hcHBlbmQoV1RG TW92ZShtb25pdG9yKSk7CkBAIC0xMDUsNiArMTA3LDcgQEAgdm9pZCBEaXNwbGF5UmVmcmVzaE1v bml0b3JNYW5hZ2VyOjpkaXNwbGF5RGlkUmVmcmVzaChEaXNwbGF5UmVmcmVzaE1vbml0b3ImIG1v bmkKIHsKICAgICBpZiAoIW1vbml0b3Iuc2hvdWxkQmVUZXJtaW5hdGVkKCkpCiAgICAgICAgIHJl dHVybjsKKyAgICBMT0coUmVxdWVzdEFuaW1hdGlvbkZyYW1lLCAiRGlzcGxheVJlZnJlc2hNb25p dG9yTWFuYWdlcjo6ZGlzcGxheURpZFJlZnJlc2goKSAtIGRlc3Ryb3lpbmcgbW9uaXRvciAlcCIs ICZtb25pdG9yKTsKIAogICAgIHNpemVfdCBtb25pdG9ySW5kZXggPSBtX21vbml0b3JzLmZpbmQo Jm1vbml0b3IpOwogICAgIGlmIChtb25pdG9ySW5kZXggIT0gbm90Rm91bmQpCg== 330749 2018-01-08 15:52:37 -0800 2018-01-09 11:11:11 -0800 Patch for landing bug-181396-20180108155236.patch text/plain 4821 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZiNGYwMjkxNWNiZTc1 NmM2MTBmMjNlYWUxMmNhYTI5NWM4MmI1My4uMGU1ODk2NzI3NzliMGNmZGU5ZjdjNWQ1OWYxMDA0 YzZkYTg3ZjNmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTAxLTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE1hbnkgQ1ZEaXNwbGF5TGlu ayB0aHJlYWRzIGNyZWF0ZWQgYW5kIGRlc3Ryb3llZCB3aGlsZSB3YXRjaGluZyBhIFlvdVR1YmUg dmlkZW8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 MTM5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo ZW4gd2F0Y2hpbmcgc29tZSBZb3VUdWJlIHZpZGVvcyAob3IgYW55IHZpZGVvIHdpdGggZGVmYXVs dCBjb250cm9scyksIGV2ZW50IGhhbmRsZXJzIGZvcgorICAgICAgICB0aGUgInRpbWV1cGRhdGUi IGV2ZW50IHdoaWNoIHVzZSByQUYgd2lsbCBjYXVzZSB0aGUgdW5kZXJseWluZyBwbGF0Zm9ybSBv YmplY3RzIHRvIGJlCisgICAgICAgIGRlc3Ryb3llZCBpbiBiZXR3ZWVuICJ0aW1ldXBkYXRlIiBl dmVudHMgYmVpbmcgZmlyZWQsIHNpbmNlIHRoZXkgb2NjdXIgZXZlcnkgMjUwbXMsIGFuZCByQUYK KyAgICAgICAgb2JqZWN0cyBhcmUgZGVzdHJveWVkIGV2ZXJ5IDE2Nm1zIChvciAxMC82MGh6KS4g VXBkYXRlIHRoaXMgY29uc3RhbnQgdG8gZGVzdHJveSB0aGUKKyAgICAgICAgdW5kZXJseWluZyBv YmplY3RzIGV2ZXJ5IDMzM21zIChvciAyMC82MGh6KSBzbyB0aGF0IHRoaXMgY29tbW9uIHBhdHRl cm4gZG9lc24ndCBsZWFkIHRvCisgICAgICAgIGV4Y2Vzc2l2ZSByQUYgcGxhdGZvcm0gb2JqZWN0 IHR1cm5vdmVyLgorCisgICAgICAgICogcGxhdGZvcm0vTG9nZ2luZy5oOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oOgorICAgICAgICAoV2ViQ29y ZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yOjpzaG91bGRCZVRlcm1pbmF0ZWQgY29uc3QpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEaXNwbGF5UmVmcmVzaE1vbml0b3I6OmRpc3BsYXlEaWRSZWZyZXNoKToK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2Vy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXI6OmNy ZWF0ZU1vbml0b3JGb3JDbGllbnQpOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheVJlZnJlc2hN b25pdG9yTWFuYWdlcjo6ZGlzcGxheURpZFJlZnJlc2gpOgorCiAyMDE3LTEyLTIxICBKZXIgTm9i bGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IFtpT1NdIEFT U0VSVElPTiBGQUlMRUQ6ICFub2RlLmlzQ29ubmVjdGVkKCkgaW4gV2ViQ29yZTo6bm90aWZ5Tm9k ZUluc2VydGVkSW50b0RvY3VtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9Mb2dnaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKaW5kZXggYmFk OGFlMDg5MjBkNjc4ZTVhNDMwNWNlNTFiZGFiMDE0MmQwZTQ1MS4uY2Y3MDIwYzQ4NTEyNTkwZDFk MDU3MmQxOWFiNmEwMzNjYzAwYzMxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vTG9nZ2luZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaApAQCAt NzgsNiArNzgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgTShQb3B1cEJsb2NraW5nKSBc CiAgICAgTShQcm9ncmVzcykgXAogICAgIE0oUmVtb3RlSW5zcGVjdG9yKSBcCisgICAgTShSZXF1 ZXN0QW5pbWF0aW9uRnJhbWUpIFwKICAgICBNKFJlc291cmNlTG9hZGluZykgXAogICAgIE0oUmVz b3VyY2VMb2FkT2JzZXJ2ZXIpIFwKICAgICBNKFJlc291cmNlTG9hZFN0YXRpc3RpY3MpIFwKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNo TW9uaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVm cmVzaE1vbml0b3IuY3BwCmluZGV4IGM5ZTIwNzc4Njk2MzQ1YWFkYTE4NTRkM2FiNDBmZjM3NDVh ZDJjMjAuLjIxYTJlN2RmNTkxZmMxM2Y1NDg1YjlmNzY0MTc2Y2QxY2YzMGI5NjMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRv ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJl c2hNb25pdG9yLmNwcApAQCAtODUsNiArODUsNyBAQCB2b2lkIERpc3BsYXlSZWZyZXNoTW9uaXRv cjo6ZGlzcGxheURpZFJlZnJlc2goKQogewogICAgIHsKICAgICAgICAgTG9ja0hvbGRlciBsb2Nr KG1fbXV0ZXgpOworICAgICAgICBMT0coUmVxdWVzdEFuaW1hdGlvbkZyYW1lLCAiRGlzcGxheVJl ZnJlc2hNb25pdG9yOjpkaXNwbGF5RGlkUmVmcmVzaCglcCkgLSBtX3NjaGVkdWxlZCglZCksIG1f dW5zY2hlZHVsZWRGaXJlQ291bnQoJWQpIiwgdGhpcywgbV9zY2hlZHVsZWQsIG1fdW5zY2hlZHVs ZWRGaXJlQ291bnQpOwogICAgICAgICBpZiAoIW1fc2NoZWR1bGVkKQogICAgICAgICAgICAgKytt X3Vuc2NoZWR1bGVkRmlyZUNvdW50OwogICAgICAgICBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3IuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oCmluZGV4 IGNjYzYwNjVlZmEzODE2NWI0OTFjOTJkZTVkZDQ2OGJhMDM5Mzk3M2MuLjFlNzA1YzBhYzc0N2Ji MGMxNGJkYWY5MDAyYWM0MTk0M2FkZmVkMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oCkBAIC01Niw3ICs1 Niw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgc2hvdWxkQmVUZXJtaW5hdGVkKCkgY29uc3QKICAg ICB7Ci0gICAgICAgIGNvbnN0IGludCBtYXhJbmFjdGl2ZUZpcmVDb3VudCA9IDEwOworICAgICAg ICBjb25zdCBpbnQgbWF4SW5hY3RpdmVGaXJlQ291bnQgPSAyMDsKICAgICAgICAgcmV0dXJuICFt X3NjaGVkdWxlZCAmJiBtX3Vuc2NoZWR1bGVkRmlyZUNvdW50ID4gbWF4SW5hY3RpdmVGaXJlQ291 bnQ7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXIuY3BwCmluZGV4IDU5NGQx ZjA0YWYwNTA1MGQ1ZjJlOTVjZjZjZWNlMjViZjEyOTAzN2MuLmY4MjhkYzVmNjkxOWU3N2NlODgw MDE5ODk4NGJjMmVmZGMyMDgwMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXIuY3Bw CkBAIC0zMCw2ICszMCw3IEBACiAKICNpbmNsdWRlICJEaXNwbGF5UmVmcmVzaE1vbml0b3IuaCIK ICNpbmNsdWRlICJEaXNwbGF5UmVmcmVzaE1vbml0b3JDbGllbnQuaCIKKyNpbmNsdWRlICJMb2dn aW5nLmgiCiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKQEAgLTU2LDYgKzU3LDcgQEAgRGlzcGxheVJlZnJlc2hNb25pdG9yKiBEaXNwbGF5UmVmcmVz aE1vbml0b3JNYW5hZ2VyOjpjcmVhdGVNb25pdG9yRm9yQ2xpZW50KERpc3AKICAgICBpZiAoIW1v bml0b3IpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCisgICAgTE9HKFJlcXVlc3RBbmltYXRp b25GcmFtZSwgIkRpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXI6OmNyZWF0ZU1vbml0b3JGb3JD bGllbnQoKSAtIGNyZWF0ZWQgbW9uaXRvciAlcCIsIG1vbml0b3IuZ2V0KCkpOwogICAgIG1vbml0 b3ItPmFkZENsaWVudChjbGllbnQpOwogICAgIERpc3BsYXlSZWZyZXNoTW9uaXRvciogcmVzdWx0 ID0gbW9uaXRvci5nZXQoKTsKICAgICBtX21vbml0b3JzLmFwcGVuZChXVEZNb3ZlKG1vbml0b3Ip KTsKQEAgLTEwNSw2ICsxMDcsNyBAQCB2b2lkIERpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXI6 OmRpc3BsYXlEaWRSZWZyZXNoKERpc3BsYXlSZWZyZXNoTW9uaXRvciYgbW9uaQogewogICAgIGlm ICghbW9uaXRvci5zaG91bGRCZVRlcm1pbmF0ZWQoKSkKICAgICAgICAgcmV0dXJuOworICAgIExP RyhSZXF1ZXN0QW5pbWF0aW9uRnJhbWUsICJEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpk aXNwbGF5RGlkUmVmcmVzaCgpIC0gZGVzdHJveWluZyBtb25pdG9yICVwIiwgJm1vbml0b3IpOwog CiAgICAgc2l6ZV90IG1vbml0b3JJbmRleCA9IG1fbW9uaXRvcnMuZmluZCgmbW9uaXRvcik7CiAg ICAgaWYgKG1vbml0b3JJbmRleCAhPSBub3RGb3VuZCkK 330838 2018-01-09 11:11:17 -0800 2018-01-09 15:47:40 -0800 Patch for landing bug-181396-20180109111115.patch text/plain 4819 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZiNGYwMjkxNWNiZTc1 NmM2MTBmMjNlYWUxMmNhYTI5NWM4MmI1My4uODViYWIzNWFiY2ViYTk3OGNiZDM0MzYzYzkwNmE2 NGFkNDA5N2E0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTAxLTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE1hbnkgQ1ZEaXNwbGF5TGlu ayB0aHJlYWRzIGNyZWF0ZWQgYW5kIGRlc3Ryb3llZCB3aGlsZSB3YXRjaGluZyBhIFlvdVR1YmUg dmlkZW8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 MTM5NgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAgICBXaGVu IHdhdGNoaW5nIHNvbWUgWW91VHViZSB2aWRlb3MgKG9yIGFueSB2aWRlbyB3aXRoIGRlZmF1bHQg Y29udHJvbHMpLCBldmVudCBoYW5kbGVycyBmb3IKKyAgICAgICAgdGhlICJ0aW1ldXBkYXRlIiBl dmVudCB3aGljaCB1c2UgckFGIHdpbGwgY2F1c2UgdGhlIHVuZGVybHlpbmcgcGxhdGZvcm0gb2Jq ZWN0cyB0byBiZQorICAgICAgICBkZXN0cm95ZWQgaW4gYmV0d2VlbiAidGltZXVwZGF0ZSIgZXZl bnRzIGJlaW5nIGZpcmVkLCBzaW5jZSB0aGV5IG9jY3VyIGV2ZXJ5IDI1MG1zLCBhbmQgckFGCisg ICAgICAgIG9iamVjdHMgYXJlIGRlc3Ryb3llZCBldmVyeSAxNjZtcyAob3IgMTAvNjBoeikuIFVw ZGF0ZSB0aGlzIGNvbnN0YW50IHRvIGRlc3Ryb3kgdGhlCisgICAgICAgIHVuZGVybHlpbmcgb2Jq ZWN0cyBldmVyeSAzMzNtcyAob3IgMjAvNjBoeikgc28gdGhhdCB0aGlzIGNvbW1vbiBwYXR0ZXJu IGRvZXNuJ3QgbGVhZCB0bworICAgICAgICBleGNlc3NpdmUgckFGIHBsYXRmb3JtIG9iamVjdCB0 dXJub3Zlci4KKworICAgICAgICAqIHBsYXRmb3JtL0xvZ2dpbmcuaDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3IuaDoKKyAgICAgICAgKFdlYkNvcmU6 OkRpc3BsYXlSZWZyZXNoTW9uaXRvcjo6c2hvdWxkQmVUZXJtaW5hdGVkIGNvbnN0KToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3IuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yOjpkaXNwbGF5RGlkUmVmcmVzaCk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpjcmVh dGVNb25pdG9yRm9yQ2xpZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXlSZWZyZXNoTW9u aXRvck1hbmFnZXI6OmRpc3BsYXlEaWRSZWZyZXNoKToKKwogMjAxNy0xMi0yMSAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OOiBbaU9TXSBBU1NF UlRJT04gRkFJTEVEOiAhbm9kZS5pc0Nvbm5lY3RlZCgpIGluIFdlYkNvcmU6Om5vdGlmeU5vZGVJ bnNlcnRlZEludG9Eb2N1bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v TG9nZ2luZy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCmluZGV4IGJhZDhh ZTA4OTIwZDY3OGU1YTQzMDVjZTUxYmRhYjAxNDJkMGU0NTEuLmNmNzAyMGM0ODUxMjU5MGQxZDA1 NzJkMTlhYjZhMDMzY2MwMGMzMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L0xvZ2dpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKQEAgLTc4 LDYgKzc4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIE0oUG9wdXBCbG9ja2luZykgXAog ICAgIE0oUHJvZ3Jlc3MpIFwKICAgICBNKFJlbW90ZUluc3BlY3RvcikgXAorICAgIE0oUmVxdWVz dEFuaW1hdGlvbkZyYW1lKSBcCiAgICAgTShSZXNvdXJjZUxvYWRpbmcpIFwKICAgICBNKFJlc291 cmNlTG9hZE9ic2VydmVyKSBcCiAgICAgTShSZXNvdXJjZUxvYWRTdGF0aXN0aWNzKSBcCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1v bml0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJl c2hNb25pdG9yLmNwcAppbmRleCBjOWUyMDc3ODY5NjM0NWFhZGExODU0ZDNhYjQwZmYzNzQ1YWQy YzIwLi4yMWEyZTdkZjU5MWZjMTNmNTQ4NWI5Zjc2NDE3NmNkMWNmMzBiOTYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3Iu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNo TW9uaXRvci5jcHAKQEAgLTg1LDYgKzg1LDcgQEAgdm9pZCBEaXNwbGF5UmVmcmVzaE1vbml0b3I6 OmRpc3BsYXlEaWRSZWZyZXNoKCkKIHsKICAgICB7CiAgICAgICAgIExvY2tIb2xkZXIgbG9jayht X211dGV4KTsKKyAgICAgICAgTE9HKFJlcXVlc3RBbmltYXRpb25GcmFtZSwgIkRpc3BsYXlSZWZy ZXNoTW9uaXRvcjo6ZGlzcGxheURpZFJlZnJlc2goJXApIC0gbV9zY2hlZHVsZWQoJWQpLCBtX3Vu c2NoZWR1bGVkRmlyZUNvdW50KCVkKSIsIHRoaXMsIG1fc2NoZWR1bGVkLCBtX3Vuc2NoZWR1bGVk RmlyZUNvdW50KTsKICAgICAgICAgaWYgKCFtX3NjaGVkdWxlZCkKICAgICAgICAgICAgICsrbV91 bnNjaGVkdWxlZEZpcmVDb3VudDsKICAgICAgICAgZWxzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3IuaAppbmRleCBj Y2M2MDY1ZWZhMzgxNjViNDkxYzkyZGU1ZGQ0NjhiYTAzOTM5NzNjLi4xZTcwNWMwYWM3NDdiYjBj MTRiZGFmOTAwMmFjNDE5NDNhZGZlZDAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3IuaApAQCAtNTYsNyArNTYs NyBAQCBwdWJsaWM6CiAKICAgICBib29sIHNob3VsZEJlVGVybWluYXRlZCgpIGNvbnN0CiAgICAg ewotICAgICAgICBjb25zdCBpbnQgbWF4SW5hY3RpdmVGaXJlQ291bnQgPSAxMDsKKyAgICAgICAg Y29uc3QgaW50IG1heEluYWN0aXZlRmlyZUNvdW50ID0gMjA7CiAgICAgICAgIHJldHVybiAhbV9z Y2hlZHVsZWQgJiYgbV91bnNjaGVkdWxlZEZpcmVDb3VudCA+IG1heEluYWN0aXZlRmlyZUNvdW50 OwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyLmNwcAppbmRleCA1OTRkMWYw NGFmMDUwNTBkNWYyZTk1Y2Y2Y2VjZTI1YmYxMjkwMzdjLi5mODI4ZGM1ZjY5MTllNzdjZTg4MDAx OTg5ODRiYzJlZmRjMjA4MDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyLmNwcApA QCAtMzAsNiArMzAsNyBAQAogCiAjaW5jbHVkZSAiRGlzcGxheVJlZnJlc2hNb25pdG9yLmgiCiAj aW5jbHVkZSAiRGlzcGxheVJlZnJlc2hNb25pdG9yQ2xpZW50LmgiCisjaW5jbHVkZSAiTG9nZ2lu Zy5oIgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CkBAIC01Niw2ICs1Nyw3IEBAIERpc3BsYXlSZWZyZXNoTW9uaXRvciogRGlzcGxheVJlZnJlc2hN b25pdG9yTWFuYWdlcjo6Y3JlYXRlTW9uaXRvckZvckNsaWVudChEaXNwCiAgICAgaWYgKCFtb25p dG9yKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAorICAgIExPRyhSZXF1ZXN0QW5pbWF0aW9u RnJhbWUsICJEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpjcmVhdGVNb25pdG9yRm9yQ2xp ZW50KCkgLSBjcmVhdGVkIG1vbml0b3IgJXAiLCBtb25pdG9yLmdldCgpKTsKICAgICBtb25pdG9y LT5hZGRDbGllbnQoY2xpZW50KTsKICAgICBEaXNwbGF5UmVmcmVzaE1vbml0b3IqIHJlc3VsdCA9 IG1vbml0b3IuZ2V0KCk7CiAgICAgbV9tb25pdG9ycy5hcHBlbmQoV1RGTW92ZShtb25pdG9yKSk7 CkBAIC0xMDUsNiArMTA3LDcgQEAgdm9pZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpk aXNwbGF5RGlkUmVmcmVzaChEaXNwbGF5UmVmcmVzaE1vbml0b3ImIG1vbmkKIHsKICAgICBpZiAo IW1vbml0b3Iuc2hvdWxkQmVUZXJtaW5hdGVkKCkpCiAgICAgICAgIHJldHVybjsKKyAgICBMT0co UmVxdWVzdEFuaW1hdGlvbkZyYW1lLCAiRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlcjo6ZGlz cGxheURpZFJlZnJlc2goKSAtIGRlc3Ryb3lpbmcgbW9uaXRvciAlcCIsICZtb25pdG9yKTsKIAog ICAgIHNpemVfdCBtb25pdG9ySW5kZXggPSBtX21vbml0b3JzLmZpbmQoJm1vbml0b3IpOwogICAg IGlmIChtb25pdG9ySW5kZXggIT0gbm90Rm91bmQpCg==