181384 2018-01-08 04:04:52 -0800 WebProcessPool::terminateServiceWorkerProcess should protect itself in debug builds 2018-01-08 10:37:42 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1386657 0 youennf 2018-01-08 04:04:52 -0800 Otherwise, the assertions might do some use after free errors. 1386659 1 330680 youennf 2018-01-08 04:06:25 -0800 Created attachment 330680 Patch 1386690 2 webkit-bug-importer 2018-01-08 05:24:53 -0800 <rdar://problem/36347765> 1386691 3 webkit-bug-importer 2018-01-08 05:24:54 -0800 <rdar://problem/36347764> 1386789 4 330680 cdumez 2018-01-08 10:22:23 -0800 Comment on attachment 330680 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330680&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:1461 > +#ifndef NDEBUG This looks suspicious. Why do we only need to protect |this| in debug? 1386790 5 330680 youennf 2018-01-08 10:25:26 -0800 Comment on attachment 330680 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330680&action=review >> Source/WebKit/UIProcess/WebProcessPool.cpp:1461 >> +#ifndef NDEBUG > > This looks suspicious. Why do we only need to protect |this| in debug? We only have ASSERT() after the call to requestTermination which may cause WebProcessPool to be freed. 1386797 6 330680 commit-queue 2018-01-08 10:37:41 -0800 Comment on attachment 330680 Patch Clearing flags on attachment: 330680 Committed r226519: <https://trac.webkit.org/changeset/226519> 1386798 7 commit-queue 2018-01-08 10:37:42 -0800 All reviewed patches have been landed. Closing bug. 330680 2018-01-08 04:06:25 -0800 2018-01-08 10:37:41 -0800 Patch bug-181384-20180108130623.patch text/plain 1406 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzY2Q4NjA5YmM2MzlkZGNl YjJlY2U2MDMyYjE5YjIwMGIwMDc5MzUuLjJiMmZiN2RjNjVhMTJmYjMwZWE2MDlmYWVmMjA5YjFi MWMyY2ExNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDEtMDggIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlByb2Nlc3NQb29sOjp0ZXJt aW5hdGVTZXJ2aWNlV29ya2VyUHJvY2VzcyBzaG91bGQgcHJvdGVjdCBpdHNlbGYgaW4gZGVidWcg YnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODEzODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nl c3NQb29sOjp0ZXJtaW5hdGVTZXJ2aWNlV29ya2VyUHJvY2Vzcyk6CisKIDIwMTgtMDEtMDUgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBDYWNo ZSBBUEkgcGFydGl0aW9uaW5nIGJhc2VkIG9uIENsaWVudE9yaWdpbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCmluZGV4IGJkMDZlZmM1MzFhMzc1YTc4MGYxNTg5 NWYxMGIyYWNkM2M1NGFjNzguLjk4NzY3ODg2YjI4YjI3NzczZjgxOWY5MGE4MmRlMGU3YWE2MGE2 NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKQEAgLTE0 NTgsNiArMTQ1OCw5IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnRlcm1pbmF0ZVNlcnZpY2VXb3Jr ZXJQcm9jZXNzKCkKICAgICBpZiAoIW1fc2VydmljZVdvcmtlclByb2Nlc3MpCiAgICAgICAgIHJl dHVybjsKIAorI2lmbmRlZiBOREVCVUcKKyAgICBhdXRvIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVm KCp0aGlzKTsKKyNlbmRpZgogICAgIG1fc2VydmljZVdvcmtlclByb2Nlc3MtPnJlcXVlc3RUZXJt aW5hdGlvbihQcm9jZXNzVGVybWluYXRpb25SZWFzb246OlJlcXVlc3RlZEJ5Q2xpZW50KTsKICAg ICBBU1NFUlQoIW1fcHJvY2Vzc2VzLmNvbnRhaW5zKG1fc2VydmljZVdvcmtlclByb2Nlc3MpKTsK ICAgICBBU1NFUlQoIW1fc2VydmljZVdvcmtlclByb2Nlc3MpOwo=