181363 2018-01-06 04:05:02 -0800 Use WeakPtr for RenderTreePosition::m_nextSibling 2018-01-06 13:02:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1386480 0 koivisto 2018-01-06 04:05:02 -0800 For safety. 1386481 1 330637 koivisto 2018-01-06 04:09:38 -0800 Created attachment 330637 patch 1386496 2 330637 zalan 2018-01-06 08:14:17 -0800 Comment on attachment 330637 patch View in context: https://bugs.webkit.org/attachment.cgi?id=330637&action=review > Source/WebCore/rendering/updating/RenderTreePosition.h:60 > + WeakPtr<RenderObject> m_nextSibling { nullptr }; { nullptr } is not really needed here. 1386509 3 330637 commit-queue 2018-01-06 13:01:23 -0800 Comment on attachment 330637 patch Clearing flags on attachment: 330637 Committed r226488: <https://trac.webkit.org/changeset/226488> 1386510 4 commit-queue 2018-01-06 13:01:24 -0800 All reviewed patches have been landed. Closing bug. 1386511 5 webkit-bug-importer 2018-01-06 13:02:52 -0800 <rdar://problem/36336120> 330637 2018-01-06 04:09:38 -0800 2018-01-06 13:01:23 -0800 patch nextsibling-weak.patch text/plain 2631 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNjQ4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAxLTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgV2Vha1B0ciBmb3IgUmVu ZGVyVHJlZVBvc2l0aW9uOjptX25leHRTaWJsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODEzNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGb3Igc2FmZXR5LiBJbiBtb3N0IGNhc2VzIGl0IGlzIG51 bGwgYW5kIHdvbid0IGNhdXNlIHVzIHRvIGluc3RhbnRpYXRlIFdlYWtSZWZlcmVuY2VzIGZvcgor ICAgICAgICBtYW55IG5ldyBvYmplY3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5n L1JlbmRlclRyZWVQb3NpdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUcmVlUG9z aXRpb246OmNvbXB1dGVOZXh0U2libGluZyk6CisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5n L1JlbmRlclRyZWVQb3NpdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVHJlZVBvc2l0 aW9uOjpSZW5kZXJUcmVlUG9zaXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVHJlZVBv c2l0aW9uOjpuZXh0U2libGluZyBjb25zdCk6CisKIDIwMTgtMDEtMDUgIERhdmlkIEtpbHplciAg PGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZS1lbmFibGUgLVdjYXN0LXF1YWwgaW4g V2ViQ29yZSBmb3IgQXBwbGUgcG9ydHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91 cGRhdGluZy9SZW5kZXJUcmVlUG9zaXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlUG9zaXRpb24uY3BwCShyZXZpc2lvbiAy MjYyMjcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZVBv c2l0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDUsNyArNDUsNyBAQCB2b2lkIFJlbmRlclRy ZWVQb3NpdGlvbjo6Y29tcHV0ZU5leHRTaWJsCiAjZW5kaWYKICAgICAgICAgcmV0dXJuOwogICAg IH0KLSAgICBtX25leHRTaWJsaW5nID0gbmV4dFNpYmxpbmdSZW5kZXJlcihub2RlKTsKKyAgICBt X25leHRTaWJsaW5nID0gbWFrZVdlYWtQdHIobmV4dFNpYmxpbmdSZW5kZXJlcihub2RlKSk7CiAg ICAgbV9oYXNWYWxpZE5leHRTaWJsaW5nID0gdHJ1ZTsKIH0KIApJbmRleDogU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVQb3NpdGlvbi5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlUG9zaXRpb24uaAko cmV2aXNpb24gMjI2MjI3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1Jl bmRlclRyZWVQb3NpdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCwxMyArNDAsMTMgQEAgcHVi bGljOgogICAgIH0KICAgICBSZW5kZXJUcmVlUG9zaXRpb24oUmVuZGVyRWxlbWVudCYgcGFyZW50 LCBSZW5kZXJPYmplY3QqIG5leHRTaWJsaW5nKQogICAgICAgICA6IG1fcGFyZW50KHBhcmVudCkK LSAgICAgICAgLCBtX25leHRTaWJsaW5nKG5leHRTaWJsaW5nKQorICAgICAgICAsIG1fbmV4dFNp YmxpbmcobWFrZVdlYWtQdHIobmV4dFNpYmxpbmcpKQogICAgICAgICAsIG1faGFzVmFsaWROZXh0 U2libGluZyh0cnVlKQogICAgIHsKICAgICB9CiAKICAgICBSZW5kZXJFbGVtZW50JiBwYXJlbnQo KSBjb25zdCB7IHJldHVybiBtX3BhcmVudDsgfQotICAgIFJlbmRlck9iamVjdCogbmV4dFNpYmxp bmcoKSBjb25zdCB7IEFTU0VSVChtX2hhc1ZhbGlkTmV4dFNpYmxpbmcpOyByZXR1cm4gbV9uZXh0 U2libGluZzsgfQorICAgIFJlbmRlck9iamVjdCogbmV4dFNpYmxpbmcoKSBjb25zdCB7IEFTU0VS VChtX2hhc1ZhbGlkTmV4dFNpYmxpbmcpOyByZXR1cm4gbV9uZXh0U2libGluZy5nZXQoKTsgfQog CiAgICAgdm9pZCBjb21wdXRlTmV4dFNpYmxpbmcoY29uc3QgTm9kZSYpOwogICAgIHZvaWQgbW92 ZVRvTGFzdENoaWxkKCk7CkBAIC01Nyw3ICs1Nyw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAg ICBSZW5kZXJFbGVtZW50JiBtX3BhcmVudDsKLSAgICBSZW5kZXJPYmplY3QqIG1fbmV4dFNpYmxp bmcgeyBudWxscHRyIH07CisgICAgV2Vha1B0cjxSZW5kZXJPYmplY3Q+IG1fbmV4dFNpYmxpbmcg eyBudWxscHRyIH07CiAgICAgYm9vbCBtX2hhc1ZhbGlkTmV4dFNpYmxpbmcgeyBmYWxzZSB9Owog I2lmICFBU1NFUlRfRElTQUJMRUQKICAgICB1bnNpZ25lZCBtX2Fzc2VydGlvbkxpbWl0Q291bnRl ciB7IDAgfTsK