181324 2018-01-05 02:36:17 -0800 REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources 2018-01-05 03:12:38 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen annulen bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1386099 0 fujii 2018-01-05 02:36:17 -0800 Bug 180921 changes to use cmake -E copy to copy header files of DerivedSources. This command copies files unconditionally, then introduced unnecessary recompilations. cmake -E copy_if_different should be used. 1386100 1 330543 fujii 2018-01-05 02:40:04 -0800 Created attachment 330543 Patch 1386107 2 330543 commit-queue 2018-01-05 03:11:47 -0800 Comment on attachment 330543 Patch Clearing flags on attachment: 330543 Committed r226442: <https://trac.webkit.org/changeset/226442> 1386108 3 commit-queue 2018-01-05 03:11:49 -0800 All reviewed patches have been landed. Closing bug. 1386109 4 webkit-bug-importer 2018-01-05 03:12:38 -0800 <rdar://problem/36316638> 330543 2018-01-05 02:40:04 -0800 2018-01-05 03:11:47 -0800 Patch bug-181324-20180105194003.patch text/plain 1885 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2NDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQppbmRleCBm MDk4MWViNmFjZTZiOGRkYzFmYzRhY2U3ZmI1Mzg0ZmUwYzM5NGQwLi43ZTY5NTU3YzAxYjlmMjhl MzZiNmY3OGI2YWZlYzI0ZDA2ZGY2YjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTI3 Myw3ICsyNzMsNyBAQCBmdW5jdGlvbihXRUJLSVRfTUFLRV9GT1JXQVJESU5HX0hFQURFUlMgZnJh bWV3b3JrKQogICAgICAgICAgICAgICAgICJmaWxlKEdMT0IgaGVhZGVycyBcIiR7ZGlyfS8qLmhc IilcbiIKICAgICAgICAgICAgICAgICAiZm9yZWFjaCAoaGVhZGVyIElOIExJU1RTIGhlYWRlcnMp XG4iCiAgICAgICAgICAgICAgICAgIiAgICBnZXRfZmlsZW5hbWVfY29tcG9uZW50KGhlYWRlcl9m aWxlbmFtZSBcJHtoZWFkZXJ9IE5BTUUpXG4iCi0gICAgICAgICAgICAgICAgIiAgICBleGVjdXRl X3Byb2Nlc3MoQ09NTUFORCBcJHtDTUFLRV9DT01NQU5EfSAtRSBjb3B5IFwke2hlYWRlcn0gJHtk ZXN0aW5hdGlvbn0vXCR7aGVhZGVyX2ZpbGVuYW1lfSBSRVNVTFRfVkFSSUFCTEUgcmVzdWx0KVxu IgorICAgICAgICAgICAgICAgICIgICAgZXhlY3V0ZV9wcm9jZXNzKENPTU1BTkQgXCR7Q01BS0Vf Q09NTUFORH0gLUUgY29weV9pZl9kaWZmZXJlbnQgXCR7aGVhZGVyfSAke2Rlc3RpbmF0aW9ufS9c JHtoZWFkZXJfZmlsZW5hbWV9IFJFU1VMVF9WQVJJQUJMRSByZXN1bHQpXG4iCiAgICAgICAgICAg ICAgICAgIiAgICBpZiAoTk9UIFwke3Jlc3VsdH0gRVFVQUwgMClcbiIKICAgICAgICAgICAgICAg ICAiICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SIFwiRmFpbGVkIHRvIGNvcHkgXCR7aGVhZGVy fTogXCR7cmVzdWx0fVwiKVxuIgogICAgICAgICAgICAgICAgICIgICAgZW5kaWYgKClcbiIKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhNTkyYzRjOGJkYWY4YTY2ZDQy MzM5MzQ3OGU3YzEzYzQxYzllNzBiLi41YWVhMjdlYjNjODQzNjE2NTBhOTY2OGZkM2JkMjMwZTk2 NzQxMzlmIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTgtMDEtMDUgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjI2MzA2KVtXaW5dW0NNYWtlXSBVbm5lY2Vzc2Fy eSByZWNvbXBpbGF0aW9ucyB0cmlnZ2VyZWQgYnkgdW5jb25kaXRpb25hbGx5IGNvcGllZCBoZWFk ZXIgZmlsZXMgb2YgRGVyaXZlZFNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MTMyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIHIyMjYzMDYgY2hhbmdlZCB0byB1c2UgY21ha2UgLUUgY29weSB0 byBjb3B5IGhlYWRlciBmaWxlcyBvZgorICAgICAgICBEZXJpdmVkU291cmNlcy4gVGhpcyBjb21t YW5kIGNvcGllcyBmaWxlcyB1bmNvbmRpdGlvbmFsbHksIHRoZW4KKyAgICAgICAgaW50cm9kdWNl ZCB1bm5lY2Vzc2FyeSByZWNvbXBpbGF0aW9ucy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9X ZWJLaXRNYWNyb3MuY21ha2U6IFVzZSBjb3B5X2lmX2RpZmZlcmVudCBpbnN0ZWFkIG9mIGNvcHku CisKIDIwMTgtMDEtMDMgIFRpbmctV2VpIExhbiAgPGxhbnR3NDRAZ21haWwuY29tPgogCiAgICAg ICAgIFJlcGxhY2UgaGFyZC1jb2RlZCBwYXRocyBpbiBzaGViYW5ncyB3aXRoICMhL3Vzci9iaW4v ZW52Cg==