181316 2018-01-04 20:36:44 -0800 SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded() should do nothing if the property is not animating 2018-01-05 12:10:50 -0800 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue simon.fraser thorton webkit-bug-importer zalan zimmermann oldest_to_newest 1386036 0 sabouhallawa 2018-01-04 20:36:44 -0800 If SVGAnimatedListPropertyTearOff is not animating this means its m_animatedProperty is null. In this case SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded() should do nothing. Otherwise a crash will happen. SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded() can now be called from SVGAnimatedTypeAnimator::resetFromBaseValue() and a very intermittent crash with the following call stack was recorded: WebCore::SVGListProperty<WebCore::SVGTransformListValues>::values() WebCore::SVGAnimatedListPropertyTearOff<WebCore::SVGTransformListValues>::synchronizeWrappersIfNeeded() WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue<WebCore::SVGAnimatedTransformListPropertyTearOff>() WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal() WebCore::SVGAnimateElementBase::resetAnimatedType() The crash was happening because SVGAnimatedListPropertyTearOff::m_animatedProperty is null. 1386037 1 sabouhallawa 2018-01-04 20:40:03 -0800 <rdar://problem/36147545> 1386038 2 330518 sabouhallawa 2018-01-04 20:40:54 -0800 Created attachment 330518 Patch 1386170 3 330556 sabouhallawa 2018-01-05 10:27:16 -0800 Created attachment 330556 Patch 1386172 4 330556 simon.fraser 2018-01-05 10:31:00 -0800 Comment on attachment 330556 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330556&action=review > Source/WebCore/ChangeLog:9 > + This is a speculative change to fix a crash which appeared after r226065. This should say why there is no testcase. > Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:147 > ASSERT(isAnimating()); > + if (!isAnimating()) We normally avoid patterns like this. If you think the assert and the if() are both needed, then add a comment saying "this should never happen, but we've seen it in the field. Please comment in bug ### i you hit this" or something. 1386180 5 330559 sabouhallawa 2018-01-05 11:05:15 -0800 Created attachment 330559 Patch 1386211 6 330559 commit-queue 2018-01-05 12:10:48 -0800 Comment on attachment 330559 Patch Clearing flags on attachment: 330559 Committed r226457: <https://trac.webkit.org/changeset/226457> 1386212 7 commit-queue 2018-01-05 12:10:50 -0800 All reviewed patches have been landed. Closing bug. 330518 2018-01-04 20:40:54 -0800 2018-01-05 10:27:15 -0800 Patch bug-181316-20180104204053.patch text/plain 1717 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMxMzZlODA3YjY5NzNm YWViYzQ3M2IwNjNiODU1NTRlMmFiZTk5Mi4uMjNkZWUxYmUyNTA0OTRiN2U0YmQ2YWYwYWU2ZWM3 YzI3MjhmYTZjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAxLTA0ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgU1ZHQW5p bWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmOjpzeW5jaHJvbml6ZVdyYXBwZXJzSWZOZWVkZWQoKSBz aG91bGQgZG8gbm90aGluZyBpZiB0aGUgcHJvcGVydHkgaXMgbm90IGFuaW1hdGluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMzE2CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zNjE0NzU0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4IGZvciBhIGNyYXNo IHdoaWNoIGhhcHBlbmVkIGFmdGVyIHIyMjYwNjUuCisKKyAgICAgICAgKiBzdmcvcHJvcGVydGll cy9TVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNW R0FuaW1hdGVkTGlzdFByb3BlcnR5VGVhck9mZjo6c3luY2hyb25pemVXcmFwcGVyc0lmTmVlZGVk KToKKwogMjAxOC0wMS0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgTWFrZSBNZXNzYWdlUG9ydENoYW5uZWw6OnRha2VBbGxNZXNzYWdlc0Zyb21SZW1vdGUg YXN5bmNocm9ub3VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL3Byb3BlcnRpZXMv U1ZHQW5pbWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmLmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJv cGVydGllcy9TVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaAppbmRleCBkNmM0ZTVkZWU4 OWVjZTJjZGEwMzgwZDE1MGJmMzU2NWU1YjY0N2UxLi42MzYzMDNkZTllMWU3NTg0MDZlYjBmNDQ4 Yjc1MzFmM2U4N2ExOWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGll cy9TVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9z dmcvcHJvcGVydGllcy9TVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaApAQCAtMTQ0LDYg KzE0NCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHN5bmNocm9uaXplV3JhcHBlcnNJZk5lZWRlZCgp CiAgICAgewogICAgICAgICBBU1NFUlQoaXNBbmltYXRpbmcoKSk7CisgICAgICAgIGlmICghaXNB bmltYXRpbmcoKSkKKyAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAvLyBFdmVudHVhbGx5 IHRoZSB3cmFwcGVyIGxpc3QgbmVlZHMgc3luY2hyb25pemF0aW9uIGJlY2F1c2UgYW55IFNWR0Fu aW1hdGVMZW5ndGhMaXN0OjpjYWxjdWxhdGVBbmltYXRlZFZhbHVlKCkgY2FsbCBtYXkKICAgICAg ICAgLy8gbXV0YXRlIHRoZSBsZW5ndGggb2Ygb3VyIHZhbHVlcygpIGxpc3QsIGFuZCB0aHVzIHRo ZSB3cmFwcGVyKCkgY2FjaGUgbmVlZHMgc3luY2hyb25pemF0aW9uLCB0byBoYXZlIHRoZSBzYW1l IHNpemUuCg== 330556 2018-01-05 10:27:16 -0800 2018-01-05 11:05:14 -0800 Patch bug-181316-20180105102716.patch text/plain 3592 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMxMzZlODA3YjY5NzNm YWViYzQ3M2IwNjNiODU1NTRlMmFiZTk5Mi4uMGY4OWVlYjFhZmYxYTNjZmU4NmY3NmNhNzkwYjEw ZGYzODQxZjk1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTAxLTA1ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgU1ZHQW5p bWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmOjpzeW5jaHJvbml6ZVdyYXBwZXJzSWZOZWVkZWQoKSBz aG91bGQgZG8gbm90aGluZyBpZiB0aGUgcHJvcGVydHkgaXMgbm90IGFuaW1hdGluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMzE2CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zNjE0NzU0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgc3BlY3VsYXRpdmUgY2hhbmdlIHRvIGZpeCBh IGNyYXNoIHdoaWNoIGFwcGVhcmVkIGFmdGVyIHIyMjYwNjUuCisKKyAgICAgICAgKiBzdmcvU1ZH QW5pbWF0ZWRUeXBlQW5pbWF0b3IuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0FuaW1hdGVkVHlw ZUFuaW1hdG9yOjpyZXNldEZyb21CYXNlVmFsdWVzKTogRm9yIFNWRyBwcm9wZXJ0eQorICAgICAg ICB3aXRoIHR3byB2YWx1ZXMsIGUuZy4gPFNWR0FuZ2xlVmFsdWUsIFNWR01hcmtlck9yaWVudFR5 cGU+LCAgd2UgbmVlZCB0bworICAgICAgICBkZXRhY2ggdGhlIHdyYXBwZXJzIG9mIHRoZSBhbmlt YXRlZCBwcm9wZXJ0eSBpZiB0aGUgYW5pbWF0ZWQgdmFsdWUgaXMgZ29pbmcKKyAgICAgICAgdG8g Y2hhbmdlLgorCisgICAgICAgICogc3ZnL3Byb3BlcnRpZXMvU1ZHQW5pbWF0ZWRMaXN0UHJvcGVy dHlUZWFyT2ZmLmg6CisgICAgICAgIChXZWJDb3JlOjpTVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRl YXJPZmY6OnN5bmNocm9uaXplV3JhcHBlcnNJZk5lZWRlZCk6CisKIDIwMTgtMDEtMDIgIEJyYWR5 IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgTWVzc2FnZVBvcnRD aGFubmVsOjp0YWtlQWxsTWVzc2FnZXNGcm9tUmVtb3RlIGFzeW5jaHJvbm91cy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdBbmltYXRlZFR5cGVBbmltYXRvci5oIGIvU291cmNl L1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGVkVHlwZUFuaW1hdG9yLmgKaW5kZXggYThiMDk3Y2M3NTA2 ZGJhZDllNmRjMmNkZGNjN2M4ZDEzY2M0ZmYwOC4uNzRlOWFhODIwMDQ1NjQwMTg0YzhhNGEzNmJl NWNiNDc5NjI5MzNkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGVk VHlwZUFuaW1hdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGVkVHlwZUFu aW1hdG9yLmgKQEAgLTEyNywxMCArMTI3LDE0IEBAIHByb3RlY3RlZDoKICAgICB7CiAgICAgICAg IEFTU0VSVChhbmltYXRlZFR5cGVzWzBdLnByb3BlcnRpZXMuc2l6ZSgpID09IDIpOwogICAgICAg ICBBU1NFUlQodHlwZS50eXBlKCkgPT0gbV90eXBlKTsKKyAgICAgICAgYXV0byogZmlyc3RQcm9w ZXJ0eSA9IGNhc3RBbmltYXRlZFByb3BlcnR5VG9BY3R1YWxUeXBlPEFuaW1WYWxUeXBlMT4oYW5p bWF0ZWRUeXBlc1swXS5wcm9wZXJ0aWVzWzBdLmdldCgpKTsKKyAgICAgICAgYXV0byogc2Vjb25k UHJvcGVydHkgPSAgY2FzdEFuaW1hdGVkUHJvcGVydHlUb0FjdHVhbFR5cGU8QW5pbVZhbFR5cGUy PihhbmltYXRlZFR5cGVzWzBdLnByb3BlcnRpZXNbMV0uZ2V0KCkpOworICAgICAgICBmaXJzdFBy b3BlcnR5LT5zeW5jaHJvbml6ZVdyYXBwZXJzSWZOZWVkZWQoKTsKKyAgICAgICAgc2Vjb25kUHJv cGVydHktPnN5bmNocm9uaXplV3JhcHBlcnNJZk5lZWRlZCgpOwogCiAgICAgICAgIHN0ZDo6cGFp cjx0eXBlbmFtZSBBbmltVmFsVHlwZTE6OkNvbnRlbnRUeXBlLCB0eXBlbmFtZSBBbmltVmFsVHlw ZTI6OkNvbnRlbnRUeXBlPiYgYW5pbWF0ZWRUeXBlVmFsdWUgPSAodHlwZS4qZ2V0dGVyKSgpOwot ICAgICAgICBhbmltYXRlZFR5cGVWYWx1ZS5maXJzdCA9IGNhc3RBbmltYXRlZFByb3BlcnR5VG9B Y3R1YWxUeXBlPEFuaW1WYWxUeXBlMT4oYW5pbWF0ZWRUeXBlc1swXS5wcm9wZXJ0aWVzWzBdLmdl dCgpKS0+Y3VycmVudEJhc2VWYWx1ZSgpOwotICAgICAgICBhbmltYXRlZFR5cGVWYWx1ZS5zZWNv bmQgPSBjYXN0QW5pbWF0ZWRQcm9wZXJ0eVRvQWN0dWFsVHlwZTxBbmltVmFsVHlwZTI+KGFuaW1h dGVkVHlwZXNbMF0ucHJvcGVydGllc1sxXS5nZXQoKSktPmN1cnJlbnRCYXNlVmFsdWUoKTsKKyAg ICAgICAgYW5pbWF0ZWRUeXBlVmFsdWUuZmlyc3QgPSBmaXJzdFByb3BlcnR5LT5jdXJyZW50QmFz ZVZhbHVlKCk7CisgICAgICAgIGFuaW1hdGVkVHlwZVZhbHVlLnNlY29uZCA9IHNlY29uZFByb3Bl cnR5LT5jdXJyZW50QmFzZVZhbHVlKCk7CiAKICAgICAgICAgZXhlY3V0ZUFjdGlvbjxBbmltVmFs VHlwZTE+KFN0YXJ0QW5pbWF0aW9uQWN0aW9uLCBhbmltYXRlZFR5cGVzLCAwLCAmYW5pbWF0ZWRU eXBlVmFsdWUuZmlyc3QpOwogICAgICAgICBleGVjdXRlQWN0aW9uPEFuaW1WYWxUeXBlMj4oU3Rh cnRBbmltYXRpb25BY3Rpb24sIGFuaW1hdGVkVHlwZXMsIDEsICZhbmltYXRlZFR5cGVWYWx1ZS5z ZWNvbmQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL3Byb3BlcnRpZXMvU1ZHQW5p bWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmLmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGll cy9TVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaAppbmRleCBkNmM0ZTVkZWU4OWVjZTJj ZGEwMzgwZDE1MGJmMzU2NWU1YjY0N2UxLi42MzYzMDNkZTllMWU3NTg0MDZlYjBmNDQ4Yjc1MzFm M2U4N2ExOWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGllcy9TVkdB bmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJv cGVydGllcy9TVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaApAQCAtMTQ0LDYgKzE0NCw4 IEBAIHB1YmxpYzoKICAgICB2b2lkIHN5bmNocm9uaXplV3JhcHBlcnNJZk5lZWRlZCgpCiAgICAg ewogICAgICAgICBBU1NFUlQoaXNBbmltYXRpbmcoKSk7CisgICAgICAgIGlmICghaXNBbmltYXRp bmcoKSkKKyAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAvLyBFdmVudHVhbGx5IHRoZSB3 cmFwcGVyIGxpc3QgbmVlZHMgc3luY2hyb25pemF0aW9uIGJlY2F1c2UgYW55IFNWR0FuaW1hdGVM ZW5ndGhMaXN0OjpjYWxjdWxhdGVBbmltYXRlZFZhbHVlKCkgY2FsbCBtYXkKICAgICAgICAgLy8g bXV0YXRlIHRoZSBsZW5ndGggb2Ygb3VyIHZhbHVlcygpIGxpc3QsIGFuZCB0aHVzIHRoZSB3cmFw cGVyKCkgY2FjaGUgbmVlZHMgc3luY2hyb25pemF0aW9uLCB0byBoYXZlIHRoZSBzYW1lIHNpemUu Cg== 330559 2018-01-05 11:05:15 -0800 2018-01-05 12:10:48 -0800 Patch bug-181316-20180105110515.patch text/plain 3976 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMxMzZlODA3YjY5NzNm YWViYzQ3M2IwNjNiODU1NTRlMmFiZTk5Mi4uZTFmNWIxZmNhZGIyN2RjMTBkZjM4OGQ2NDM0ZTIw YTFjNDJlMTZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTAxLTA1ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgU1ZHQW5p bWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmOjpzeW5jaHJvbml6ZVdyYXBwZXJzSWZOZWVkZWQoKSBz aG91bGQgZG8gbm90aGluZyBpZiB0aGUgcHJvcGVydHkgaXMgbm90IGFuaW1hdGluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMzE2CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zNjE0NzU0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBG cmFzZXIuCisKKyAgICAgICAgVGhpcyBpcyBhIHNwZWN1bGF0aXZlIGNoYW5nZSB0byBmaXggYSBj cmFzaCB3aGljaCBhcHBlYXJlZCBhZnRlciByMjI2MDY1LgorICAgICAgICBUaGUgY3Jhc2ggaXMg dmVyeSBpbnRlcm1pdHRlbnQgYW5kIHNvbWV0aW1lcyB2ZXJ5IGhhcmQgdG8gcmVwcm9kdWNlLiBU aGUKKyAgICAgICAgYmFzaWMgY29kZSBhbmFseXNpcyBkaWQgbm90IHNob3cgaG93IHRoaXMgY3Jh c2ggY2FuIGV2ZW4gaGFwcGVuLgorCisgICAgICAgICogc3ZnL1NWR0FuaW1hdGVkVHlwZUFuaW1h dG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpTVkdBbmltYXRlZFR5cGVBbmltYXRvcjo6cmVzZXRG cm9tQmFzZVZhbHVlcyk6IEZvciBTVkcgcHJvcGVydHkKKyAgICAgICAgd2l0aCB0d28gdmFsdWVz LCBlLmcuIDxTVkdBbmdsZVZhbHVlLCBTVkdNYXJrZXJPcmllbnRUeXBlPiwgIHdlIG5lZWQgdG8K KyAgICAgICAgZGV0YWNoIHRoZSB3cmFwcGVycyBvZiB0aGUgYW5pbWF0ZWQgcHJvcGVydHkgaWYg dGhlIGFuaW1hdGVkIHZhbHVlcyBhcmUKKyAgICAgICAgZ29pbmcgdG8gY2hhbmdlLiBUaGlzIGlz IHNpbWlsYXIgdG8gd2hhdCB3ZSBkaWQgaW4gcmVzZXRGcm9tQmFzZVZhbHVlKCkuCisKKyAgICAg ICAgKiBzdmcvcHJvcGVydGllcy9TVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaDoKKyAg ICAgICAgKFdlYkNvcmU6OlNWR0FuaW1hdGVkTGlzdFByb3BlcnR5VGVhck9mZjo6c3luY2hyb25p emVXcmFwcGVyc0lmTmVlZGVkKToKKwogMjAxOC0wMS0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNv bkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBNZXNzYWdlUG9ydENoYW5uZWw6OnRha2VBbGxN ZXNzYWdlc0Zyb21SZW1vdGUgYXN5bmNocm9ub3VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvc3ZnL1NWR0FuaW1hdGVkVHlwZUFuaW1hdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZH QW5pbWF0ZWRUeXBlQW5pbWF0b3IuaAppbmRleCBhOGIwOTdjYzc1MDZkYmFkOWU2ZGMyY2RkY2M3 YzhkMTNjYzRmZjA4Li43NGU5YWE4MjAwNDU2NDAxODRjOGE0YTM2YmU1Y2I0Nzk2MjkzM2Q1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0ZWRUeXBlQW5pbWF0b3IuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0ZWRUeXBlQW5pbWF0b3IuaApAQCAtMTI3 LDEwICsxMjcsMTQgQEAgcHJvdGVjdGVkOgogICAgIHsKICAgICAgICAgQVNTRVJUKGFuaW1hdGVk VHlwZXNbMF0ucHJvcGVydGllcy5zaXplKCkgPT0gMik7CiAgICAgICAgIEFTU0VSVCh0eXBlLnR5 cGUoKSA9PSBtX3R5cGUpOworICAgICAgICBhdXRvKiBmaXJzdFByb3BlcnR5ID0gY2FzdEFuaW1h dGVkUHJvcGVydHlUb0FjdHVhbFR5cGU8QW5pbVZhbFR5cGUxPihhbmltYXRlZFR5cGVzWzBdLnBy b3BlcnRpZXNbMF0uZ2V0KCkpOworICAgICAgICBhdXRvKiBzZWNvbmRQcm9wZXJ0eSA9ICBjYXN0 QW5pbWF0ZWRQcm9wZXJ0eVRvQWN0dWFsVHlwZTxBbmltVmFsVHlwZTI+KGFuaW1hdGVkVHlwZXNb MF0ucHJvcGVydGllc1sxXS5nZXQoKSk7CisgICAgICAgIGZpcnN0UHJvcGVydHktPnN5bmNocm9u aXplV3JhcHBlcnNJZk5lZWRlZCgpOworICAgICAgICBzZWNvbmRQcm9wZXJ0eS0+c3luY2hyb25p emVXcmFwcGVyc0lmTmVlZGVkKCk7CiAKICAgICAgICAgc3RkOjpwYWlyPHR5cGVuYW1lIEFuaW1W YWxUeXBlMTo6Q29udGVudFR5cGUsIHR5cGVuYW1lIEFuaW1WYWxUeXBlMjo6Q29udGVudFR5cGU+ JiBhbmltYXRlZFR5cGVWYWx1ZSA9ICh0eXBlLipnZXR0ZXIpKCk7Ci0gICAgICAgIGFuaW1hdGVk VHlwZVZhbHVlLmZpcnN0ID0gY2FzdEFuaW1hdGVkUHJvcGVydHlUb0FjdHVhbFR5cGU8QW5pbVZh bFR5cGUxPihhbmltYXRlZFR5cGVzWzBdLnByb3BlcnRpZXNbMF0uZ2V0KCkpLT5jdXJyZW50QmFz ZVZhbHVlKCk7Ci0gICAgICAgIGFuaW1hdGVkVHlwZVZhbHVlLnNlY29uZCA9IGNhc3RBbmltYXRl ZFByb3BlcnR5VG9BY3R1YWxUeXBlPEFuaW1WYWxUeXBlMj4oYW5pbWF0ZWRUeXBlc1swXS5wcm9w ZXJ0aWVzWzFdLmdldCgpKS0+Y3VycmVudEJhc2VWYWx1ZSgpOworICAgICAgICBhbmltYXRlZFR5 cGVWYWx1ZS5maXJzdCA9IGZpcnN0UHJvcGVydHktPmN1cnJlbnRCYXNlVmFsdWUoKTsKKyAgICAg ICAgYW5pbWF0ZWRUeXBlVmFsdWUuc2Vjb25kID0gc2Vjb25kUHJvcGVydHktPmN1cnJlbnRCYXNl VmFsdWUoKTsKIAogICAgICAgICBleGVjdXRlQWN0aW9uPEFuaW1WYWxUeXBlMT4oU3RhcnRBbmlt YXRpb25BY3Rpb24sIGFuaW1hdGVkVHlwZXMsIDAsICZhbmltYXRlZFR5cGVWYWx1ZS5maXJzdCk7 CiAgICAgICAgIGV4ZWN1dGVBY3Rpb248QW5pbVZhbFR5cGUyPihTdGFydEFuaW1hdGlvbkFjdGlv biwgYW5pbWF0ZWRUeXBlcywgMSwgJmFuaW1hdGVkVHlwZVZhbHVlLnNlY29uZCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGllcy9TVkdBbmltYXRlZExpc3RQcm9wZXJ0 eVRlYXJPZmYuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR0FuaW1hdGVkTGlz dFByb3BlcnR5VGVhck9mZi5oCmluZGV4IGQ2YzRlNWRlZTg5ZWNlMmNkYTAzODBkMTUwYmYzNTY1 ZTViNjQ3ZTEuLjdjMjAyMDU3YTJlNWEwZDEwN2E4YWM5MDIwMWU2NDA5MjI1NzJkNjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR0FuaW1hdGVkTGlzdFByb3Bl cnR5VGVhck9mZi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR0FuaW1h dGVkTGlzdFByb3BlcnR5VGVhck9mZi5oCkBAIC0xNDMsNyArMTQzLDExIEBAIHB1YmxpYzoKIAog ICAgIHZvaWQgc3luY2hyb25pemVXcmFwcGVyc0lmTmVlZGVkKCkKICAgICB7Ci0gICAgICAgIEFT U0VSVChpc0FuaW1hdGluZygpKTsKKyAgICAgICAgaWYgKCFpc0FuaW1hdGluZygpKSB7CisgICAg ICAgICAgICAvLyBUaGlzIHNob3VsZCBuZXZlciBoYXBwZW4sIGJ1dCB3ZSd2ZSBzZWVuIGl0IGlu IHRoZSBmaWVsZC4gUGxlYXNlIGNvbW1lbnQgaW4gYnVnICMxODEzMTYgaWYgeW91IGhpdCB0aGlz LgorICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIH0KIAogICAgICAgICAvLyBFdmVudHVhbGx5IHRoZSB3cmFwcGVyIGxpc3QgbmVl ZHMgc3luY2hyb25pemF0aW9uIGJlY2F1c2UgYW55IFNWR0FuaW1hdGVMZW5ndGhMaXN0OjpjYWxj dWxhdGVBbmltYXRlZFZhbHVlKCkgY2FsbCBtYXkKICAgICAgICAgLy8gbXV0YXRlIHRoZSBsZW5n dGggb2Ygb3VyIHZhbHVlcygpIGxpc3QsIGFuZCB0aHVzIHRoZSB3cmFwcGVyKCkgY2FjaGUgbmVl ZHMgc3luY2hyb25pemF0aW9uLCB0byBoYXZlIHRoZSBzYW1lIHNpemUuCg==