<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>181296</bug_id>
          
          <creation_ts>2018-01-04 10:47:35 -0800</creation_ts>
          <short_desc>Add a new pattern matching rule to Graph::methodOfGettingAValueProfileFor for SetLocal(@nodeWithHeapPrediction)</short_desc>
          <delta_ts>2018-01-04 16:05:55 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1385851</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-01-04 10:47:35 -0800</bug_when>
    <thetext>Often they&apos;ll be from the same origin, so they don&apos;t fall into the normal loop that checks nodes from different origins. Speedometer has a lot of:

```
a:GetByVal(..., originX)
SetLocal(Cell:@a, locY, originX)
```

Where Cell:@a fails a lot. In such a case, it makes sense to update the value profile for the GetByVal.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385863</commentid>
    <comment_count>1</comment_count>
      <attachid>330476</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-01-04 11:41:14 -0800</bug_when>
    <thetext>Created attachment 330476
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385884</commentid>
    <comment_count>2</comment_count>
      <attachid>330479</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-01-04 12:33:34 -0800</bug_when>
    <thetext>Created attachment 330479
patch for landing

Made a slight change from the patch pizlo reviewed. Will wait for his thumbs up before landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385885</commentid>
    <comment_count>3</comment_count>
      <attachid>330480</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-01-04 12:34:36 -0800</bug_when>
    <thetext>Created attachment 330480
patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385886</commentid>
    <comment_count>4</comment_count>
      <attachid>330481</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-01-04 12:35:19 -0800</bug_when>
    <thetext>Created attachment 330481
patch for landing

Just fixing style stuff</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385964</commentid>
    <comment_count>5</comment_count>
      <attachid>330481</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2018-01-04 15:34:59 -0800</bug_when>
    <thetext>Comment on attachment 330481
patch for landing

still lgtm</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385978</commentid>
    <comment_count>6</comment_count>
      <attachid>330481</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-04 16:01:37 -0800</bug_when>
    <thetext>Comment on attachment 330481
patch for landing

Clearing flags on attachment: 330481

Committed r226426: &lt;https://trac.webkit.org/changeset/226426&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385979</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-01-04 16:01:38 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385980</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-01-04 16:05:55 -0800</bug_when>
    <thetext>&lt;rdar://problem/36308599&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>330476</attachid>
            <date>2018-01-04 11:41:14 -0800</date>
            <delta_ts>2018-01-04 12:33:34 -0800</delta_ts>
            <desc>patch</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>3353</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2NDExKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA
CisyMDE4LTAxLTA0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IEFkZCBhIG5ldyBwYXR0ZXJuIG1hdGNoaW5nIHJ1bGUgdG8gR3JhcGg6Om1ldGhvZE9mR2V0dGlu
Z0FWYWx1ZVByb2ZpbGVGb3IgZm9yIFNldExvY2FsKEBub2RlV2l0aEhlYXBQcmVkaWN0aW9uKQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMjk2CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zaWRlIFNw
ZWVkb21ldGVyJ3MgRW1iZXIgdGVzdCwgdGhlcmUgaXMgYSByZWNvbXBpbGUgbG9vcCBsaWtlOgor
ICAgICAgICBhOiBHZXRCeVZhbCguLi4sIHNlbWFudGljT3JpZ2luWCkKKyAgICAgICAgYjogU2V0
TG9jYWwoQ2VsbDpAYSwgc2VtYW50aWNPcmlnaW5YKQorICAgICAgICAKKyAgICAgICAgd2hlcmUg
dGhlIGNlbGwgY2hlY2sgYWx3YXlzIGZhaWxzLiBGb3IgcmVhc29ucyBJIGRpZG4ndCBpbnZlc3Rp
Z2F0ZSwgdGhlCisgICAgICAgIGJhc2VsaW5lIEpJVCdzIHZhbHVlIHByb2ZpbGluZyBkb2Vzbid0
IGFjY3VyYXRlbHkgY2FwdHVyZSB0aGUgR2V0QnlWYWwncworICAgICAgICByZXN1bHQuCisgICAg
ICAgIAorICAgICAgICBIb3dldmVyLCB3aGVuIGNvbXBpbGluZyB0aGlzIGNlbGwgc3BlY3VsYXRp
b24gY2hlY2sgaW4gdGhlIERGRywgd2UgZ2V0IGEgbnVsbAorICAgICAgICBNZXRob2RPZkdldHRp
bmdBVmFsdWVQcm9maWxlIGluc2lkZSBHcmFwaDo6bWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmls
ZUZvciBmb3IKKyAgICAgICAgdGhpcyBJUiBwYXR0ZXJuIGJlY2F1c2UgYm90aCBAYSBhbmQgQGIg
aGF2ZSB0aGUgc2FtZSBzZW1hbnRpYyBvcmlnaW4uIFdlCisgICAgICAgIHNob3VsZCBub3QgZm9s
bG93IHRoZSBzYW1lIHNlbWFudGljIG9yaWdpbiBoZXVyaXN0aWMgd2hlbiBkZWFsaW5nIHdpdGgK
KyAgICAgICAgU2V0TG9jYWwgc2luY2UgU2V0TG9jYWwoQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24p
IGlzIHN1Y2ggYSBjb21tb24gSVIgcGF0dGVybi4KKyAgICAgICAgRm9yIHBhdHRlcm5zIGxpa2Ug
dGhpcywgd2UgaW50cm9kdWNlIGEgbmV3IGhldXJpc3RpYzogQE5vZGVUaGF0RG9lc05vdFByb2R1
Y2VBVmFsdWUoQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24pLgorICAgICAgICBGb3IgdGhpcyBJUiBw
YXR0ZXJuLCB3ZSB3aWxsIHVwZGF0ZSB0aGUgdmFsdWUgcHJvZmlsZSBmb3IgdGhlIHNlbWFudGlj
IG9yaWdpbgorICAgICAgICBmb3IgQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24uIFNvLCBmb3IgdGhl
IFNwZWVkb21ldGVyIGV4YW1wbGUgYWJvdmUsIHdlCisgICAgICAgIHdpbGwgY29ycmVjdGx5IHVw
ZGF0ZSB0aGUgR2V0QnlWYWwncyB2YWx1ZSBwcm9maWxlLCB3aGljaCB3aWxsIHByZXZlbnQKKyAg
ICAgICAgYW4gT1NSIGV4aXQgbG9vcC4KKworICAgICAgICAqIGRmZy9ERkdHcmFwaC5jcHA6Cisg
ICAgICAgIChKU0M6OkRGRzo6R3JhcGg6Om1ldGhvZE9mR2V0dGluZ0FWYWx1ZVByb2ZpbGVGb3Ip
OgorCiAyMDE4LTAxLTA0ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgog
CiAgICAgICAgIFtERkddIERlZmluZSBkZWZzIGZvciBNYXBTZXQvU2V0QWRkIHRvIHBhcnRpY2lw
YXRlIGluIENTRQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJl
dmlzaW9uIDIyNjM3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3Bw
CSh3b3JraW5nIGNvcHkpCkBAIC0xNjE3LDExICsxNjE3LDEzIEBAIENvbnRyb2xFcXVpdmFsZW5j
ZUFuYWx5c2lzJiBHcmFwaDo6ZW5zdXIKIAogTWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZSBH
cmFwaDo6bWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZUZvcihOb2RlKiBjdXJyZW50Tm9kZSwg
Tm9kZSogb3BlcmFuZE5vZGUpCiB7CisgICAgLy8gVGhpcyByZXByZXNlbnRzIElSIGxpa2UgYEN1
cnJlbnROb2RlKEBvcGVyYW5kTm9kZSlgLiBGb3IgZXhhbXBsZTogYEdldEJ5VmFsKC4uLiwgSW50
MzI6QEdldExvY2FsKWAuCisKICAgICBmb3IgKE5vZGUqIG5vZGUgPSBvcGVyYW5kTm9kZTsgbm9k
ZTspIHsKKyAgICAgICAgQ29kZUJsb2NrKiBwcm9maWxlZEJsb2NrID0gYmFzZWxpbmVDb2RlQmxv
Y2tGb3Iobm9kZS0+b3JpZ2luLnNlbWFudGljKTsKKwogICAgICAgICAvLyBjdXJyZW50Tm9kZSBp
cyBudWxsIHdoZW4gd2UncmUgZG9pbmcgc3BlY3VsYXRpb24gY2hlY2tzIGZvciBjaGVja0FyZ3Vt
ZW50VHlwZXMoKS4KICAgICAgICAgaWYgKCFjdXJyZW50Tm9kZSB8fCBub2RlLT5vcmlnaW4uc2Vt
YW50aWMgIT0gY3VycmVudE5vZGUtPm9yaWdpbi5zZW1hbnRpYykgewotICAgICAgICAgICAgQ29k
ZUJsb2NrKiBwcm9maWxlZEJsb2NrID0gYmFzZWxpbmVDb2RlQmxvY2tGb3Iobm9kZS0+b3JpZ2lu
LnNlbWFudGljKTsKLQogICAgICAgICAgICAgaWYgKG5vZGUtPmFjY2Vzc2VzU3RhY2soKnRoaXMp
KSB7CiAgICAgICAgICAgICAgICAgaWYgKG1fZm9ybSAhPSBTU0EgJiYgbm9kZS0+bG9jYWwoKS5p
c0FyZ3VtZW50KCkpIHsKICAgICAgICAgICAgICAgICAgICAgaW50IGFyZ3VtZW50ID0gbm9kZS0+
bG9jYWwoKS50b0FyZ3VtZW50KCk7CkBAIC0xNjQ5LDYgKzE2NTEsOSBAQCBNZXRob2RPZkdldHRp
bmdBVmFsdWVQcm9maWxlIEdyYXBoOjptZXRoCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAor
ICAgICAgICBpZiAoY3VycmVudE5vZGUgJiYgIWN1cnJlbnROb2RlLT5oYXNSZXN1bHQoKSAmJiBu
b2RlLT5oYXNIZWFwUHJlZGljdGlvbigpKQorICAgICAgICAgICAgcmV0dXJuICZwcm9maWxlZEJs
b2NrLT52YWx1ZVByb2ZpbGVGb3JCeXRlY29kZU9mZnNldChub2RlLT5vcmlnaW4uc2VtYW50aWMu
Ynl0ZWNvZGVJbmRleCk7CisKICAgICAgICAgc3dpdGNoIChub2RlLT5vcCgpKSB7CiAgICAgICAg
IGNhc2UgQm9vbGVhblRvTnVtYmVyOgogICAgICAgICBjYXNlIElkZW50aXR5Ogo=
</data>
<flag name="review"
          id="349493"
          type_id="1"
          status="+"
          setter="fpizlo"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>330479</attachid>
            <date>2018-01-04 12:33:34 -0800</date>
            <delta_ts>2018-01-04 12:34:36 -0800</delta_ts>
            <desc>patch for landing</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>3190</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2NDExKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA
CisyMDE4LTAxLTA0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IEFkZCBhIG5ldyBwYXR0ZXJuIG1hdGNoaW5nIHJ1bGUgdG8gR3JhcGg6Om1ldGhvZE9mR2V0dGlu
Z0FWYWx1ZVByb2ZpbGVGb3IgZm9yIFNldExvY2FsKEBub2RlV2l0aEhlYXBQcmVkaWN0aW9uKQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMjk2CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgRmlsaXAgUGl6bG8uCisKKyAgICAgICAgSW5zaWRlIFNwZWVk
b21ldGVyJ3MgRW1iZXIgdGVzdCwgdGhlcmUgaXMgYSByZWNvbXBpbGUgbG9vcCBsaWtlOgorICAg
ICAgICBhOiBHZXRCeVZhbCguLi4sIHNlbWFudGljT3JpZ2luWCkKKyAgICAgICAgYjogU2V0TG9j
YWwoQ2VsbDpAYSwgc2VtYW50aWNPcmlnaW5YKQorICAgICAgICAKKyAgICAgICAgd2hlcmUgdGhl
IGNlbGwgY2hlY2sgYWx3YXlzIGZhaWxzLiBGb3IgcmVhc29ucyBJIGRpZG4ndCBpbnZlc3RpZ2F0
ZSwgdGhlCisgICAgICAgIGJhc2VsaW5lIEpJVCdzIHZhbHVlIHByb2ZpbGluZyBkb2Vzbid0IGFj
Y3VyYXRlbHkgY2FwdHVyZSB0aGUgR2V0QnlWYWwncworICAgICAgICByZXN1bHQuCisgICAgICAg
IAorICAgICAgICBIb3dldmVyLCB3aGVuIGNvbXBpbGluZyB0aGlzIGNlbGwgc3BlY3VsYXRpb24g
Y2hlY2sgaW4gdGhlIERGRywgd2UgZ2V0IGEgbnVsbAorICAgICAgICBNZXRob2RPZkdldHRpbmdB
VmFsdWVQcm9maWxlIGluc2lkZSBHcmFwaDo6bWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZUZv
ciBmb3IKKyAgICAgICAgdGhpcyBJUiBwYXR0ZXJuIGJlY2F1c2UgYm90aCBAYSBhbmQgQGIgaGF2
ZSB0aGUgc2FtZSBzZW1hbnRpYyBvcmlnaW4uIFdlCisgICAgICAgIHNob3VsZCBub3QgZm9sbG93
IHRoZSBzYW1lIHNlbWFudGljIG9yaWdpbiBoZXVyaXN0aWMgd2hlbiBkZWFsaW5nIHdpdGgKKyAg
ICAgICAgU2V0TG9jYWwgc2luY2UgU2V0TG9jYWwoQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24pIGlz
IHN1Y2ggYSBjb21tb24gSVIgcGF0dGVybi4KKyAgICAgICAgRm9yIHBhdHRlcm5zIGxpa2UgdGhp
cywgd2UgaW50cm9kdWNlIGEgbmV3IGhldXJpc3RpYzogQE5vZGVUaGF0RG9lc05vdFByb2R1Y2VB
VmFsdWUoQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24pLgorICAgICAgICBGb3IgdGhpcyBJUiBwYXR0
ZXJuLCB3ZSB3aWxsIHVwZGF0ZSB0aGUgdmFsdWUgcHJvZmlsZSBmb3IgdGhlIHNlbWFudGljIG9y
aWdpbgorICAgICAgICBmb3IgQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24uIFNvLCBmb3IgdGhlIFNw
ZWVkb21ldGVyIGV4YW1wbGUgYWJvdmUsIHdlCisgICAgICAgIHdpbGwgY29ycmVjdGx5IHVwZGF0
ZSB0aGUgR2V0QnlWYWwncyB2YWx1ZSBwcm9maWxlLCB3aGljaCB3aWxsIHByZXZlbnQKKyAgICAg
ICAgYW4gT1NSIGV4aXQgbG9vcC4KKworICAgICAgICAqIGRmZy9ERkdHcmFwaC5jcHA6CisgICAg
ICAgIChKU0M6OkRGRzo6R3JhcGg6Om1ldGhvZE9mR2V0dGluZ0FWYWx1ZVByb2ZpbGVGb3IpOgor
CiAyMDE4LTAxLTA0ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAg
ICAgICAgIFtERkddIERlZmluZSBkZWZzIGZvciBNYXBTZXQvU2V0QWRkIHRvIHBhcnRpY2lwYXRl
IGluIENTRQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJldmlz
aW9uIDIyNjM3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCSh3
b3JraW5nIGNvcHkpCkBAIC0xNjE3LDExICsxNjE3LDEzIEBAIENvbnRyb2xFcXVpdmFsZW5jZUFu
YWx5c2lzJiBHcmFwaDo6ZW5zdXIKIAogTWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZSBHcmFw
aDo6bWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZUZvcihOb2RlKiBjdXJyZW50Tm9kZSwgTm9k
ZSogb3BlcmFuZE5vZGUpCiB7CisgICAgLy8gVGhpcyByZXByZXNlbnRzIElSIGxpa2UgYEN1cnJl
bnROb2RlKEBvcGVyYW5kTm9kZSlgLiBGb3IgZXhhbXBsZTogYEdldEJ5VmFsKC4uLiwgSW50MzI6
QEdldExvY2FsKWAuCisKICAgICBmb3IgKE5vZGUqIG5vZGUgPSBvcGVyYW5kTm9kZTsgbm9kZTsp
IHsKLSAgICAgICAgLy8gY3VycmVudE5vZGUgaXMgbnVsbCB3aGVuIHdlJ3JlIGRvaW5nIHNwZWN1
bGF0aW9uIGNoZWNrcyBmb3IgY2hlY2tBcmd1bWVudFR5cGVzKCkuCi0gICAgICAgIGlmICghY3Vy
cmVudE5vZGUgfHwgbm9kZS0+b3JpZ2luLnNlbWFudGljICE9IGN1cnJlbnROb2RlLT5vcmlnaW4u
c2VtYW50aWMpIHsKLSAgICAgICAgICAgIENvZGVCbG9jayogcHJvZmlsZWRCbG9jayA9IGJhc2Vs
aW5lQ29kZUJsb2NrRm9yKG5vZGUtPm9yaWdpbi5zZW1hbnRpYyk7CisgICAgICAgIENvZGVCbG9j
ayogcHJvZmlsZWRCbG9jayA9IGJhc2VsaW5lQ29kZUJsb2NrRm9yKG5vZGUtPm9yaWdpbi5zZW1h
bnRpYyk7CiAKKyAgICAgICAgLy8gY3VycmVudE5vZGUgaXMgbnVsbCB3aGVuIHdlJ3JlIGRvaW5n
IHNwZWN1bGF0aW9uIGNoZWNrcyBmb3IgY2hlY2tBcmd1bWVudFR5cGVzKCkuCisgICAgICAgIGlm
ICghY3VycmVudE5vZGUgfHwgbm9kZS0+b3JpZ2luLnNlbWFudGljICE9IGN1cnJlbnROb2RlLT5v
cmlnaW4uc2VtYW50aWMgfHwgIWN1cnJlbnROb2RlLT5oYXNSZXN1bHQoKSkgewogICAgICAgICAg
ICAgaWYgKG5vZGUtPmFjY2Vzc2VzU3RhY2soKnRoaXMpKSB7CiAgICAgICAgICAgICAgICAgaWYg
KG1fZm9ybSAhPSBTU0EgJiYgbm9kZS0+bG9jYWwoKS5pc0FyZ3VtZW50KCkpIHsKICAgICAgICAg
ICAgICAgICAgICAgaW50IGFyZ3VtZW50ID0gbm9kZS0+bG9jYWwoKS50b0FyZ3VtZW50KCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>330480</attachid>
            <date>2018-01-04 12:34:36 -0800</date>
            <delta_ts>2018-01-04 12:35:19 -0800</delta_ts>
            <desc>patch for landing</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>3015</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2NDExKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA
CisyMDE4LTAxLTA0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IEFkZCBhIG5ldyBwYXR0ZXJuIG1hdGNoaW5nIHJ1bGUgdG8gR3JhcGg6Om1ldGhvZE9mR2V0dGlu
Z0FWYWx1ZVByb2ZpbGVGb3IgZm9yIFNldExvY2FsKEBub2RlV2l0aEhlYXBQcmVkaWN0aW9uKQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMjk2CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgRmlsaXAgUGl6bG8uCisKKyAgICAgICAgSW5zaWRlIFNwZWVk
b21ldGVyJ3MgRW1iZXIgdGVzdCwgdGhlcmUgaXMgYSByZWNvbXBpbGUgbG9vcCBsaWtlOgorICAg
ICAgICBhOiBHZXRCeVZhbCguLi4sIHNlbWFudGljT3JpZ2luWCkKKyAgICAgICAgYjogU2V0TG9j
YWwoQ2VsbDpAYSwgc2VtYW50aWNPcmlnaW5YKQorICAgICAgICAKKyAgICAgICAgd2hlcmUgdGhl
IGNlbGwgY2hlY2sgYWx3YXlzIGZhaWxzLiBGb3IgcmVhc29ucyBJIGRpZG4ndCBpbnZlc3RpZ2F0
ZSwgdGhlCisgICAgICAgIGJhc2VsaW5lIEpJVCdzIHZhbHVlIHByb2ZpbGluZyBkb2Vzbid0IGFj
Y3VyYXRlbHkgY2FwdHVyZSB0aGUgR2V0QnlWYWwncworICAgICAgICByZXN1bHQuCisgICAgICAg
IAorICAgICAgICBIb3dldmVyLCB3aGVuIGNvbXBpbGluZyB0aGlzIGNlbGwgc3BlY3VsYXRpb24g
Y2hlY2sgaW4gdGhlIERGRywgd2UgZ2V0IGEgbnVsbAorICAgICAgICBNZXRob2RPZkdldHRpbmdB
VmFsdWVQcm9maWxlIGluc2lkZSBHcmFwaDo6bWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZUZv
ciBmb3IKKyAgICAgICAgdGhpcyBJUiBwYXR0ZXJuIGJlY2F1c2UgYm90aCBAYSBhbmQgQGIgaGF2
ZSB0aGUgc2FtZSBzZW1hbnRpYyBvcmlnaW4uIFdlCisgICAgICAgIHNob3VsZCBub3QgZm9sbG93
IHRoZSBzYW1lIHNlbWFudGljIG9yaWdpbiBoZXVyaXN0aWMgd2hlbiBkZWFsaW5nIHdpdGgKKyAg
ICAgICAgU2V0TG9jYWwgc2luY2UgU2V0TG9jYWwoQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24pIGlz
IHN1Y2ggYSBjb21tb24gSVIgcGF0dGVybi4KKyAgICAgICAgRm9yIHBhdHRlcm5zIGxpa2UgdGhp
cywgd2UgaW50cm9kdWNlIGEgbmV3IGhldXJpc3RpYzogQE5vZGVUaGF0RG9lc05vdFByb2R1Y2VB
VmFsdWUoQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24pLgorICAgICAgICBGb3IgdGhpcyBJUiBwYXR0
ZXJuLCB3ZSB3aWxsIHVwZGF0ZSB0aGUgdmFsdWUgcHJvZmlsZSBmb3IgdGhlIHNlbWFudGljIG9y
aWdpbgorICAgICAgICBmb3IgQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24uIFNvLCBmb3IgdGhlIFNw
ZWVkb21ldGVyIGV4YW1wbGUgYWJvdmUsIHdlCisgICAgICAgIHdpbGwgY29ycmVjdGx5IHVwZGF0
ZSB0aGUgR2V0QnlWYWwncyB2YWx1ZSBwcm9maWxlLCB3aGljaCB3aWxsIHByZXZlbnQKKyAgICAg
ICAgYW4gT1NSIGV4aXQgbG9vcC4KKworICAgICAgICAqIGRmZy9ERkdHcmFwaC5jcHA6CisgICAg
ICAgIChKU0M6OkRGRzo6R3JhcGg6Om1ldGhvZE9mR2V0dGluZ0FWYWx1ZVByb2ZpbGVGb3IpOgor
CiAyMDE4LTAxLTA0ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAg
ICAgICAgIFtERkddIERlZmluZSBkZWZzIGZvciBNYXBTZXQvU2V0QWRkIHRvIHBhcnRpY2lwYXRl
IGluIENTRQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJldmlz
aW9uIDIyNjM3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCSh3
b3JraW5nIGNvcHkpCkBAIC0xNjE3LDExICsxNjE3LDEyIEBAIENvbnRyb2xFcXVpdmFsZW5jZUFu
YWx5c2lzJiBHcmFwaDo6ZW5zdXIKIAogTWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZSBHcmFw
aDo6bWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZUZvcihOb2RlKiBjdXJyZW50Tm9kZSwgTm9k
ZSogb3BlcmFuZE5vZGUpCiB7CisgICAgLy8gVGhpcyByZXByZXNlbnRzIElSIGxpa2UgYEN1cnJl
bnROb2RlKEBvcGVyYW5kTm9kZSlgLiBGb3IgZXhhbXBsZTogYEdldEJ5VmFsKC4uLiwgSW50MzI6
QEdldExvY2FsKWAuCisKICAgICBmb3IgKE5vZGUqIG5vZGUgPSBvcGVyYW5kTm9kZTsgbm9kZTsp
IHsKICAgICAgICAgLy8gY3VycmVudE5vZGUgaXMgbnVsbCB3aGVuIHdlJ3JlIGRvaW5nIHNwZWN1
bGF0aW9uIGNoZWNrcyBmb3IgY2hlY2tBcmd1bWVudFR5cGVzKCkuCi0gICAgICAgIGlmICghY3Vy
cmVudE5vZGUgfHwgbm9kZS0+b3JpZ2luLnNlbWFudGljICE9IGN1cnJlbnROb2RlLT5vcmlnaW4u
c2VtYW50aWMpIHsKKyAgICAgICAgaWYgKCFjdXJyZW50Tm9kZSB8fCBub2RlLT5vcmlnaW4uc2Vt
YW50aWMgIT0gY3VycmVudE5vZGUtPm9yaWdpbi5zZW1hbnRpYyB8fCAhY3VycmVudE5vZGUtPmhh
c1Jlc3VsdCgpKSB7CiAgICAgICAgICAgICBDb2RlQmxvY2sqIHByb2ZpbGVkQmxvY2sgPSBiYXNl
bGluZUNvZGVCbG9ja0Zvcihub2RlLT5vcmlnaW4uc2VtYW50aWMpOwotCiAgICAgICAgICAgICBp
ZiAobm9kZS0+YWNjZXNzZXNTdGFjaygqdGhpcykpIHsKICAgICAgICAgICAgICAgICBpZiAobV9m
b3JtICE9IFNTQSAmJiBub2RlLT5sb2NhbCgpLmlzQXJndW1lbnQoKSkgewogICAgICAgICAgICAg
ICAgICAgICBpbnQgYXJndW1lbnQgPSBub2RlLT5sb2NhbCgpLnRvQXJndW1lbnQoKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>330481</attachid>
            <date>2018-01-04 12:35:19 -0800</date>
            <delta_ts>2018-01-04 16:01:37 -0800</delta_ts>
            <desc>patch for landing</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>2882</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2NDExKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA
CisyMDE4LTAxLTA0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IEFkZCBhIG5ldyBwYXR0ZXJuIG1hdGNoaW5nIHJ1bGUgdG8gR3JhcGg6Om1ldGhvZE9mR2V0dGlu
Z0FWYWx1ZVByb2ZpbGVGb3IgZm9yIFNldExvY2FsKEBub2RlV2l0aEhlYXBQcmVkaWN0aW9uKQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMjk2CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgRmlsaXAgUGl6bG8uCisKKyAgICAgICAgSW5zaWRlIFNwZWVk
b21ldGVyJ3MgRW1iZXIgdGVzdCwgdGhlcmUgaXMgYSByZWNvbXBpbGUgbG9vcCBsaWtlOgorICAg
ICAgICBhOiBHZXRCeVZhbCguLi4sIHNlbWFudGljT3JpZ2luWCkKKyAgICAgICAgYjogU2V0TG9j
YWwoQ2VsbDpAYSwgc2VtYW50aWNPcmlnaW5YKQorICAgICAgICAKKyAgICAgICAgd2hlcmUgdGhl
IGNlbGwgY2hlY2sgYWx3YXlzIGZhaWxzLiBGb3IgcmVhc29ucyBJIGRpZG4ndCBpbnZlc3RpZ2F0
ZSwgdGhlCisgICAgICAgIGJhc2VsaW5lIEpJVCdzIHZhbHVlIHByb2ZpbGluZyBkb2Vzbid0IGFj
Y3VyYXRlbHkgY2FwdHVyZSB0aGUgR2V0QnlWYWwncworICAgICAgICByZXN1bHQuCisgICAgICAg
IAorICAgICAgICBIb3dldmVyLCB3aGVuIGNvbXBpbGluZyB0aGlzIGNlbGwgc3BlY3VsYXRpb24g
Y2hlY2sgaW4gdGhlIERGRywgd2UgZ2V0IGEgbnVsbAorICAgICAgICBNZXRob2RPZkdldHRpbmdB
VmFsdWVQcm9maWxlIGluc2lkZSBHcmFwaDo6bWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJvZmlsZUZv
ciBmb3IKKyAgICAgICAgdGhpcyBJUiBwYXR0ZXJuIGJlY2F1c2UgYm90aCBAYSBhbmQgQGIgaGF2
ZSB0aGUgc2FtZSBzZW1hbnRpYyBvcmlnaW4uIFdlCisgICAgICAgIHNob3VsZCBub3QgZm9sbG93
IHRoZSBzYW1lIHNlbWFudGljIG9yaWdpbiBoZXVyaXN0aWMgd2hlbiBkZWFsaW5nIHdpdGgKKyAg
ICAgICAgU2V0TG9jYWwgc2luY2UgU2V0TG9jYWwoQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24pIGlz
IHN1Y2ggYSBjb21tb24gSVIgcGF0dGVybi4KKyAgICAgICAgRm9yIHBhdHRlcm5zIGxpa2UgdGhp
cywgd2UgaW50cm9kdWNlIGEgbmV3IGhldXJpc3RpYzogQE5vZGVUaGF0RG9lc05vdFByb2R1Y2VB
VmFsdWUoQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24pLgorICAgICAgICBGb3IgdGhpcyBJUiBwYXR0
ZXJuLCB3ZSB3aWxsIHVwZGF0ZSB0aGUgdmFsdWUgcHJvZmlsZSBmb3IgdGhlIHNlbWFudGljIG9y
aWdpbgorICAgICAgICBmb3IgQG5vZGVXaXRoSGVhcFByZWRpY3Rpb24uIFNvLCBmb3IgdGhlIFNw
ZWVkb21ldGVyIGV4YW1wbGUgYWJvdmUsIHdlCisgICAgICAgIHdpbGwgY29ycmVjdGx5IHVwZGF0
ZSB0aGUgR2V0QnlWYWwncyB2YWx1ZSBwcm9maWxlLCB3aGljaCB3aWxsIHByZXZlbnQKKyAgICAg
ICAgYW4gT1NSIGV4aXQgbG9vcC4KKworICAgICAgICAqIGRmZy9ERkdHcmFwaC5jcHA6CisgICAg
ICAgIChKU0M6OkRGRzo6R3JhcGg6Om1ldGhvZE9mR2V0dGluZ0FWYWx1ZVByb2ZpbGVGb3IpOgor
CiAyMDE4LTAxLTA0ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAg
ICAgICAgIFtERkddIERlZmluZSBkZWZzIGZvciBNYXBTZXQvU2V0QWRkIHRvIHBhcnRpY2lwYXRl
IGluIENTRQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJldmlz
aW9uIDIyNjM3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCSh3
b3JraW5nIGNvcHkpCkBAIC0xNjE3LDkgKzE2MTcsMTEgQEAgQ29udHJvbEVxdWl2YWxlbmNlQW5h
bHlzaXMmIEdyYXBoOjplbnN1cgogCiBNZXRob2RPZkdldHRpbmdBVmFsdWVQcm9maWxlIEdyYXBo
OjptZXRob2RPZkdldHRpbmdBVmFsdWVQcm9maWxlRm9yKE5vZGUqIGN1cnJlbnROb2RlLCBOb2Rl
KiBvcGVyYW5kTm9kZSkKIHsKKyAgICAvLyBUaGlzIHJlcHJlc2VudHMgSVIgbGlrZSBgQ3VycmVu
dE5vZGUoQG9wZXJhbmROb2RlKWAuIEZvciBleGFtcGxlOiBgR2V0QnlWYWwoLi4uLCBJbnQzMjpA
R2V0TG9jYWwpYC4KKwogICAgIGZvciAoTm9kZSogbm9kZSA9IG9wZXJhbmROb2RlOyBub2RlOykg
ewogICAgICAgICAvLyBjdXJyZW50Tm9kZSBpcyBudWxsIHdoZW4gd2UncmUgZG9pbmcgc3BlY3Vs
YXRpb24gY2hlY2tzIGZvciBjaGVja0FyZ3VtZW50VHlwZXMoKS4KLSAgICAgICAgaWYgKCFjdXJy
ZW50Tm9kZSB8fCBub2RlLT5vcmlnaW4uc2VtYW50aWMgIT0gY3VycmVudE5vZGUtPm9yaWdpbi5z
ZW1hbnRpYykgeworICAgICAgICBpZiAoIWN1cnJlbnROb2RlIHx8IG5vZGUtPm9yaWdpbi5zZW1h
bnRpYyAhPSBjdXJyZW50Tm9kZS0+b3JpZ2luLnNlbWFudGljIHx8ICFjdXJyZW50Tm9kZS0+aGFz
UmVzdWx0KCkpIHsKICAgICAgICAgICAgIENvZGVCbG9jayogcHJvZmlsZWRCbG9jayA9IGJhc2Vs
aW5lQ29kZUJsb2NrRm9yKG5vZGUtPm9yaWdpbi5zZW1hbnRpYyk7CiAKICAgICAgICAgICAgIGlm
IChub2RlLT5hY2Nlc3Nlc1N0YWNrKCp0aGlzKSkgewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>