181280 2018-01-03 21:57:26 -0800 Web Inspector: ⌘G / ⇧⌘G text search does not working after closing find banner 2018-01-04 12:56:48 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker mitz webkit-bug-importer oldest_to_newest 1385703 0 joepeck 2018-01-03 21:57:26 -0800 ⌘G / ⇧⌘G text search does not working after closing find banner This is frustrating since they work if you don't open and close the find banner. Steps to Reproduce: (⌘G not working) 1. Inspect webkit.org 2. Show "global.js" 3. Show find banner (⌘F) 4. Search for "document" 5. Use ⌘G to find next => works (okay) 6. Close find banner => search highlights go away (okay) 7. Use ⌘G/⇧⌘G to find previous => doesn't work Notes: - Hiding the find banner apparently makes ContentBrowser call searchCleared() which clears the list of search results instead of just hiding them. 1385705 1 webkit-bug-importer 2018-01-03 21:58:00 -0800 <rdar://problem/36291176> 1385706 2 webkit-bug-importer 2018-01-03 21:58:00 -0800 <rdar://problem/36291175> 1385710 3 joepeck 2018-01-03 22:00:32 -0800 Test comment to see what it gets imported to. 1385718 4 330448 joepeck 2018-01-03 22:16:24 -0800 Created attachment 330448 [PATCH] Proposed Fix 1385887 5 330448 mattbaker 2018-01-04 12:35:44 -0800 Comment on attachment 330448 [PATCH] Proposed Fix r=me 1385905 6 330448 commit-queue 2018-01-04 12:56:46 -0800 Comment on attachment 330448 [PATCH] Proposed Fix Clearing flags on attachment: 330448 Committed r226415: <https://trac.webkit.org/changeset/226415> 1385906 7 commit-queue 2018-01-04 12:56:48 -0800 All reviewed patches have been landed. Closing bug. 330448 2018-01-03 22:16:24 -0800 2018-01-04 12:56:46 -0800 [PATCH] Proposed Fix search-fix-1.patch text/plain 5006 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM4NTdiNDg5NGM1Li43NzcxZGUzOTZhMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzYgQEAKIDIwMTgtMDEtMDMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiDijJhHIC8g4oen4oyYRyB0ZXh0IHNlYXJjaCBkb2VzIG5vdCB3b3JraW5nIGFmdGVyIGNsb3Np bmcgZmluZCBiYW5uZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4MTI4MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYyOTExNzU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0NvbnRlbnRCcm93c2VyLmpzOgorICAgICAgICAoV0kuQ29udGVudEJyb3dzZXIucHJv dG90eXBlLl9maW5kQmFubmVyRGlkSGlkZSk6CisgICAgICAgIFdoZW4gdGhlIGZpbmQgYmFubmVy IGlzIGhpZGRlbiB0cmlnZ2VyIGEgbmV3IENvbnRlbnRWaWV3IG1ldGhvZCwKKyAgICAgICAgc2Vh cmNoSGlkZGVuIGluc3RlYWQgb2YgdGhlIGRlc3RydWN0aXZlIHNlYXJjaENsZWFyZWQuIFRoaXMg YWxsb3dzCisgICAgICAgIG1vc3QgY29udGVudCB2aWV3cyAodGV4dCBlZGl0b3JzLCBET00gdHJl ZSwgTmV0d29yayBIZWFkZXJzIHZpZXcpCisgICAgICAgIHRvIGtlZXAgdGhlaXIgcG9wdWxhdGVk IHNlYXJjaCByZXN1bHRzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50 Vmlldy5qczoKKyAgICAgICAgKFdJLkNvbnRlbnRWaWV3LnByb3RvdHlwZS5zZWFyY2hIaWRkZW4p OgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanM6CisgICAg ICAgIChXSS5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUuc2VhcmNoSGlkZGVuKToKKyAgICAgICAg QnkgZGVmYXVsdCBzZWFyY2hIaWRkZW4gZG9lcyBub3RoaW5nLiBUaGUgQ29uc29sZSdzIExvZ0Nv bnRlbnRWaWV3CisgICAgICAgIHRyZWF0cyB0aGUgZmluZCBiYW5uZXIgZGlmZmVyZW50bHkgYW5k IGNsZWFycyBpdHMgc2VhcmNoIHJlc3VsdHMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL1RleHRFZGl0b3IuanM6CisgICAgICAgIChXSS5UZXh0RWRpdG9yLnByb3RvdHlwZS5zZWFy Y2hDbGVhcmVkKToKKyAgICAgICAgTW9kZXJuaXplIHNvbWUgY29kZSB3aGlsZSB3b3JraW5nIGlu IHRoaXMgYXJlYS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTWFpbi5jc3M6Cisg ICAgICAgICguYm91bmN5LWhpZ2hsaWdodCk6CisgICAgICAgIEVuc3VyZSBibGFjayB0ZXh0IG9u IHllbGxvdyBiYWNrZ3JvdW5kIGluIHRoZSBib3VuY3kgaGlnaGxpZ2h0LiBJbiB0aGUKKyAgICAg ICAgRE9NIFRyZWUgaXQgY291bGQgaGF2ZSBiZWVuIHdoaXRlIGlmIHRoZSBmaW5kIGJhbm5lciB3 YXMgY2xvc2VkLgorCisyMDE4LTAxLTAzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRmluZCBuZXh0IC8gcHJldmlvdXMgd2l0 aGluIGEgcmVzb3VyY2UgY29udGVudCB2aWV3IGRvZXMgbm90IGhhdmUgYm91bmN5IGhpZ2hsaWdo dCB3aGVuIGVkaXRvciBzY3JvbGxzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODEyNzkKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM2MjkxMDk3Pgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29u dGVudEJyb3dzZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Db250ZW50QnJvd3Nlci5qcwppbmRleCA1YzIyM2JiZGYxNS4uMWJmYWRhYjA0MGUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRC cm93c2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NvbnRlbnRCcm93c2VyLmpzCkBAIC0zMjUsNyArMzI1LDcgQEAgV0kuQ29udGVudEJyb3dzZXIg PSBjbGFzcyBDb250ZW50QnJvd3NlciBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgICAgIHJldHVy bjsKIAogICAgICAgICBjdXJyZW50Q29udGVudFZpZXcuYXV0b21hdGljYWxseVJldmVhbEZpcnN0 U2VhcmNoUmVzdWx0ID0gZmFsc2U7Ci0gICAgICAgIGN1cnJlbnRDb250ZW50Vmlldy5zZWFyY2hD bGVhcmVkKCk7CisgICAgICAgIGN1cnJlbnRDb250ZW50Vmlldy5zZWFyY2hIaWRkZW4oKTsKICAg ICB9CiAKICAgICBfY29udGVudFZpZXdOdW1iZXJPZlNlYXJjaFJlc3VsdHNEaWRDaGFuZ2UoZXZl bnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Db250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NvbnRlbnRWaWV3LmpzCmluZGV4IGZjMWI4MTczMTk4Li40NTllOGNkMzEzMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudFZp ZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29u dGVudFZpZXcuanMKQEAgLTQ0NSw2ICs0NDUsMTEgQEAgV0kuQ29udGVudFZpZXcgPSBjbGFzcyBD b250ZW50VmlldyBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgLy8gSW1wbGVtZW50ZWQgYnkgc3Vi Y2xhc3Nlcy4KICAgICB9CiAKKyAgICBzZWFyY2hIaWRkZW4oKQorICAgIHsKKyAgICAgICAgLy8g SW1wbGVtZW50ZWQgYnkgc3ViY2xhc3Nlcy4KKyAgICB9CisKICAgICBzZWFyY2hDbGVhcmVkKCkK ICAgICB7CiAgICAgICAgIC8vIEltcGxlbWVudGVkIGJ5IHN1YmNsYXNzZXMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmll dy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRl bnRWaWV3LmpzCmluZGV4IDMyMTE3MTAzZWVmLi40YTI3NjVkNmVjOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVu dFZpZXcuanMKQEAgLTEwNzYsNiArMTA3NiwxMSBAQCBXSS5Mb2dDb250ZW50VmlldyA9IGNsYXNz IExvZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAgfQogICAgIH0K IAorICAgIHNlYXJjaEhpZGRlbigpCisgICAgeworICAgICAgICB0aGlzLnNlYXJjaENsZWFyZWQo KTsKKyAgICB9CisKICAgICBzZWFyY2hDbGVhcmVkKCkKICAgICB7CiAgICAgICAgIHRoaXMucGVy Zm9ybVNlYXJjaCgiIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9NYWluLmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL01haW4uY3NzCmluZGV4IDEyNGY0N2Q1ZDliLi5mZWU5NjI2MTY0MCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWFpbi5jc3MK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWFpbi5jc3MK QEAgLTMzMyw2ICszMzMsNyBAQCBib2R5W2Rpcj1ydGxdIC5nby10by1hcnJvdyB7CiAgICAgYm94 LXNoYWRvdzogaW5zZXQgaHNsKDUwLCA5MSUsIDc2JSkgMCAtMXB4IDAsIGhzbCg1MiwgNTYlLCA2 MCUpIDAgMXB4IDFweCwgaHNsYSgwLCAwJSwgMCUsIDAuMzMpIDAgMXB4IDJweCAxcHg7CiAKICAg ICBiYWNrZ3JvdW5kLWNvbG9yOiBoc2woNTQsIDkzJSwgNzAlKTsKKyAgICBjb2xvcjogYmxhY2sg IWltcG9ydGFudDsKIAogICAgIHBhZGRpbmc6IDJweCA0cHg7CiAgICAgbWFyZ2luLXRvcDogLTJw eDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UZXh0RWRpdG9yLmpzCmluZGV4IGFlNTY4Zjc4NjJlLi4wMTEwZmYxMGYwZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRp dG9yLmpzCkBAIC00MDYsMTIgKzQwNiwxMCBAQCBXSS5UZXh0RWRpdG9yID0gY2xhc3MgVGV4dEVk aXRvciBleHRlbmRzIFdJLlZpZXcKIAogICAgIHNlYXJjaENsZWFyZWQoKQogICAgIHsKLSAgICAg ICAgZnVuY3Rpb24gY2xlYXJSZXN1bHRzKCkgewotICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCB0aGlzLl9zZWFyY2hSZXN1bHRzLmxlbmd0aDsgKytpKQotICAgICAgICAgICAgICAgIHRo aXMuX3NlYXJjaFJlc3VsdHNbaV0uY2xlYXIoKTsKLSAgICAgICAgfQotCi0gICAgICAgIHRoaXMu X2NvZGVNaXJyb3Iub3BlcmF0aW9uKGNsZWFyUmVzdWx0cy5iaW5kKHRoaXMpKTsKKyAgICAgICAg dGhpcy5fY29kZU1pcnJvci5vcGVyYXRpb24oKCkgPT4geworICAgICAgICAgICAgZm9yIChsZXQg c2VhcmNoUmVzdWx0IG9mIHRoaXMuX3NlYXJjaFJlc3VsdHMpCisgICAgICAgICAgICAgICAgc2Vh cmNoUmVzdWx0LmNsZWFyKCk7CisgICAgICAgIH0pOwogCiAgICAgICAgIHRoaXMuX3NlYXJjaFF1 ZXJ5ID0gbnVsbDsKICAgICAgICAgdGhpcy5fc2VhcmNoUmVzdWx0cyA9IFtdOwo=