181275 2018-01-03 20:31:36 -0800 Web Inspector: RTL - DOM Tree Element selection doesn't work 2018-01-03 21:57:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1385675 0 joepeck 2018-01-03 20:31:36 -0800 RTL - DOM Tree Element selection doesn't work. Steps to Reproduce: 1. Inspect webkit.org 2. Configure Web Inspector for RTL Layout Direction 3. Inspect the "Feature Status" link at the top of the page 4. Try to use the DOM Tree in the Elements Tab => Selection always goes to the top level parent and not the node you selected. Notes: - Algorithm in TreeOutline.prototype.treeElementFromEvent adjusts `x` used for elementFromPoint but doesn't take into account layout direction. 1385676 1 webkit-bug-importer 2018-01-03 20:32:06 -0800 <rdar://problem/36290450> 1385678 2 330438 joepeck 2018-01-03 20:34:14 -0800 Created attachment 330438 [PATCH] Proposed Fix 1385696 3 330438 hi 2018-01-03 21:36:44 -0800 Comment on attachment 330438 [PATCH] Proposed Fix r=me 1385702 4 330438 commit-queue 2018-01-03 21:57:26 -0800 Comment on attachment 330438 [PATCH] Proposed Fix Clearing flags on attachment: 330438 Committed r226392: <https://trac.webkit.org/changeset/226392> 1385704 5 commit-queue 2018-01-03 21:57:28 -0800 All reviewed patches have been landed. Closing bug. 330438 2018-01-03 20:34:14 -0800 2018-01-03 21:57:26 -0800 [PATCH] Proposed Fix trailing-1.patch text/plain 3123 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGViMDYzNGJkODc2Li45MzRiYWY1YjJiMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTgtMDEtMDMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBSVEwgLSBET00gVHJlZSBFbGVtZW50IHNlbGVjdGlvbiBkb2Vzbid0IHdvcmsKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTI3NQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMzYyOTA0NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzOgor ICAgICAgICAoV0kuVHJlZU91dGxpbmUucHJvdG90eXBlLnRyZWVFbGVtZW50RnJvbUV2ZW50KToK KyAgICAgICAgUHJvdmlkZSBhIGJldHRlciBleHBsYW5hdGlvbiBmb3Igd2h5IHdlIGFyZSBtYWtp bmcgdGhlIGB4YCBhZGp1c3RtZW50IGhlcmUsCisgICAgICAgIHRvIGRldGVjdCB0aGUgaW5uZXIg bW9zdCB0cmVlIGVsZW1lbnQgYWxvbmcgdGhlIGhvcml6b250YWwuIEZpeCB0aGUgYWxnb3JpdGht CisgICAgICAgIGZvciBSVEwsIHNpbmNlIHRoZSBpbnRlbnQgaXMgdG8gYWRqdXN0IHRvIHRoZSB0 cmFpbGluZyBlZGdlIG9mIHRoZSBjb250YWluZXIKKyAgICAgICAgd2hpY2ggaXMgb24gdGhlIG9w cG9zaXRlIHNpZGUgaW4gUlRMLgorCisyMDE4LTAxLTAzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNv cmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRmluZCBiYW5uZXIgc29t ZXRpbWVzIGRvZXMgbm90IHdvcmsgKHdoZW4gYWxyZWFkeSBwb3B1bGF0ZWQgYW5kIHNob3duIGZv ciBmaXJzdCB0aW1lIG9uIHJlc291cmNlKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMjU1CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjI0ODg1 NT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVHJlZU91dGxpbmUuanMKaW5kZXggNTJjZWI4MTU3NGIuLmNhZDhhZDg4NWY5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGlu ZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVl T3V0bGluZS5qcwpAQCAtNzQwLDEwICs3NDAsMjAgQEAgV0kuVHJlZU91dGxpbmUgPSBjbGFzcyBU cmVlT3V0bGluZSBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICBsZXQgc2Nyb2xsQ29udGFpbmVy ID0gdGhpcy5lbGVtZW50LnBhcmVudEVsZW1lbnQ7CiAKICAgICAgICAgLy8gV2UgY2hvb3NlIHRo aXMgWCBjb29yZGluYXRlIGJhc2VkIG9uIHRoZSBrbm93bGVkZ2UgdGhhdCBvdXIgbGlzdAotICAg ICAgICAvLyBpdGVtcyBleHRlbmQgYXQgbGVhc3QgdG8gdGhlIHJpZ2h0IGVkZ2Ugb2YgdGhlIG91 dGVyIDxvbD4gY29udGFpbmVyLgorICAgICAgICAvLyBpdGVtcyBleHRlbmQgYXQgbGVhc3QgdG8g dGhlIHRyYWlsaW5nIGVkZ2Ugb2YgdGhlIG91dGVyIDxvbD4gY29udGFpbmVyLgogICAgICAgICAv LyBJbiB0aGUgbm8td29yZC13cmFwIG1vZGUgdGhlIG91dGVyIDxvbD4gbWF5IGJlIHdpZGVyIHRo YW4gdGhlIHRyZWUgY29udGFpbmVyCi0gICAgICAgIC8vIChhbmQgcGFydGlhbGx5IGhpZGRlbiks IGluIHdoaWNoIGNhc2Ugd2UgYXJlIGxlZnQgdG8gdXNlIG9ubHkgaXRzIHJpZ2h0IGJvdW5kYXJ5 LgotICAgICAgICBsZXQgeCA9IHNjcm9sbENvbnRhaW5lci50b3RhbE9mZnNldExlZnQgKyBzY3Jv bGxDb250YWluZXIub2Zmc2V0V2lkdGggLSAzNjsKKyAgICAgICAgLy8gKGFuZCBwYXJ0aWFsbHkg aGlkZGVuKSwgaW4gd2hpY2ggY2FzZSB3ZSBhcmUgbGVmdCB0byB1c2Ugb25seSBpdHMgdHJhaWxp bmcgYm91bmRhcnkuCisgICAgICAgIC8vIFRoaXMgYWRqdXN0bWVudCBpcyB1c2VmdWwgaW4gb3Jk ZXIgdG8gZmluZCB0aGUgaW5uZXItbW9zdCB0cmVlIGVsZW1lbnQgdGhhdAorICAgICAgICAvLyBs aW5lcyB1cCBob3Jpem9udGFsbHkgd2l0aCB0aGUgbG9jYXRpb24gb2YgdGhlIGV2ZW50LiBJZiB0 aGUgbW91c2UgZXZlbnQKKyAgICAgICAgLy8gaGFwcGVuZWQgaW4gdGhlIHNwYWNlIHByZWNlZGlu ZyBhIG5lc3RlZCB0cmVlIGVsZW1lbnQgKGluIHRoZSBsZWFkaW5nIGluZGVudGF0ZWQKKyAgICAg ICAgLy8gc3BhY2UpIHdlIHVzZSB0aGlzIGFkanVzdG1lbnQgdG8gZ2V0IHRoZSBuZXN0ZWQgdHJl ZSBlbGVtZW50IGFuZCBub3QgYSB0cmVlIGVsZW1lbnQKKyAgICAgICAgLy8gZnJvbSBhIHBhcmVu dCAvIG91dGVyIHRyZWUgb3V0bGluZSAvIHRyZWUgZWxlbWVudC4KKyAgICAgICAgLy8KKyAgICAg ICAgLy8gTk9URTogVGhpcyBjYW4gZmFpbCBpZiB0aGVyZSBpcyBmbG9hdGluZyBjb250ZW50IG92 ZXIgdGhlIHRyYWlsaW5nIGVkZ2Ugb2YKKyAgICAgICAgLy8gdGhlIDxsaT4gY29udGVudCwgc2lu Y2UgdGhlIGVsZW1lbnQgZnJvbSBwb2ludCBjb3VsZCBoaXQgdGhhdC4KKyAgICAgICAgbGV0IGlz UlRMID0gV0kucmVzb2x2ZWRMYXlvdXREaXJlY3Rpb24oKSA9PT0gV0kuTGF5b3V0RGlyZWN0aW9u LlJUTDsKKyAgICAgICAgbGV0IHRyYWlsaW5nRWRnZU9mZnNldCA9IGlzUlRMID8gMzYgOiAoc2Ny b2xsQ29udGFpbmVyLm9mZnNldFdpZHRoIC0gMzYpOworICAgICAgICBsZXQgeCA9IHNjcm9sbENv bnRhaW5lci50b3RhbE9mZnNldExlZnQgKyB0cmFpbGluZ0VkZ2VPZmZzZXQ7CiAgICAgICAgIGxl dCB5ID0gZXZlbnQucGFnZVk7CiAKICAgICAgICAgLy8gT3VyIGxpc3QgaXRlbXMgaGF2ZSAxLXBp eGVsIGNyYWNrcyBiZXR3ZWVuIHRoZW0gdmVydGljYWxseS4gV2UgYXZvaWQK