181265 2018-01-03 16:20:00 -0800 Add "noInline" to $vm 2022-02-27 23:30:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff ews-watchlist keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1385594 0 msaboff 2018-01-03 16:20:00 -0800 We should add noInline() function in the JSC shell to $vm so it can be used in Web tests. 1385596 1 webkit-bug-importer 2018-01-03 16:20:45 -0800 <rdar://problem/36287150> 1385598 2 330420 msaboff 2018-01-03 16:25:05 -0800 Created attachment 330420 Patch 1385599 3 ews-watchlist 2018-01-03 16:27:14 -0800 Attachment 330420 did not pass style-queue: ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:1174: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1385602 4 330420 mark.lam 2018-01-03 16:31:42 -0800 Comment on attachment 330420 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330420&action=review r=me with style fix. > Source/JavaScriptCore/tools/JSDollarVM.cpp:1175 > + FunctionExecutable* executable = jsDynamicCast<FunctionExecutable*>(vm, > + theFunction->executable()); > + return executable; Please fix style issue on line 1174. Maybe just put this in one line: return jsDynamicCast<FunctionExecutable*>(vm, theFunction->executable()); 1385620 5 msaboff 2018-01-03 16:47:58 -0800 (In reply to Mark Lam from comment #4) > Comment on attachment 330420 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330420&action=review > > r=me with style fix. > > > Source/JavaScriptCore/tools/JSDollarVM.cpp:1175 > > + FunctionExecutable* executable = jsDynamicCast<FunctionExecutable*>(vm, > > + theFunction->executable()); > > + return executable; > > Please fix style issue on line 1174. Maybe just put this in one line: > return jsDynamicCast<FunctionExecutable*>(vm, theFunction->executable()); Thanks. Fixed locally. 1385627 6 msaboff 2018-01-03 16:55:43 -0800 Committed r226384: <https://trac.webkit.org/changeset/226384> 330420 2018-01-03 16:25:05 -0800 2022-02-27 23:30:20 -0800 Patch 181265.patch text/plain 2859 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI2Mzc1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE4LTAxLTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFkZCAibm9JbmxpbmUiIHRvICR2bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyB3b3VsZCBiZSB1c2VmdWwgZm9yIHdlYiBiYXNlZCB0ZXN0 cy4KKworICAgICAgICAqIHRvb2xzL0pTRG9sbGFyVk0uY3BwOgorICAgICAgICAoSlNDOjpnZXRF eGVjdXRhYmxlRm9yRnVuY3Rpb24pOgorICAgICAgICAoSlNDOjpmdW5jdGlvbk5vSW5saW5lKToK KyAgICAgICAgKEpTQzo6SlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24pOgorCiAyMDE4LTAxLTAz ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXVtE ZWJ1Z10gdGVzdGFwaSBsaW5rIGVycm9yLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rv b2xzL0pTRG9sbGFyVk0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90 b29scy9KU0RvbGxhclZNLmNwcAkocmV2aXNpb24gMjI2Mzc1KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYwLDYgKzEx NjAsMjEgQEAgcHJpdmF0ZToKICAgICBtdXRhYmxlIEpJVENvZGU6OkpJVFR5cGUgbV9qaXRUeXBl OwogfTsKIAorc3RhdGljIEZ1bmN0aW9uRXhlY3V0YWJsZSogZ2V0RXhlY3V0YWJsZUZvckZ1bmN0 aW9uKEpTVmFsdWUgdGhlRnVuY3Rpb25WYWx1ZSkKK3sKKyAgICBpZiAoIXRoZUZ1bmN0aW9uVmFs dWUuaXNDZWxsKCkpCisgICAgICAgIHJldHVybiBudWxscHRyOworICAgIAorICAgIFZNJiB2bSA9 ICp0aGVGdW5jdGlvblZhbHVlLmFzQ2VsbCgpLT52bSgpOworICAgIEpTRnVuY3Rpb24qIHRoZUZ1 bmN0aW9uID0ganNEeW5hbWljQ2FzdDxKU0Z1bmN0aW9uKj4odm0sIHRoZUZ1bmN0aW9uVmFsdWUp OworICAgIGlmICghdGhlRnVuY3Rpb24pCisgICAgICAgIHJldHVybiBudWxscHRyOworICAgIAor ICAgIEZ1bmN0aW9uRXhlY3V0YWJsZSogZXhlY3V0YWJsZSA9IGpzRHluYW1pY0Nhc3Q8RnVuY3Rp b25FeGVjdXRhYmxlKj4odm0sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0aGVGdW5jdGlvbi0+ZXhlY3V0YWJs ZSgpKTsKKyAgICByZXR1cm4gZXhlY3V0YWJsZTsKK30KKwogLy8gUmV0dXJucyB0cnVlIGlmIHRo ZSBjdXJyZW50IGZyYW1lIGlzIGEgTExJbnQgZnJhbWUuCiAvLyBVc2FnZTogaXNMTEludCA9ICR2 bS5sbGludFRydWUoKQogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rp b25MTGludFRydWUoRXhlY1N0YXRlKiBleGVjKQpAQCAtMTE4Miw2ICsxMTk3LDIzIEBAIHN0YXRp YyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmMKICAgICByZXR1cm4gSlNWYWx1ZTo6 ZW5jb2RlKGpzQm9vbGVhbihmdW5jdG9yLmppdFR5cGUoKSA9PSBKSVRDb2RlOjpCYXNlbGluZUpJ VCkpOwogfQogCisvLyBTZXQgdGhhdCB0aGUgYXJndW1lbnQgZnVuY3Rpb24gc2hvdWxkIG5vdCBi ZSBpbmxpbmVkLgorLy8gVXNhZ2U6CisvLyBmdW5jdGlvbiBmKCkgeyB9OworLy8gJHZtLm5vSW5s aW5lKGYpOworc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25Ob0lu bGluZShFeGVjU3RhdGUqIGV4ZWMpCit7CisgICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA8 IDEpCisgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CisgICAg CisgICAgSlNWYWx1ZSB0aGVGdW5jdGlvblZhbHVlID0gZXhlYy0+dW5jaGVja2VkQXJndW1lbnQo MCk7CisKKyAgICBpZiAoRnVuY3Rpb25FeGVjdXRhYmxlKiBleGVjdXRhYmxlID0gZ2V0RXhlY3V0 YWJsZUZvckZ1bmN0aW9uKHRoZUZ1bmN0aW9uVmFsdWUpKQorICAgICAgICBleGVjdXRhYmxlLT5z ZXROZXZlcklubGluZSh0cnVlKTsKKyAgICAKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpz VW5kZWZpbmVkKCkpOworfQorCiAvLyBSdW5zIGEgZnVsbCBHQyBzeW5jaHJvbm91c2x5LgogLy8g VXNhZ2U6ICR2bS5nYygpCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5j dGlvbkdDKEV4ZWNTdGF0ZSogZXhlYykKQEAgLTE3MzcsNiArMTc2OSw4IEBAIHZvaWQgSlNEb2xs YXJWTTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogICAgIGFkZEZ1bmN0aW9uKHZtLCAibGxpbnRU cnVlIiwgZnVuY3Rpb25MTGludFRydWUsIDApOwogICAgIGFkZEZ1bmN0aW9uKHZtLCAiaml0VHJ1 ZSIsIGZ1bmN0aW9uSklUVHJ1ZSwgMCk7CiAKKyAgICBhZGRGdW5jdGlvbih2bSwgIm5vSW5saW5l IiwgZnVuY3Rpb25Ob0lubGluZSwgMSk7CisKICAgICBhZGRGdW5jdGlvbih2bSwgImdjIiwgZnVu Y3Rpb25HQywgMCk7CiAgICAgYWRkRnVuY3Rpb24odm0sICJlZGVuR0MiLCBmdW5jdGlvbkVkZW5H QywgMCk7CiAK