181261 2018-01-03 15:46:24 -0800 NetworkProcess cache files use functions from unistd.h without explicitly including it 2018-01-04 14:34:18 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned achristensen cdumez cgarcia commit-queue darin don.olmstead ews-watchlist rniwa webkit-bug-importer oldest_to_newest 1385579 0 stephan.szabo 2018-01-03 15:46:24 -0800 It seems like NetworkCacheBlobStorage.cpp and NetworkCacheData.cpp use things out of unistd.h (for example unlink) without explicitly including it. 1385910 1 330483 stephan.szabo 2018-01-04 13:05:00 -0800 Created attachment 330483 Add #includes for unistd.h 1385936 2 330483 commit-queue 2018-01-04 14:33:05 -0800 Comment on attachment 330483 Add #includes for unistd.h Clearing flags on attachment: 330483 Committed r226423: <https://trac.webkit.org/changeset/226423> 1385937 3 commit-queue 2018-01-04 14:33:07 -0800 All reviewed patches have been landed. Closing bug. 1385938 4 webkit-bug-importer 2018-01-04 14:34:18 -0800 <rdar://problem/36306115> 330483 2018-01-04 13:05:00 -0800 2018-01-04 14:33:05 -0800 Add #includes for unistd.h 181261-1.diff text/plain 1621 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzkyZTBhNWM3ZmIuLjYzNDM2NDA1YTU2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDE4LTAxLTAzICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNv bT4KKworICAgICAgICBOZXR3b3JrUHJvY2VzcyBjYWNoZSBmaWxlcyB1c2UgZnVuY3Rpb25zIGZy b20gdW5pc3RkLmggd2l0aG91dCBleHBsaWNpdGx5IGluY2x1ZGluZyBpdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgxMjYxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNo ZS9OZXR3b3JrQ2FjaGVCbG9iU3RvcmFnZS5jcHA6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mv Y2FjaGUvTmV0d29ya0NhY2hlRGF0YS5jcHA6CisKIDIwMTgtMDEtMDMgIE1pY2hhZWwgQ2F0YW56 YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCB3ZWIgcHJv Y2VzcyBBUEkgdG8gZGV0ZWN0IHdoZW4gZm9ybSBpcyBzdWJtaXR0ZWQgdmlhIEphdmFTY3JpcHQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlQmxvYlN0b3JhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9O ZXR3b3JrQ2FjaGVCbG9iU3RvcmFnZS5jcHAKaW5kZXggMTYzNWYyM2NlNmUuLjk5M2FmMGUyZDg5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtD YWNoZUJsb2JTdG9yYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2Nh Y2hlL05ldHdvcmtDYWNoZUJsb2JTdG9yYWdlLmNwcApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1 ZGUgPGZjbnRsLmg+CiAjaW5jbHVkZSA8c3lzL21tYW4uaD4KICNpbmNsdWRlIDxzeXMvc3RhdC5o PgorI2luY2x1ZGUgPHVuaXN0ZC5oPgogI2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+CiAjaW5jbHVk ZSA8d3RmL1NIQTEuaD4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9jYWNoZS9OZXR3b3JrQ2FjaGVEYXRhLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvY2FjaGUvTmV0d29ya0NhY2hlRGF0YS5jcHAKaW5kZXggN2JiNjQ5MmE2NjAuLmNmNjM3YTc1 MGNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZURhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUv TmV0d29ya0NhY2hlRGF0YS5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlIDxmY250bC5o PgogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAjaW5jbHVkZSA8c3lzL3N0YXQuaD4KKyNpbmNsdWRl IDx1bmlzdGQuaD4KICNpbmNsdWRlIDx3dGYvQ3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIu aD4KIAogbmFtZXNwYWNlIFdlYktpdCB7Cg==