181259 2018-01-03 14:16:50 -0800 Remove WebCore::IOSApplication::isWebApp() 2019-10-15 14:14:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 david_quesada webkit-unassigned achristensen commit-queue darin lingcherd_ho webkit-bug-importer oldest_to_newest 1385567 0 david_quesada 2018-01-03 14:16:50 -0800 This check isn't needed anymore since com.apple.webapp no longer uses WebKit directly. It is also subtly wrong since com.apple.webapp isn't the only bundle id where these hacks would have been needed. We should remove it. 1577231 1 380290 david_quesada 2019-10-05 15:11:27 -0700 Created attachment 380290 Patch 1579883 2 380290 commit-queue 2019-10-14 16:24:08 -0700 Comment on attachment 380290 Patch Clearing flags on attachment: 380290 Committed r251108: <https://trac.webkit.org/changeset/251108> 1579884 3 commit-queue 2019-10-14 16:24:10 -0700 All reviewed patches have been landed. Closing bug. 1580145 4 380290 darin 2019-10-15 10:04:23 -0700 Comment on attachment 380290 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380290&action=review > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:251 > // FIXME: Ideally we should just have Safari, WebApp, and webbookmarksd create a data store with A bit peculiar that this comment still mentions WebApp. 1580250 5 lingcherd_ho 2019-10-15 14:14:12 -0700 <rdar://problem/56269442> 380290 2019-10-05 15:11:27 -0700 2019-10-14 16:24:08 -0700 Patch file_181259.txt text/plain 6772 david_quesada Y29tbWl0IDQxNDc4N2U0ZGFiN2ZmZmFhNjRjM2U0N2MxOTJkMjQ1NjNiZjhkNjANCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIFNhdCBPY3Qg NSAxNTowMDo1OSAyMDE5IC0wNzAwDQoNCiAgICBSZW1vdmUgV2ViQ29yZTo6SU9TQXBwbGljYXRp b246OmlzV2ViQXBwKCkNCiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTgxMjU5DQogICAgDQogICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQogICAgDQog ICAgU291cmNlL1dlYkNvcmU6DQogICAgDQogICAgQXMgb2YgaU9TIDExLCB0aGUgV2ViLmFwcCBw cm9jZXNzIG5vIGxvbmdlciB1c2VzIFdlYktpdCBkaXJlY3RseSwgc28gSU9TQXBwbGljYXRpb246 OmlzV2ViQXBwKCkNCiAgICBpcyBuZXZlciB0cnVlLiBTaW5jZSBpdCdzIG5vIGxvbmdlciBuZWVk ZWQsIHJlbW92ZSBpdC4NCiAgICANCiAgICAqIHBsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNo ZWNrcy5oOg0KICAgICogcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29j b2EubW06DQogICAgKFdlYkNvcmU6OklPU0FwcGxpY2F0aW9uOjppc1dlYkFwcCk6IERlbGV0ZWQu DQogICAgDQogICAgU291cmNlL1dlYktpdDoNCiAgICANCiAgICAqIFVJUHJvY2Vzcy9XZWJzaXRl RGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW06DQogICAgKFdlYktpdDo6V2Vic2l0 ZURhdGFTdG9yZTo6ZGVmYXVsdEFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkpOg0KICAgICAgICBS ZW1vdmUgdGhlIHdvcmRpbmcgInRoaXMgaXMgbm90IHN1cHBvcnRlZCBhcyBvZiByaWdodCBub3ci LCBhcyBpdCBzZWVtcyB0byBiZSBzdXBwb3J0ZWQNCiAgICAgICAgc2luY2UgcjI0NzY4Niwgd2hp Y2ggYWRkZWQgU1BJIG9uIF9XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uIHRvIHNldCB0 aGUgYXBwbGljYXRpb24NCiAgICAgICAgY2FjaGUgZGlyZWN0b3J5Lg0KICAgIA0KICAgIFNvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjOg0KICAgIA0KICAgICogV2ViQ29yZVN1cHBvcnQvV2ViQXBwbGlj YXRpb25DYWNoZS5tbToNCiAgICAoYXBwbGljYXRpb25DYWNoZUJ1bmRsZUlkZW50aWZpZXIpOg0K DQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nDQppbmRleCAzNzU2NmEwOTA3My4uZjAyOGQwMDNkOGUgMTAwNjQ0DQotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0K QEAgLTEsMyArMSwxNyBAQA0KKzIwMTktMTAtMDUgIERhdmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVz YWRhQGFwcGxlLmNvbT4NCisNCisgICAgICAgIFJlbW92ZSBXZWJDb3JlOjpJT1NBcHBsaWNhdGlv bjo6aXNXZWJBcHAoKQ0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4MTI1OQ0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQor DQorICAgICAgICBBcyBvZiBpT1MgMTEsIHRoZSBXZWIuYXBwIHByb2Nlc3Mgbm8gbG9uZ2VyIHVz ZXMgV2ViS2l0IGRpcmVjdGx5LCBzbyBJT1NBcHBsaWNhdGlvbjo6aXNXZWJBcHAoKQ0KKyAgICAg ICAgaXMgbmV2ZXIgdHJ1ZS4gU2luY2UgaXQncyBubyBsb25nZXIgbmVlZGVkLCByZW1vdmUgaXQu DQorDQorICAgICAgICAqIHBsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oOg0KKyAg ICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9SdW50aW1lQXBwbGljYXRpb25DaGVja3NDb2NvYS5tbToN CisgICAgICAgIChXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNXZWJBcHApOiBEZWxldGVkLg0K Kw0KIDIwMTktMTAtMDUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4NCiANCiAgICAg ICAgIFtMRkNdIExheW91dENoaWxkdEl0ZXJhdG9yQWRhcHRlciAtPiBMYXlvdXRDaGlsZEl0ZXJh dG9yQWRhcHRlcg0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVB cHBsaWNhdGlvbkNoZWNrcy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxp Y2F0aW9uQ2hlY2tzLmgNCmluZGV4IDA4YWM3YjQxOTA1Li4xZTVhZWQzMzJmYSAxMDA2NDQNCi0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oDQor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaA0K QEAgLTg2LDcgKzg2LDYgQEAgV0VCQ09SRV9FWFBPUlQgYm9vbCBpc1dlYkJvb2ttYXJrc0QoKTsN CiBXRUJDT1JFX0VYUE9SVCBib29sIGlzRHVtcFJlbmRlclRyZWUoKTsNCiBib29sIGlzTW9iaWxl U3RvcmUoKTsNCiBib29sIGlzU3ByaW5nQm9hcmQoKTsNCi1XRUJDT1JFX0VYUE9SVCBib29sIGlz V2ViQXBwKCk7DQogV0VCQ09SRV9FWFBPUlQgYm9vbCBpc1dlYlByb2Nlc3MoKTsNCiBXRUJDT1JF X0VYUE9SVCBib29sIGlzSUJvb2tzKCk7DQogYm9vbCBpc0lCb29rc1N0b3J5dGltZSgpOw0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1J1bnRpbWVBcHBsaWNhdGlv bkNoZWNrc0NvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGltZUFw cGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0NCmluZGV4IGQxODYxZGJmYWFjLi5kZTQ3NDViNzNjYiAx MDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1J1bnRpbWVBcHBsaWNh dGlvbkNoZWNrc0NvY29hLm1tDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9S dW50aW1lQXBwbGljYXRpb25DaGVja3NDb2NvYS5tbQ0KQEAgLTI1OCwxMiArMjU4LDYgQEAgYm9v bCBJT1NBcHBsaWNhdGlvbjo6aXNTcHJpbmdCb2FyZCgpDQogICAgIHJldHVybiBpc1NwcmluZ0Jv YXJkOw0KIH0NCiANCi1ib29sIElPU0FwcGxpY2F0aW9uOjppc1dlYkFwcCgpDQotew0KLSAgICBz dGF0aWMgYm9vbCBpc1dlYkFwcCA9IGFwcGxpY2F0aW9uQnVuZGxlSXNFcXVhbFRvKCJjb20uYXBw bGUud2ViYXBwIl9zKTsNCi0gICAgcmV0dXJuIGlzV2ViQXBwOw0KLX0NCi0NCiAvLyBGSVhNRTog dGhpcyBuZWVkcyB0byBiZSBjaGFuZ2VkIHdoZW4gdGhlIFdlYlByb2Nlc3MgaXMgY2hhbmdlZCB0 byBhbiBYUEMgc2VydmljZS4NCiBib29sIElPU0FwcGxpY2F0aW9uOjppc1dlYlByb2Nlc3MoKQ0K IHsNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nDQppbmRleCA1NzQzZDRiNWI5Ny4uZjk2OTJkNDg3YzkgMTAwNjQ0DQotLS0gYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZw0KKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cNCkBA IC0xLDMgKzEsMTYgQEANCisyMDE5LTEwLTA1ICBEYXZpZCBRdWVzYWRhICA8ZGF2aWRfcXVlc2Fk YUBhcHBsZS5jb20+DQorDQorICAgICAgICBSZW1vdmUgV2ViQ29yZTo6SU9TQXBwbGljYXRpb246 OmlzV2ViQXBwKCkNCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODEyNTkNCisNCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0K KyAgICAgICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNv Y29hLm1tOg0KKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdEFwcGxp Y2F0aW9uQ2FjaGVEaXJlY3RvcnkpOg0KKyAgICAgICAgICAgIFJlbW92ZSB0aGUgd29yZGluZyAi dGhpcyBpcyBub3Qgc3VwcG9ydGVkIGFzIG9mIHJpZ2h0IG5vdyIsIGFzIGl0IHNlZW1zIHRvIGJl IHN1cHBvcnRlZA0KKyAgICAgICAgICAgIHNpbmNlIHIyNDc2ODYsIHdoaWNoIGFkZGVkIFNQSSBv biBfV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbiB0byBzZXQgdGhlIGFwcGxpY2F0aW9u DQorICAgICAgICAgICAgY2FjaGUgZGlyZWN0b3J5Lg0KKw0KIDIwMTktMTAtMDQgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPg0KIA0KICAgICAgICAgVXNlIGEgYmV0dGVyIG5hbWUgdGhh biBhbGxvd0Zhc3RDbGlja3NFdmVyeXdoZXJlDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNv Y29hLm1tDQppbmRleCA1OGQxZjkwMGU2My4uY2Q0YWI5Y2IyZDkgMTAwNjQ0DQotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29j b2EubW0NCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dl YnNpdGVEYXRhU3RvcmVDb2NvYS5tbQ0KQEAgLTI0OSw4ICsyNDksOCBAQCBXVEY6OlN0cmluZyBX ZWJzaXRlRGF0YVN0b3JlOjpkZWZhdWx0QXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSgpDQogICAg IC8vIFRoaXMgcXVpcmsgdXNlZCB0byBtYWtlIHRoZXNlIGFwcHMgc2hhcmUgYXBwbGljYXRpb24g Y2FjaGUgc3RvcmFnZSwgYnV0IGRvZXNuJ3QgYWNjb21wbGlzaCB0aGF0IGFueSBtb3JlLg0KICAg ICAvLyBQcmVzZXJ2aW5nIGl0IGF2b2lkcyB0aGUgbmVlZCB0byBtaWdyYXRlIGRhdGEgd2hlbiB1 cGdyYWRpbmcuDQogICAgIC8vIEZJWE1FOiBJZGVhbGx5IHdlIHNob3VsZCBqdXN0IGhhdmUgU2Fm YXJpLCBXZWJBcHAsIGFuZCB3ZWJib29rbWFya3NkIGNyZWF0ZSBhIGRhdGEgc3RvcmUgd2l0aA0K LSAgICAvLyB0aGlzIGFwcGxpY2F0aW9uIGNhY2hlIHBhdGgsIGJ1dCB0aGF0J3Mgbm90IHN1cHBv cnRlZCBhcyBvZiByaWdodCBub3cuDQotICAgIGlmIChXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6 aXNNb2JpbGVTYWZhcmkoKSB8fCBXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNXZWJBcHAoKSB8 fCBXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNXZWJCb29rbWFya3NEKCkpIHsNCisgICAgLy8g dGhpcyBhcHBsaWNhdGlvbiBjYWNoZSBwYXRoLg0KKyAgICBpZiAoV2ViQ29yZTo6SU9TQXBwbGlj YXRpb246OmlzTW9iaWxlU2FmYXJpKCkgfHwgV2ViQ29yZTo6SU9TQXBwbGljYXRpb246OmlzV2Vi Qm9va21hcmtzRCgpKSB7DQogICAgICAgICBOU1N0cmluZyAqY2FjaGVQYXRoID0gW05TSG9tZURp cmVjdG9yeSgpIHN0cmluZ0J5QXBwZW5kaW5nUGF0aENvbXBvbmVudDpAIkxpYnJhcnkvQ2FjaGVz L2NvbS5hcHBsZS5XZWJBcHBDYWNoZSJdOw0KIA0KICAgICAgICAgcmV0dXJuIFdlYktpdDo6c3Ry aW5nQnlSZXNvbHZpbmdTeW1saW5rc0luUGF0aChjYWNoZVBhdGguc3RyaW5nQnlTdGFuZGFyZGl6 aW5nUGF0aCk7DQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nDQppbmRleCA4NTE5ZDNjMDEyNi4u MDhjMTdjOWRkNjIgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VM b2cNCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZw0KQEAgLTEsMyArMSwx MyBAQA0KKzIwMTktMTAtMDUgIERhdmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVzYWRhQGFwcGxlLmNv bT4NCisNCisgICAgICAgIFJlbW92ZSBXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNXZWJBcHAo KQ0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MTI1 OQ0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L1dlYkFwcGxpY2F0aW9uQ2FjaGUubW06DQorICAgICAgICAoYXBwbGlj YXRpb25DYWNoZUJ1bmRsZUlkZW50aWZpZXIpOg0KKw0KIDIwMTktMTAtMDQgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4NCiANCiAgICAgICAgIFJlbmFtZSBTY2hl bWVSZWdpc3RyeSB0byBMZWdhY3lTY2hlbWVSZWdpc3RyeQ0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkFwcGxpY2F0aW9uQ2FjaGUubW0gYi9T b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJBcHBsaWNhdGlvbkNhY2hl Lm1tDQppbmRleCBmYjAxMGZmYTJmNy4uYTIyNzgxYWVmYTMgMTAwNjQ0DQotLS0gYS9Tb3VyY2Uv V2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJBcHBsaWNhdGlvbkNhY2hlLm1tDQor KysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJBcHBsaWNhdGlv bkNhY2hlLm1tDQpAQCAtNjYsNyArNjYsNyBAQCBzdGF0aWMgTlNTdHJpbmcgKmFwcGxpY2F0aW9u Q2FjaGVCdW5kbGVJZGVudGlmaWVyKCkNCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkNCiAgICAg aWYgKG92ZXJyaWRlQnVuZGxlSWRlbnRpZmllcikNCiAgICAgICAgIHJldHVybiBvdmVycmlkZUJ1 bmRsZUlkZW50aWZpZXI7DQotICAgIGlmIChXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNNb2Jp bGVTYWZhcmkoKSB8fCBXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNXZWJBcHAoKSkNCisgICAg aWYgKFdlYkNvcmU6OklPU0FwcGxpY2F0aW9uOjppc01vYmlsZVNhZmFyaSgpKQ0KICAgICAgICAg cmV0dXJuIEAiY29tLmFwcGxlLldlYkFwcENhY2hlIjsNCiAjZW5kaWYNCiANCg==