181253 2018-01-03 12:18:30 -0800 REGRESSION: Web Inspector: Debugger tab doesn't restore selected resource on reload 2018-01-03 14:46:38 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1385533 0 joepeck 2018-01-03 12:18:30 -0800 Debugger tab doesn't restore selected resource on reload Steps to Reproduce: 1. Inspect webkit.org 2. Show Debugger tab 3. Select "global.js" 4. Reload => Expected global.js to be selected, instead webkit.org (document resource) was. Notes: - Following DebuggerSidebarPanel.prototype.restoreStateFromCookie has: ... else if (cookie[WI.DebuggerSidebarPanel.SelectedAssertionsCookieKey]) this._assertionsBreakpointTreeElement.revealAndSelect(); else if (cookie[WI.DebuggerSidebarPanel.SelectedAllRequestsCookieKey]) if (this._xhrBreakpointTreeController) this._xhrBreakpointTreeController.revealAndSelect(WI.domDebuggerManager.allRequestsBreakpoint); else super.restoreStateFromCookie(cookie, relaxedMatchDelay); Which actually executes as: ... else if (cookie[WI.DebuggerSidebarPanel.SelectedAssertionsCookieKey]) this._assertionsBreakpointTreeElement.revealAndSelect(); else if (cookie[WI.DebuggerSidebarPanel.SelectedAllRequestsCookieKey]) if (this._xhrBreakpointTreeController) this._xhrBreakpointTreeController.revealAndSelect(WI.domDebuggerManager.allRequestsBreakpoint); else super.restoreStateFromCookie(cookie, relaxedMatchDelay); Oops. 1385534 1 webkit-bug-importer 2018-01-03 12:19:35 -0800 <rdar://problem/36280564> 1385535 2 330408 joepeck 2018-01-03 12:21:30 -0800 Created attachment 330408 [PATCH] Proposed Fix 1385536 3 330408 mattbaker 2018-01-03 12:23:45 -0800 Comment on attachment 330408 [PATCH] Proposed Fix r=me 1385574 4 330408 commit-queue 2018-01-03 14:46:37 -0800 Comment on attachment 330408 [PATCH] Proposed Fix Clearing flags on attachment: 330408 Committed r226374: <https://trac.webkit.org/changeset/226374> 1385575 5 commit-queue 2018-01-03 14:46:38 -0800 All reviewed patches have been landed. Closing bug. 330408 2018-01-03 12:21:30 -0800 2018-01-03 14:46:37 -0800 [PATCH] Proposed Fix oops-1.patch text/plain 1985 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVmMmJiZGY5NzI2Li43ZTdiZDYyMGViNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDEtMDMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBX ZWIgSW5zcGVjdG9yOiBEZWJ1Z2dlciB0YWIgZG9lc24ndCByZXN0b3JlIHNlbGVjdGVkIHJlc291 cmNlIG9uIHJlbG9hZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgxMjUzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjI4MDU2ND4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXSS5EZWJ1Z2dlclNpZGVi YXJQYW5lbC5wcm90b3R5cGUucmVzdG9yZVN0YXRlRnJvbUNvb2tpZSk6CisgICAgICAgIEFkZCBi cmFjZXMgdG8gZW5zdXJlIHRoZSB0cmFpbGluZyBlbHNlIGlzIGFjdHVhbGx5IHRyYWlsaW5nIHRo ZSBvdXRlcgorICAgICAgICBjaGFpbiBhcyBpdCB3YXMgaW50ZW5kZWQgdG8gYmUuCisKIDIwMTgt MDEtMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBDbGlja2luZyBzb3VyY2UgbG9jYXRpb24gbGluayBpbiBDb25zb2xlIHVu ZXhwZWN0ZWRseSBqdW1wcyB0byBOZXR3b3JrIHRhYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQ YW5lbC5qcwppbmRleCA2YTJjOGYwNjgxNi4uM2RlNGM0YzI1YWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVs LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVn Z2VyU2lkZWJhclBhbmVsLmpzCkBAIC0zNzUsMTAgKzM3NSwxMCBAQCBXSS5EZWJ1Z2dlclNpZGVi YXJQYW5lbCA9IGNsYXNzIERlYnVnZ2VyU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuTmF2aWdhdGlv blNpZGViYQogICAgICAgICAgICAgdGhpcy5fYWxsVW5jYXVnaHRFeGNlcHRpb25zQnJlYWtwb2lu dFRyZWVFbGVtZW50LnJldmVhbEFuZFNlbGVjdCgpOwogICAgICAgICBlbHNlIGlmIChjb29raWVb V0kuRGVidWdnZXJTaWRlYmFyUGFuZWwuU2VsZWN0ZWRBc3NlcnRpb25zQ29va2llS2V5XSkKICAg ICAgICAgICAgIHRoaXMuX2Fzc2VydGlvbnNCcmVha3BvaW50VHJlZUVsZW1lbnQucmV2ZWFsQW5k U2VsZWN0KCk7Ci0gICAgICAgIGVsc2UgaWYgKGNvb2tpZVtXSS5EZWJ1Z2dlclNpZGViYXJQYW5l bC5TZWxlY3RlZEFsbFJlcXVlc3RzQ29va2llS2V5XSkKKyAgICAgICAgZWxzZSBpZiAoY29va2ll W1dJLkRlYnVnZ2VyU2lkZWJhclBhbmVsLlNlbGVjdGVkQWxsUmVxdWVzdHNDb29raWVLZXldKSB7 CiAgICAgICAgICAgICBpZiAodGhpcy5feGhyQnJlYWtwb2ludFRyZWVDb250cm9sbGVyKQogICAg ICAgICAgICAgICAgIHRoaXMuX3hockJyZWFrcG9pbnRUcmVlQ29udHJvbGxlci5yZXZlYWxBbmRT ZWxlY3QoV0kuZG9tRGVidWdnZXJNYW5hZ2VyLmFsbFJlcXVlc3RzQnJlYWtwb2ludCk7Ci0gICAg ICAgIGVsc2UKKyAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBzdXBlci5yZXN0b3JlU3RhdGVG cm9tQ29va2llKGNvb2tpZSwgcmVsYXhlZE1hdGNoRGVsYXkpOwogICAgIH0KIAo=